github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-23 23:54:16 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
49,091 Commits 190 Branches 500 Tags 938 MiB
e88b997153
Commit Graph

49091 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Kris
8caa58acf2
DEV: remove old and experimental user menu styles (#21326) 2023-05-02 15:07:42 -04:00
Penar Musaraj
1b2a1c94d4
A11Y: select kit close on focus out (#21274) 
When navigating with the keyboard, the select-kit would not close when
focus was moved to an element outside of the body. For example, when
navigating via Tab or Shift+Tab, once the end (or beginning) of the list
was reached, focus would move out of the SK element, but the SK itself
would stay visible.

Switching from a click event to a focusout event solves the issue and
covers both mouse and keyboard navigation.
 2023-05-02 14:22:31 -04:00
Jan Cernik
bfd3bd5516
FIX: ChatComposerMessageDetails icon was always edit (#21340) 2023-05-02 14:31:42 -03:00
Daniel Waterworth
bc236119d3
DEV: Increase docker.rake system test timeout time to match CI (#21339) 2023-05-02 12:12:03 -05:00
Joffrey JAFFEUX
616f4a1118
FIX: disables send btn while uploads in progress (#21298) 
Before this fix you could press send while upload was in progress and lose it as it was not yet uploaded.
 2023-05-02 18:11:40 +02:00
Discourse Translator Bot
6bbf9a0bcc
Update translations (#21334) 2023-05-02 17:39:33 +02:00
David Taylor
c6f5b4297d
DEV: Use --frozen-lockfile in GitHub CI (#21338) 
This will help us to catch missing lockfile changes before they are merged into `main`
 2023-05-02 16:25:22 +01:00
Isaac Janzen
b505999266
DEV: Update yarn.lock (#21337) 2023-05-02 16:07:10 +01:00
Isaac Janzen
b0e640c086
DEV: Bump eslint-config version (#21325) 2023-05-02 09:17:52 -05:00
David Taylor
19540dfa0e
DEV: Do not include silenced Discourse deprecations in counter (#21336) 
Silenced Ember deprecations were already being excluded from the test output. This applies the same logic to Discourse deprecations.
 2023-05-02 14:55:41 +01:00
NullVoxPopuli
b3e063bc63
DEV: Co-locate select-kit component templates (#20779) 2023-05-02 14:10:53 +01:00
Joffrey JAFFEUX
69a72015f0
UX: resets active message when scrolling (#21305) 
This will avoid the messages actions floating around while scrolling. Note it's not testing the thread counterpart yet as I have a plan in mind to tests channels and threads in a clean way in the near future.
 2023-05-02 14:21:30 +02:00
Joffrey JAFFEUX
6c90747dea
FIX: correctly use types for reviewables type (#21333) 
Before this fix if the underlying model of a reviewable was changed, the filter wouldn't work anymore as it was expecting a 1:1 relation between filter type and model name.

This commit also relies on the `Reviewable.types` array to check against valid types instead of a regex not checking much.

Finally this commit adds a spec to ensure chat reviewables are listable from the review index page.
 2023-05-02 14:21:14 +02:00
Natalie Tay
ccca2dbfe0
FIX: Quoted images should be lightboxed (#21332) 
An older change about optimising images caused the selector that adds lightboxing not to apply on quoted images. This fixes that. The selector is now not applicable as optimisation occurs in a separate place.

This change allows quoted images to be opened in a lightbox.
 2023-05-02 17:02:19 +08:00
Gerhard Schlager
01dc461cc2
FIX: Disallow invisible Unicode characters in usernames (#21331) 
The list of excluded characters is based on https://invisible-characters.com/ and the list of invisible characters used by Visual Studio Code (https://github.com/hediet/vscode-unicode-data)
 2023-05-02 17:34:53 +10:00
Sam
c63551d227
FEATURE: search_rank_sort_priorities modifier (#21329) 
This new modifier can be used by plugins to modify search ordering.

Specifically plugins such as discourse_solved can amend search ordering
so solved topics bump to the top.

Also correct edge case where low and high sort priority categories did not
order correctly when it came to closed/archived
 2023-05-02 16:36:36 +10:00
Krzysztof Kotlarek
a8e28060d1
FIX: rename notify_about_flags_after to notify_about_reviewable_item_after (#21320) 
Change name and description for SiteSetting to make it easier to understand.
 2023-05-02 08:08:22 +10:00
Mark VanLandingham
86385bc9cf
REVERT: "FEATURE: Offline indicator controlled by message-bus connectivity (#21324)" (#21327) 
This reverts commit b1da670898.
 2023-05-01 15:27:02 -05:00
Daniel Waterworth
a4dd758f5c
DEV: Add 20m timeout to system tests (#21323) 2023-05-01 13:23:48 -05:00
Penar Musaraj
d697fd5766
DEV: Do not rerender widgets on mouseup/mousedown (#21300) 
Ran into an issue with these hooks preventing click events on anchors from completing (because the triggered rerender cancels the click). See:
https://github.com/discourse/discourse-header-search/pull/24

This change should have no effect on existing usage of these hooks. Current usage is limited to:

- legacy navigation (should be a no-op)
- reactions plugin (should be a no-op)
- discourse-header-search (will fix the issue!)
 2023-05-01 14:07:49 -04:00
Mark VanLandingham
b1da670898
FEATURE: Offline indicator controlled by message-bus connectivity (#21324) 2023-05-01 12:41:30 -05:00
Mark VanLandingham
685e1de3ea
DEV: Fire appEvents for user menu events (opening/clicking) (#21322) 2023-05-01 11:31:57 -05:00
Kris
4cca7de22d
UX: two column dropdown sidebar layout (#21288) 2023-05-01 10:41:28 -04:00
dependabot[bot]
96a3830c48
Build(deps): Bump mini_portile2 from 2.8.1 to 2.8.2 (#21312) 
Bumps [mini_portile2](https://github.com/flavorjones/mini_portile) from 2.8.1 to 2.8.2.
- [Release notes](https://github.com/flavorjones/mini_portile/releases)
- [Changelog](https://github.com/flavorjones/mini_portile/blob/main/CHANGELOG.md)
- [Commits](https://github.com/flavorjones/mini_portile/compare/v2.8.1...v2.8.2)

---
updated-dependencies:
- dependency-name: mini_portile2
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2023-05-01 08:09:59 +08:00
dependabot[bot]
2e92c0bb29
Build(deps-dev): Bump better_errors from 2.9.1 to 2.10.0 (#21315) 
Bumps [better_errors](https://github.com/BetterErrors/better_errors) from 2.9.1 to 2.10.0.
- [Release notes](https://github.com/BetterErrors/better_errors/releases)
- [Commits](https://github.com/BetterErrors/better_errors/compare/v2.9.1...v2.10.0)

---
updated-dependencies:
- dependency-name: better_errors
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2023-05-01 08:09:43 +08:00
dependabot[bot]
c262f937ef
Build(deps): Bump zeitwerk from 2.6.7 to 2.6.8 (#21314) 
Bumps [zeitwerk](https://github.com/fxn/zeitwerk) from 2.6.7 to 2.6.8.
- [Release notes](https://github.com/fxn/zeitwerk/releases)
- [Changelog](https://github.com/fxn/zeitwerk/blob/main/CHANGELOG.md)
- [Commits](https://github.com/fxn/zeitwerk/compare/v2.6.7...v2.6.8)

---
updated-dependencies:
- dependency-name: zeitwerk
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2023-05-01 08:09:30 +08:00
Alan Guo Xiang Tan
b06a154bb1
DEV: Use \A and \z instead of ^ and $ in TopicsFilter (#21316) 
`^` and `$` matches per line which is technically not what we want.
 2023-05-01 08:09:08 +08:00
Joffrey JAFFEUX
3e50a81d96
DEV: potential flakey fixes (#21309) 2023-04-29 00:15:51 +02:00
Blake Erickson
e2fbf4865a
DEV: Check if video thumbnails site setting is enabled (#21306) 2023-04-28 14:08:20 -06:00
Joffrey JAFFEUX
cd24656570
DEV: potential flakey specs fixes (#21307) 2023-04-28 22:06:27 +02:00
Blake Erickson
0dea991156
FIX: Empty video thumbnails (#21290) 
* FIX: Empty video thumbnails

This fix ensures that topic video thumbnail generation is completed
before the composer is allowed to submit which should prevent some bugs
around missing thumbnails on video topics.

* move callback to on upload-success
 2023-04-28 12:14:36 -06:00
Joffrey JAFFEUX
0239e88809
UX: cook message before sending edit (#21303) 
This allows for instant feedback in the UI.
 2023-04-28 20:11:57 +02:00
Mark VanLandingham
7f0682f4f2
DEV: Wrap remote theme update in transaction (#21302) 2023-04-28 12:11:53 -05:00
Joffrey JAFFEUX
290bd975c5
FIX: correctly differentiates channel/thread upload inputs (#21301) 
Prior to this fix uploads event could end up in the wrong textarea. This will most importantly allow pasting an image in the thread composer.

Also fixes a minor padding issue on thread when uploads are associated to it.
 2023-04-28 19:08:55 +02:00
Jarek Radosz
4a08c23965
DEV: Show select-kit deprecations in non-dev envs (#21297) 
We should have them in CI ;) (silenced for now, fixing them is not a priority)
 2023-04-28 17:58:41 +02:00
Penar Musaraj
a67c96438c
UX: Fix user onebox layout (#21284) 2023-04-28 09:50:49 -04:00
Joffrey JAFFEUX
69696843c6
FIX: allows youtube embeds to respect the t param (#21295) 2023-04-28 15:46:27 +02:00
Mark VanLandingham
36d388b57f
Revert "FEATURE: Reimplement offline indicator (#21285)" (#21296) 
This reverts commit de1066abcd.
 2023-04-28 06:59:10 -05:00
Mark VanLandingham
de1066abcd
FEATURE: Reimplement offline indicator (#21285) 2023-04-28 06:32:35 -05:00
Joffrey JAFFEUX
1403064835
FIX: correctly homogenizes panels min width (#21294) 
`.chat-channel` had `300px` min width, when `.chat-drawer` was `250px`, resulting in overflowing channel when in drawer. This commits ensures the limits are always set at `250px`.
 2023-04-28 13:05:00 +02:00
Joffrey JAFFEUX
e4029bfab8
FIX: chat height was incorrect on ipad (#21289) 2023-04-28 10:51:23 +02:00
chapoi
f29f131387
UX: composer use BEM + small tweaks to enabled/disabled styling (#21246) 
- using BEM notation
- making animation linear instead of default ease
- small tweaks to composer state (disabled/send-disabled/send-enabled)
- fixing bug with disabled composer on mobile
 2023-04-28 10:24:49 +02:00
Natalie Tay
eb0836e133
UX: Add a warning that updating min_trust_level_for_user_api_key will disable users from using DiscourseHub (#21291) 2023-04-28 14:29:13 +08:00
dependabot[bot]
4f3749f0b8
Build(deps): Bump async from 2.6.3 to 2.6.4 (#21183) 
Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4.
- [Release notes](https://github.com/caolan/async/releases)
- [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md)
- [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4)

---
updated-dependencies:
- dependency-name: async
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2023-04-27 21:29:21 +02:00
dependabot[bot]
fe3944f188
Build(deps): Bump webpack in /app/assets/javascripts (#21272) 
Bumps [webpack](https://github.com/webpack/webpack) from 5.79.0 to 5.81.0.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v5.79.0...v5.81.0)

---
updated-dependencies:
- dependency-name: webpack
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2023-04-27 20:45:49 +02:00
Daniel Waterworth
ae63d9ea09
PERF: Remove unnecessary queries from Theme#set_field (#21281) 2023-04-27 13:04:58 -05:00
Mark VanLandingham
3527fbcd8e
Revert "FEATURE: Service to track message bus connectivity + offline indicator(#21259)" (#21282) 
This reverts commit 6bba514b64.
 2023-04-27 12:55:41 -05:00
Mark VanLandingham
6bba514b64
FEATURE: Service to track message bus connectivity + offline indicator(#21259) 2023-04-27 11:04:56 -05:00
David Taylor
f5fa1ef771
UX: Use dvh for sidebar height (#21278) 
This will automatically adjust when browser UI is shown/hidden (e.g. when scrolling up/down on mobile Safari).

Similar approach to c82094cd9d, which targeted the 'slide-in' version of menus.
 2023-04-27 16:31:09 +01:00
Loïc Guitaut
c4c2da83b4 DEV: Set limits for text fields in badges 2023-04-27 17:22:32 +02:00