2358 Commits

Author	SHA1	Message	Date
Guo Xiang Tan	f26804394a	DEV: Remove the use of stubs on Rails.logger in our test suite.	2018-10-10 09:34:50 +08:00
David Taylor	9bf522f227	FEATURE: Mixed case tagging (#6454) ... - By default, behaviour is not changed: tags are made lowercase upon creation and edit. - If force_lowercase_tags is disabled, then mixed case tags are allowed. - Tags must remain case-insensitively unique. This is enforced by ActiveRecord and Postgres. - A migration is added to provide a `UNIQUE` index on `lower(name)`. Migration includes a safety to correct any current tags that do not meet the criteria. - A `where_name` scope is added to `models/tag.rb`, to allow easy case-insensitive lookups. This is used instead of `Tag.where(name: "blah")`. - URLs remain lowercase. Mixed case URLs are functional, but have the lowercase equivalent as the canonical.	2018-10-05 10:23:52 +01:00
Vinoth Kannan	8430ea927e	FIX: Generate webhook payloads before destroy events (#6325)	2018-10-05 16:53:59 +08:00
Joffrey JAFFEUX	a515ba8612	FIX: corrects typo and adds a spec for likes report (#6439) ... * FIX: corrects typo and adds a spec for likes report * save!	2018-10-02 02:27:43 -07:00
Kyle Zhao	e402394375	FEATURE: auto grant an available title when removing old title ... * FEATURE: auto grant an available title when removing old title	2018-09-21 12:06:08 +10:00
Guo Xiang Tan	195bd02fce	FIX: Avoid race condition when enqueuing job.	2018-09-20 11:24:01 +08:00
Sam	7d6b348d0b	SECURITY: correct XSS on long topic titles	2018-09-18 08:54:44 +10:00
Kyle Zhao	7b19ed06c1	reworked specs of existing group behavior	2018-09-17 17:46:43 +10:00
Kyle Zhao	6659417807	FEATURE: match user title when primary group changes ... When primary group changes and the user's title is the previous primary group's title, change the title to the new primary group's title	2018-09-17 15:08:39 +10:00
Sam	33541c4096	FEATURE: unconditionally omit no-follow for staff ... Previously TL2 and below staff would have links no-followed which was never intended	2018-09-17 12:02:20 +10:00
Sam	725d2c0d47	correct spec	2018-09-17 10:54:35 +10:00
Sam	173d0d53d5	correct erratic spec	2018-09-17 10:12:00 +10:00
OsamaSayegh	c7d81e2682	FIX/FEATURE: don't blow up when can't reach theme's repo, show problem themes on dashboard	2018-09-17 09:49:53 +10:00
Guo Xiang Tan	c3f6b4d966	DEV: Test against real Upload#url format.	2018-09-14 13:43:33 +08:00
Sam	419b14e58b	FIX: correctly keep stylesheet cache entries ... The intent from day one was to keep MAX_TO_KEEP stylesheets per target however the DELETE statement did not perform target filtering This meant we often deleted the wrong stylesheets from the cache	2018-09-14 12:54:11 +10:00
Joffrey JAFFEUX	a6502ce879	FIX: ensures errors in report initialization fail nicely (#6392)	2018-09-13 17:36:55 +02:00
Guo Xiang Tan	05a57d4f27	DEV: Clear cache after not before. ... * Clearing after ensures that state does not leak to specs in other files.	2018-09-13 14:23:32 +08:00
Guo Xiang Tan	3884e99e88	Add extra protection in Upload#get_from_url. ... In case the extension goes missing from the URL.	2018-09-12 00:12:14 -07:00
Guo Xiang Tan	b3469bea2d	FIX: Uploads not being linked correctly to posts. ... Regression due to 1f636c445b.	2018-09-11 23:50:23 -07:00
Osama Sayegh	16bd3f2cf2	FIX: use current user color scheme when filling theme-color attribute (#6384) ... * FIX: use current user color scheme when filling `meta` attribute `theme-color` * update manifest.webmanifest colors	2018-09-12 11:04:58 +10:00
Sam	e64402cb3b	SECURITY: correct edge case when SSO provides unvalidated emails	2018-09-11 08:24:02 +10:00
Guo Xiang Tan	1f636c445b	PERF: Add fast path to find uploads before resorting to LIKE query. ... For a normal upload url Before ``` Warming up -------------------------------------- 264.000 i/100ms Calculating ------------------------------------- 2.754k (± 8.4%) i/s - 13.728k in 5.022066s ``` After ``` Warming up -------------------------------------- 341.000 i/100ms Calculating ------------------------------------- 3.435k (±11.6%) i/s - 17.050k in 5.045676s ```	2018-09-06 14:44:24 +08:00
Guo Xiang Tan	434035f167	FIX: Link post to uploads in PostCreator. ... * This ensures that uploads are linked to their post on creation instead of a background job which may be delayed if Sidekiq is facing difficulties.	2018-09-06 11:18:11 +08:00
Sam	ad70502ab8	FIX: ignore invalid usernames in incoming link tracker ... If an incoming link username has NULL in it simply ignore it	2018-09-04 12:28:32 +10:00
Guo Xiang Tan	8dc1463ab3	Enable Lint/ShadowingOuterLocalVariable for Rubocop.	2018-09-04 10:16:42 +08:00
Bianca Nenciu	f5e0356fb2	correct miscellaneous issues with user login history	2018-09-02 17:24:54 +10:00
Sam	e1975e293f	FIX: when uploads are destroyed clear up avatar refs in user table ... This also auto corrects twice daily when we ensure consistency	2018-08-31 14:46:42 +10:00
David Taylor	f0abb4d09a	FIX: Allow user actions to be saved even if the post has nil user ... This issue made it impossible to delete users if they had flagged a post with nil user	2018-08-30 01:03:32 +01:00
Sam	e6970151a6	FEATURE: allow specifying locale via SSO ... Use: locale locale_force_update To force user locale on users where SiteSetting.allow_user_locale is enabled Note: If an invalid locale is specified no action will occur	2018-08-30 09:58:03 +10:00
Kyle Zhao	e25a6e085e	FIX: drop title updates through RSS feeds ... can create an update loop	2018-08-28 16:25:04 +10:00
Sam	9ab1fb7dfc	FEATURE: correctly store width and height on uploads ... Previously we used width and height for thumbnails, new code ensures 1. We auto correct width and height 2. We added extra columns for thumbnail_width and height, this is determined by actual upload and no longer passed in as a side effect 3. Optimized Image now stores filesize which can be used for analysis, decisions Also - fixes Android image manifest as a side effect - fixes issue where a thumbnail generated that is smaller than the upload is no longer used	2018-08-28 12:59:22 +10:00
Guo Xiang Tan	932195d828	DEV: Update test case for TopicEmbed.	2018-08-24 09:42:12 +08:00
Guo Xiang Tan	1ba24496ab	Merge pull request #6261 from xrav3nz/fix/topic-embed-import-updates ... FIX: update TopicEmbed's title and user correctly	2018-08-24 09:32:03 +08:00
Osama Sayegh	e0cc29d658	FEATURE: themes and components split ... * FEATURE: themes and components split * two seperate methods to switch theme type * use strict equality operator	2018-08-24 11:30:00 +10:00
Osama Sayegh	2711f173dc	FIX: don't allow inviting more than max_allowed_message_recipients ... * FIX: don't allow inviting more than `max_allowed_message_recipients` setting allows * add specs for guardian * user preferences for auto track shouldn't be applicable to PMs (it auto watches on visit) Execlude PMs from "Automatically track topics I enter..." and "When I post in a topic, set that topic to..." user preferences * groups take only 1 slot in PM * just return if topic is a PM	2018-08-23 14:36:49 +10:00
Kyle Zhao	baf413d527	FIX: update TopicEmbed's title and user correctly	2018-08-21 18:31:01 +08:00
Gerhard Schlager	14af90df5b	UX: Stop putting usernames in edit reason when changing post owner	2018-08-20 12:28:04 +02:00
Sam	d7b1919ead	correct specs	2018-08-20 12:46:14 +10:00
Sam	8b5e42ea16	FIX: always test and coerce to image on upload ... In the past the filename of the origin was used as the source for the extension of the file when optimizing on upload. We now use the actual calculated extension based on upload data.	2018-08-20 12:18:59 +10:00
Régis Hanol	93201d8dbe	FIX: don't trigger 'flag_reviewed' when no flags were reviewed	2018-08-16 18:11:29 +02:00
Joffrey JAFFEUX	10a3499d68	uses emoji versions for specs (#6276)	2018-08-16 13:45:30 +02:00
Sam	243fc9d0f9	FIX: refreshing auto groups when min_username_length is long	2018-08-15 16:59:56 +10:00
Gerhard Schlager	c358421ca5	FIX: Bulk updating category failed when topic title was too short	2018-08-14 16:37:52 +02:00
Gerhard Schlager	216f4c99b0	Correct flaky spec	2018-08-14 12:43:57 +02:00
Régis Hanol	de92913bf4	FIX: store the topic links using the cooked upload url	2018-08-14 12:23:32 +02:00
Guo Xiang Tan	664186a2a4	DEV: Remove stub to make test more reliable.	2018-08-13 14:48:46 +08:00
Sam	2b2612d0f5	correct flaky spec ... after(:all) and before(:all) are to be avoided, state can leak	2018-08-10 16:08:07 +10:00
Simon Cossar	093c3510e6	Rework moderators activity query (#6230) ... * Order rows in query * Don't increment revisions when moderator revises their own post	2018-08-10 10:51:31 +10:00
Gerhard Schlager	b9072e8292	FEATURE: Add "Reset Bump Date" action to topic admin wrench (#6246)	2018-08-10 10:51:03 +10:00
Misaka 0x4e21	6db623ef6b	UX: Improve category filtering and include subcategories ... * category_filtering 1. report_top_referred_topics 2. report_top_traffic_sources 3. report_post_edit * category_filtering with subcategory topics 1. report_top_referred_topics 2. report_top_traffic_sources 3. report_post_edit 4. report_posts 5. report_topics 6. report_topics_with_no_response * category_filtering tests (without subcategory topics) 1. report_posts 2. report_topics_with_no_response * subcategory topics tests `in_category_and_subcategories` in `topic_spec.rb` 1. `in_category_and_subcategories` in `topic_spec.rb` 2. topics, posts, flags and topics_with_no_response in `report_spec.rb`	2018-08-10 10:50:05 +10:00
Osama Sayegh	0d5ebcb21d	fix flaky specs (#6255)	2018-08-10 10:38:36 +10:00
Osama Sayegh	0b7ed8ffaf	FEATURE: backend support for user-selectable components ... * FEATURE: backend support for user-selectable components * fix problems with previewing default theme * rename preview_key => preview_theme_id * omit default theme from child themes dropdown and try a different fix * cache & freeze stylesheets arrays	2018-08-08 14:46:34 +10:00
David Taylor	aa9a9a5a72	FIX: Include auth_providers for anonymous users when login_required	2018-08-07 09:24:16 +01:00
David Taylor	812add18bd	REFACTOR: Serve auth provider information in the site serializer. ... At the moment core providers are hard-coded in Javascript, and plugin providers get added to the JS payload at compile time. This refactor means that we only ship enabled providers to the client.	2018-08-06 09:25:48 +01:00
Guo Xiang Tan	4e11811321	FIX: UserAvatar#update_gravatar! does not update User#uploaded_avatar. ... https://meta.discourse.org/t/missing-user-profile-pictures/93844/4	2018-08-06 13:29:44 +08:00
Osama Sayegh	18b396ad56	FEATURE: add link to see new commits when updates are available for themes (#6233) ... * FEATURE: add link to see new commits when updates are available for themes * shorten regexp	2018-08-06 15:29:15 +10:00
Osama Sayegh	880462a41c	FEATURE: display out of date themes on admin dashboard ... * FEATURE: disaply out of date themes on admin dashboard * Update copy	2018-08-03 09:53:48 +10:00
Penar Musaraj	4a872823e7	Improvements to user drafts (#6226) ... * drafts in user profile: only show to user herself (not to admins), use avatar replying to (instead of topic OP), add keyboard shortcut for drafts, simplify display labels * use JSON when testing Draft.stream	2018-08-02 07:41:27 +10:00
Dan Ungureanu	1a0ffc5ace	FEATURE: Added method to get multiple values at once from PluginStore. (#6225)	2018-08-01 18:42:40 +02:00
Gerhard Schlager	f4ca105498	FIX: Moving posts to existing topic didn't update topic metadata	2018-08-01 18:05:43 +02:00
Joffrey JAFFEUX	499ed469b0	FIX: disk_space refresh is now on demand	2018-08-01 10:06:20 -04:00
Penar Musaraj	1f45215537	FEATURE: Drafts view in user profile ... * add drafts.json endpoint, user profile tab with drafts stream * improve drafts stream display in user profile * truncate excerpts in drafts list, better handling for resume draft action * improve draft stream SQL query, add rspec tests * if composer is open, quietly close it when user opens another draft from drafts stream; load PM draft only when user is in /u/username/messages (instead of /u/username) * cleanup * linting fixes * apply prettier styling to modified files * add client tests for drafts, includes a fixture for drafts.json * improvements to code following review * refresh drafts route when user deletes a draft open in the composer while being in the drafts route; minor prettier scss fix * added more spec tests, deleted an acceptance test for removing drafts that was too finicky, formatting and code style fixes, added appEvent for draft:destroyed * prettier, eslint fixes * use "username_lower" from users table, added error handling for rejected promises * adds guardian spec for can_see_drafts, adds improvements following code review * move DraftsController spec to its own file * fix failing drafts qunit test, use getOwner instead of deprecated this.container * limit test fixture for draft.json testing to new_topic request only	2018-08-01 16:34:54 +10:00
Joffrey JAFFEUX	849f0d00f6	FEATURE: adds revision_count to moderators_activity (#6218) ... Co-Authored-By: Simon Cossar <scossar@users.noreply.github.com>	2018-07-31 23:40:45 -04:00
Guo Xiang Tan	919e8db686	FIX: Check for group name availability should skip reserved usernames.	2018-08-01 11:09:33 +08:00
Joffrey JAFFEUX	2b2a506a7b	FIX: makes dashboard more resilient to errors (#6217) ... This commit is an attempt to limit cases where the dashboard will generate a full exception page and also make it easier to track the error.	2018-07-31 21:23:28 -04:00
Joffrey JAFFEUX	8299fe0947	fix report spec (#6214)	2018-07-31 18:15:14 -04:00
Guo Xiang Tan	87537b679c	Drop reply_key, skipped and skipped_reason from email_logs.	2018-07-30 11:39:28 +08:00
Guo Xiang Tan	6f9a91cbd5	Merge pull request #6175 from vinothkannans/post_approval_webhook ... FEATURE: Webhook for post approval events	2018-07-27 10:50:49 +08:00
Joffrey JAFFEUX	313cd9940d	starts refactoring report spec	2018-07-26 19:24:18 -04:00
Neil Lalonde	135c803f49	FIX: don't send PM if flagged post is deleted but flags were deferred or cleared	2018-07-26 15:12:31 -04:00
Vinoth Kannan	af5b88f8e2	Rename approval web hook event type to queued post	2018-07-26 10:29:38 +05:30
Guo Xiang Tan	f8b367cc9c	Fix the build.	2018-07-26 10:17:51 +08:00
Guo Xiang Tan	30242972d3	Add spec for 4bf3bf6786.	2018-07-26 09:16:14 +08:00
Régis Hanol	4bf3bf6786	SECURITY: force IM decoder based on file extension	2018-07-25 22:00:04 +02:00
Vinoth Kannan	5059dad8f0	FEATURE: Webhook for post approval events	2018-07-25 23:43:19 +05:30
Joffrey JAFFEUX	796639a797	FIX: makes disk_space computation more resilient (#6172)	2018-07-25 11:04:01 -04:00
Neil Lalonde	fe39cdc90a	FEATURE: when a post is deleted because a moderator agreed with flags, send a message to the post author	2018-07-24 17:17:56 -04:00
Guo Xiang Tan	7a2bf8e368	Fix invalid query syntax when CategoryCustomField#value is blank.	2018-07-24 14:48:27 +08:00
Guo Xiang Tan	fad9c2b971	PERF: Move EmailLog#reply_key into new post_reply_keys table.	2018-07-24 13:51:53 +08:00
Guo Xiang Tan	ae8b0a517f	PERF: Split skipped email logs into a seperate table.	2018-07-24 13:14:37 +08:00
David Taylor	eda1462b3b	FEATURE: List, revoke and reconnect associated accounts. Phase 1 (#6099) ... Listing connections is supported for all built-in auth providers. Revoke and reconnect is currently only implemented for Facebook.	2018-07-23 16:51:57 +01:00
Joffrey JAFFEUX	32062864d3	FIX: removes system from user to user report (#6144)	2018-07-23 10:33:12 -04:00
Vinoth Kannan	84ab825e41	FEATURE: Webhook for user destroyed event (#6124)	2018-07-23 13:19:49 +05:30
Guo Xiang Tan	b4ef7dfe9a	DEV: Make spec less brittle.	2018-07-21 09:13:11 +08:00
Guo Xiang Tan	7cf6c2825e	Merge pull request #6106 from OsamaSayegh/watch-when-splitting ... FIX: topic owner should watch the new topic when moving posts to a new topic	2018-07-20 15:18:59 +08:00
OsamaSayegh	69450750d1	shorter method name and better specs	2018-07-20 10:13:27 +03:00
Joffrey JAFFEUX	1a78e12f4e	FEATURE: part 2 of dashboard improvements ... - moderation tab - sorting/pagination - improved third party reports support - trending charts - better perf - many fixes - refactoring - new reports Co-Authored-By: Simon Cossar <scossar@users.noreply.github.com>	2018-07-19 14:33:11 -04:00
Maja Komel	a9ebad3f6c	FIX: do not add a moderator post when post is flagged via direct message (#6100)	2018-07-18 23:18:14 +02:00
Neil Lalonde	afc94ac9e4	FEATURE: add a Top Categories section to the user summary page, showing the categories in which a user has the most activity	2018-07-18 16:39:16 -04:00
Régis Hanol	6d6e026e3c	FEATURE: selectable avatars	2018-07-18 12:57:43 +02:00
Guo Xiang Tan	b068a8a771	Fix the build.	2018-07-18 14:03:27 +08:00
Arpit Jalan	7da22e395b	FIX: do not show links with 0 click on topic map	2018-07-18 10:50:01 +05:30
OsamaSayegh	281538ae61	FIX: theme JS should only run when needed global objects exist (#6098)	2018-07-18 15:13:47 +10:00
Sam	0c159f17b7	skip failing spec	2018-07-18 14:43:06 +10:00
Sam	02628883d2	FEATURE: adjust autobump system ... - We spread out bumping through the day, if you are bumping 4 topics then a topic will be bumped every 6 hours - We add a small, bumping action at the bottom of the post to denote a topic got bumped	2018-07-18 10:17:33 +10:00
Guo Xiang Tan	d839a42bf9	Skip imagemagick tests on Travis.	2018-07-17 17:11:05 +08:00
Guo Xiang Tan	3553375dd2	PERF: Store EmailLog#reply_key as uuid data type.	2018-07-17 17:05:42 +08:00
Guo Xiang Tan	1d74ccaaf8	Add compatibility for ImageMagick7.	2018-07-17 15:50:58 +08:00
Sam	91266cdabb	correct auto bump topic logic	2018-07-17 09:33:33 +10:00
Guo Xiang Tan	c0c263405a	PERF: Store EmailLog#bounce_key as uuid data type. (#6093) ... PERF: Store `EmailLog#bounce_key` as `uuid` data type.	2018-07-16 20:05:54 +08:00
Sam	ac0053f491	FEATURE: navigate to first post and auto bump category settings ... ### navigate_to_first_post_after_read setting for categories When enabled on categories logged on users will return to OP after reading the entire category. (useful for documentation categories) ### num_auto_bump_daily Set a number of topics that will automatically bump daily on a category. - Every 15 minutes we will check if any category has this setting - Categories with the setting are shuffled - We exclude pinned, closed, category description and archived topics - Maximum of 1 topic for the list of categories is bumped till limit reached per category - We always try to bump oldest first - Limit is elastic using a RateLimiter that ensures that we only bump N per day Also some minor organisation on category settings Froze strings on category.rb	2018-07-16 18:10:35 +10:00
Leo McArdle	21ebb1cd54	FEATURE: Secondary emails support.	2018-07-16 11:09:49 +08:00
Kyle Zhao	2901691e87	FEATURE: per-category approval settings (#5778) ... - disallow moving topics to a category that requires topic approval	2018-07-13 12:51:08 +10:00
OsamaSayegh	decf1f27cf	FEATURE: Groundwork for user-selectable theme components ... * Phase 0 for user-selectable theme components - Drops `key` column from the `themes` table - Drops `theme_key` column from the `user_options` table - Adds `theme_ids` (array of ints default []) column to the `user_options` table and migrates data from `theme_key` to the new column. - Removes the `default_theme_key` site setting and adds `default_theme_id` instead. - Replaces `theme_key` cookie with a new one called `theme_ids` - no longer need Theme.settings_for_client	2018-07-12 14:18:21 +10:00
OsamaSayegh	f2cc05c6c6	FIX: ignore self-quotes from the same post when saving (#6082)	2018-07-10 16:17:28 +08:00
Maja Komel	18f5f646b1	FEATURE: allow selecting a tag when moving posts to a new topic (#6072)	2018-07-06 18:21:32 +02:00
Guo Xiang Tan	7163bf9323	FIX: Upload.get_from_url not respective subfolder in s3 bucket names.	2018-07-06 11:37:11 +08:00
Sam	0408e87e00	remove uneeded specs	2018-07-05 15:34:58 +10:00
Neil Lalonde	f134701c7b	FIX: user topic and post counts can become negative when staff deletes posts in personal messages	2018-07-04 09:31:16 -04:00
Leo McArdle	c3129444ea	FIX: allow multiple secondary emails	2018-07-03 18:21:35 +08:00
Arpit Jalan	7550e9ff95	FIX: purge unactivated users with a message from non-human users	2018-06-29 13:03:04 +05:30
Maja Komel	ec3e6a81a4	FEATURE: Second factor backup	2018-06-28 10:12:32 +02:00
David Lee	4644d777bd	FEATURE: add website field to SSO	2018-06-25 16:09:39 +10:00
Jeff Wong	bc52bdfa12	Feature: unconditionally consider TL0 users as "first day" users	2018-06-21 10:53:08 -07:00
Guo Xiang Tan	6ddd214476	FIX: Post#summary returning posts from other topics.	2018-06-21 12:00:54 +08:00
Sam	cb824a6b33	DEV: remove all calls to SqlBuilder use DB.build instead ... This is part of the migration to mini_sql, SqlBuilder.new is being deprecated and replaced with DB.build	2018-06-20 17:53:49 +10:00
riking	7f37ee9152	SearchLog: fix specs	2018-06-20 10:44:11 +10:00
Jeff Wong	2ff226e509	FIX: consider staged users mature (no spam checks) after 1 day	2018-06-19 09:41:10 -07:00
Andrew Schleifer	2f7a8ed86c	use different example domain	2018-06-19 11:15:27 -05:00
Arpit Jalan	784202170b	fix the build	2018-06-19 21:40:08 +05:30
Michael Brown	ae5d255f83	FIX: Reference example.com instead of somesite.com in examples ... * somesite.com actually exists... * example.com should be used in examples and is harmless to visit	2018-06-19 10:37:24 -04:00
Sam	5f64fd0a21	DEV: remove exec_sql and replace with mini_sql ... Introduce new patterns for direct sql that are safe and fast. MiniSql is not prone to memory bloat that can happen with direct PG usage. It also has an extremely fast materializer and very a convenient API - DB.exec(sql, *params) => runs sql returns row count - DB.query(sql, *params) => runs sql returns usable objects (not a hash) - DB.query_hash(sql, *params) => runs sql returns an array of hashes - DB.query_single(sql, *params) => runs sql and returns a flat one dimensional array - DB.build(sql) => returns a sql builder See more at: https://github.com/discourse/mini_sql	2018-06-19 16:13:36 +10:00
Jeff Wong	68e4e6a575	FIX: staged users are still tl0 but do not trigger spam if 1 week old.	2018-06-18 17:20:04 -07:00
Jeff Wong	9e55767f6a	FIX: don't punish a user for being previously staged for spam flags.	2018-06-15 12:25:25 -07:00
Robin Ward	fd54c92a52	FEATURE: New site setting, whitelisted_link_domains ... If provided, users who normally couldn't post links (say, due to a low trust level), can post links to those specific hosts.	2018-06-13 16:11:22 -04:00
Maja Komel	6c9190357c	fix get from url for external uploads without CDN	2018-06-13 16:21:28 +10:00
Sam Saffron	003df147a5	workaround fabricator not working correctly	2018-06-12 14:44:59 +10:00
riking	13a5e41fca	TEST: TopicViewItem ip logging test	2018-06-12 12:43:56 +10:00
Sam	89ad2b5900	DEV: Rails 5.2 upgrade and global gem upgrade ... This updates tests to use latest rails 5 practice and updates ALL dependencies that could be updated Performance testing shows that performance has not regressed if anything it is marginally faster now.	2018-06-07 14:21:33 +10:00
Guo Xiang Tan	d600e71b3d	FIX: Clean up stale UserExport records daily. ... * Add tests for `UserExport.remove_old_exports`	2018-06-05 09:43:40 +08:00
Arpit Jalan	36f9af4fa4	minor optimizations for post rejected logs	2018-06-02 09:44:55 +05:30
Arpit Jalan	89eca87f16	FEATURE: add staff action log for post rejections	2018-06-01 21:48:27 +05:30
Guo Xiang Tan	d57a5d3e8c	Fix brittle spec.	2018-06-01 11:56:56 +08:00
Guo Xiang Tan	7fc8a36529	DEV: Take 2 Queue jobs in tests by default. ... On my machine this cuts the time taken to run our test suite from ~11mins to ~9mins.	2018-05-31 16:23:23 +08:00
Guo Xiang Tan	56e9ff6853	Revert "DEV: Queue jobs in tests by default." ... Too risky for now This reverts commit be28154d3b.	2018-05-31 15:34:46 +08:00
Guo Xiang Tan	be28154d3b	DEV: Queue jobs in tests by default.	2018-05-31 14:45:47 +08:00
Neil Lalonde	e26a14dc29	FIX: error when flagging to notify moderators because message title is too long	2018-05-29 12:21:47 -04:00
Sam	df815d6c0e	DEV: prefer using ordering in relation over default scope	2018-05-29 09:34:12 +10:00
Arpit Jalan	c8bc942333	FIX: do not add invited user to automatic groups	2018-05-28 17:17:48 +05:30
Sam	5a32a70d6c	FIX: ColorScheme color missing was returning "nil"	2018-05-28 11:46:00 +10:00
Gerhard Schlager	20b94bc714	FIX: Extraction of quoted posts failed in some cases ... * It stored only oneboxed "quotes" when [quote] and links to topics or posts were mixed. * Revising a post didn't add or remove records from the quoted_posts table.	2018-05-25 12:00:17 +02:00
riking	12e4dd59b7	Style fix for test	2018-05-25 15:54:14 +10:00
riking	501bc0e9af	FIX: UserProfileView: Do not log IP of logged-in users	2018-05-25 15:54:14 +10:00
Sam	be1b8fc3a8	DEV: ensure specs run in consistent times	2018-05-25 14:22:43 +10:00
Guo Xiang Tan	1f27c91924	DEV: Better diagnostic when topic tracking state tests fail.	2018-05-24 15:36:41 +08:00
Gerhard Schlager	beed676b04	FIX: Check group names when checking username availability	2018-05-22 21:55:54 +02:00
riking	d4639bc734	TEST: Add TopicLinkClick spec for ip logging	2018-05-22 16:05:38 +10:00
Guo Xiang Tan	467d91347a	Missing specs for Group, Tag, Category and Flag web hooks.	2018-05-21 17:29:58 +08:00
Guo Xiang Tan	bf84037f79	FIX: Payload for webhooks should be current as of the time the event was triggered. ... https://meta.discourse.org/t/group-category-tag-user-deleted-webhooks-not-firing/87752	2018-05-21 17:29:58 +08:00
Arpit Jalan	290ee312e6	FIX: handle invalid mailto links	2018-05-18 18:02:52 +05:30
Guo Xiang Tan	416d19af27	FIX: Wrong target user displayed for user actions in activity stream. ... https://meta.discourse.org/t/wrong-assigned-username-in-activity-list/73816	2018-05-18 11:28:13 +08:00
Guo Xiang Tan	417bcc5f2a	Remove blank test.	2018-05-18 11:07:57 +08:00
Guo Xiang Tan	147ea37115	FIX: Missing notification for watching first post users when topic is recategorized. ... https://meta.discourse.org/t/not-receiving-notifications-for-announcements/87275/2?u=tgxworld	2018-05-17 16:15:29 +08:00
Arpit Jalan	33899664ce	FIX: handle bad user profile website	2018-05-17 13:21:24 +05:30
Arpit Jalan	539cf32f87	FIX: handle encoded mailto links when looking for upload record	2018-05-17 12:44:53 +05:30
Arpit Jalan	aee4045dd0	FIX: suggest name when username/name is provided	2018-05-17 10:36:36 +05:30
Régis Hanol	39aceed63d	FIX: don't purge unactivated users with a message	2018-05-16 18:24:11 +02:00
Régis Hanol	4103783821	FIX: don't use PMs in Incoming Links reports	2018-05-16 16:55:54 +02:00
Régis Hanol	5e97a9bfb7	FIX: tags in a 'visible by everyone but usable only by staff' group weren't visible by everyone	2018-05-16 09:48:19 +02:00
Sam	b9c6821261	correct spec	2018-05-15 15:20:36 +10:00
Régis Hanol	a28c58feb1	FIX: automatic group membership when using SSO	2018-05-15 01:48:30 +02:00
riking	d2347474a5	Tests for IncomingLink IP logging	2018-05-15 09:32:29 +10:00
Joffrey JAFFEUX	e474351ae4	inactive users report is not used anymore	2018-05-14 21:31:14 +02:00
Sam	8a783412b7	UX: improvements to new dashboard ... - remove inactive user report and replace with posts - clean up internals so grouping by week happens on client - when switching periods old report was not destroyed leading to bugs - calculate trend based on previous interval ... not previous 30 days - show percentages for mau/dau - be more careful about utc date usage - show uniqu and click through rate on search panel - publish key of report with report so we only load the correct one - subscribe earlier in channel in case of concurrency issues	2018-05-11 13:30:32 +10:00
Arpit Jalan	83245aa508	FIX: better handling of invite links after they are redeemed ... FIX: deprecate invite_passthrough_hours setting	2018-05-08 20:17:57 +05:30
Robin Ward	8262fc5d15	Merge pull request #5807 from discourse/min-flags-by-topic ... FEATURE: New site setting `min_flags_staff_visibility`	2018-05-08 09:17:29 -04:00
Guo Xiang Tan	086cb0f849	Fix brittle spec.	2018-05-08 10:52:03 +08:00
Robin Ward	ac60a84329	FEATURE: New site setting min_flags_staff_visibility ... When set higher than 1, flags won't show up for staff in the admin section unless the minimum threshold of flags on a post is reached.	2018-05-07 16:05:13 -04:00
Guo Xiang Tan	ee1eb1a5bd	FIX: Retrigger notification when a topic is recategorized. ... https://meta.discourse.org/t/notifications-when-a-topic-is-recategorized/63079	2018-05-07 21:29:06 +08:00
Misaka 0x4e21	ff6be3c2e3	FEATURE: add profile_background fields into SSO (#5701) ... Add profile_background and card_background fields into Discourse SSO.	2018-05-07 10:03:26 +02:00
Guo Xiang Tan	ad833c4485	FIX: Don't downcase group name.	2018-05-07 14:02:11 +08:00
Gerhard Schlager	40e22b14f3	Fix specs (didn't work on UTC+xx timezones)	2018-05-04 08:21:57 +02:00
Gerhard Schlager	ee426623e4	Dashboard next: correctly group inactive member count	2018-05-04 07:48:55 +02:00
Gerhard Schlager	41cd8c169c	Add specs for inactive users report	2018-05-04 07:48:55 +02:00
Sam	3a06cb461e	FEATURE: remove support for legacy auth tokens	2018-05-04 10:12:10 +10:00
Joffrey JAFFEUX	980972182f	dashboard next: caching, mobile support and new charts	2018-05-03 15:41:41 +02:00
Sam	bdd9775869	improve spec	2018-05-02 17:16:00 +10:00
Kyle Zhao	0cc4b42180	FIX: TopicEmbed.import should update title and author	2018-05-02 17:12:31 +10:00
Arpit Jalan	d074a39d39	fix the build	2018-04-27 20:04:24 +05:30
Arpit Jalan	67357b84b9	FIX: only allow one user to be created per invite	2018-04-27 19:21:10 +05:30
Joffrey JAFFEUX	9fabf2543b	dashboard next: activity metrics and new contributors ... This commit also introduces a better grouping of data points.	2018-04-26 14:49:41 +02:00
Sam	b26e27bdab	correct specs	2018-04-26 17:24:16 +10:00
Sam	88f5251415	FIX: disallow invalid top_menu and post_menu and share_links ... In the past any text could be entered there causing big potential issues	2018-04-26 17:00:56 +10:00
Guo Xiang Tan	ee82abba3c	Prefer save!/create! over save/create.	2018-04-25 13:39:45 +08:00
Robin Ward	456e40a709	FIX: Don't allow a user to become TL3 if they've ever been penalized ... Previously the code would only check if they were *currently* suspended or silenced.	2018-04-24 15:15:32 -04:00
Gerhard Schlager	ed4c0c4a63	FEATURE: Add option to delete all replies of flagged post	2018-04-24 11:08:05 -04:00
Arpit Jalan	0a442977b3	FEATURE: add staff action log for post approvals	2018-04-23 11:28:44 +05:30
Guo Xiang Tan	9eabf7c02c	Fix randomly failing specs due to SearchLog cache.	2018-04-23 10:10:10 +08:00
Neil Lalonde	70f2c5d3fd	FEATURE: move staff tags setting to tag group settings	2018-04-20 15:34:23 -04:00
Joffrey JAFFEUX	0e414d0890	dashboard next: trending search report ... This commit also improves how data is loaded sync and async	2018-04-19 18:19:21 +02:00
Régis Hanol	45850a0cd6	FIX: don't break when posting invalid URIs	2018-04-19 12:29:35 +02:00
Joffrey JAFFEUX	01c061d20d	dashboard next: perf and UI tweaks ... * cache CORE reports * adds backups/uploads section * few css tweaks	2018-04-18 21:30:41 +02:00
Joffrey JAFFEUX	a4a0b8e922	fix spec	2018-04-16 13:40:44 +02:00
Joffrey JAFFEUX	06b6c805d5	dashboard next: adds report for user types	2018-04-16 13:03:43 +02:00
Neil Lalonde	06022d042c	fix failing spec user_profile_spec	2018-04-13 10:32:28 -04:00
Arpit Jalan	a16b616861	FEATURE: webhook for flag events	2018-04-13 07:47:58 +05:30
Guo Xiang Tan	874003b7b1	FIX: Group can't be deleted if certain users are demoted.	2018-04-10 14:19:35 +08:00
Sam	fe37ce165d	correct issue where groups was never being blanked	2018-04-10 15:30:18 +10:00
Sam	afaeb20f27	FEATURE: Add option to have sso synchronize group membership ... In some cases add_groups and remove_groups is too much work, some sites may wish to simply synchronize group membership based on a list. When sso_overrides_groups is on all not automatic group membership is sourced from SSO. Note if you omit to specify groups, they will be cleared out.	2018-04-10 13:17:23 +10:00
Guo Xiang Tan	c82b2dcc24	Remove admin group management pages.	2018-04-09 15:14:50 +08:00
osamasayegh	fe8301007c	Add spec + make it work with .raw templates	2018-04-09 16:47:28 +10:00
Gerhard Schlager	56ca87bb01	Improve spec	2018-04-05 17:27:32 +02:00
Gerhard Schlager	cd6a99a027	FEATURE: Send a different PM when a post has been hidden more than once	2018-04-05 14:03:21 +02:00
Sam	f8637ed616	FIX: if a message is *partially* archived consider it not archived	2018-04-05 17:17:47 +10:00
Vinoth Kannan	434cbc649f	FEATURE: Webhook for tag events	2018-04-04 17:49:20 +05:30
Arpit Jalan	b49f2bf7d9	fix false spec	2018-04-04 12:20:50 +05:30
Arpit Jalan	c36e201eb3	FIX: update categories topic_count when converting topic to a PM and vice versa	2018-04-04 12:01:56 +05:30
Guo Xiang Tan	221503cd10	FIX: Add server side uniqueness validations for Group#name and User#username. ... https://meta.discourse.org/t/groups-can-be-given-same-name-as-existing-username/74010	2018-04-02 18:19:18 +08:00
Guo Xiang Tan	142571bba0	Remove use of rescue nil. ... * `rescue nil` is a really bad pattern to use in our code base. We should rescue errors that we expect the code to throw and not rescue everything because we're unsure of what errors the code would throw. This would reduce the amount of pain we face when debugging why something isn't working as expexted. I've been bitten countless of times by errors being swallowed as a result during debugging sessions.	2018-04-02 13:52:51 +08:00
Vinoth Kannan	efb19dbdaf	Merge pull request #5705 from discourse/new_webhooks ... FEATURE: Webhook for group and category events	2018-04-02 10:53:21 +05:30
Robin Ward	31d0998506	FIX: Don't allow links with no href	2018-03-28 12:32:16 -04:00
Guo Xiang Tan	ee69d58a59	FIX: Tests could get stucked in infinite loop if it fails to resolve IP of a hostname.	2018-03-28 14:49:05 +08:00
Neil Lalonde	7311023a52	Merge pull request #5700 from discourse/crawl-block ... FEATURE: control web crawlers access with white/blacklist	2018-03-27 15:06:03 -04:00
Arpit Jalan	518f7ba91b	FIX: show private message topic count on admin dashboard reports	2018-03-27 17:10:33 +05:30
Vinoth Kannan	e7407d0adc	FEATURE: Webhook for group and category events	2018-03-27 11:53:35 +05:30
Neil Lalonde	f2c060bdf2	FEATURE: option for tags in a tag group to be visible only to staff	2018-03-26 17:05:09 -04:00
Guo Xiang Tan	35745166b5	UX: New group membership management workflow. ... https://meta.discourse.org/t/adding-owners-members-ux-is-inconsistent-and-misleading/58084	2018-03-26 16:15:02 +08:00
Guo Xiang Tan	3d18cd1d9d	Raise error when timestamp is invalid when creating topic timers. ... https://meta.discourse.org/t/topic-timer-doesnt-work-for-fa-ir-locale/83702	2018-03-26 11:33:52 +08:00
Neil Lalonde	ced7e9a691	FEATURE: control which web crawlers can access using a whitelist or blacklist	2018-03-22 15:41:02 -04:00
Guo Xiang Tan	f3b402ffd5	UX: Allow users to filter members on group page. ... * Only admins are allowed to filter users by email.	2018-03-22 14:02:41 +08:00
Robin Ward	b9abd7dc9e	FEATURE: Shared Drafts ... This feature can be enabled by choosing a destination for the `shared drafts category` site setting. * Staff members can create shared drafts, choosing a destination category for the topic when it is published. * Shared Drafts can be viewed in their category, or above the topic list for the destination category where it will end up. * When the shared draft is ready, it can be published to the appropriate category by clicking a button on the topic view. * When published, Drafts change their timestamps to the current time, and any edits to the original post are removed.	2018-03-20 17:15:26 -04:00
Robin Ward	b39fbf7187	A staff member can hide another staff's member's post by flagging	2018-03-20 09:38:23 -04:00
Guo Xiang Tan	69a53210d3	Improve UserEmail#email validation to use the index.	2018-03-20 10:22:06 +08:00
Neil Lalonde	4d44024c82	FIX: error when trying to block an IP address. Return a message when IP address matches an existing screened IP address, including ranges.	2018-03-19 14:34:43 -04:00
Arpit Jalan	5005482dd8	Fix random spec failures	2018-03-19 15:25:05 +05:30
Arpit Jalan	f053e4cf37	Merge pull request #5682 from techAPJ/allowed-tags-page ... FIX: show only allowed tags on PM tags page and display correct count	2018-03-17 08:29:00 +05:30
Gerhard Schlager	6c736a1fa4	FIX: Translation overrides for flag types didn't expire cache	2018-03-16 22:10:19 +01:00
Arpit Jalan	e9bc763440	FIX: show only allowed tags on PM tags page and display correct count ... FIX: tags page should link to user profile we are browsing	2018-03-17 00:17:48 +05:30
Guo Xiang Tan	fe96ef6ed2	UX: Use topic list for displaying group messages on group page. ... https://meta.discourse.org/t/group-inbox-on-a-groups-page-mockup/71319	2018-03-16 11:56:40 +08:00
Sam	c589564f6a	FIX: color schemes not updating when remote saves	2018-03-15 18:26:54 +11:00
Michael Brown	6f40037ba5	Add test guarding against the SSO logic I broke	2018-03-13 18:39:39 -04:00
Arpit Jalan	7d375690c1	Merge pull request #5667 from techAPJ/pm-tags-page ... FEATURE: replace PM tags dropdown with a dedicated tags page	2018-03-13 13:08:21 +05:30
Arpit Jalan	24338fbbe8	FEATURE: replace PM tags dropdown with a dedicated tags page	2018-03-13 13:06:58 +05:30
Guo Xiang Tan	d5c828213f	FIX: Circular references warning in TopicTrackingState.	2018-03-13 08:35:15 +08:00
Arpit Jalan	82143a421c	FIX: max topic invitations per day should apply on PM invites as well ... FIX: do not apply `max topic invitations per day` on email invites	2018-03-12 23:17:58 +05:30
Arpit Jalan	12706c4b29	FEATURE: support markdown rendering for embedded posts	2018-03-11 08:00:48 +05:30
Michael Brown	3c3d205180	FIX: sso_overrides_username may inappropriately change the username if the case changed	2018-03-09 16:06:55 -05:00
Arpit Jalan	4b23634092	FIX: converting topic to message for a second time was broken	2018-03-08 17:59:04 +05:30
Arpit Jalan	0c2be8b775	Merge pull request #5655 from techAPJ/pm-tags-dropdown ... FEATURE: filter personal messages by tags	2018-03-08 16:30:38 +05:30
Arpit Jalan	a8149f8969	FIX: user should not be able to invite to PM if trust level requirment not met ... FIX: when personal messages are disabled let user invite to a public topic	2018-03-08 14:59:04 +05:30
Arpit Jalan	c29660c8f1	FEATURE: filter personal messages by tags	2018-03-08 14:42:07 +05:30
Sam	e162cd16b6	FEATURE: editing_grace_period_max_diff to force revisions in grace period ... If a user performs a substantive edit of 20 chars or more during grace period we will store a revision to track the change This allows for better auditing of changes that happen during the grace period	2018-03-07 18:34:34 +11:00
Guo Xiang Tan	3045c589f6	FIX: Publish live messages to both team inbox and archive on update.	2018-03-07 14:01:20 +08:00
Guo Xiang Tan	5169be6080	FIX: User archiving message should also publish to sent section.	2018-03-07 11:39:23 +08:00
Guo Xiang Tan	bef35f7be5	FIX: User archive messages should only publish to the user.	2018-03-07 11:28:29 +08:00
Robin Ward	c74d10cf34	FIX: Consider live links in <code> as links when counting	2018-03-06 11:46:12 -05:00
Guo Xiang Tan	1365bab0d7	FEATURE: Live updates for user's messages page. ... https://meta.discourse.org/t/group-inbox-messages-not-updated-for-new-posts/38189	2018-03-06 18:15:21 +08:00
Guo Xiang Tan	d576056cff	REFACTOR: Add basic tests for TopicTrackingState#publish_*. ... * Ensure we don't publish events for PMs.	2018-03-06 17:37:53 +08:00
Gerhard Schlager	8e48b339fa	Drop unused tables (#5630)	2018-03-05 17:27:30 -05:00
Guo Xiang Tan	07f1d90b88	FIX: Inviting a group that I am part of creates a notification. ... https://meta.discourse.org/t/inviting-a-group-to-a-message-does-not-trigger-a-notification-mail/50509/10?u=tgxworld	2018-03-05 13:51:32 +08:00
Guo Xiang Tan	42e0aaed61	FIX: Set first visit PM notification level to group default notification level. ... https://meta.discourse.org/t/notifications-not-received-for-private-messages-im-invited-to/71577/21?u=tgxworld	2018-03-05 13:39:00 +08:00
Sam	9331b4849d	FEATURE: we need access to settings in theme js	2018-03-05 15:35:41 +11:00
OsamaSayegh	282f53f0cd	FEATURE: Theme settings (2) (#5611) ... Allows theme authors to specify custom theme settings for the theme. Centralizes the theme/site settings into a single construct	2018-03-04 19:04:23 -05:00
Arpit Jalan	2e202495a3	FIX: do not allow invite notifications from muted user/topic	2018-03-02 12:24:51 +05:30
Gerhard Schlager	fffd1a6602	FIX: Associated Instagram account was missing at some places	2018-03-01 12:26:40 +01:00
Guo Xiang Tan	47c41f474d	Missing indentation.	2018-03-01 13:12:13 +08:00
Guo Xiang Tan	947b6fdf46	FIX: Incorrect rate limit applied to topics invitation flow.	2018-03-01 12:50:00 +08:00
Robin Ward	b283bb2ba7	FIX: Don't include unlisted topic in groups/posts	2018-02-28 14:40:18 -05:00
Guo Xiang Tan	902c5d11cf	FIX: Don't allow other flag actions after notify_moderator has happened. ... https://meta.discourse.org/t/receiving-sorry-an-error-has-occurred-during-flagging-step-of-discobot-tutorial/77233/5	2018-02-28 11:27:56 +08:00
Guo Xiang Tan	66d620f7b1	FEATURE: Trigger topic webhook when topic status is updated.	2018-02-27 11:07:37 +08:00
Neil Lalonde	3313072957	Remove censored_pattern site setting, which is replaced by watched words	2018-02-26 16:29:27 -05:00
Gerhard Schlager	5ca5817902	FIX: Only likes should change the given daily likes	2018-02-26 22:27:18 +01:00
Guo Xiang Tan	c1f53e1ece	UX: Invited users should watch PM topic once topic has been visited. ... https://meta.discourse.org/t/notifications-not-received-for-private-messages-im-invited-to/71577/11	2018-02-26 17:58:58 +08:00
Guo Xiang Tan	65cb785374	Improve specs for Topic#invite.	2018-02-26 15:18:34 +08:00
Guo Xiang Tan	6a88f7db61	Notification created for wrong user after invite. ... Introduced in c64f09b6b7	2018-02-26 13:21:19 +08:00
Guo Xiang Tan	6c1c5fe2d6	Fix the build take 2.	2018-02-26 13:09:13 +08:00
Guo Xiang Tan	1b5d955a34	Fix the build.	2018-02-26 12:46:15 +08:00
Guo Xiang Tan	c64f09b6b7	REFACTOR: Simplify and DRY Group#invite.	2018-02-26 11:59:07 +08:00
Régis Hanol	0559a4736a	FIX: don't double request when downloading a file	2018-02-24 12:35:57 +01:00
Arpit Jalan	ff12dee922	make rubocop happy	2018-02-23 15:25:15 +05:30
Arpit Jalan	709f201bd4	FIX: update group user count when bulk adding users	2018-02-23 14:29:56 +05:30
Guo Xiang Tan	dd26bbe868	Merge pull request #5610 from discourse/pm-tags ... FEATURE: Allow staffs to tag PMs	2018-02-23 07:07:41 +08:00
Vinoth Kannan	7cbda949f1	REFACTOR: New spec tests and code improvement	2018-02-22 20:27:02 +05:30
scossar	9d0807224b	Don't enqueue topic webhook unless a post has a topic	2018-02-22 14:34:59 +08:00
Vinoth Kannan	2b509eaa91	Merge branch 'master' into pm-tags	2018-02-21 23:55:59 +05:30
Neil Lalonde	81e873138f	FIX: error when deleting a tag associated with a deleted topic	2018-02-21 12:35:53 -05:00
Vinoth Kannan	84ce1acfef	FEATURE: Allow staffs to tag PMs	2018-02-21 20:11:46 +05:30
Guo Xiang Tan	8964e75ad6	Merge pull request #5612 from discourse/featheredtoast-two-factor-login ... Featheredtoast two factor login	2018-02-21 15:00:10 +08:00
Guo Xiang Tan	14f3594f9f	Review Changes for f4f8a293e7.	2018-02-21 14:55:49 +08:00
Robin Ward	5c40ae9e63	FIX: Links in quotes should be counted for rate limits	2018-02-20 20:42:01 -05:00
Robin Ward	3ea272f4f1	New setting: minimum trust level to embed images in a post	2018-02-20 20:00:06 -05:00
Arpit Jalan	c66405df7e	correct spec description	2018-02-15 17:49:57 +05:30
Arpit Jalan	f07b1a5c05	FIX: activate user even if email token is already confirmed	2018-02-14 20:44:48 +05:30
Gerhard Schlager	5a56746610	FIX: Embedded topic was not found when URL contained query string	2018-02-14 00:28:30 +01:00
Robin Ward	4c9959f795	FIX: Don't allow silenced users to reach TL3	2018-02-12 17:20:11 -05:00
Neil Lalonde	76c309fe6b	PERF: a faster way to count tags used per category	2018-02-12 15:16:47 -05:00
Robin Ward	cee3337357	Don't allow users to auto-hide staff posts	2018-02-09 19:53:58 -05:00
Robin Ward	5466389f4e	FIX: Consider oneboxes links wrt to min_trust_level_to_post_links	2018-02-08 18:27:40 -05:00
Gerhard Schlager	0ecdf90023	FIX: Validations could prevent moving posts	2018-02-08 13:36:13 +01:00
Gerhard Schlager	8ab6689f43	FIX: Preserve original date when moving first post	2018-02-08 12:55:32 +01:00
Gerhard Schlager	890ffb1eb5	FIX: overriding _MF translations worked only for English	2018-02-07 12:47:15 +01:00
Robin Ward	1bab15c757	FEATURE: A site setting for a minimum TL to post links	2018-02-06 18:07:58 -05:00
Vinoth Kannan	e8559f222c	FIX: After moving the posts topic timestamp should be updated with newest post	2018-02-02 19:30:52 +05:30
Neil Lalonde	ef2a7ac0f7	FIX: admin reports would sometimes return fewer than 30 days of data, causing current 30 day period counts to be too small and prev30day counts to count the wrong days	2018-02-01 15:50:51 -05:00
Arpit Jalan	350cbb1700	deprecate existing site settings	2018-02-01 13:25:29 +05:30
Arpit Jalan	f88b8a8945	rename 'default_email_private_messages' to 'default_email_personal_messages'	2018-02-01 13:25:29 +05:30
Arpit Jalan	25ec077eca	rename 'min_private_message_{post/title}_length' to 'min_personal_message_{post/title}_length'	2018-02-01 13:25:29 +05:30
Régis Hanol	4bcf9c5bf3	FIX: only count 'human' users in group.user_count	2018-01-31 21:55:01 +01:00
Gerhard Schlager	b784c1eda4	FIX: Remove all notifications of staged user during sign-up	2018-01-25 14:58:43 +01:00
Gerhard Schlager	d9515c37b3	FIX: Show message from discobot when staged user signs up	2018-01-25 14:58:43 +01:00
Gerhard Schlager	eb52c5469e	FEATURE: Allow plugins to register a new locale	2018-01-25 14:57:41 +01:00
Gerhard Schlager	dde0fcc658	FEATURE: Allow sending invites to staged users	2018-01-22 15:37:18 +01:00
Kyle Zhao	83c549bd31	FEATURE: grant badges in post admin wrench (#5498) ... * FEATURE: grant badges in post admin wrench * only grant manually grantable badges * extract GrantBadgeController mixin	2018-01-22 14:10:53 +11:00
Sam	47058b29d3	FEATURE: emit external_id field with user webhook	2018-01-22 10:09:26 +11:00
Rafael dos Santos Silva	70c5f6ae17	Merge pull request #5489 from discourse/fix-shared-s3-cdn ... FIX: Allow shared CDN for s3 and assets	2018-01-17 16:32:11 -02:00
Sam	b7023da894	PERF: reduce queries required for post timings ... - also freezes a bunch of strings - bypass active record for an exists query	2018-01-17 15:50:41 +11:00
Neil Lalonde	ce79ec0127	FIX: subfolder: top referred topics report was missing subfolder in links	2018-01-15 17:28:35 -05:00
Arpit Jalan	785d063a6b	Merge pull request #5496 from techAPJ/admin-graphs ... FIX: graphs should go to zero for missing dates	2018-01-15 11:10:29 +05:30
Arpit Jalan	b7ba490df7	FIX: graphs should go to zero for missing dates	2018-01-15 10:16:34 +05:30
Sam	bf68d394f4	PERF: handle debounce in redis cause SQL can be slow	2018-01-15 14:48:28 +11:00
Neil Lalonde	ad58a1743b	rename topic_list.tags to topic_list.top_tags	2018-01-12 16:35:27 -05:00
Neil Lalonde	6d68275ef9	don't show tag groups if they're restricted to categories you can't access	2018-01-12 14:25:42 -05:00
Rafael dos Santos Silva	b9a343afe7	FIX: Allow shared CDN for s3 and assets	2018-01-12 01:08:15 -02:00
Vinoth Kannan	b96ae14261	FEATURE: Display force_https warning in admin problems dashboard	2018-01-11 12:16:10 +05:30
Neil Lalonde	8f21c96ea5	FIX: don't downcase watched words on input since it can break the watched_words_regular_expressions setting	2018-01-09 16:51:59 -05:00
Guo Xiang Tan	e90187cbf7	Merge pull request #5469 from tgxworld/add_guard_to_prevent_primary_email_from_being_reassigned ... FIX: Add guard to prevent a primary `UserEmail` from being reassigned.	2018-01-09 13:35:08 +08:00
Vinoth Kannan	e5affdf230	FIX: URI must be ascii only for URI.parse command	2018-01-07 02:31:35 +05:30
Arpit Jalan	9030d3ef63	FIX: do not create duplicate topics ... https://meta.discourse.org/t/duplicate-http-https-topics-are-randomly-created/77190	2018-01-04 23:53:52 +05:30
Guo Xiang Tan	8a3bbcb19a	FIX: Add guard to prevent a primary UserEmail from being reassigned.	2018-01-04 19:40:50 +08:00
Guo Xiang Tan	9644569a28	FIX: Wildcard webhooks could send duplicated events.	2018-01-03 17:00:44 +08:00
Gerhard Schlager	38269c416d	FIX: return regular notification level for categories when not set by user	2017-12-30 20:36:58 +01:00
Arpit Jalan	ef4c6c67ba	fix the build	2017-12-23 14:42:40 +05:30
Guo Xiang Tan	6ecf37c482	Improve URL validation to check for a valid host. ... Parsing a URL with `URI` is not sufficient as the following cases are considered valid: URI.parse("http://https://google.com") => #<URI::HTTP http://https//google.com>	2017-12-21 13:50:15 +08:00
Guo Xiang Tan	6c4ee9d5b5	FEATURE: Trigger user webhook when a user logs in/out. ... https://meta.discourse.org/t/how-do-you-learn-how-to-build-these-plugins/57946/10?u=tgxworld	2017-12-20 17:47:30 +08:00
Sam	7aa56fc9d9	refinement and test for batch mode on feature_topics	2017-12-20 13:58:05 +11:00
Arpit Jalan	eab66065d1	FEATURE: search log term details page (#5445)	2017-12-20 13:41:31 +11:00
Régis Hanol	24e89b6b38	FIX: validates 'ThemeField' name when used in a SCSS variable	2017-12-19 16:10:44 +01:00
Guo Xiang Tan	30ddc1f222	Don't swallow errors when failing to create message for post action.	2017-12-19 10:58:26 +08:00
Guo Xiang Tan	b39d3a863d	FIX: moderators group wasn't being updated to be messagable by everyone. ... https://meta.discourse.org/t/custom-flag-not-showing-text/76244	2017-12-19 10:14:56 +08:00
Sam	1abc276451	FIX: properly omit inactive and silenced users from directory	2017-12-19 12:53:59 +11:00
Régis Hanol	b91f83eb7d	Ignore auto-quote/reply when counting replies	2017-12-15 00:38:14 +01:00
Régis Hanol	092c976d7c	FIX: prevent 💥 when selecting replies to posts quoting themselves	2017-12-15 00:23:51 +01:00
Régis Hanol	5db3d39b05	FIX: Post.reply_ids should also handle quotes	2017-12-14 00:43:48 +01:00
Régis Hanol	1b4483c942	FEATURE: Added 'select +below' and 'select +all replies' options to selecting posts	2017-12-13 22:12:06 +01:00
Gerhard Schlager	f525d83b53	FIX: empty uploads and blank filenames caused errors during validation	2017-12-13 22:03:31 +01:00
Neil Lalonde	3f1d6a302e	FIX: links with query params to external sites fail to load if ga universal auto link domains is used	2017-12-13 13:58:44 -05:00
Guo Xiang Tan	7aee1e3083	Remove specs that makes the build very sad.	2017-12-13 17:51:52 +08:00
Guo Xiang Tan	d5293aeae2	Clean Topic#slug when SiteSetting.slug_generation_method changes. ... https://meta.discourse.org/t/removing-the-concept-of-slugs-for-some-languages/26643/24?u=tgxworld	2017-12-13 16:11:07 +08:00
Gerhard Schlager	a7c1b0c81f	FIX: path whitelist for embedded comments didn't work with non-ASCII chars	2017-12-12 20:17:46 +01:00
Gerhard Schlager	e30851e45a	Move escape_uri method to a more suitable place	2017-12-12 20:17:46 +01:00
Régis Hanol	62a5b174e1	FIX: wasn't able to use the same username when taking over a staged account	2017-12-12 11:26:00 +01:00
Guo Xiang Tan	365bd771d9	Fix the build.	2017-12-11 17:03:05 +08:00
Guo Xiang Tan	4bd5acec47	FIX: Topic#featured_link may contain more than a URL.	2017-12-11 16:36:19 +08:00
Arpit Jalan	3c56c9b637	FIX: strip webhook payload_url	2017-12-11 13:48:11 +05:30
Robin Ward	74b9828731	FIX: Remove mentions filters from user and groups ... Additionally return no data if disabled	2017-12-07 16:29:02 -05:00
Joffrey JAFFEUX	f0ef307d2d	FIX: topic timer offset applied two times ... timezone offset was calculated and sent from browser to server, it would be applied on utc time generated from '2013-11-22 5:00' format for example and then sent back to browser which would display it thinking it's UTC time using `moment(utc time)` when it's in fact an UTC time we have offseted with the initial user timezone. This is impossible to automatically test in the current app state. Easiest reproduction is in live browser after setting your timezone to `America/New_York`, when setting a topic timer to later_today, after save, the time under the topic should be off to something roughly equal +1/-1 hour to your timezone offset.	2017-12-07 14:42:58 +01:00
Sam	dd70ef3abf	Revert "Revert "PERF: improve speed of rate limiter"" ... This reverts commit 2373d85239.	2017-12-04 21:23:11 +11:00
Sam	2373d85239	Revert "PERF: improve speed of rate limiter" ... This reverts commit a9bcdd7f27.	2017-12-04 21:19:28 +11:00
Sam	a9bcdd7f27	PERF: improve speed of rate limiter ... Also - adds a global rate limiter option - cleans up usage in tests - fixes freeze_time so it handles clock_gettime	2017-12-04 18:17:30 +11:00
Guo Xiang Tan	e73fbfe265	FIX: Topic#featured_link_root_domain extracts URL before parsing.	2017-12-04 10:00:07 +08:00
Arpit Jalan	496cd3b4df	Merge pull request #5385 from techAPJ/search-logs-improvements ... FEATURE: support search click through tracking for user, category and tags	2017-12-01 12:08:38 +05:30
Arpit Jalan	e3925278e2	FEATURE: support search click through tracking for user, category and tags ... https://meta.discourse.org/t/search-logs-page/73281/11?u=techapj This commit adds following features: - support for tracking click through to user, tag and category - new filter for search type (header, full page) This commit also removes "most viewed topic" field from search logs page because we are now tracking multiple click through entities, so topic is not a special entity anymore. This also improves query perf. The query now takes `20.5ms` to runs, as opposed to `655.9ms` previously.	2017-12-01 12:04:55 +05:30
Vinoth Kannan	7f2eeaf767	FIX: Password required flag should be cleared whenever clearing the raw password (#5384)	2017-12-01 15:19:24 +11:00
Guo Xiang Tan	1c2d1682ae	Merge pull request #5328 from tgxworld/reenable_interpolation_keys_check ... FIX: Re-enable invalid interpolation keys check and allow default key…	2017-11-30 13:04:54 +08:00
Guo Xiang Tan	9fbe1436b6	UX: Replace heuristic solution root domain extraction for topic featured link.	2017-11-29 21:52:41 +08:00
Robin Ward	77f90876d3	REFACTOR: Track manual locked user levels separately from groups	2017-11-27 11:23:44 -05:00
Guo Xiang Tan	5805979e88	FIX: Re-enable invalid interpolation keys check and allow default keys to be left out of translation overrides. ... https://meta.discourse.org/t/bulk-invite-from-file-resets-the-invite-forum-mailer-customized-text/67606/16	2017-11-27 11:00:08 +08:00
Gerhard Schlager	b3094e9954	FIX: incoming and outgoing emails got lost when post was moved	2017-11-24 11:45:36 +01:00
Arpit Jalan	406ad1a1f2	Merge pull request #5357 from techAPJ/invite-trust-level ... FIX: invited users were not granted trust level based on their group	2017-11-23 23:42:20 +05:30
Robin Ward	ad07e6e172	FEATURE: group_removes_trust_level setting ... By default in Discourse, if a group grants a user a particular trust level that is locked even if they are removed from the group. With this new setting, when a user is removed from a group their trust level is set to either the next highest trust level based on group membership, or they are unlocked and promoted based on the default mechanisms.	2017-11-23 13:03:24 -05:00
Arpit Jalan	3508046e33	FIX: invited users were not granted trust level based on their group ... https://meta.discourse.org/t/bulk-invites-and-trust-level/73535 If the user enters password when accepting invite they were not granted trust level based on their group privileges. It was because `password_required` was set to true when creating user record and when the user was updated again when granting trust level the password validation was raising error saying that the password is empty. This commit fetches fresh user record after the user is created so that the user record can be updated successfully.	2017-11-23 22:19:28 +05:30
Gerhard Schlager	39810e4425	FIX: do not move small post actions	2017-11-23 17:25:53 +01:00
Sam	7e841a0495	FIX: stop counting PMs, deleted topics and whispers in directory and user stats	2017-11-20 16:44:09 +11:00
Gerhard Schlager	92a831bae6	FEATURE: user directory returns staged users during search	2017-11-19 01:17:31 +01:00
Neil Lalonde	87ec11e298	FIX: more accurate counting of posts read. Skipping to the end of a topic does not count all posts as read in user stats.	2017-11-17 16:08:46 -05:00
Sam	20fbf81505	FEATURE: Allow plugins to easily add defaults to GlobalSetting ... usage: GlobalSetting.add_default("plugin_setting_name", "value")	2017-11-16 08:39:29 +11:00
Gerhard Schlager	9207dee69a	FEATURE: escape HTML when cooking plaintext emails	2017-11-15 20:22:11 +01:00
Robin Ward	fc73de9578	Support for finding new locales in plugins	2017-11-15 11:20:04 -05:00
Vinoth Kannan	cbc0afb399	REFACTOR: Instance methods added to 'PluginStore' model for easy access (#5315)	2017-11-15 10:10:20 -05:00
Arpit Jalan	3831663fea	FEATURE: search logs page (#5313)	2017-11-15 11:13:50 +11:00
Robin Ward	971e302ff2	FEATURE: Support an end date for user silencing	2017-11-14 13:20:19 -05:00
Gerhard Schlager	4be8f17e66	FIX: counting invites didn't work ... PostgreSQL reported the following error: "for SELECT DISTINCT, ORDER BY expressions must appear in select list"	2017-11-14 11:40:07 +01:00
Sam	075a458489	FIX: child theme component vars not resolved in parent	2017-11-14 15:22:59 +11:00
Robin Ward	1f14350220	Rename "Blocked" to "Silenced"	2017-11-10 14:10:27 -05:00
Neil Lalonde	16ff2a4715	FIX: topic counts after converting topic to/from public and private	2017-11-09 15:33:44 -05:00
Arpit Jalan	b21d5d3633	FIX: SSO email match should be case insensitive	2017-11-08 20:37:41 +05:30
Guo Xiang Tan	6090994cdf	FEATURE: Retain the latest 30 days of WebHookEvent records by default.	2017-11-08 14:11:01 +08:00
Neil Lalonde	c7d7cb940c	FIX: dashboard posts report was including posts in daily data, but not in totals	2017-11-02 18:46:28 -04:00
Guo Xiang Tan	edf4af608e	FIX: Better match when searching for groups.	2017-11-02 10:20:14 +08:00
Guo Xiang Tan	401fbdbfe7	FIX: Topic#title were being parameterized when encoded slug is ... enabled.	2017-10-27 11:02:47 +08:00
Guo Xiang Tan	f1615c2148	Merge pull request #5263 from tgxworld/improve_pattern ... REFACTOR: Always validate email by default.	2017-10-26 14:34:09 +08:00
Guo Xiang Tan	defea6245c	REFACTOR: Always validate email by default.	2017-10-25 13:48:34 +08:00
Sam	1db4c2d1a0	moving redis to readonly mode destablizes the test suite	2017-10-25 14:39:49 +11:00
Sam	0d816302e2	Explicitly avoid all readonly protection and scoping	2017-10-25 13:31:44 +11:00
Sam	7ca8853861	don't risk being stuck in readonly	2017-10-25 13:22:50 +11:00
Sam	877b7be579	FIX: in readonly mode don't double count pages	2017-10-25 13:19:43 +11:00
Neil Lalonde	4452d67a23	Revert "FIX: TL0 users' messages to moderators were not being posted when flagging private messages"	2017-10-23 18:17:53 -04:00
Guo Xiang Tan	19f3b81161	Revert "FIX: always trigger the ':user_updated' event" ... This reverts commit 519b70ea46. https://meta.discourse.org/t/creating-a-topic-or-a-post-sends-the-user-updated-webhook/71643	2017-10-23 11:44:22 +08:00
Gerhard Schlager	4205c1ad2b	FIX: postprocessing ignored cook method	2017-10-20 10:26:45 +02:00
Robin Ward	838568cbc3	Refactor flag types for more customization	2017-10-19 13:55:23 -04:00
Gerhard Schlager	1cae875146	FIX: topic link extraction shouldn't fail when the parsed URL has no path	2017-10-19 15:26:37 +02:00
Gerhard Schlager	3cd73cdf18	FIX: fancy topic title must fit into column	2017-10-19 14:34:30 +02:00
Guo Xiang Tan	22ba70fb01	Merge pull request #5226 from tgxworld/allow_user_to_disable_private_messages ... FEATURE: Allow users to disable new PMs.	2017-10-19 16:46:18 +08:00
Guo Xiang Tan	5b9ddaf972	FIX: Topic#fancy_title should not write in readonly mode.	2017-10-19 16:07:03 +08:00
Guo Xiang Tan	25c25ae423	FEATURE: Allow user to leave a PM.	2017-10-19 12:32:55 +08:00
Sam	229a10e142	Missed a whitelist, compensate for strict classes	2017-10-16 10:46:01 +11:00
Neil Lalonde	b124e5f19f	FIX: TL0 users' messages to moderators were not being posted when flagging private messages	2017-10-13 11:55:49 -04:00
Arpit Jalan	a2183c3f1d	SECURITY: verify that inviter can invite new user to a topic	2017-10-09 15:59:41 +05:30
Sam	4ea87b5ab8	Merge branch 's3_refactor'	2017-10-09 10:27:52 +11:00
Sam	70bb2aa426	FEATURE: allow specifying s3 config via globals ... This refactors handling of s3 so it can be specified via GlobalSetting This means that in a multisite environment you can configure s3 uploads without actual sites knowing credentials in s3 It is a critical setting for situations where assets are mirrored to s3.	2017-10-06 16:20:01 +11:00
Guo Xiang Tan	b0557c6692	UX: Allow users to remove a remind me topic timer.	2017-10-05 11:50:08 +08:00
Neil Lalonde	f5a2ed99b0	FIX: deleting category background images sometimes has no effect	2017-10-04 17:04:37 -04:00
Régis Hanol	e212435545	FIX: redirect to top wasn't working	2017-10-04 22:08:41 +02:00
Guo Xiang Tan	1310181664	FIX: Adding a public topic timer deletes a private topic timer.	2017-10-04 16:31:40 +08:00
Guo Xiang Tan	c872225762	Improve MessageBus.track_publish to allow filter by channel.	2017-10-02 11:34:57 +08:00
Arpit Jalan	d64853dfa0	FIX: update group.has_messages field weekly	2017-09-29 08:23:07 +05:30
Guo Xiang Tan	c37598ddbc	Merge pull request #5200 from gschlager/embed ... FIX: do not escape already escaped chars in URL	2017-09-26 09:07:57 +08:00
Guo Xiang Tan	88555f32cf	Improve specs.	2017-09-25 13:49:00 +08:00
Guo Xiang Tan	e542884b00	FIX: Incorrect notification state being published.	2017-09-25 13:48:59 +08:00
Guo Xiang Tan	77d4c4d8dc	Fix all the errors to get our tests green on Rails 5.1.	2017-09-25 13:48:58 +08:00
Gerhard Schlager	6f6b47f096	FIX: do not escape already escaped chars in URL	2017-09-22 17:36:44 +02:00
Gerhard Schlager	1a435414d5	FIX: handle URL encoded email addresses	2017-09-22 14:26:06 +02:00
Lidiane Taquehara	66ed7195d6	Add spec to cover Badge Type has many Badges relation ... Also: fix filename. `_spec` suffix was missing. By default, RSpec ignores files in this situation. Ref: https://github.com/rspec/rspec-core/issues/642	2017-09-20 00:51:32 -03:00
Gerhard Schlager	f3d3129113	FIX: Use default locale for edit reason when owner of post gets changed	2017-09-14 17:17:37 +02:00
Gerhard Schlager	efef422416	FIX: Use default locale for moderator post when posts are moved	2017-09-14 17:17:37 +02:00
Neil Lalonde	d7d9923b8e	FIX: display email validation error messages	2017-09-11 13:22:14 -04:00
Joffrey JAFFEUX	caedefd675	FIX: correctly resets user_themes template ... This commit adds tests for this behaviour and also adds support for reseting cache when updating a theme name and destroying a theme.	2017-09-04 13:27:58 +02:00
Arpit Jalan	66f2925348	SECURITY: do not include links from whispers in topic summary map ... https://meta.discourse.org/t/staff-whispers-links-in-whispers-showing-up-publicly-in-topics-summary/69134?u=techapj	2017-08-31 23:44:54 +05:30
Bianca Nenciu	6bc74ceb50	Split alias levels in mentionable and messageable levels. (#5065) ... * Split alias levels in mentionable and messageable levels. * Fixed some tests. * Set messageable level to everyone by default. * By defaults, groups are not mentionable or messageable. * Made staff groups messageable by the system.	2017-08-28 12:32:08 -04:00
Neil Lalonde	398604ac71	FEATURE: set purge_unactivated_users_grace_period_days to 0 to disable purging unactivated users	2017-08-25 15:20:06 -04:00
Sam	bcbee91f0c	lint	2017-08-24 13:24:52 -04:00
Sam	f60a1b0275	correct erratic spec	2017-08-24 13:19:26 -04:00
Sam	f766ea4257	Correct short url decoding for sha1s leading with zero ... This was picked up cause we had a flaky test!	2017-08-23 11:08:18 -04:00
Neil Lalonde	224796a7d4	FIX: wrongs counts on tags with deleted topics	2017-08-22 16:55:05 -04:00
Sam	bcf7dc38c2	FEATURE: server side support for upload:// markdown ... This allows uploads to be specified using short sha1 hash instead of full URL Client side change is pending	2017-08-22 11:46:23 -04:00
Arpit Jalan	b00747fd49	FIX: do not create topic link reflection for unlisted topics	2017-08-22 14:28:01 +05:30
Guo Xiang Tan	bc3e43b496	FIX: Topic timers being incorrectly trashed!. ... https://meta.discourse.org/t/temporary-timed-closure-of-topic-not-re-opening-topic/67877	2017-08-22 15:23:09 +09:00
Guo Xiang Tan	87994a86ce	FIX: Don't set topic timer for close topics when changing category. ... https://meta.discourse.org/t/moving-a-topic-after-closure-reopens-topic/67659/4	2017-08-22 12:54:34 +09:00
Sam	c2a6616035	Correct erratic spec failure	2017-08-17 15:26:31 -04:00
Robin Ward	b78958fbfc	Silence CSS logging in development - it's way too noisy	2017-08-16 10:59:56 -04:00
Guo Xiang Tan	b77aa29e71	Merge pull request #5013 from LeoMcA/alternate-emails-phase-1.5 ... FIX: add additional email to tests and clean up resulting mess	2017-08-16 16:19:28 +09:00
Guo Xiang Tan	ed851dbfff	FIX: Avoid publishing a gigantic payload. ... * Certain sites have way too many categories.	2017-08-16 11:38:30 +09:00
Joffrey JAFFEUX	506572bf04	FIX: display emojis (set, custom and native) in bio excerpt	2017-08-15 10:05:09 +02:00
Neil Lalonde	94d8f6d734	FIX: digest emails should not include posts that are still in the edit grace period	2017-08-14 12:47:33 -04:00
Neil Lalonde	9813f9f0f8	FIX: more cases of case sensitive group membership in sso	2017-08-11 18:09:29 -04:00
Neil Lalonde	15a74d6d3e	FIX: don't enforce newuser_spam_host_threshold on private messages	2017-08-10 17:19:08 -04:00
Guo Xiang Tan	b404a4b97c	Merge pull request #5034 from tgxworld/fix_staged_primary_email ... FIX: Staged users are still missing primary email.	2017-08-10 10:30:51 +09:00
Neil Lalonde	ca1609c821	FIX: user directory didn't update stats of users with no recent activity	2017-08-09 15:57:42 -04:00
Guo Xiang Tan	90d7dd1f05	FIX: Ensure that post action moderation post uses the site's default locale. ... https://meta.discourse.org/t/a-post-in-looking-for-someone-to-customize-discourse-to-create-a-forum-site-requires-staff-attention/67468/5?u=tgxworld	2017-08-09 18:20:20 +09:00
Guo Xiang Tan	0bc690ed11	FIX: Staged users are still missing primary email.	2017-08-09 12:03:49 +09:00
Régis Hanol	519b70ea46	FIX: always trigger the ':user_updated' event ... We don't always use the UserUpdated class to update a user's record	2017-08-04 18:12:10 +02:00
Guo Xiang Tan	40fc6c429a	Merge pull request #5018 from discourse/wekbit-embedded-referer ... FIX: First load of embed comments would always fail on WebKit	2017-08-04 14:12:26 +09:00
Rafael dos Santos Silva	57a214e920	FIX: First load of embed comments would always fail on WebKit	2017-08-02 17:43:31 -03:00
Neil Lalonde	3de45ce0cd	FIX: use case insensitive group name search when applying group rules from SSO	2017-08-02 11:30:37 -04:00
Régis Hanol	e43799134c	fix the regexp used to valide user's website	2017-08-02 10:19:24 +02:00
Leo McArdle	836dee1120	FIX: add additional email to tests and clean up resulting mess	2017-07-31 22:27:29 +00:00
Neil Lalonde	5d528f0d15	Merge pull request #4958 from dmacjam/search_posts_by_filetype ... FEATURE: Search posts by filetype	2017-07-31 11:55:34 -04:00
Guo Xiang Tan	305b9b2da0	Add spec to ensure that even staged users contain a primary email.	2017-07-31 12:16:08 +09:00
Guo Xiang Tan	24e0e000b9	FIX: Always validate presence of user's primary_email.	2017-07-31 11:47:29 +09:00
Guo Xiang Tan	4620dfe92d	FEATURE: Add group settngs to allow users to leave a group freely. ... https://meta.discourse.org/t/split-join-leave-freely-setting-on-groups/65565	2017-07-28 15:00:25 +09:00
Guo Xiang Tan	5012d46cbd	Add rubocop to our build. (#5004)	2017-07-28 10:20:09 +09:00
Guo Xiang Tan	2442bba131	UX: Better group creation workflow. ... * Owners and users can now be added to a group during creation. https://meta.discourse.org/t/you-cannot-allow-membership-requests-without-any-owners/64760/3	2017-07-27 16:12:42 +09:00
Neil Lalonde	24cb950432	FEATURE: Watched Words: when posts contain words, do one of flag, require approval, censor, or block	2017-07-26 11:01:09 -04:00
Neil Lalonde	d8c27e3871	Merge branch 'master' into search_posts_by_filetype	2017-07-25 14:41:20 -04:00
Sam Saffron	045a2abcec	FEATURE: remove the timecop gem ... We should only have one way of mocking time, misuse of timecop was causing build stability issues	2017-07-24 12:11:10 -04:00
Guo Xiang Tan	6b17178533	Validate uniquness of api_key.	2017-07-24 21:46:08 +09:00
Guo Xiang Tan	fa09a02201	Fix specs.	2017-07-24 15:56:08 +09:00
Guo Xiang Tan	381a2a55be	Clear the cache after each test otherwise we are leaking state.	2017-07-24 11:41:37 +09:00
Leo McArdle	d0b027d88d	FEATURE: phase 1 of supporting multiple email addresses	2017-07-20 11:22:27 +09:00
Robin Ward	21e02d6969	Include the search_log_id in search results	2017-07-17 12:10:32 -04:00
Sam Saffron	d0c5205a52	Feature: Change markdown engine to markdown it ... This commit removes the old evilstreak markdownjs engine. - Adds specs to WhiteLister and changes it to stop using globals (Fixes large memory leak) - Fixes edge cases around bbcode handling - Removes mdtest which is no longer valid (to be replaced with CommonMark) - Updates MiniRacer to correct minor unmanaged memory leak - Fixes plugin specs	2017-07-17 11:41:34 -04:00
Robin Ward	6b6ad9391b	Clean up job for search logs	2017-07-14 14:30:58 -04:00
Robin Ward	97e211f837	FEATURE: Log Search Queries	2017-07-14 14:30:58 -04:00
Guo Xiang Tan	9792e03c63	FIX: Group name was being reverted to non-localized version. ... https://meta.discourse.org/t/localized-staff-group-names-changed/65360/16	2017-07-14 14:15:33 +09:00
Sam	3613ebee5b	Revert "correct specs" ... This reverts commit 2c6284ece3.	2017-07-12 18:09:57 -04:00
Sam	2c6284ece3	correct specs	2017-07-12 18:03:56 -04:00
Arpit Jalan	76981605fa	FIX: don't raise error when inviting existing user to private topic via email ... https://meta.discourse.org/t/inviting-existing-user-to-a-private-topic-message-via-email-shows-error-message/65994	2017-07-12 21:51:21 +05:30
Guo Xiang Tan	f529cb1674	Remove validation for invalid interpolation keys. ... * Our codebase currently supports custom interpolations keys that are not present in the original translation. The proper fix should be to make `TranslateOverride` aware of such keys.	2017-07-11 11:12:11 +09:00
Guo Xiang Tan	c5b1317a15	Remove code that is no longer being used.	2017-07-11 11:11:51 +09:00
Régis Hanol	c66b9dcdbd	add 'us-east-2' S3 region	2017-07-10 15:36:38 +02:00
Guo Xiang Tan	a338a7a53e	Fix the build.	2017-07-10 11:12:21 +09:00
Guo Xiang Tan	13f3de4bf6	Nuke all SiteSetting.stubs from our codebase.	2017-07-07 15:09:14 +09:00
Guo Xiang Tan	e7e16de3e0	Remove use of stubs in specs.	2017-07-07 13:18:53 +09:00
Jakub Macina	8c445e9f17	Fix backend code for searching by a filetype as a combination of uploads and topic links. Add rspec test for extracting file extension in upload.	2017-07-06 19:19:31 +02:00
Neil Lalonde	fcb2f68565	FIX: duplicate topics and posts in summary email because user has muted tags and topics contain multiple tags	2017-07-04 16:12:10 -04:00
Neil Lalonde	3964929c75	FIX: summary email excludes all untagged topics if user has muted some tags	2017-07-04 12:52:25 -04:00
Sam	845170bd6b	FEATURE: add support for group visibility level ... There are 4 visibility levels - public (default) - members only - staff - owners Note, admins and group owners ALWAYS have visibility to groups Migration treated old "non public" as "members only"	2017-07-03 15:26:57 -04:00
Sam	c79418d334	DEV: Move RTL into lib where it belongs	2017-07-03 15:26:57 -04:00
Arpit Jalan	984778d3ac	FIX: handle moving first post to a closed/archived topic	2017-07-03 21:21:20 +05:30
Arpit Jalan	e7b9b1312e	FEATURE: remove all invites ... https://meta.discourse.org/t/remove-all-invitations-button-for-the-admin-panel/65207	2017-06-29 22:30:10 +05:30
Guo Xiang Tan	5e156fbe85	FIX: Group.search should look up Group#full_name too. ... https://meta.discourse.org/t/mentioning-group-by-full-name-doesnt-work/63437/3	2017-06-29 16:37:59 +09:00
Robin Ward	b93edc9945	FIX: Make sure censored words are on boundaries in topic titles	2017-06-28 13:13:40 -04:00
Guo Xiang Tan	80e348d226	PERF: Speed up slow tests in our test suite. ... Before ``` Finished in 7 minutes 23 seconds (files took 4.15 seconds to load) 7145 examples, 0 failures, 10 pending ``` After ``` Finished in 6 minutes 12 seconds (files took 4.41 seconds to load) 7145 examples, 0 failures, 10 pending ```	2017-06-22 11:23:31 +09:00
Guo Xiang Tan	4c98bd9d5f	FIX: Can't update status_type of topic timers. ... https://meta.discourse.org/t/topic-timers-internal-error-500/64805	2017-06-21 15:31:15 +09:00
Jakub Macina	eaf46431d4	Add extraction of file extension in TopicLink and related rspec tests.	2017-06-19 17:09:54 +02:00
Guo Xiang Tan	b5ec241716	FIX: Validate interpolation keys used in translation overrides. ... https://meta.discourse.org/t/discobot-translation-missing-error/64429/6?u=tgxworld	2017-06-16 08:54:48 +09:00
Régis Hanol	d6c63cc5b2	FIX: user's default group should only be set once ... Setting a user's default groups based on their email address should only be done once, ie. when they confirm their email address. Previously we were doing this everytime we'd save a user record 🤷	2017-06-14 19:20:18 +02:00
Guo Xiang Tan	2fdf9068eb	FIX: Create notification for group users when group has been invited. ... https://meta.discourse.org/t/inviting-a-group-to-a-message-does-not-trigger-a-notification-mail/50509	2017-06-14 14:53:49 +09:00
Joffrey JAFFEUX	299339a373	Fixes emoji name to code missing tones	2017-06-13 14:10:26 -04:00
Arpit Jalan	b9c94aa234	FEATURE: add required user fields to invite accept form ... UX: make "accept invitation" page consistent with sign up modal	2017-06-12 20:43:07 +05:30
Guo Xiang Tan	e888369f51	UX: Don't send emails for discobot notifications.	2017-06-12 17:00:27 +09:00
Guo Xiang Tan	5794ff53a1	FIX: Copy custom fields when moving first post of a topic. ... https://meta.discourse.org/t/transfer-poll-votes-when-moving-a-topic-into-an-existing-one/63678	2017-06-07 19:04:48 +09:00
Guo Xiang Tan	ac6c1acbed	FIX: Groups that do not have any owners should not allow membership requests.	2017-06-05 10:02:37 +09:00
Sam	096177d0d5	confirm we notify on the destination, not source	2017-06-02 11:20:40 -04:00
Guo Xiang Tan	af3dc4e537	FIX: Publish group's categories to user when adding user to group. ... https://meta.discourse.org/t/joining-a-group-doesnt-take-effect-unless-the-browser-is-hard-refreshed/57357/11?u=tgxworld	2017-06-02 17:38:14 +09:00
Sam	a7fc93acac	FIX: post mover not clearing reply_to_user_id	2017-06-01 18:00:14 -04:00
Guo Xiang Tan	bd486100c0	Remove stubs on DiscourseEvent in tests.	2017-06-01 16:21:00 +09:00
Guo Xiang Tan	b0dd05fdc6	FIX: Inherit topic auto close when changing topic's category.	2017-05-31 17:40:21 +09:00
Sam	0aed2533ac	Revert unread optimisation, has too many edge cases	2017-05-26 09:04:13 -04:00
Guo Xiang Tan	e57d2f5cb8	FIX: Don't do anything if avatar url returns an invalid status code.	2017-05-26 13:02:40 +08:00
Sam	29fac1ac18	PERF: improve performance of unread queries ... Figuring out what unread topics a user has is a very expensive operation over time. Users can easily accumulate 10s of thousands of tracking state rows (1 for every topic they ever visit) When figuring out what a user has that is unread we need to join the tracking state records to the topic table. This can very quickly lead to cases where you need to scan through the entire topic table. This commit optimises it so we always keep track of the "first" date a user has unread topics. Then we can easily filter out all earlier topics from the join. We use pg functions, instead of nested queries here to assist the planner.	2017-05-25 15:07:30 -04:00
Guo Xiang Tan	76229535ac	Remove old test case.	2017-05-22 18:23:09 +08:00
Guo Xiang Tan	08c36fa968	REFACTOR: Clean up some code associated with topic timers.	2017-05-22 18:10:29 +08:00
Neil Lalonde	cbe8e05f79	disable test that fails randomly	2017-05-17 12:46:50 -04:00
Sam	763f156d91	FIX: require re-activation if SSO changes email and updates it	2017-05-16 16:18:18 -04:00
Neil Lalonde	7821400141	FEATURE: staff can set a timer to remind them about a topic	2017-05-16 14:49:50 -04:00
Sam	44d7fe89ed	FIX: unescape emoji in pretty title ... This makes emoji in title consistent, it is later escaped back when needed	2017-05-15 10:28:05 -04:00
Neil Lalonde	55b61e9bea	rename topic_status_update to topic_timer	2017-05-11 18:27:53 -04:00
Régis Hanol	9641d2413d	REFACTOR: upload workflow creation into UploadCreator ... - Automatically convert large-ish PNG/BMP to JPEG - Updated fast_image to latest version	2017-05-11 00:16:57 +02:00
Sam	7d9b5514ba	FIX: correctly invalidate theme css cache on scheme change	2017-05-10 15:47:11 -04:00
Sam	04b5516bf2	improve upload functionality	2017-05-10 15:47:11 -04:00
Sam	27362c5a4b	improve spec	2017-05-10 15:47:11 -04:00
Sam	bc0b9af576	FEATURE: support uploads for themes ... This allows themes to bundle various assets	2017-05-10 15:47:11 -04:00
Sam	f709899a1d	Allow theme field object model to support uploads	2017-05-10 15:46:42 -04:00
Robin Ward	96c59c5b82	FIX: Don't notify or return flags on system users	2017-05-08 13:13:35 -04:00
Sam	257c0dea70	Merge pull request #4852 from tgxworld/pull_the_plug_on_daily_mailing_list ... Remove daily mailing mode option as it doesn't scale.	2017-05-08 09:10:46 -04:00
Guo Xiang Tan	e61959e6a8	FIX: CustomEmoji may contain an invalid upload_id. ... https://meta.discourse.org/t/white-screen-after-deleting-custom-emoji/61608	2017-05-05 14:53:38 +08:00
Guo Xiang Tan	71a266b673	Remove daily mailing mode option as it doesn't scale. ... https://meta.discourse.org/t/daily-updates-option-for-mailing-list-mode/45029/14?u=tgxworld	2017-05-05 12:21:50 +08:00
Guo Xiang Tan	441e0059af	Fix tests that was testing the wrong class.	2017-05-05 10:59:07 +08:00
Sam	4ebbad991e	FIX: properly clean up related color schemes on delete	2017-05-04 14:03:17 -04:00
Sam	342ef5f81a	FEATURE: out-of-the-box dark/light user selectable themes	2017-05-03 11:31:33 -04:00
Arpit Jalan	75300b6356	improve specs	2017-05-03 17:48:33 +05:30
Arpit Jalan	86f1cc8c92	FIX: don't apply max_emails_per_day_per_user on critical emails	2017-05-03 17:07:39 +05:30
Arpit Jalan	cdce060a38	FIX: don't apply max emails per day per user to forgot password	2017-05-03 14:02:37 +05:30
Sam	946f25098f	Refactor theme fields so they support custom theme defined vars ... This paves the way to allowing themes to specify uploads and so on.	2017-05-02 16:02:14 -04:00
Arpit Jalan	77a8cae094	FIX: rescue specific errors on invite failure	2017-05-02 15:13:33 +05:30
Guo Xiang Tan	59b906ab0d	FEATURE: Disable minimum post length check when in PM with non human users. ... https://meta.discourse.org/t/discourse-narrative-bot-beta-feedback/58621/65?u=tgxworld	2017-04-27 16:00:22 +08:00
Arpit Jalan	aeead60036	FIX: make TopicEmbed trashable	2017-04-25 18:40:39 +05:30
Sam	aec73d4003	correct the spec again	2017-04-20 17:41:35 -04:00
Sam	47b99e0922	group is now default watched	2017-04-20 17:38:46 -04:00
Sam	5365973c0a	FIX: detection of error changed, so you can clear errors	2017-04-20 16:55:18 -04:00
Sam	7a9eee1b71	FEATURE: default notification level for group messages ... also fixes it so staff can amend other user's group notification level	2017-04-20 15:47:35 -04:00
Sam	7eabb90b71	FEATURE: added error messages for bad theme CSS / JS	2017-04-19 16:46:46 -04:00
cpradio	2dccaff25d	FIX: Correct behavior of auto-notification state updating to exclude when the topic already has a state of normal/muted	2017-04-19 06:29:35 -04:00
Arpit Jalan	f968b4e662	Fix the build	2017-04-18 16:34:58 +05:30
Arpit Jalan	1c23aedccf	FIX: always send password reset email when accepting invite if password is not set	2017-04-18 14:37:06 +05:30
Arpit Jalan	8dea70d354	Revert "FIX: User website allows new TLDs"	2017-04-18 13:18:51 +05:30
Rafael dos Santos Silva	4289dbe3e5	FIX: User website allows new TLDs	2017-04-18 00:30:37 -03:00
Sam	5e3a0846f7	FEATURE: allow themes to share color schemes	2017-04-17 15:56:24 -04:00
Arpit Jalan	7389831961	Fix the build	2017-04-15 15:52:35 +05:30
Arpit Jalan	0954367bf4	FIX: send activation email when accepting invite if password is set	2017-04-15 14:59:50 +05:30
Guo Xiang Tan	04016f0dec	Support Ruby 2.4.	2017-04-15 12:29:00 +08:00
cpradio	e3ad50de05	Add spec for auto notification update ... It should update the topic subscription so long as what is being requested is higher than what is currently set for the user and the given topic It should not update the topic subscription if the requested subscription is less than what is currently set for the user and given topic	2017-04-14 18:30:01 -04:00
Sam	def7348777	FIX: display custom sections with default theme ... also cleans up mechanism for previewing themes, cleans up naming, gets rid of old janky "preview_style", secures local theme key	2017-04-14 13:35:12 -04:00
Guo Xiang Tan	bda20cc44a	FIX: Don't enqueue topic status update job if topic is deleted.	2017-04-13 12:02:35 +08:00
Guo Xiang Tan	57788200ec	REFACTOR: Add User.reserved_username?.	2017-04-13 10:44:26 +08:00
Sam	a7ed8a0310	correct theme importer to support embedded.scss	2017-04-12 11:30:16 -04:00
Sam	95d095c97d	test should be configuring git info	2017-04-12 11:19:47 -04:00
Sam	a3e8c3cd7b	FEATURE: Native theme support ... This feature introduces the concept of themes. Themes are an evolution of site customizations. Themes introduce two very big conceptual changes: - A theme may include other "child themes", children can include grand children and so on. - A theme may specify a color scheme The change does away with the idea of "enabled" color schemes. It also adds a bunch of big niceties like - You can source a theme from a git repo - History for themes is much improved - You can only have a single enabled theme. Themes can be selected by users, if you opt for it. On a technical level this change comes with a whole bunch of goodies - All CSS is now compiled using a custom pipeline that uses libsass see /lib/stylesheet - There is a single pipeline for css compilation (in the past we used one for customizations and another one for the rest of the app - The stylesheet pipeline is now divorced of sprockets, there is no reliance on sprockets for CSS bundling - CSS is generated with source maps everywhere (including themes) this makes debugging much easier - Our "live reloader" is smarter and avoid a flash of unstyled content we run a file watcher in "puma" in dev so you no longer need to run rake autospec to watch for CSS changes	2017-04-12 10:53:49 -04:00
Dean Taylor	1a9afa976d	FEATURE: Add AWS S3 EU (London) "eu-west-2" region	2017-04-12 10:38:17 -04:00
Guo Xiang Tan	7cb389a235	Add DiscourseEvent trigger when user's topic notification level changes.	2017-04-12 11:56:50 +08:00
Arpit Jalan	8fb41bf5fb	FIX: update timestamp when resending invite	2017-04-11 20:02:32 +05:30
Guo Xiang Tan	73180c8a19	FIX: Private message can be set to publish in the future.	2017-04-11 20:44:25 +08:00
Robin Ward	e2ff06ce02	FIX: rounding error in spec	2017-04-07 17:44:02 -04:00
Robin Ward	40cee37bcc	FIX: Don't insert topic status messages unless the status changes	2017-04-07 17:10:43 -04:00
Guo Xiang Tan	71501feaf3	Improve validation for TopicStatusUpdate.	2017-04-07 15:32:00 +08:00
David Rodríguez	934bff43d9	FIX: Copy post actions when moving a topic.	2017-04-06 12:16:22 +08:00
Guo Xiang Tan	ad44d2a400	Merge pull request #4790 from tgxworld/add_publish_to_topic_status_update ... FEATURE: Allow admins to schedule a topic to be published in the future.	2017-04-04 11:18:53 +08:00
Guo Xiang Tan	f4758a4c4d	FEATURE: Allow admins to schedule a topic to be published in the future.	2017-04-04 11:16:05 +08:00
Arpit Jalan	5ff29ce321	add test case for topic status update based on last post	2017-04-03 22:35:56 +05:30
Guo Xiang Tan	5cf75c67df	FIX: Callback undefined error when topic has been deleted.	2017-04-03 09:06:15 +08:00
Guo Xiang Tan	ed577fbff8	FEATURE: Pause a topic instead of permanently closing when flag threshold is reached.	2017-03-31 14:35:05 +08:00
Guo Xiang Tan	34b7bee568	FEATURE: Allow admin to auto reopen at topic. ... * This commit also introduces a `TopicStatusUpdate` model to support other forms of deferred topic status update in the future.	2017-03-31 11:14:18 +08:00
Robin Ward	7b6242bfbb	Minor cleanup of /users/ rename	2017-03-30 10:23:24 -04:00
Robin Ward	14410b71fb	Convert server side paths to use /u/	2017-03-30 10:23:24 -04:00
Robin Ward	45a257815a	Convert front end paths from /users/ to /u/	2017-03-30 10:23:24 -04:00
Guo Xiang Tan	7cf0f39066	Require Sidekiq::Testing in rails helper.	2017-03-29 11:10:25 +08:00
Arpit Jalan	4812417192	FIX: do not add user to group based on email domain unless email is confirmed	2017-03-28 15:02:40 +05:30
Arpit Jalan	3378e2d49f	FIX: update topic fancy title when updating category name	2017-03-26 12:29:53 +05:30
Arpit Jalan	295cf8839e	FIX: better error message when invited user already exists	2017-03-22 13:55:28 +05:30
Arpit Jalan	8cbfa24ca2	Fix failing test	2017-03-20 20:14:25 +05:30
Arpit Jalan	521c88fe58	FIX: enqueue activation email for invited user that has password set	2017-03-20 17:13:21 +05:30
Guo Xiang Tan	6057e17ae7	Fix weird test failure.	2017-03-20 12:06:37 +08:00
Robin Ward	fd591257a8	Merge pull request #4759 from kennym/support-ports-for-ip-addresses-in-embedding ... FIX: Allow ports for embed host IPs	2017-03-16 11:23:42 -04:00
Guo Xiang Tan	bf78c228f4	FIX: User created web hook being enqueued before record has been saved. ... * Improve web hook tests as well.	2017-03-16 14:44:09 +08:00
Erick Guan	cfbfea0596	FEATURE: Allow easier customization to the web hook event serialization.	2017-03-16 10:09:05 +08:00
Kenny Meyer	ae957bca25	Allow ports for embed host IPs	2017-03-15 18:16:34 -03:00
Guo Xiang Tan	d173473509	Fix randomly failing specs.	2017-03-14 14:43:48 +08:00
Sam	64680286f4	correct logic, so revalidation is reset ... correct test so it can run at any point	2017-03-13 10:47:43 -04:00
Sam	ef24fd54ba	FEATUE: automatically validate token is stored in redis ... This ensures we have some handling for redis flushall We attempt to recover our in-memory session token once every 30 seconds Code is careful to only set the token if it is nil, to allow for manual cycling to remain safe if needed	2017-03-13 10:19:02 -04:00
Guo Xiang Tan	4d4a1a1552	Add scope for human users.	2017-03-11 14:25:09 +08:00
Sam	99f4d5082b	FIX: Improve token rotation and increase logging ... - avoid access denied on bad cookie, instead just nuke it - avoid marking a token unseen for first minute post rotation - log path in user auth token logs	2017-03-07 13:27:43 -05:00
Robin Ward	dad57fa033	FIX: More errors with non-ascii URLs	2017-03-07 11:21:41 -05:00
Guo Xiang Tan	d1e587c10a	Merge pull request #4737 from oblakeerickson/approve_invited_user ... FIX: approve invited user	2017-03-07 21:14:34 +08:00
Guo Xiang Tan	7d82a53dfe	FIX: Group#name is case insensitive.	2017-03-06 17:24:03 +08:00
Guo Xiang Tan	8aea3caf00	FIX: Ensure that we only move posts that belong to the original topic.	2017-03-06 15:04:10 +08:00
Blake Erickson	dbb3ddc7a6	FIX: approve invited user ... This commit fixes the case where invited users who typed in a password would not be approved by default. Because we moved the user create logic for an invited user there was a clash with the `save` in the user model and the `save` in the invite_redeemer class. - added approve logic into invite_redeemer class. - added tests to verify that the user is approved - added a check to see if must_approve_users is on - added a check to see if the inviter is staff - go ahead and approve the user if must_approve_users is off - keep existing User.approve workflow if user exists - improve if/else logic to remove duplicate code - use `Time.zone.now`	2017-03-05 06:58:23 -07:00
Guo Xiang Tan	bcf634ca85	Merge pull request #4728 from nbianca/username-regex ... Add support for username regex.	2017-03-03 22:59:23 +08:00
Bianca Nenciu	30909ec54e	Add support for username regex.	2017-03-02 13:53:45 +02:00
Neil Lalonde	262016604d	FEATURE: each category can control how many topics to show on categories page	2017-03-01 15:12:57 -05:00
Sam	3ac4709903	FIX: on initial token issue stop unmarking token as unseen ... prev and current are the same so we need special logic to bypass	2017-02-28 10:38:22 -05:00
Robin Ward	bf9626d031	FIX: Embedding was broken with non-english URLs and ports	2017-02-27 12:17:52 -05:00
Sam Saffron	7e8f0dc967	FIX: attempt to handle ios edge case where token is seen but unsaved ... This relaxes our security in the following way - prev auth token is always accepted as long as rotation date is within our window of SiteSetting.maximum_session_age.hours (previously old token expired within a minute of new one being seen) - new auth token is marked unseen if we are presented with an old token after we already saw new one This attempts to fix an issue where ios webkit is not committing new cookies	2017-02-26 17:09:57 -05:00
Neil Lalonde	c94fdcea38	FIX: admin dashboard posts count should not include system posts and whispers	2017-02-21 14:45:41 -05:00
Régis Hanol	cb99f59ec3	reset bounce score when email is successfully changed	2017-02-20 10:37:01 +01:00
Robin Ward	e62c0a42fa	FIX: Support multiple embeddable host records with the same host	2017-02-17 12:41:34 -05:00
Neil Lalonde	c0e1722ca6	fix intermittent spec failure due to Time comparison with TimeWithZone	2017-02-17 10:30:29 -05:00
Neil Lalonde	3fb50d587d	FIX: invited users and new TL1 users will see their first notification highlighted	2017-02-17 10:30:29 -05:00
Neil Lalonde	4b28bfaa15	Merge pull request #4710 from ento/fix-s3-config-check ... FIX: admin dashboard shouldn't complain when using IAM profile for S3 access	2017-02-15 17:02:07 -05:00
Neil Lalonde	d0fbb27f3e	FEATURE: new invite acceptance page, where username can be chosen and password can be set	2017-02-15 16:51:57 -05:00
Sam	9c51e3e8e7	amend preloader api to supply topic list	2017-02-15 12:04:02 -05:00
Sam	2c59ffeb2c	FIX: token rotation not accounting for overlapping tokens correctly ... also... freeze_time has no block form, correct all usages and specs	2017-02-15 10:58:18 -05:00
Marica Odagaki	af9c97ec43	Add failing tests	2017-02-15 00:05:58 -08:00
Marica Odagaki	2c1279b740	Fix typo to be more consistent with other test descriptions	2017-02-15 00:04:10 -08:00
Sam	f2099c3811	adjust API	2017-02-14 16:32:33 -05:00
Sam	89d5e8ab4b	FEATURE: allow plugins to preload data in topic list	2017-02-14 16:29:06 -05:00
Sam	0ab96a7691	FEATURE: add hidden setting for verbose auth token logging ... This is only needed to debug auth token issues, will result in lots of logging	2017-02-13 14:01:09 -05:00
Robin Ward	e1d358ffbf	FIX: Don't clear the login hint when the system user is saved	2017-02-13 10:54:20 -05:00
Jeff Atwood	3ee7a9266c	Merge pull request #4686 from tgxworld/group_is_visible_if_user_is_group_owner ... FIX: Show groups that user is owner of on groups page.	2017-02-11 22:18:44 -08:00
Sam Saffron	4332f0dde1	FEATURE: allow user search API to restrict to group	2017-02-09 18:45:39 -05:00
Sam	49e7124a5e	clarify override semantics in spec	2017-02-07 10:41:27 -05:00
Sam	f34907b523	Merge pull request #4681 from vietqhoang/feature/add-user-title-to-sso-payload ... FEATURE: Add user title to SSO payload	2017-02-07 10:25:32 -05:00
Sam	ff49f72ad9	FEATURE: per client user tokens ... Revamped system for managing authentication tokens. - Every user has 1 token per client (web browser) - Tokens are rotated every 10 minutes New system migrates the old tokens to "legacy" tokens, so users still remain logged on. Also introduces weekly job to expire old auth tokens.	2017-02-07 09:22:16 -05:00
Régis Hanol	84af84dc52	prevent inactive & staged users from being automatically added to a group	2017-02-06 17:49:27 +01:00
Robin Ward	b251d11518	FIX: If you make a new banner, clear the old dismissed values	2017-02-03 15:07:38 -05:00
Guo Xiang Tan	61111a3f9b	FIX: Show groups that user is owner of on groups page.	2017-02-03 16:51:32 +08:00
Arpit Jalan	6b8691ecea	Merge pull request #4685 from techAPJ/approve-users-invite-fix ... FIX: allow existing users to be invited to topic/message when must_approve_users is enabled	2017-02-03 13:22:18 +05:30
Arpit Jalan	dc2171960b	FIX: allow existing users to be invited to topic/message when must_approve_users is enabled	2017-02-03 13:01:23 +05:30
Guo Xiang Tan	c392994793	Fix specs.	2017-02-03 08:38:19 +08:00
Neil Lalonde	b91cb92af0	FIX: reports for time to first reply and topics without replies were counting whispers and moderator actions	2017-02-02 17:27:41 -05:00
Guo Xiang Tan	3c28d94706	FIX: Don't configure Redis connector if Redis slave config is not set.	2017-02-02 13:48:55 +08:00
Viet Hoang	40164ccd4a	Add user title to SSO payload	2017-01-31 16:42:27 -08:00
Rimian Perkins	25516874b5	FIX: Escape regexp chars in SiteSetting.censored_words.	2017-01-31 10:14:51 +08:00
Guo Xiang Tan	0e5d490b05	No need for special helper to reset SiteSetting state. ... * SiteSetting in tests uses a local provider that resets it.	2017-01-28 10:55:49 +08:00
Neil Lalonde	7ead3e1f18	fix failing specs	2017-01-27 16:17:10 -05:00
Robin Ward	496682c442	Merge pull request #4662 from tgxworld/fix_localized_group_name_change ... Fix localized group name change	2017-01-26 10:50:00 -05:00
Guo Xiang Tan	ce07da1d8b	UX: Only display the words that fails censored words validations.	2017-01-24 13:11:05 +08:00
Guo Xiang Tan	59dfb51a35	FIX: Don't change automatic group name if localized name has been taken.	2017-01-18 12:20:23 +08:00
Guo Xiang Tan	63954c1b33	FIX: Same user record being saved twice causing validation to fail.	2017-01-16 16:41:03 +08:00
Guo Xiang Tan	e3b6f9b8ae	FIX: Do not update user stats like counts for private messages.	2017-01-16 11:07:53 +08:00
Guo Xiang Tan	ed5fa20b0c	Revert "FIX: error during signup saying "Password is the same as your current password" due to automatic group membership granting a trust level" ... This reverts commit 9c40657ba4. Calling this whenever a user is initialize is hurting us bad on performance.	2017-01-16 09:44:10 +08:00
Régis Hanol	887e9af84f	FEATURE: new 'max_image_megapixels' site setting	2017-01-11 23:37:12 +01:00
Guo Xiang Tan	3d21ccd4a5	FIX: Add validation to disallow censored words in topic title.	2017-01-09 16:55:41 +08:00
Guo Xiang Tan	f1beef43a8	Merge pull request #4618 from tgxworld/fix_invalid_emails ... FIX: Don't allow invalid email to be saved.	2016-12-30 07:11:48 +08:00
Neil Lalonde	9c40657ba4	FIX: error during signup saying "Password is the same as your current password" due to automatic group membership granting a trust level	2016-12-28 17:36:04 -05:00
Arpit Jalan	d72cbcb2a4	FEATURE: new setting to validate user website	2016-12-26 21:29:27 +05:30
Sam	c531f4ded5	remove rails-observers ... Rails yanked out observers many many years ago, instead the functionality was yanked out to a gem that is very lightly maintained. For example: if we want to upgrade to rails 5 there is no published gem Internally the usage of observers had quite a few problem. The series of refactors renamed a bunch of classes to give us more clarity and removed some magic.	2016-12-22 16:46:53 +11:00
Sam	019f1a1d06	UserEmailObserver is now removed ... no big surprises here was pretty straightforward after_commit semantics sure are weird though	2016-12-22 16:46:53 +11:00
Sam	2f6a4cc6de	remove UserActionObserver, replace with after_save and service ... interestingly there was some left over dead code from when stars existed in the topic_users table	2016-12-22 16:46:53 +11:00
Sam	0a78ae739d	Remove SearchObserver, aim is to remove all observers ... rails-observers gem is mostly unmaintained and is a pain to carry forward new implementation contains significantly less magic as a bonus	2016-12-22 13:13:14 +11:00
Guo Xiang Tan	13c6191e89	FIX: Don't allow invalid email to be saved.	2016-12-21 17:47:11 +08:00
Guo Xiang Tan	5d7f3223f0	SECURITY: Users can only bookmark posts which they can see.	2016-12-21 12:01:26 +08:00
Neil Lalonde	74956694e5	If summary email finds no topics, show topics more than 1 day old from new users	2016-12-19 14:54:08 -05:00
Neil Lalonde	923cf73c6e	Topic Featured Links: move data from custom fields to topics and categories tables. Invert behaviour of topic_featured_link_allowed checkbox. Fix a bug with invalid topic records due to changing that category checkbox.	2016-12-19 14:54:07 -05:00
Sam	eb2db23b40	FEATURE: remove email_token_grace_period_hours ... The site setting email_token_grace_period_hours just causes confusion and should not be used anyway. Out of the box, tokens stop working once confirmed, no need to add complexity here	2016-12-19 17:15:20 +11:00
Sam	15b5fddd49	SECURITY: protect upload params, only allow very strict filenames	2016-12-19 10:16:18 +11:00
Guo Xiang Tan	69330f8bc2	Add user_updated event to webhooks.	2016-12-13 11:26:26 +08:00
Guo Xiang Tan	9a800107cb	FIX: Associate category logo and background to uploads record.	2016-12-12 17:37:28 +08:00
Guo Xiang Tan	05f55dbc10	FEATURE: Group logs.	2016-12-12 17:29:54 +08:00
Neil Lalonde	24d2973108	enable featured links by default	2016-12-09 16:08:17 -05:00