Commit Graph

582 Commits

Author SHA1 Message Date
Martin Brennan
6261339da9
Improving bookmarks part 1 (#8466)
Note: All of this functionality is hidden behind a hidden, default false, site setting called `enable_bookmarks_with_reminders`. Also, any feedback on Ember code would be greatly appreciated!

This is part 1 of the bookmark improvements. The next PR will address the backend logic to send reminder notifications for bookmarked posts to users. This PR adds the following functionality:

* We are adding a new `bookmarks` table and `Bookmark` model to make the bookmarks a first-class citizen and to allow attaching reminders to them.
* Posts now have a new button in their actions menu that has the icon of an actual book
* Clicking the button opens the new bookmark modal.
* Both name and the reminder type are optional.
* If you close the modal without doing anything, the bookmark is saved with no reminder.
* If you click the Cancel button, no bookmark is saved at all.
* All of the reminder type tiles are dynamic and the times they show will be based on your user timezone set in your profile (this should already be set for you).
* If for some reason a user does not have their timezone set they will not be able to set a reminder, but they will still be able to create a bookmark.
* A bookmark can be deleted by clicking on the book icon again which will be red if the post is bookmarked.

This PR does NOT do anything to migrate or change existing bookmarks in the form of `PostActions`, the two features live side-by-side here. Also this does nothing to the topic bookmarking.
2019-12-11 14:04:02 +10:00
Mark VanLandingham
14cb386f1e
FEATURE: Featured topic for user profile & card (#8461) 2019-12-09 11:15:47 -08:00
Kris
6c9af6d81e FIX: Too much blank padding in video oneboxes 2019-11-06 15:07:51 -05:00
Joe
d14851e552 UX: better alignment for tags in the header (#8047)
* Removes unused styles

This commit only removes unnecessary / duplicate styles. It does not cause any visual changes.

* adds class to `<h1>` tag in header topic info.

This is much better to target than `h1`

* removes unused styles

* header title margin adjustment

* minor header-title margin adjustments

* One more header-title margin adjustment
2019-08-28 18:18:27 +10:00
Roman Rizzi
7c741fa0d6
FEATURE: Publish read state on group messages. (Originally introduced in #7989) (#8025)
* Revert "Revert "FEATURE: Publish read state on group messages. (#7989) [Undo revert] (#8024)""

This reverts commit 36425eb9f0.

* Fix: Show who read only if the attribute is enabled

* PERF: Precalculate the last post  readed by a group member

* Use book-reader icon instear of far-eye

* FIX: update topic groups correctly

* DEV: Tidy up read indicator update on write
2019-08-27 09:09:00 -03:00
romanrizzi
36425eb9f0 Revert "FEATURE: Publish read state on group messages. (#7989) [Undo revert] (#8024)"
This reverts commit 5dda5c2f7c.
2019-08-20 13:29:22 -03:00
Roman Rizzi
5dda5c2f7c
FEATURE: Publish read state on group messages. (#7989) [Undo revert] (#8024)
* Reenable: "FEATURE: Publish read state on group messages. (#7989)"

This reverts commit 67f5cc1ce8.

* FIX: Read indicator only appears when the group setting is enabled
2019-08-20 11:57:25 -03:00
romanrizzi
67f5cc1ce8 Revert "FEATURE: Publish read state on group messages. (#7989)"
This reverts commit 1630dae2db.
2019-08-20 10:24:34 -03:00
Roman Rizzi
1630dae2db
FEATURE: Publish read state on group messages. (#7989)
* Enable or disable read state based on group attribute

* When read state needs to be published, the minimum unread count is calculated in the topic query. This way, we can know if someone reads the last post

* The option can be enabled/disabled from the UI

* The read indicator will live-updated using message bus

* Show read indicator on every post

* The read indicator now shows read count and can be expanded to see user avatars

* Read count gets updated everytime someone reads a message

* Simplify topic-list read indicator logic

* Unsubscribe from message bus on willDestroyElement, removed unnecesarry values from post-menu, and added a comment to explain where does minimum_unread_count comes from
2019-08-20 09:46:57 -03:00
Kris
36cb5f3038 UX: Increase contrast of pinned/tracking reason text, improve layout 2019-07-29 11:54:23 -04:00
Joe
e49b5fa30c
UX: expand-post button alignment fix (#7865) 2019-07-08 14:36:15 +08:00
Osama Sayegh
50e4ecc77e
UX: hide post is unread tooltip after the post is read (#7813)
Note we can't use `display: none` here because it doesn't work with
animations.
2019-06-26 22:39:57 +03:00
Arpit Jalan
2738d11f60
UX: show like icon on archived posts (#7775) 2019-06-21 20:47:32 +05:30
Kris
98336de266 UX: Cleanup crawler styles, improve schema.org markup (#7668)
* Cleaning up crawler styles, improving some schema.org markup

* Cleaning up crawler styles, improving some schema.org markup

* additional styling

* add space for pagination
2019-06-03 12:03:16 +10:00
Robin Ward
31e100530f FEATURE: Flag count in post menu
This change shows a notification number besides the flag icon in the
post menu if there is reviewable content associated with the post.
Additionally, if there is pending stuff to review, the icon has a red
background.

We have also removed the list of links below a post with the flag
status. A reviewer is meant to click the number beside the flag icon to
view the flags. As a consequence of losing those links, we've removed
the ability to undo or ignore flags below a post.
2019-05-06 16:13:31 -04:00
Saurabh Patel
da2f659635 UX: Improve posts layout for crawler (#7286) 2019-04-03 11:58:00 +02:00
Kris
252e17ea1b UX: add padding to hidden content link 2019-03-21 11:50:41 -04:00
Kris
6e26358380 REFACTOR: streamline like button styles, clarify for themeing, enable tab focus 2019-03-07 21:09:57 -05:00
Kris
d6875a77fb UX: Apply new-user color to full name and username 2019-02-25 17:09:41 -05:00
Joffrey JAFFEUX
04a63cfaaa
[WIP] FEATURE: merge share and invite actions together (#7021)
This commit also:
- removes [+ New Topic] behaviour from share, this feature has been duplicated in composer actions, months ago
- introduces our new experimental spacing standard for css: eg: `s(2)`
- introduces a new panel UI for modals
2019-02-20 15:42:44 +01:00
Kris
3da35081e5 UX: Embedded post collapse button hover color fix 2019-02-12 17:21:33 -05:00
Robin Ward
ca03b2ff30 Move SCSS variables for topic post width
This allows them to be re-used by other components, for example the
upcoming review queue.
2019-02-06 11:37:59 -05:00
Kris
94f16ba931 UX: Make button icons use lighter color instead of opacity 2019-01-31 13:59:49 -05:00
Kris
ec71091216 FIX: Don't override user flair styles in topic map 2019-01-21 12:37:49 -05:00
Joe
74f0bd08c0
UX: removes unnecessary margin in header tag wrapper
This margin is not needed and doesn't exist in the mobile view. 

It causes a bit of a problem in desktop topics with no categories and more prominently in PMs in the desktop view.

There's a small TODO here where the rest of the extra-info-wrapper styles should all be moved to header sylesheets.
2018-12-28 21:31:41 +08:00
Kris
db32d29eaa UX: Refactoring topic statuses for consistent icon sizes & colors 2018-12-06 19:22:04 -05:00
Kris
a88f931d6f UX: Moving categories under topic title in topic list, removing category column (#6731)
* Starting to remove category column from topic list

* stacked nav alignment adjustment

* Revert "stacked nav alignment adjustment"

This reverts commit 98800c7058.

* remove comment

* removing function
2018-12-05 16:12:26 -08:00
Kris
a113777003 Extra margin isn't needed on mobile 2018-11-30 19:49:26 -05:00
Kris
964fd983b7 z-index fix for tooltips within posts 2018-11-27 09:49:34 -05:00
Penar Musaraj
03deda2147
Upgrade to FontAwesome 5 (take two) (#6673)
* Add missing icons to set

* Revert FA5 revert

 This reverts commit 42572ff

* use new SVG syntax in locales

* Noscript page changes (remove login button, center "powered by" footer text)

* Cast wider net for SVG icons in settings

- include any _icon setting for SVG registry (offers better support for plugin settings)

- let themes store multiple pipe-delimited icons in a setting

- also replaces broken onebox image icon with SVG reference in cooked post processor

* interpolate icons in locales

* Fix composer whisper icon alignment

* Add support for stacked icons

* SECURITY: enforce hostname to match discourse hostname

This ensures that the hostname rails uses for various helpers always matches
the Discourse hostname

* load SVG sprite with pre-initializers

* FIX: enable caching on SVG sprites

* PERF: use JSONP for SVG sprites so they are served from CDN

This avoids needing to deal with CORS for loading of the SVG

Note, added the svg- prefix to the filename so we can quickly tell in
dev tools what the file is

* Add missing SVG sprite JSONP script to CSP

* Upgrade to FA 5.5.0

* Add support for all FA4.7 icons

- adds complete frontend and backend for renamed FA4.7 icons

- improves performance of SvgSprite.bundle and SvgSprite.all_icons

* Fix group avatar flair preview

- adds an endpoint at /svg-sprites/search/:keyword

- adds frontend ajax call that pulls icon in avatar flair preview even when it is not in subset

* Remove FA 4.7 font files
2018-11-26 16:49:57 -05:00
Joe
ee6c0170ce FEATURE: Scroll-based logo on mobile (#6632) 2018-11-21 21:21:49 -05:00
Sam
e17a13ce19 FEATURE: additional "related messages" section
This splits out previous message correspondence from suggeted and instead
has a dedicated section called "related messages"
2018-11-12 13:04:42 +11:00
Sam
42572ff138 Revert font awesome 5 changes
We are still pushing ahead on this 100% just need a bit longer to prepare
all plugins
2018-11-08 16:12:18 +11:00
Penar Musaraj
005e1ecb9b
FEATURE: Update Font Awesome to v5.4.1 and SVGs (#6557)
* First take on subsetting svg icons

* FontAwesome 5 svg subset WIP

* Include icons from plugins/badges into svg sprite subset

* add svg icon support to themes

* Add spec for SvgSprite

* Misc. SVG icon fixes

* Use FA5 svgs in local-dates plugin

* CSS adjustments, fix SVG icons in group flair

* Use SVG icons in poll plugin

* Add SVG icons to /wizard
2018-11-07 13:05:43 -05:00
Kris
b23ebf10c2 Minor post alignment fixes 2018-10-16 12:39:55 -04:00
Kris
34e8d17ad0 Fixing left alignment of post controls 2018-10-10 12:11:47 -04:00
Kris
ec33b46d31 IE11 doesn't support nested calc 2018-10-08 11:55:54 -04:00
Kris
41ceb6ca88 topic body and small action widths inconsistent 2018-10-05 18:37:23 -04:00
Kris
fa21b39875 FIX: topic admin menu was clipped on short posts due to overflow hidden 2018-10-05 10:51:27 -04:00
Kris
1c65969bb4 post read-state icon alignment 2018-09-05 13:19:36 -04:00
Joffrey JAFFEUX
4fdc27bab5
UI: improves participants list in messages (#6320) 2018-08-27 15:41:34 +02:00
Kris
84d822959a Reducing some specificity, color fix 2018-08-03 17:44:22 -04:00
Kris
f0bea4ae55 Improve PM participant list 2018-08-01 16:20:14 -04:00
Kris
c6fe6a8820 Improving mutli-post select styling 2018-07-20 16:37:43 -04:00
Kris
b79fedd540 Streamlining some breakpoint mixins 2018-07-12 16:39:16 -04:00
Robin Ward
45a2c94fb3 FIX: Margin on post-info should be present in mobile and desktop 2018-06-20 15:39:36 -04:00
Robin Ward
e7fbcf4ba4
UX: Refactor topic metadata's many floats into flexbox (#6018) 2018-06-20 13:06:20 -04:00
Robin Ward
fbc194c330 Don't use !important for wiki color. Allow themes to override it. 2018-06-20 10:47:27 -04:00
Joffrey JAFFEUX
913d97e780
fix prettier 2018-06-18 20:10:48 +02:00
Kris
ceb9226518 Giving post admin menu variable width in case of long translations 2018-06-18 13:02:50 -04:00
Joffrey JAFFEUX
174d392e5a
DEV: adds prettier (#5956)
Run `prettier --write "app/assets/stylesheets/**/*.scss" "plugins/**/*.scss"` after making sure you installed it with `yarn`

It's recommended to configure your editor to run prettier on file save.
2018-06-08 11:49:31 +02:00
Kris
de6dd2dc02 removing extra border 2018-05-02 16:25:27 -04:00
Kris
606670815c Improving signup CTA padding 2018-04-25 21:59:47 -04:00
Kris
02590feb4d Like counter spacing fix 2018-04-24 13:39:03 -04:00
Kris
f812f5cd1c UX: Use empty heart for unliked state 2018-04-23 12:41:41 -04:00
Jeff Wong
641276af46 more consistent colors for dark themes on hover (#5743) 2018-04-06 22:44:51 -04:00
Kris
2eec572159 minor alignment fix on new like button 2018-04-02 12:17:50 -04:00
Arpit Jalan
9815f301cc UX: alignment was off on likes for your own post 2018-03-31 07:21:18 +05:30
Kris
4fcbe9128e Minor color/alignment adjustment on like button 2018-03-30 16:46:37 -04:00
Arpit Jalan
4760f0e7a9 UX: better like button
Co-authored-by: jjaffeux <j.jaffeux@gmail.com>
2018-03-30 22:45:51 +05:30
Arpit Jalan
bf41010ac3 UX: make own post heart glyph grey 2018-03-30 10:35:54 +05:30
Arpit Jalan
fe17ee6924 UX: own post likes glyph margin was off 2018-03-30 10:10:55 +05:30
Arpit Jalan
a55b458e56 UX: show heart glyph on your own likes count 2018-03-30 09:06:57 +05:30
Jeff Atwood
131b19c26b move like count a tad closer to like glyph 2018-03-29 16:36:59 -07:00
Arpit Jalan
629ad48621 UX: better likes count margin 2018-03-30 03:02:56 +05:30
Kris
e2a524550c Prevent long category names from breaking topic/category list layouts 2018-02-26 14:21:28 -05:00
Guo Xiang Tan
ae2d7ba857 Partially revert d170c8fccc to bring back 3df0626aa5. 2018-02-22 13:42:04 +08:00
Arpit Jalan
d170c8fccc Revert 'Accessibility: focus management in topics'
reverts:

- 3df0626aa5
- 3212cdda78
- 59b7760e2e
- bfc1301823
2018-02-22 10:32:37 +05:30
Kane York
3df0626aa5 UX: Apply hover styling to post actions on focus 2018-02-22 11:55:36 +08:00
Kris
677e126fbf UX: Implementing a box-shadow system, cleaning up existing shadows 2018-02-20 12:18:20 -05:00
Kris
32116654ec removing duplicate topic-map desktop/mobile styles 2018-02-12 15:20:14 -05:00
Kris
6f094ee27e extra-info-wrapper titles were too short 2018-02-08 20:43:34 -05:00
Kris
cd798e49d8 header text wrap fix 2018-02-02 19:33:00 -05:00
Kris
8bac9c7a09 header-extra wrap fix 2018-02-02 19:28:45 -05:00
Kris
76317957ed UX: Removing some old references to the star feature 2018-01-26 13:05:29 -05:00
Bruno Perel
6750ff6873 (S)CSS cleanup: 0px => O and removal of duplicated properties (#5526) 2018-01-25 09:53:36 -05:00
Kris
2de1264213 UX: Adjustments for embedded reply collapse button 2018-01-19 16:16:22 -05:00
Kris
3cec2394b2 FIX: Margin below topic-map 2018-01-19 11:06:21 -05:00
Arpit Jalan
73dea4e7eb Merge branch 'embedded-posts' 2018-01-19 12:54:34 +05:30
Kris
fe5374dd3b FIX: increasing z-index on topic-avatar 2018-01-18 13:38:27 -05:00
Kris
0c01e0b2fe
UX: Implementing a z-index system (#5507) 2018-01-16 19:05:12 -05:00
Kris
2e12c2c352 UX: button styling 2018-01-16 16:06:04 -05:00
Kris
dc5b0e05e2 UX: Styling embedded post collapse button 2018-01-16 15:48:47 -05:00
Kris
22849fce96 UX: Line-height should be larger with single-line titles 2018-01-15 11:00:04 -05:00
Kris
53fb02f7fc UX: increase post meta font size 2018-01-15 10:30:52 -05:00
Kris
674013129a
UX: Type system rebuild (#5492) 2018-01-12 17:27:38 -05:00
Kris
4bf558f941 UX: Reducing number of overall font sizes 2017-12-20 15:57:49 -05:00
Kris
2d9d43ed1a UX: Removing px font defintions and replacing with em 2017-12-18 15:49:11 -05:00
Kris
f7c77171b9 UX: Eliminating a "sweet spot" at 870px viewport where the topic-body exceeds 690px wide 2017-12-07 14:32:31 -05:00
Kris
ef0d9d631c
UX: New style for staff highlight
Moved highlight to cooked content, also highlighting primary name (with shield) and title (if applicable). 

**Before**:
![image](https://user-images.githubusercontent.com/1681963/33724323-2269e79e-db3d-11e7-8c93-75b9dc9a1ab7.png)


**After**:
<img width="809" alt="screen shot 2017-12-06 at 3 55 31 pm" src="https://user-images.githubusercontent.com/1681963/33724287-09eb66de-db3d-11e7-8e02-0062ed2b8716.png">
2017-12-07 12:40:39 -05:00
Joffrey JAFFEUX
dd5562322b Revert "FIX: reflects discourse icons naming scheme s/d-icon-*/d-*"
This reverts commit b5ed980235.
2017-11-23 18:24:26 +01:00
Joffrey JAFFEUX
b5ed980235
FIX: reflects discourse icons naming scheme s/d-icon-*/d-* 2017-11-21 16:01:15 +01:00
Kris
9716e3ddf3 bringing mobile topic statuses to parity with desktop 2017-11-10 16:45:06 -05:00
Kris
dc2d9f05dc removing scale-color, first pass 2017-10-13 11:57:10 -04:00
Joffrey JAFFEUX
950b9e9eaf FIX: keeps as much as possible the same api for select-box components 2017-09-09 20:29:07 +02:00
Robin Ward
afc075d93b UX: Convert bookmark icon from CSS to a proper icon using our helper 2017-09-07 11:41:19 -04:00
Robin Ward
27b10a709b Revert "FIX: Un-revert the btn class added to the topic post menu"
This reverts commit aa07d23caa.
2017-08-25 23:50:00 -04:00
Robin Ward
aa07d23caa FIX: Un-revert the btn class added to the topic post menu 2017-08-25 17:08:34 -04:00
Robin Ward
4085c40e50 Minor CSS changes 2017-08-15 13:17:25 -04:00
Jeff Atwood
3538b63305 FIX: on desktop, anon topic reply btn too far over 2017-08-01 16:47:52 -07:00