Régis Hanol
33bc8c276d
FIX: default top timeframe was overriding best_periods_for
2019-06-04 10:57:50 +02:00
Maja Komel
7da875f52a
FIX: trigger user_updated webhook when avatar changes
2019-06-04 16:46:46 +08:00
Maja Komel
42809f4d69
FIX: use crawler layout when saving url in Wayback Machine ( #7667 )
2019-06-03 12:13:32 +10:00
Sam Saffron
f415712269
DEV: avoid double sign-in which can lead to flaky tests
...
We should not be signing in twice in tests, it is both wasteful and risky
2019-06-03 10:15:49 +10:00
Robin Ward
2e0a40007b
FIX: Category topics should not be deletable via review queue
2019-05-30 16:43:23 -04:00
romanrizzi
e7ee556e87
Support multi-group user search
2019-05-30 08:45:20 +08:00
Sam Saffron
b114bcd294
DEV: switch message bus backend to memory for tests
...
This backend is a bit faster and well tested, this is part of a longer
term plan to have a `backend: :memory, threaded: false` type config for
message bus which we can use in test.
The threading in message bus causes all sorts of surprises in test, it will
be nice not to be beholden to them.
2019-05-29 16:34:55 +10:00
Guo Xiang Tan
f0620e7118
FEATURE: Support [description|attachment](upload://<short-sha>)
in MD take 2.
...
Previous attempt was missing `post_uploads` records.
2019-05-29 09:26:32 +08:00
Penar Musaraj
7c9fb95c15
Temporarily revert "FEATURE: Support [description|attachment](upload://<short-sha>)
in MD. ( #7603 )"
...
This reverts commit b1d3c678ca
.
We need to make sure post_upload records are correctly stored.
2019-05-28 16:37:01 -04:00
Guo Xiang Tan
b1d3c678ca
FEATURE: Support [description|attachment](upload://<short-sha>)
in MD. ( #7603 )
2019-05-28 11:18:21 -04:00
Bianca Nenciu
07b80d491b
FIX: Refresh automatic groups after inviting moderators.
2019-05-28 17:19:34 +08:00
Robin Ward
d95a68b837
FEATURE: When suspending a user, allow the Delete + Replies action
...
Previously you could only delete the post
2019-05-27 12:27:16 -04:00
Robin Ward
89b84651c3
Migrate score settings to use sensitivities
...
We hide scores so these settings no longer made sense.
2019-05-24 15:44:24 -04:00
Gerhard Schlager
f4a471f0eb
FIX: Correctly cache hash of extra translations
2019-05-24 11:38:26 +02:00
Gerhard Schlager
c1e9a70d59
FIX: Fallback locale was not available for extra translations
...
Translations from fallback locales were not sent to the client
for admin_js and wizard_js.
2019-05-24 11:38:26 +02:00
Robin Ward
e74cd54fc6
REFACTOR: Replace score bonuses with low/med/high priorities
...
We removed score from the UX so it makes more sense to have sites set
priorities instead of score bonuses.
2019-05-23 11:54:45 -04:00
Gerhard Schlager
58f72cd439
Remove duplicate translations
2019-05-22 16:15:22 +02:00
Sam Saffron
307c526840
DEV: correct test that assumed group 123 did not exist
...
This is an incorrect assumption leading to a flaky test, cause for all we
know, since sequences do not reset every test, group 123 could exist.
2019-05-21 12:57:14 +10:00
Gerhard Schlager
b788948985
FEATURE: English locale with international date formats
...
Makes en_US the new default locale
2019-05-20 13:47:20 +02:00
Guo Xiang Tan
148bfc9be5
DEV: Simplify client and server side code to support removing tags.
...
Follow up to 834c86678f
.
2019-05-17 16:39:20 +08:00
Guo Xiang Tan
834c86678f
FIX: Missing post revision when editing the first post.
2019-05-17 12:54:27 +08:00
Guo Xiang Tan
e2444e0d31
DEV: Fix another frozen string error.
2019-05-17 10:07:37 +08:00
David Taylor
1299c94a52
FIX: Make serverside and clientside omniauth origin redirects consistent
...
Previously external domains were allowed in the client-side redirects, but not the server-side redirects. Now the behavior is to only allow local origins.
2019-05-15 12:40:51 +01:00
Guo Xiang Tan
ab1684999c
DEV: Improve specs to use upload_s3
fabricator.
2019-05-15 08:42:17 +08:00
Vinoth Kannan
42b10a646d
FIX: return 404 only if upload url also not internal.
2019-05-15 02:06:54 +05:30
Gerhard Schlager
81c329fbb8
FIX: Customizing missing pluralized translations didn't work
2019-05-13 09:36:05 +02:00
Sam Saffron
3fbab595d9
FEATURE: use the exact name provided by auth provider
...
Previously we would attempt to titleize it causing names like McDonald's
not to work as expected
2019-05-13 16:45:24 +10:00
Robin Ward
643c75c419
FIX: Don't increment version if the reviewable operation fails
...
In fact, roll back the entire operation in the database.
2019-05-10 09:53:25 -04:00
Daniel Waterworth
bf7594b327
More prefabrication
2019-05-10 08:34:04 -04:00
Guo Xiang Tan
ce15f085c6
DEV: Return the right response code and error message.
...
Follow up to d1dbafebbc
.
Also remove test that is a duplicate of
867c1a5ac9
.
2019-05-10 07:33:02 +08:00
Robin Ward
b380ed5282
FEATURE: Claim Reviewables by Topic
...
This is a feature that used to be present in discourse-assign but is
much easier to implement in core. It also allows a topic to be assigned
without it claiming for review and vice versa and allows it to work with
category group reviewers.
2019-05-09 13:40:36 -04:00
Blake Erickson
d1dbafebbc
FIX: Return error if new topic category not found take 2
...
If creating a topic via the api as an admin and the category you specify
cannot be found an error will now be returned instead of just creating
the topic with no category. This will prevent accidental public topic
creation originally intended for a private category.
This commit is follow up to 535c594891
and
still allows for the creation of topics where the category param is
blank.
2019-05-09 11:27:45 -06:00
Guo Xiang Tan
867c1a5ac9
DEV: Add request spec for creating an uncategorized category.
2019-05-09 14:53:13 +08:00
Guo Xiang Tan
535c594891
Revert "FIX: Return error if new topic category not found"
...
This reverts commit 9c606dd99a
.
2019-05-09 14:53:13 +08:00
Blake Erickson
9c606dd99a
FIX: Return error if new topic category not found
...
If creating a topic via the api as an admin and the category you specify
cannot be found an error will now be returned instead of just creating
the topic with no category. This will prevent accidental public topic
creation originally intended for a private category.
2019-05-08 15:02:00 -06:00
Daniel Waterworth
ebc5888c95
Prefabricated trust_level_4
2019-05-08 08:57:07 -04:00
Daniel Waterworth
1d0565eca2
Prefabricated admin at the top level
2019-05-08 08:57:07 -04:00
Daniel Waterworth
cef14d81ac
Prefabricated moderator at the top level
2019-05-08 08:57:07 -04:00
Daniel Waterworth
a473a56dc2
Prefabricated user at the top level
2019-05-08 08:57:07 -04:00
Daniel Waterworth
73f25311fa
Prefabricated post by user
2019-05-08 08:54:37 -04:00
Daniel Waterworth
0578809460
Prefabricate trust_level_4
2019-05-08 08:54:37 -04:00
Daniel Waterworth
f984c1740f
Use prefabricated user
2019-05-08 08:54:37 -04:00
Daniel Waterworth
86372a94d5
Prefabricated moderator at the top level
2019-05-08 08:54:37 -04:00
Daniel Waterworth
e3c09c666b
Prefabricated admin
2019-05-08 08:54:37 -04:00
Sam Saffron
77f9fff41e
DEV: correct flaky test
...
Hardcoding the number 1 into a test means that the test may fail if topic_id
1 is somehow seeded
This ensures we are always talking about a topic that does not exist
2019-05-08 09:31:47 +10:00
Blake Erickson
5b5b5a5931
FIX: return an error if a user tries to whisper
...
This commit fixes a bug where a user creates a whisper post via the api
but is posted as a regular message because they don't have access to
whisper. Now a 403 unauthorized will be returned instead of the whisper
param just being ignored for regular users. Staff users should not be
affected by this change.
https://meta.discourse.org/t/a-whisper-is-posted-as-a-message-if-the-user-is-not-staff-moderator-admin-when-using-the-api/116601
2019-05-07 11:42:26 -06:00
Bianca Nenciu
4696be4c19
DEV: Fix failling test.
2019-05-07 11:19:13 +03:00
Bianca Nenciu
4ff1195537
FEATURE: Use Beacon API for tracking clicks. ( #7483 )
2019-05-07 16:37:43 +10:00
Daniel Waterworth
e219588142
DEV: Prefabrication (test optimization) ( #7414 )
...
* Introduced fab!, a helper that creates database state for a group
It's almost identical to let_it_be, except:
1. It creates a new object for each test by default,
2. You can disable it using PREFABRICATION=0
2019-05-07 13:12:20 +10:00
Guo Xiang Tan
152238b4cf
DEV: Prefer public_send
over send
.
2019-05-07 09:33:21 +08:00