Commit Graph

769 Commits

Author SHA1 Message Date
Gerhard Schlager
37fa843efc Allow pulling of Urdu translations from Transifex again
The translations have been fixed.
2018-03-27 11:56:40 +02:00
Neil Lalonde
cd99ccdbf0 Update translations 2018-03-26 10:58:01 -04:00
Guo Xiang Tan
51657d3426 Allow polls to be added/renamed/removed as long as user can edit posts. 2018-03-14 11:00:57 +08:00
Guo Xiang Tan
b77553a635 FIX: Staff should be able to updates polls when edit window expires.
https://meta.discourse.org/t/moderators-cannot-remove-polls-from-posts/81804/7?u=tgxworld
2018-03-08 16:45:06 +08:00
Neil Lalonde
0c8df32903 Update translations, except ur because of errors 2018-03-07 14:11:56 -05:00
Guo Xiang Tan
d02e2cbcca PERF: Avoid fetching a bunch of ids in polls updater. 2018-03-07 14:18:56 +08:00
Maja Komel
e2a441ade9 Add Slovenian translations 2018-03-06 20:51:41 +01:00
Gerhard Schlager
7a2183e8ab FEATURE: rake task for merging users 2018-03-01 12:28:12 +01:00
Régis Hanol
10139692b2 forgot the error message 2018-02-27 00:25:15 +01:00
Régis Hanol
dee35b72f2 FIX: must be able to post in a topic in order to vote on a poll 2018-02-27 00:19:44 +01:00
Neil Lalonde
32ad98161f Update translations 2018-02-15 16:36:03 -05:00
Sam
94b2c70c0d PERF: remove oga gem
oga gem is automatically required by the aws gem
the oga gem retains about 1mb of memory, aws now uses nokogiri

This also removes the html normalize from the pretty text specs that was
a fair bit buggy as the polls test shows.
2018-02-15 14:36:40 +11:00
Neil Lalonde
f7042ecc85 Update translations 2018-01-31 11:19:21 -05:00
Bruno Perel
6750ff6873 (S)CSS cleanup: 0px => O and removal of duplicated properties (#5526) 2018-01-25 09:53:36 -05:00
Sam
7e3543d96f correct plugin specs 2018-01-12 14:42:05 +11:00
Joffrey JAFFEUX
b295c03001
FIX: select single choice as default when building a poll 2018-01-03 09:23:15 +01:00
Joffrey JAFFEUX
315b9d796d
select-kit refactoring
* better test helper
* more reliable tests
* more consistent use of data-value/data-name/title/aria-label everywhere: header and rows
2017-12-22 13:08:12 +01:00
Neil Lalonde
7e3c4b4b2f Update translations 2017-12-20 15:28:29 -05:00
blokovi
0df1c85fd3 FEATURE: Serbian translation (#5443) 2017-12-19 12:26:06 +01:00
Joffrey JAFFEUX
c1c31b99ce
Replaces toolbar popup-menu with select-kit 2017-12-13 10:49:32 +01:00
Neil Lalonde
929aa98723 Update translations 2017-12-11 12:01:57 -05:00
Kyle Zhao
c52f747031 FEATURE: Catalan Translations (#5404) 2017-12-07 10:36:25 +01:00
Neil Lalonde
978cf9485f Update translations 2017-12-06 10:25:12 -05:00
Joffrey JAFFEUX
067d454937
FIX: makes sur we have polls before validating 2017-12-05 12:07:21 -05:00
Joffrey JAFFEUX
316d814130
FIX: staff should always be allowed to create polls if they are enabled 2017-12-05 00:03:56 +01:00
Joffrey JAFFEUX
76bc173d47
FEATURE: adds poll_allow_staff_to_create
This setting will bypass poll_minimum_trust_level_to_create if set to true
2017-12-04 18:12:17 +01:00
Joffrey JAFFEUX
1e0bfa1d97
FIX: poll new_post_manager spec 2017-12-04 16:12:40 +01:00
Joffrey JAFFEUX
63bab32816 FEATURE: introduces minimum trust level for polls (#5391)
* FEATURE: introduces minimum trust level for polls

This commit makes `poll_enabled` less misleading and introduces `poll_minimum_trust_level_to_create`. If poll are enabled they will always be cooked, and if you have the required trust level you can create polls. As a side effect, it also fixes a bug where rebaking a post created by staff member when `poll_enabled=false` would end up not cooking it.

It also adds more tests to ensure settings are respected.

* admins should be whitelisted

* checks for admin in post validation

* test for >= instead of == trust level
2017-12-04 14:47:11 +01:00
Neil Lalonde
1603dcf0d1 Update translations 2017-11-30 15:32:15 -05:00
Eric Berry
ab22c8cad4 FIX: Infinite loop when poll step is zero (#5380)
* Fix infinite loop when poll step is zero

* Add test for step minimum and for breaking test

* Remove trailing spaces (eslint)

* Remove extra space (eslint)

* Removed test call .twice
2017-11-30 17:04:41 +01:00
Joffrey JAFFEUX
9208909b26 tweak icon-library generation 2017-11-23 18:24:26 +01:00
Joffrey JAFFEUX
39f3dbd945
Introduces select-kit
* renames `select-box-kit` into `select-kit`
* introduces `single-select` and `multi-select` as base components
* introduces {{search-advanced-category-chooser}} as a better component for selecting category in advanced search
* improves events handling in select-kit
* recreates color selection inputs using {{multi-select}} and a custom {{selected-color}} component
* replaces category-selector by a component using select-kit and based on multi-select
* improves positioning of wrapper
* removes the need for offscreen, and instead use `select-kit-header` as a base focus point for all select-kit based components
* introduces a formal plugin api for select-kit based components
* introduces a formal pattern for loading and updating select-kit based components:

```
computeValue()
computeContent()
mutateValue()
```
2017-11-21 11:53:09 +01:00
Angus McLeod
c8a6e5cbb3 If there is a specific error it should be shown to the user (#5323)
e.g. post_is_deleted, or topic_must_be_open_to_vote
2017-11-17 12:12:13 +01:00
Neil Lalonde
13c91fc7ec Update translations 2017-11-13 15:02:53 -05:00
Neil Lalonde
d2d272c5f1 Update translations 2017-09-28 13:37:19 -04:00
Guo Xiang Tan
77d4c4d8dc Fix all the errors to get our tests green on Rails 5.1. 2017-09-25 13:48:58 +08:00
Neil Lalonde
346442134e Update translations 2017-09-14 11:02:39 -04:00
Robin Ward
e41a828774 Update translations 2017-08-31 14:50:40 -04:00
Neil Lalonde
ea969d1ed0 FEATURE: add Thai language 2017-08-25 12:33:09 -04:00
Neil Lalonde
3b7657e4b3 Update translations 2017-08-16 11:38:45 -04:00
Neil Lalonde
130ae2cd4b FEATURE: add Latvian language 2017-08-15 11:40:00 -04:00
Sam
43c0111ca1 FIX: multichoice poll with more than 25 votes
In the past we would double up on avatars due to incorrect logic for
handling offset
2017-08-14 15:33:59 -04:00
Régis Hanol
80daa7006c use new reload-friendly API 2017-08-12 04:22:44 +02:00
David Taylor
ea032d8372 Improve source code linting for continuous integration (#5017)
* Add rubocop linting to docker:test rake task

* Add eslint JS listing to plugin files, and add SKIP_LINT variable

* Fix failing ‘polls’ plugin eslint

Using eslint-disable-line, as is done in core qunit tests such as `acceptance/group-logs-test.js.es6`

* Add plugin test eslint to travis config

* Merge some eslint lines
2017-08-02 11:33:29 +09:00
Guo Xiang Tan
5012d46cbd Add rubocop to our build. (#5004) 2017-07-28 10:20:09 +09:00
Robin Ward
5b590b9637 REFACTOR: Replace some fa-* uses with helpers 2017-07-27 14:55:41 -04:00
Robin Ward
e87125b63c FEATURE: Plugins can overwrite and add support for new icons 2017-07-26 13:21:17 -04:00
Sam
8317fb12e0 FIX: don't escape html of poll options 2017-07-25 13:38:19 -04:00
Sam Saffron
045a2abcec FEATURE: remove the timecop gem
We should only have one way of mocking time, misuse of timecop
was causing build stability issues
2017-07-24 12:11:10 -04:00
Sam
9b4f5710e6 api cleanup for before / after rules 2017-07-21 16:12:11 -04:00
Arpit Jalan
d666b73893 Update translations. 2017-07-20 14:57:02 +05:30
Sam
b7f58fe880 regression polls could not be closed properly 2017-07-18 14:52:58 -04:00
Sam
93e5112dfa correct poll specs 2017-07-18 14:31:22 -04:00
Sam
1661a8745b correct issues with poll specs
fixes regression where an error message is missing from a poll
with one option
2017-07-17 17:44:48 -04:00
Sam
8921058c67 FIX: medium URL with @ incorrectly handled as mention
Also:

- remove unused code
- rename bbcode_ruler to bbcode.ruler
- add md.core.textPostProcess.ruler to apply at end of chain (excluding links)
2017-07-17 17:44:48 -04:00
Guo Xiang Tan
e80a1dfa43 FIX: Post with multiple polls containing votes can not be edited.
https://meta.discourse.org/t/500-internal-server-error-when-editing-specific-poll-in-a-post-with-votes-editing-other-polls-works-fine/59684
2017-07-14 12:33:22 +09:00
Sam
5d139e461c FIX: multi option poll not working (new engine) 2017-07-11 14:43:34 -04:00
Arpit Jalan
25d70ec900 Update Translations 2017-07-05 11:35:35 +05:30
Sam
6200d7d6ab correct bug where only a single poll per topic worked 2017-06-28 15:36:19 -04:00
Guo Xiang Tan
a10689de94 Fix broken specs due to new default emoji set. 2017-06-27 10:13:21 +09:00
Neil Lalonde
febfe27669 Update translations 2017-06-26 14:56:22 -04:00
Sam
234694b50f Feature: CommonMark support
This adds the markdown.it engine to Discourse.
https://github.com/markdown-it/markdown-it

As the migration is going to take a while the new engine is default
disabled. To enable it you must change the hidden site setting:
enable_experimental_markdown_it.

This commit is a squash of many other commits, it also includes some
improvements to autospec (ability to run plugins), and a dev dependency
on the og gem for html normalization.
2017-06-23 12:01:33 -04:00
Guo Xiang Tan
a23ce56682 Update translations. 2017-06-19 12:39:30 +09:00
Robin Ward
cc525b1a8d Upgrade QUnit to latest version 2017-06-15 10:12:07 -04:00
Robin Ward
8ae445766f Upgrade Ember to 2.13 2017-06-15 10:12:07 -04:00
Arpit Jalan
4112c2b883 Update translations 2017-06-12 21:24:40 +05:30
Arpit Jalan
266acbcc6c Update Translations 2017-05-29 12:23:49 +05:30
Arpit Jalan
f57914ccd8 Update translations 2017-05-22 10:24:44 +05:30
Neil Lalonde
8651fc57a5 Update translations 2017-05-15 11:11:18 -04:00
Neil Lalonde
b839eb41ff add space in number of poll voters on mobile 2017-05-15 10:19:40 -04:00
Arpit Jalan
a160589e84 Update Translations 2017-05-09 22:59:38 +05:30
Arpit Jalan
1f6ffd5fb0 Update Translations 2017-05-02 16:08:55 +05:30
Neil Lalonde
5259a7824e Update translations 2017-04-27 13:26:15 -04:00
Arpit Jalan
df77a827e1 Update Translations 2017-04-24 18:12:40 +05:30
Arpit Jalan
ae96631692 Update Translations 2017-04-17 23:46:18 +05:30
Arpit Jalan
ff530d6fb3 Update Translations 2017-04-07 22:23:39 +05:30
Rafael dos Santos Silva
3eb125c39b FIX: Fix poll builder qunit tests 2017-04-05 18:07:50 -03:00
Rafael dos Santos Silva
8b383bb26a FIX: Poll builder validation was incorrect 2017-04-05 00:15:39 -03:00
Neil Lalonde
c19bf7e1bd Update translations 2017-03-28 10:50:09 -04:00
Bianca Nenciu
c423544208 Changed combo-box to number inputs for min, max and step values. 2017-03-15 10:56:11 +08:00
Neil Lalonde
4271aa0b48 Update translations 2017-03-08 11:54:01 -05:00
Neil Lalonde
d848916357 FEATURE: Greek language support, thanks to Vasilis Vlachokyriakos 2017-03-01 15:52:55 -05:00
Guo Xiang Tan
112ca20c96 Merge pull request #4675 from tgxworld/fix_polls_forever_broken_if_approval_required
FIX: Polls permanently broken if post requires approval.
2017-03-01 12:56:03 +08:00
Robin Ward
e089515dab FIX: Don't try to load avatars in test mode 2017-02-17 16:21:35 -05:00
Neil Lalonde
56233e9ec6 Update translations 2017-02-13 16:42:15 -05:00
Guo Xiang Tan
0988420b48 Fix broken qunit tests. 2017-02-03 12:09:30 +08:00
Guo Xiang Tan
40fae186c9 Remove stray console.log. 2017-02-02 17:38:23 +08:00
Guo Xiang Tan
1bc87bca65 Remove debugging code. 2017-02-02 13:49:26 +08:00
Guo Xiang Tan
8bd8f07ce0 FIX: Public polls should not make a request per option. 2017-01-31 17:27:43 +08:00
Neil Lalonde
8ab327665f Update translations 2017-01-26 12:22:14 -05:00
Guo Xiang Tan
bed11dfa0e FIX: Polls permanently broken if post requires approval. 2017-01-26 13:29:43 +08:00
Guo Xiang Tan
1da6fc8e3c UX: Highlight user's vote in polls. 2017-01-25 12:02:19 +08:00
Arpit Jalan
bcbcfa2078 Update Translations 2017-01-18 22:13:12 +05:30
Guo Xiang Tan
115a1c8680 FIX: Sort is destructive and that is not what we want. 2017-01-16 23:42:31 +08:00
Guo Xiang Tan
8c4dfdfa40 FIX: Votes lost when editing a poll option with votes. 2017-01-16 22:51:57 +08:00
Guo Xiang Tan
d4b2a635c7 FIX: Live updates for polls was broken. 2017-01-16 16:57:46 +08:00
Jeff Atwood
d87e5ae819 tighten spacing for poll voters list 2017-01-14 22:11:46 -08:00
Arpit Jalan
1570c4e4a7 Update Translations 2017-01-12 13:26:45 +05:30
Neil Lalonde
5a2e989e0d Update translations 2017-01-06 15:53:03 -05:00
Arpit Jalan
be303ecef9 Update Translations 2017-01-04 23:43:08 +05:30
Arpit Jalan
4e63880b5d Update Translations 2016-12-29 00:15:25 +05:30
Guo Xiang Tan
ed72920444 Make eslint happy. 2016-12-22 11:46:15 +08:00
Guo Xiang Tan
288e5faf6b FIX: Sort needs to be stable. 2016-12-22 11:45:41 +08:00
Robin Ward
e3301cd0c8 FIX: Don't load poll results while already loading 2016-12-21 21:26:57 -05:00
Robin Ward
e03d5e2140 Reapply Ember 2.10 for good this time!
This reverts commit ddd299f4aa.
2016-12-19 11:19:10 -05:00
Robin Ward
ddd299f4aa Revert "Revert "Revert Ember 2.10+ for a short while""
This reverts commit 76bbc481cb.
2016-12-16 10:29:30 -05:00
Robin Ward
76bbc481cb Revert "Revert Ember 2.10+ for a short while"
This reverts commit 21682fd60b.
2016-12-16 09:52:29 -05:00
Robin Ward
21682fd60b Revert Ember 2.10+ for a short while 2016-12-15 16:43:38 -05:00
Robin Ward
28699e66d8 Revert "REVERT: Ember 2.10 -- it's not building properly"
This reverts commit 600541c623.
2016-12-15 10:28:15 -05:00
Neil Lalonde
bad98a4987 Update translations 2016-12-14 13:55:24 -05:00
Robin Ward
600541c623 REVERT: Ember 2.10 -- it's not building properly 2016-12-12 16:19:05 -05:00
Robin Ward
765e5e9186 Upgrade to Ember 2.9 2016-12-12 14:44:29 -05:00
Robin Ward
f07443b488 Migrate Discourse Polls to use vdom instead of embedded ember 2016-12-09 10:42:56 -05:00
Sam
02b21a26dd Merge pull request #4585 from ibnesayeed/urdu-support
Add initial Urdu support with RTL direction
2016-12-09 13:01:25 +11:00
Arpit Jalan
5cc64103c6 Update Translations 2016-12-08 20:35:03 +05:30
Sawood Alam
49fc54aac6 Add initial Urdu support with RTL direction 2016-12-03 23:17:51 -05:00
Robin Ward
ffae39912f FIX: Remove the old poll view before replacing it 2016-12-02 16:41:51 -05:00
Guo Xiang Tan
6b4ef86ac4 Add acceptance test for rendering polls. 2016-12-01 10:58:00 +08:00
Régis Hanol
28b7ef7142 FIX: rendering multiple polls in the same post was broken 2016-11-30 22:59:58 +01:00
Robin Ward
d8a69e6bb2 FIX: Use the register within the poll plugin 2016-11-25 11:58:06 -05:00
Arpit Jalan
6168b2c57a Update Translations 2016-11-25 00:37:51 +05:30
Robin Ward
054c428ba3 FIX: Don't modify variables when rendering 2016-11-24 11:34:14 -05:00
Robin Ward
28061316ad Migrate poll plugin to use components 2016-11-21 14:49:46 -05:00
Robin Ward
06254d3163 Remove the last of the ModalBodyView uses 2016-11-18 12:13:21 -05:00
Arpit Jalan
ece5442c54 Update Translations 2016-11-16 23:42:01 +05:30
Arpit Jalan
541c29ff4d Update Translations 2016-11-09 20:16:29 +05:30
Robin Ward
6a1c05a268 Upgrade ember-qunit 2016-11-08 14:29:50 -05:00
Régis Hanol
71fa9541fa Merge pull request #4531 from rizka10/master
Improve summing of poll percentages to 100
2016-11-03 10:42:59 +01:00
rizka10
4ce99c998b Improve summing poll percentages to 100
My first JavaScript! I have little experience with C++ and even less with Java, but that was enough to figure out a way to solve the task. The solution is rather good, but there may be better ways. I'm going to start a pull request. Even if it gets rejected, an expert can use the idea.

NOTE: The code needs some serious testing before potential merging. I did some testing and it worked, but don't trust in my skills.
2016-11-03 11:11:17 +02:00
Arpit Jalan
f057172216 Update Translations 2016-11-02 22:47:35 +05:30
Arpit Jalan
68b559d501 Update Translations 2016-10-27 00:44:53 +05:30
Robin Ward
fab36e6cf7 Fix more deprecations:
- Remove all `needs:` code
2016-10-21 17:28:37 -04:00
Arpit Jalan
6eccf9da03 Update Translations 2016-10-20 18:49:09 +05:30
Arpit Jalan
4c614e5233 Update Translations 2016-10-14 00:15:41 +05:30
Arpit Jalan
3002cc4cc7 Update Translations 2016-10-06 21:21:00 +05:30
Arpit Jalan
38c6c69b5a Update Translations 2016-09-28 11:00:36 +02:00
Robin Ward
be1d74d207 Split out common functions into discourse-common module 2016-09-22 09:52:19 -04:00
Arpit Jalan
c1c3237d58 Update Translations 2016-09-21 21:16:03 +05:30
Arpit Jalan
1a87960454 Update Translations 2016-09-13 21:21:19 +05:30
Arpit Jalan
d2e1fccc90 Update Translations 2016-09-02 20:12:45 +05:30
Neil Lalonde
4be3b9f36d Update translations 2016-08-25 11:04:46 -04:00
Arpit Jalan
e06be6561d Update Translations 2016-08-23 18:48:00 +05:30
Arpit Jalan
25a14fcba8 Update Translations 2016-08-10 23:08:10 +05:30
Guo Xiang Tan
8213da20f2 Extract polls edit window to a site settings. 2016-08-10 15:17:16 +08:00
Neil Lalonde
f1bfc74e79 Update translations 2016-08-05 14:39:55 -04:00
Guo Xiang Tan
ad44a64c5b UX: Fixes for poll option bars on dark theme. 2016-08-02 09:48:06 +08:00
Guo Xiang Tan
dc2cf996af UX: Styles for poll options on dark theme. 2016-08-01 22:07:57 +08:00
Guo Xiang Tan
d970f4d3d8 Fix incorrect test. 2016-07-29 17:05:00 +08:00
Guo Xiang Tan
1171936850 FIX: Don't escape strings from polls. 2016-07-29 16:35:57 +08:00
Guo Xiang Tan
f9454088c3 FIX: Missing icons on polls preview. 2016-07-29 16:15:52 +08:00
Guo Xiang Tan
89d2340e37 UX: Add margins for poll links in preview. 2016-07-29 15:19:56 +08:00
Guo Xiang Tan
ffbfcd7ee2 Fix build. 2016-07-29 14:47:23 +08:00
Guo Xiang Tan
e336e56153 FIX: Incorrect sort for poll results. 2016-07-29 14:42:55 +08:00
Guo Xiang Tan
f9ef1e1997 Opps this broke polls. 2016-07-29 14:28:09 +08:00
Guo Xiang Tan
6538363c18 PERF: Reduce the number of queries when voting. 2016-07-29 14:02:48 +08:00
Guo Xiang Tan
32c962cfd8 UX: Remove button styles on polls. 2016-07-29 11:09:23 +08:00
Guo Xiang Tan
8e30ab31c2 Merge pull request #4351 from tgxworld/allow_non_number_poll_results_to_be_sorted
FEATURE: Allow poll results to be sorted.
2016-07-29 10:38:29 +08:00
Guo Xiang Tan
a7f2b2ded6 FEATURE: Allow poll results to be sorted. 2016-07-29 10:37:27 +08:00
Guo Xiang Tan
bb3f4a10f3 UX: Polls should take up full width of post's container. 2016-07-28 23:06:25 +08:00
Guo Xiang Tan
85a91c8b81 Remove unused property. 2016-07-28 21:28:49 +08:00
Neil Lalonde
6a8f57d602 Update translations 2016-07-27 17:55:28 -04:00
Neil Lalonde
a3f39866ab Update translations using temporary workaround for Transifex bugs 2016-07-27 13:29:13 -04:00
Guo Xiang Tan
33a628b0b0 UX: Vote now button to show up as primary once options have been selected. 2016-07-21 06:05:06 +08:00
Robin Ward
8141e1d9bc FIX: details fixes with extra formatting 2016-07-19 15:14:55 -04:00
Robin Ward
f38347400c FIX: currentUser can be null 2016-07-19 12:48:52 -04:00
Guo Xiang Tan
89e28c12ed UX: Fix polls on dark theme. 2016-07-19 13:01:54 +08:00
Guo Xiang Tan
5f481ec097 Merge pull request #4328 from dachary/wip-poll-empty-lines
FIX: poll builder should ignore empty lines
2016-07-17 09:24:36 +08:00
Loic Dachary
f152900969 FIX: poll builder should ignore empty lines
Although pollOptionsCount skips empty lines, pollOutput inserts empty
lines. Skip them instead.

Signed-off-by: Loic Dachary <loic@dachary.org>
2016-07-14 09:27:43 +02:00
Guo Xiang Tan
c3cab98998 FEATURE: Admins should be able to create polls even when plugin is disabled. 2016-07-13 18:05:19 +08:00
Robin Ward
ff4e60808a FIX: Polls were broken server side 2016-07-11 12:57:05 -04:00
Robin Ward
b8125b3512 REFACTOR: Remove Discourse.Ajax 2016-07-11 12:57:05 -04:00
Robin Ward
56f07529bb REFACTOR: Migrate more legacy JS to ES6 2016-07-11 12:57:05 -04:00
Robin Ward
a546395397 REFACTOR: Migrate markdown functionality in ES6 2016-07-11 12:57:05 -04:00
Arpit Jalan
5a77f558ee Update Translations 2016-07-11 20:27:50 +05:30
Guo Xiang Tan
6e385f11b3 UX: Render polls within the same run loop.
* Rendering polls in a seperate run loops causes
our topic list page to be jumpy because of changing
heights after polls have been rendered.
2016-07-11 10:19:00 +08:00
Guo Xiang Tan
3cb8bbb851 UX: Automatically generate poll name for poll builder. 2016-07-05 22:15:52 +08:00
Guo Xiang Tan
a382d5d2d2
FIX: Don't reopen instance of controller. 2016-07-05 12:22:14 +08:00
Guo Xiang Tan
d102a079b1
FIX: Bump plugin API version. 2016-07-01 09:32:30 +08:00
Arpit Jalan
342783e716 Update Translations 2016-06-30 13:47:13 +05:30
Guo Xiang Tan
5ba12840e0 Merge pull request #4285 from tgxworld/fix_polls_not_cooked
FIX: Incorrect model for embedded post widget.
2016-06-27 13:31:03 +08:00
Guo Xiang Tan
63b8797667
FIX: Incorrect model for embedded post widget. 2016-06-27 13:15:26 +08:00
Guo Xiang Tan
789a6aeb21 FIX: Public poll not showing. 2016-06-24 11:20:35 +08:00
Guo Xiang Tan
3646d45110
FIX: Voters arrow shown on polls with invalid public config. 2016-06-22 23:34:39 +08:00
Jeff Atwood
7337b2953f slightly less giant poll percentages 2016-06-21 17:01:27 -07:00
Neil Lalonde
db2bc41110 Update translations 2016-06-21 11:16:31 -04:00
Guo Xiang Tan
6416ea9e09
FIX: Make sure we reset poll builder after inserting a poll. 2016-06-20 18:16:18 +08:00
Jeff Atwood
94df22564f shorter poll copy 2016-06-19 22:55:10 -07:00
Jeff Atwood
a486d7e95b minor copyedit on poll 2016-06-19 22:44:49 -07:00
Guo Xiang Tan
01c563ca85
FIX: Use internal value for poll builder. 2016-06-20 12:40:44 +08:00
Jeff Atwood
5e8d1549a4 minor copyedit on polls 2016-06-17 23:37:02 -07:00
Jeff Atwood
54032ffd2c copyedit: go with {verb} {noun} for gear actions 2016-06-17 15:54:30 -07:00
Jeff Atwood
01347dfbe2 very minor copyedit 2016-06-16 15:27:08 -07:00
Guo Xiang Tan
adecdbee56
UX: Display number combobox as an input group so it looks nice on mobile too. 2016-06-16 17:08:00 +08:00
Guo Xiang Tan
4df224bb79
FIX: Trim whitespaces and do a global replace. 2016-06-16 16:35:23 +08:00
Guo Xiang Tan
fd91a8eee6
Bunch of UX changes for polls builder. 2016-06-15 23:47:19 +08:00
Guo Xiang Tan
e1cfe7536c
FIX: Add default values when no value has been selected. 2016-06-15 12:54:52 +08:00
Guo Xiang Tan
ae5a033469
Start checking eslint in plugins. 2016-06-15 11:14:24 +08:00
Guo Xiang Tan
8d46727d67
FEATURE: Poll UI Builder. 2016-06-15 11:14:24 +08:00
Guo Xiang Tan
a36203ff78
PERF: Paginate public polls. 2016-06-12 16:14:53 +08:00
Guo Xiang Tan
5a03eca74a
UX: Add info when poll is public. 2016-06-09 22:15:08 +08:00
Guo Xiang Tan
f53494f102 FIX: Polls with votes cannot be made public. 2016-06-09 12:10:27 +08:00
Guo Xiang Tan
7b6fb17bbb
One line import. 2016-06-08 17:23:05 +08:00
Guo Xiang Tan
3caf696d3a
FIX: Ignore title in user avatar. 2016-06-08 17:04:18 +08:00
Guo Xiang Tan
8ecde35df3
FEATURE: Add public type to polls. 2016-06-08 16:19:13 +08:00
Guo Xiang Tan
7aac5baeed
FIX: Make sure model is updated when polls change. 2016-06-08 14:42:23 +08:00
Guo Xiang Tan
5f92de8ede
Remove unnecessary for loop. 2016-06-07 16:50:45 +08:00
Guo Xiang Tan
35337cd687
FIX: Previous polls are being removed when adding a poll in a new post. 2016-06-07 11:23:38 +08:00
Guo Xiang Tan
2f14a81fa4
FIX: min setting should be greater than 0 for multiple type polls. 2016-06-07 10:48:06 +08:00
Guo Xiang Tan
a849fae5ee Add specs for polls (#4246)
* Extract validation logic into a service object.

* Extract logic for updating polls custom fields into a service object.

* Use `strip_heredoc` instead.

* FIX: Polls do not update when configuration has been changed.
2016-06-06 17:04:56 +02:00
Arpit Jalan
4f4c1b54ba Update Translations 2016-06-04 00:15:03 +05:30
Arpit Jalan
e489af0b50 add Estonian language files 2016-06-01 15:25:21 +05:30
Neil Lalonde
7050042088 Update translations 2016-05-26 11:50:15 -04:00
Robin Ward
7c0fb41ec0
Deprecation: Use Ember.Helper for later versions of Ember 2016-05-11 14:26:09 -04:00
Arpit Jalan
e8623ccd92 Update Translations 2016-05-09 23:39:52 +05:30
Robin Ward
9ea32bf7d8
Deprecation: Change {{#each x in y}} to {{#each y as |x|}} 2016-05-04 16:18:09 -04:00
Neil Lalonde
b1f798f119 Update translations 2016-05-04 14:22:15 -04:00
Gerhard Schlager
f1bc7de541
Adds support for anonymous votes to the poll plugin 2016-04-23 22:44:09 +02:00
Neil Lalonde
e63e296761 Update translations 2016-04-20 19:18:07 -04:00
Robin Ward
e91379916b
FIX: Provide the ability to reduce cooked content
This allows us to strip polls from the group posts page.
2016-04-13 13:25:18 -04:00
Neil Lalonde
a2501bfee5 Update Translations 2016-04-07 12:11:30 -04:00
Robin Ward
ef4877e009 FIX: Stability issues with multiple polls 2016-03-28 12:17:37 -04:00
Arpit Jalan
ddebd76c44 Update Translations 2016-03-23 22:25:29 +05:30
Manel Villar
6a2fe44e51 Support for Galician language added 2016-03-22 16:42:54 +01:00
Régis Hanol
6c579ba932 FIX: close existing polls in closed topics to keep old behaviour 2016-03-21 23:09:36 +01:00
Régis Hanol
b575f97ece FIX: allows polls on closed topics 2016-03-21 12:12:25 +01:00
Neil Lalonde
9f30a28a8e Update translations 2016-03-17 11:01:02 -04:00
Arpit Jalan
bdb290ccdb Update Translations 2016-03-07 19:44:32 +05:30
Robin Ward
026bba1876 Merge branch 'master' into vdom 2016-02-22 15:28:07 -05:00
Neil Lalonde
7e39619bc9 Update translations 2016-02-22 11:10:12 -05:00
Sam
c404da248a Merge branch 'master' into vdom 2016-02-22 12:20:59 +11:00
Sam
5a47199528 Merge pull request #3947 from khoa-le/update-locale-vietnamese
Add locale for Vietnamese
2016-02-22 11:41:37 +11:00
Robin Ward
6935925f10 Update Polls plugin to work with new Plugin API 2016-02-18 15:23:43 -05:00
Neil Lalonde
71a87bea0c Update translations 2016-02-04 13:35:14 -05:00
Arpit Jalan
bcc0ed7c9c Update Translations 2016-02-02 15:24:01 +05:30
Arpit Jalan
915afa703d Update Translations 2016-01-26 23:41:00 +05:30
Khoa, Le Ngoc
06e637fc4a Merge remote-tracking branch 'upstream/master' into update-locale-vietnamese
* upstream/master: (185 commits)
  SECURITY: Upgrade rails.
  FIX: new user summary page was broken
  Version bump to v1.5.0.beta9
  Remove addressable from Discourse.
  UX: change glyph when inviting existing user to a topic
  FIX: Allow for large free disk space
  Revert "FIX: disk_space should be a BigDecimal to handle large disk (closes #3923)"
  UX: improve styling of messages and mobile view of messages
  FIX: correct counts on user summary
  FIX: link to filtered down list of badges from summary FEATURE: pick featured badges in summary page
  FIX: do not allow new email to be duplicate FIX: return proper error message when email already exists
  retain unactivated accounts a bit longer default
  FEATURE: blocked users can send and reply to private messages from staff
  Remove Arel patch that has been merged upstream.
  correct path
  little typo
  FIX: Missing tag in CSS.
  PERF: remove 10-20ms of work from every page view
  FIX: remove green background for wiki (this can be re-added via a customization if needed)
  Hotfix for unsubscribe via email
  ...

# Conflicts:
#	.tx/config
2016-01-26 12:44:29 +07:00
Khoa, Le Ngoc
003399bf96 Update translation code 2016-01-22 14:54:48 +07:00
Régis Hanol
fc3bedaaed Merge pull request #3921 from gschlager/locale-sk
Add Slovak locale
2016-01-20 15:38:48 +01:00
Arpit Jalan
bfa4e6b69c Update Translations 2016-01-19 01:29:19 +05:30
Régis Hanol
fc92166d5f FIX: when rouding numbers in poll resuls, *don't* select a never-been-voted-for option to round up from zero 2016-01-14 01:59:46 +01:00
Neil Lalonde
d732c0876a Update translations 2016-01-08 15:50:00 -05:00
Sam Saffron
57944a0694 PERF: only subscribe to a topic once for polls
in the past as views were created and destroyed poll subscriptions would change

this caused a lot of load on messaging bus and uneeded traffic
2016-01-06 20:36:09 +11:00
Arpit Jalan
593c22eda1 Update Translations 2016-01-04 21:01:49 +05:30
root
e0ffce1cad Add locale for Vietnamese 2016-01-03 10:05:28 +00:00
Arpit Jalan
90d15ba588 Update Translations 2015-12-29 23:16:17 +05:30
Arpit Jalan
47410f1b99 Update Translations 2015-12-23 17:01:43 +05:30
Neil Lalonde
fe10f3e0a3 Update translations 2015-12-18 10:48:02 -05:00
Gerhard Schlager
e56f8fa471 Add Slovak locale 2015-12-14 21:55:36 +01:00
Arpit Jalan
b227897c44 Update Translations 2015-12-07 23:29:32 +05:30
Régis Hanol
72e7271687 FIX: '.intersect?' isn't available in older version of ruby 2015-12-02 17:25:01 +01:00
Régis Hanol
f4184aea33 FIX: properly re-compute # of voters in multiple-choice polls 2015-12-02 12:33:34 +01:00
Andy Waite
3e50313fdc Prepare for separation of RSpec helper files
Since rspec-rails 3, the default installation creates two helper files:
* `spec_helper.rb`
* `rails_helper.rb`

`spec_helper.rb` is intended as a way of running specs that do not
require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's
current `spec_helper.rb` does).

For more information:

https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files

In this commit, I've simply replaced all instances of `spec_helper` with
`rails_helper`, and renamed the original `spec_helper.rb`.

This brings the Discourse project closer to the standard usage of RSpec
in a Rails app.

At present, every spec relies on loading Rails, but there are likely
many that don't need to. In a future pull request, I hope to introduce a
separate, minimal `spec_helper.rb` which can be used in tests which
don't rely on Rails.
2015-12-01 20:39:42 +00:00
Arpit Jalan
04593b8fef Update Translations 2015-12-01 01:09:45 +05:30
Régis Hanol
08ae5f89bd FIX: rounding issue might appear when summing up all the decimals 2015-11-30 11:24:25 +01:00
Régis Hanol
96cd36e86d FIX: properly compute the number of voters using only valid options 2015-11-30 11:23:38 +01:00
Régis Hanol
68a44a1d59 FIX: use an algorithm that doesn't re-order percentages when rounding them up to 100% in single choice polls 2015-11-25 00:14:24 +01:00
Régis Hanol
4f25278b39 FIX: round down percentages when using multiple choices polls 2015-11-23 15:28:24 +01:00
Arpit Jalan
bde05fd334 Update Translations 2015-11-23 19:25:06 +05:30
Régis Hanol
9d2128dad3 FIX: don't round up to 100% when using multiple choices poll 2015-11-23 11:34:24 +01:00
Arpit Jalan
6ec336e56f Update Translations 2015-11-20 23:26:48 +05:30
Régis Hanol
32b6ccd622 FIX: properly round % so they add up to 100 in polls 2015-11-19 18:23:38 +01:00
Arpit Jalan
951bfb6186 Update Translations 2015-11-09 21:14:02 +05:30
Arpit Jalan
a44c2f6ea3 Update Translations 2015-11-02 17:49:57 +05:30
Arpit Jalan
574805b682 Update Translations 2015-10-30 18:16:52 +05:30
Arpit Jalan
c3cadbb4d8 Update Translations 2015-10-26 22:38:34 +05:30
Régis Hanol
515fc49727 FIX: replace polls with a link in emails 2015-10-22 19:10:07 +02:00
Arpit Jalan
717be06f17 Update Translations 2015-10-20 23:11:42 +05:30
Neil Lalonde
131e7ed445 fix MergePollsVotes migration 2015-10-16 13:54:41 -04:00
Régis Hanol
8f2b002203 FIX: a poll option cannot be voted more than 100% of the time 2015-10-16 17:18:22 +02:00
Arpit Jalan
06f616792d Update Translations 2015-10-15 18:19:04 +05:30
Arpit Jalan
43cd0912e6 Update Translations 2015-10-11 02:11:28 +11:00
Neil Lalonde
1e5ad6f219 Update translations 2015-10-02 10:40:28 -04:00
Arpit Jalan
a2e8e5f90b Update Translations 2015-09-29 12:30:01 +05:30
Gerhard Schlager
bb52042b46 FIX: Add missing pluralization keys to poll plugin locale 2015-09-27 21:36:57 +02:00
Régis Hanol
2e76c9165a FIX: polls are always editable until the first vote 2015-09-25 18:54:15 +02:00
Régis Hanol
cc75890cd4 UX: disable 'Hide results' button when poll is closed 2015-09-16 13:01:08 +02:00
Régis Hanol
26c743a962 FIX: disable poll dialect when poll plugin is disabled 2015-09-14 20:11:03 +02:00
Régis Hanol
60bbd81607 FIX: polls with votes were preventing users from updating the post 2015-09-14 19:27:54 +02:00
Arpit Jalan
b8c3187a94 Update Translations 2015-08-31 22:19:30 +05:30
Arpit Jalan
e1575746f2 Update Translations 2015-08-20 17:33:13 +05:30
Arpit Jalan
73f547b019 Update Translations 2015-08-10 23:41:05 +05:30
Sam
d16de4a0a1 correct polls spec 2015-08-05 12:39:38 +10:00
Arpit Jalan
e53bf294ef Update Translations 2015-08-04 13:17:39 +05:30
Régis Hanol
969f6ad1d0 Revert "make polls unselectable"
This reverts commit 9b819d9245.
2015-07-31 12:46:30 +02:00
Jeff Atwood
9b819d9245 make polls unselectable
https://meta.discourse.org/t/disabling-text-selection-in-polls/31586
2015-07-31 03:43:07 -07:00
Régis Hanol
233cdc011d FIX: disable text selection in polls 2015-07-31 12:42:53 +02:00
Arpit Jalan
62a59ef7c0 Update Translations 2015-07-30 22:41:12 +05:30
Arpit Jalan
e01d196bda Update Translations 2015-07-22 22:57:18 +05:30
Luke GB
9f31c3d235 Expose poll_maximum_options to client
At present this doesn't actually seem to be exposed to the client.

I discovered this by accident whilst trying to write my own plugin:

7b6d6b76eb/app/models/site_setting.rb (L17-L18)
2015-07-19 21:41:14 +01:00
Arpit Jalan
fc977771a3 Update Translations 2015-07-16 19:18:02 +05:30
Sam
00aaa692ac Merge pull request #3574 from gschlager/patch-2
FIX: Remove invalid translation keys from polls plugin
2015-07-15 16:53:37 +10:00
Arpit Jalan
63b5a6c4e0 Update Translations 2015-07-09 18:57:52 +05:30
Robin Ward
8be37193ee Trivial changes to poll plugin, including a small typo fix. 2015-07-07 10:51:51 -04:00
Kane York
af042ffe5e FEATURE: Per-plugin settings buttons, "Enabled" column
Also, added enabled_site_setting to the Poll plugin so it shows up properly.
2015-07-02 10:59:06 -07:00
Neil Lalonde
9a0e4bb96e Update translations 2015-07-01 17:09:37 -04:00
Gerhard Schlager
5eaf95b328 FIX: Remove invalid translation keys from polls plugin
And it changes the file header since it was wrong.
2015-06-28 01:31:03 +02:00
Arpit Jalan
db02dbb0da Update Translations 2015-06-26 20:30:13 +05:30
Régis Hanol
b25a16ee3e FEATURE: 2 new reports: time to first response, topics with no response
FIX: relativeAgeMediumSpan was off by 1
REFACTOR: extracted decimalAdjust & round functions from the poll plugin
2015-06-22 19:46:51 +02:00
Neil Lalonde
4b6cf528ce update translations 2015-06-19 11:29:13 -04:00
Arpit Jalan
6148ae8775 Update Translations 2015-06-17 22:05:22 +05:30
Arpit Jalan
436e84c6c1 Update Translations 2015-06-15 20:25:53 +05:30
Neil Lalonde
d9efb37ec7 Update translations 2015-06-11 15:35:01 -04:00
Arpit Jalan
45a7c314c2 Update Translations 2015-06-03 20:39:08 +05:30
Régis Hanol
7afe78eec0 FIX: don't use a table for poll results 2015-06-03 16:49:20 +02:00
Régis Hanol
50a39f7e98 use bigger bottom padding instead of line-height to vertical center 2015-06-03 12:35:49 +02:00
Régis Hanol
0013a94692 FIX: use pastel color for background of the selected poll options 2015-06-03 12:28:03 +02:00
Jeff Atwood
1a9da9133e switch back to line-height based centering on polls 2015-06-03 02:58:52 -07:00
Régis Hanol
c240a8bd80 FIX: make sure we can't vote on deleted polls 2015-06-01 22:31:47 +02:00
Arpit Jalan
1ac4e60c90 Update Translations 2015-06-01 23:33:27 +05:30
Régis Hanol
f736b6face FIX: validate poll parameters when type=multiple 2015-06-01 19:28:05 +02:00
Jeff Atwood
9ce6603864 better poll option alignment for multi-line 2015-05-29 16:32:44 -07:00
Arpit Jalan
5880313e84 Update Translations 2015-05-26 20:08:20 +05:30
Robin Ward
78abf85087 FIX: IE9 issues with latest discourse 2015-05-25 12:32:42 -04:00
Arpit Jalan
56544f2048 Update Translations 2015-05-21 00:24:12 +05:30
Régis Hanol
3859273ff7 FIX: prevent span abuse in polls 2015-05-20 15:55:27 +02:00
Régis Hanol
d889f05480 changed default 'poll maximum options' to 20 2015-05-19 14:33:27 +02:00
Régis Hanol
764f9b42fe Merge pull request #3458 from Qasem-h/Bosnian
Add Bosnian langage for discourse
2015-05-15 14:34:16 +02:00
Régis Hanol
42be2b431f ooops, we actually need that :fired: 2015-05-15 11:51:10 +02:00
Régis Hanol
a3fb2c002c FIX: remove dangerous support for style/background attributes in polls 2015-05-15 11:08:51 +02:00
riking
9d232dac9a FIX: Properly whitelist li styles 2015-05-14 16:43:01 -07:00
Régis Hanol
635b31af7b FIX: editing a post with a poll breaks sometimes 2015-05-14 17:18:45 +02:00
Régis Hanol
7c545537a6 FIX: prevent pollception 2015-05-13 23:12:53 +02:00
Régis Hanol
43755a6fab keep closed status when migrating poll to new style 2015-05-13 22:30:27 +02:00
Régis Hanol
06643fb625 add support for all types of unordered lists in migrate_old_polls 2015-05-13 22:10:02 +02:00
Régis Hanol
4df868a420 FIX: update 'migrate_old_polls' rake task to support more cases
FIX: support list that uses double newlines
FIX: support list that uses spaces before the '-'
FIX: don't break lamentably when a poll wasn't created
2015-05-13 19:56:09 +02:00
Régis Hanol
b8005f0b1b FIX: link starting with '[poll' should not break polls 2015-05-13 17:50:25 +02:00
Neil Lalonde
1c5ea5d8ef Update translations 2015-05-12 17:38:49 -04:00
Qasem Hajizadeh
a4c69d450e Create server.bs_BA.yml 2015-05-12 16:22:06 +04:30
Qasem Hajizadeh
2ad958b796 Create client.bs_BA.yml 2015-05-12 16:21:49 +04:30
Régis Hanol
3a9907f392 FIX: prevent self-xss in poll attributes 2015-05-11 20:09:17 +02:00
Robin Ward
585583d38c Upgrade polls to Ember 1.11 2015-05-11 11:20:45 -04:00
Robin Ward
aee12fd6ef Ember Deprecations for Topics 2015-05-11 11:18:37 -04:00
riking
7238c43018 SECURITY: XSS in poll errors dialog 2015-05-08 19:28:04 -07:00
Régis Hanol
0ded6434df FIX: migrate_old_polls should properly identify olds polls at the end of the post 2015-05-08 19:17:09 +02:00
Régis Hanol
c2ffe255c3 FIX: add borders on polls on mobile 2015-05-08 11:13:32 +02:00
Régis Hanol
875a013ec7 FIX: poll design on mobile 2015-05-07 19:49:06 +02:00
Régis Hanol
c1bb7bc7cc clarify copy when editing a poll after the first 5 minutes 2015-05-07 17:24:35 +02:00
Régis Hanol
9b0ca60f52 FIX: support quotes for poll parameters 2015-05-07 16:40:14 +02:00
Régis Hanol
78cff468bc FIX: poll options display issues 2015-05-07 15:19:23 +02:00
Régis Hanol
033761d2f6 FIX: reset all votes when the # of options changes 2015-05-06 18:52:09 +02:00
Arpit Jalan
ee960899df Update Translations 2015-05-06 21:32:11 +05:30
Régis Hanol
2d3a090060 FIX: poll design on mobile 2015-05-05 20:14:38 +02:00
Régis Hanol
73703dd557 FIX: poll fake 3D button effect with custom background color 2015-05-05 20:00:42 +02:00
Sam
b4f666630e make jshint happy 2015-05-05 10:10:50 +10:00
Régis Hanol
90c05ff045 FIX: two-column poll 2015-05-04 22:29:45 +02:00
Gerhard Schlager
409a367ab7 Replace all occurrences of totalVotes 2015-05-04 16:20:13 +02:00
Régis Hanol
86d7412f30 REFACTOR: rename "total_votes" poll field to the more accurate "voters"
FEATURE: automagically load plugin's migrations
2015-05-04 16:01:57 +02:00
Sam
c3e3afcb2c PERF: eliminate N+1 query due to polls 2015-05-04 16:12:03 +10:00
Sam
803feefd54 MessageBus handles readonly redis now, no need to wrap it 2015-05-04 12:21:00 +10:00
Régis Hanol
44bf8fc7f7 Merge pull request #3423 from gschlager/polls-refactor
Extract the parsing of polls
2015-05-03 19:50:58 +02:00