10757 Commits

Author	SHA1	Message	Date
Penar Musaraj	f096c994de	FIX: use correct name for selectable_avatars_enabled site setting	2019-06-19 13:18:16 -04:00
Robin Ward	6fec4982d9	FIX: Couldn't modify a widget that wasn't in the registry	2019-06-18 12:28:18 -04:00
Sam Saffron	03ba1d49fb	DEV: lint file ... We no longer need that isAppleDevice require	2019-06-18 17:12:55 +10:00
Maja Komel	506de13896	FIX: remove temporary hack for fixed iOS bug (#7773) ... A bug where input focus is displaced on modals was fixed in iOS 11.3 update. This hack was causing problems on topic page since hiding main-outlet results in lost read position after opening and closing a modal.	2019-06-18 16:25:29 +10:00
David Taylor	52387be4a4	SECURITY: Add confirmation screen when logging in via email link	2019-06-17 16:18:37 +01:00
David Taylor	5f6f707080	Revert "Merge pull request from GHSA-hv9p-jfm4-gpr9" ... This reverts commit b8340c6c8e.	2019-06-17 16:17:10 +01:00
David Taylor	b8340c6c8e	Merge pull request from GHSA-hv9p-jfm4-gpr9 ... * SECURITY: Add confirmation screen when logging in via email link * SECURITY: Add confirmation screen when logging in via user-api OTP * FIX: Correct translation key in session controller specs * FIX: Use .email-login class for page	2019-06-17 15:59:41 +01:00
Arpit Jalan	102be5a9e3	DEV: optimize fix for sub-categories not getting pre-filled.	2019-06-17 13:28:08 +05:30
tshenry	c909033f2b	Add plugin outlets to login/create-account modals (#7770)	2019-06-17 16:22:00 +10:00
Arpit Jalan	48b9e0d749	FIX: sub-categories was not getting selected for pre-filled topics	2019-06-15 13:46:15 +05:30
Arpit Jalan	efc05e7224	FIX: remove topic timer info on completion	2019-06-13 17:01:43 +05:30
Joffrey JAFFEUX	19ca2d4772	DEV: reset widget clean callback between tests (#7761)	2019-06-12 17:49:02 +02:00
Robin Ward	13b979cb71	FIX: Performing actions on a particular reviewable was displaying an error ... It was expecting a method to remove the reviewable from the current list, only we were not displaying a list. Instead, we refresh the reviewable model with the latest result.	2019-06-12 10:56:30 -04:00
David Taylor	0ebe5ec1f8	FIX: Check postStream.gaps exists before trying postSteam.gaps.after	2019-06-11 23:48:21 +01:00
Robin Ward	f6e0c79742	FIX: Trigger change event when inserting text ... This would normally not fire and result in odd behavior in the review queue when inserting links.	2019-06-11 17:27:34 -04:00
Robin Ward	3d7c26c15e	FIX: Memory Leaks w/ Container (#7750) ... Gives instance initializers the ability to add a `teardown` method that will be called between tests to clean up after themselves.	2019-06-11 18:41:27 +02:00
Robin Ward	47095a7fa1	FIX: Memory leak when adding ajax prefilter repeatedly.	2019-06-11 11:50:35 -04:00
Robin Ward	c322cccd53	FIX: Memory Leaks when decorating posts (#7749) ... * Remove long-deprecated method * FIX: Memory Leaks when decorating posts Previously we'd keep creating mixins dynamically when decorating the same class. This code changes the API to recommend an `id` parameter for each decorator which will avoid leaks. All plugins should be updated to include this parameter, although if they don't in the meantime it'll just mean a warning in the console (and a continued leak.)	2019-06-11 17:21:23 +02:00
David Taylor	f4fd75aea4	DEV: Rename variable to avoid conflict	2019-06-11 13:02:40 +01:00
David Taylor	f1d5b992bf	DEV: Correct linting error	2019-06-11 12:51:18 +01:00
Joffrey JAFFEUX	dc15486f0a	Revert "DEV: resets csrf ajax prefilter only if present (#7747)" ... This reverts commit 6612218a4e.	2019-06-11 13:34:25 +02:00
David Taylor	61b587f66e	FIX: Mark ignored posts as 'read', if last visible post is read (#7739)	2019-06-11 12:16:28 +01:00
David Taylor	000a35b219	FIX: Do not live-load posts from ignored users	2019-06-11 12:07:14 +01:00
Joffrey JAFFEUX	6612218a4e	DEV: resets csrf ajax prefilter only if present (#7747)	2019-06-11 12:50:20 +02:00
Joffrey JAFFEUX	ebf77f74b7	Revert "DEV: prevents csrf token to leak state between tests (#7746)" ... This reverts commit b29d63a52d.	2019-06-11 12:19:49 +02:00
Joffrey JAFFEUX	b29d63a52d	DEV: prevents csrf token to leak state between tests (#7746)	2019-06-11 11:54:23 +02:00
Joffrey JAFFEUX	e6714d3531	Revert "DEV: attempts to prevent session object to be retain in csrf init (#7743)" ... This reverts commit 62c56b6e59.	2019-06-11 10:58:32 +02:00
Joffrey JAFFEUX	4deb0f6d59	DEV: prevents post-cooked decorators to leak between tests (#7744)	2019-06-11 10:02:10 +02:00
Joffrey JAFFEUX	62c56b6e59	DEV: attempts to prevent session object to be retain in csrf init (#7743)	2019-06-11 09:59:14 +02:00
Joffrey JAFFEUX	c407e32368	DEV: should check on object and not length (#7742)	2019-06-11 09:45:45 +02:00
Guo Xiang Tan	e5cace9185	FIX: File size text should not be part of link.	2019-06-11 15:21:06 +08:00
Guo Xiang Tan	06d974d55c	FEATURE: Add base62 sha1 to cooked data attribute ... * FEATURE: Add base62 sha1 to data attribute in `Post#cooked`. * FIX: Use `Upload#short_url` when quoting an image.	2019-06-11 11:15:45 +10:00
Guo Xiang Tan	bd538f7437	FIX: Composer preview not caching inline onebox.	2019-06-11 09:14:53 +08:00
Bianca Nenciu	9168ffc201	PERF: Use already loaded post when quoting or opening draft.	2019-06-11 08:21:38 +08:00
Roman Rizzi	ace6ce0462	FIX: Add 'deleted' to the list of status filters (#7738)	2019-06-10 15:43:49 -03:00
Robin Ward	bdfa55ee5d	UX: Copyedits on reviewable filters	2019-06-10 13:45:38 -04:00
Robin Ward	86f3e74799	DEV: Allow {{d-button}} to include a href	2019-06-10 13:24:40 -04:00
Robin Ward	8b31b812f8	UX: Use a glyph to indicate a new topic instead of "New Topic:" ... In the review queue it was easy to miss "New Topic:" so let's try a font awesome glyph instead.	2019-06-10 12:43:20 -04:00
Robin Ward	8c4e16eafd	FIX: In reply to would sometimes have a broken link	2019-06-10 11:33:10 -04:00
Joffrey JAFFEUX	af08ab5b7b	Revert "DEV: prevents csrf-token initializer to leak session object (#7730)" ... This reverts commit da5255e560.	2019-06-07 18:31:16 +02:00
Joffrey JAFFEUX	ebecd0b7d1	Revert "fix tests, crsf token meta is not present on tests (#7733)" ... This reverts commit 240b61e844.	2019-06-07 18:31:13 +02:00
Joffrey JAFFEUX	2dce650b72	FIX: prevents screen-track from leaking object (#7734)	2019-06-07 17:18:27 +02:00
Joffrey JAFFEUX	240b61e844	fix tests, crsf token meta is not present on tests (#7733)	2019-06-07 17:11:16 +02:00
Joffrey JAFFEUX	dfb66334c1	DEV: prevents global-notice events to leak (#7732)	2019-06-07 16:49:59 +02:00
Joffrey JAFFEUX	55325679ac	DEV: prevents share-popup to leak events (#7731)	2019-06-07 16:48:45 +02:00
Joffrey JAFFEUX	da5255e560	DEV: prevents csrf-token initializer to leak session object (#7730)	2019-06-07 16:46:55 +02:00
Joffrey JAFFEUX	df01249db4	FIX: removes leaking handler in select-kit (#7729)	2019-06-07 16:12:22 +02:00
Joffrey JAFFEUX	fca90106b9	FIX: select-kit events were sometimes not cleaned up (#7728)	2019-06-07 15:20:01 +02:00
Gerhard Schlager	d1228f47bb	FIX: Handle missing plural keys on client	2019-06-07 10:24:17 +02:00
Joffrey JAFFEUX	a652d620f6	FIX: safari desktop doesnt support input[time] (#7719) ... This commit attempts to improve the experience by: - showing time input as disabled on any platform if date hasn't been set - showing a placeholder --:-- to emphasize the expected format	2019-06-07 15:50:43 +10:00