Sam
e17a13ce19
FEATURE: additional "related messages" section
...
This splits out previous message correspondence from suggeted and instead
has a dedicated section called "related messages"
2018-11-12 13:04:42 +11:00
David Taylor
c3c9299c44
FIX: Improve performance for Group.posts_for
( #6588 )
2018-11-12 08:44:20 +08:00
Kris
cee1f5b2c1
Remove unneeded color assignment from user profile
2018-11-09 18:42:19 -05:00
Kris
00ad6e8e37
signup width fix
2018-11-09 12:10:38 -05:00
Joffrey JAFFEUX
f8838ac9cd
FIX: fix/removes broken elements of old dashboard
2018-11-09 17:18:19 +01:00
David Taylor
9ddd40df13
FIX: Fix vertical scrolling in modals
...
Partially reverts 57af43b
2018-11-09 14:35:29 +00:00
Arpit Jalan
1151c093ad
bump onebox version
...
- Better Google Photos oneboxing
2018-11-09 15:44:06 +05:30
Sam
64d9be726f
the protection I placed was in the wrong path moved to /session/sso
...
correct previous commit
2018-11-09 17:18:01 +11:00
Sam
3ae4fcd1f7
Improve redirect avoidance for /sso paths
...
e6b3310577
was missing an ege case
where return url included current_hostname
2018-11-09 17:03:58 +11:00
Sam
e6b3310577
FIX: never redirect back to /sso
it will cause a loop
...
If for any reason our return url is set to `/sso` bypass using it
for login redirect
2018-11-09 14:27:36 +11:00
Sam
15991677d4
FIX: ensure we never cache login redirects by mistake
2018-11-09 11:14:35 +11:00
Gerhard Schlager
24e5be3f0c
FIX: Relative links in translations should work with subfolder
2018-11-08 23:31:05 +00:00
Robin Ward
242a5fc5ef
Add DiscourseEvents for when users as unsuspended/unsilenced
2018-11-08 16:33:38 -05:00
Kris
667af9debd
height fix
2018-11-08 16:06:41 -05:00
Kris
57af43b142
UX: Make long sign-up forms scrollable in modal
2018-11-08 15:25:10 -05:00
Kris
1a96556f38
stacked nav archive alignment adjustment
2018-11-08 12:49:29 -05:00
Kris
b39d949a8e
fix d-editor height for user profile input
2018-11-08 11:28:58 -05:00
Sam
42572ff138
Revert font awesome 5 changes
...
We are still pushing ahead on this 100% just need a bit longer to prepare
all plugins
2018-11-08 16:12:18 +11:00
Penar Musaraj
09dc922b3b
Fix several FontAwesome 5 issues
...
add missing icons, update SvgSprite methods (to fix ruby 2.4 issues), update whisper icon in composer, fix alignment issues
2018-11-07 22:20:53 -05:00
David Taylor
37fb8fc0e7
FIX: Do not display broken image on crawler/print view ( #6575 )
2018-11-07 22:28:45 +00:00
Penar Musaraj
9a34c6153e
Fix small issues with FA5 icons
2018-11-07 16:39:04 -05:00
Penar Musaraj
a5871b6dd1
Rename conflicting SCSS mixin
2018-11-07 14:18:55 -05:00
Penar Musaraj
005e1ecb9b
FEATURE: Update Font Awesome to v5.4.1 and SVGs ( #6557 )
...
* First take on subsetting svg icons
* FontAwesome 5 svg subset WIP
* Include icons from plugins/badges into svg sprite subset
* add svg icon support to themes
* Add spec for SvgSprite
* Misc. SVG icon fixes
* Use FA5 svgs in local-dates plugin
* CSS adjustments, fix SVG icons in group flair
* Use SVG icons in poll plugin
* Add SVG icons to /wizard
2018-11-07 13:05:43 -05:00
Gerhard Schlager
6b60646330
FIX: Relative links in templates should work with subfolders
2018-11-07 11:35:04 +01:00
Sam
0a442e319c
FIX: correct svg handling for images
...
We regressed and optimized images no longer worked with svg
The following adds the correct logic to simply copy file for svgs
and bypasses resizing for svg avatars
2018-11-07 15:29:26 +11:00
Guo Xiang Tan
7534042427
DEV: Update annotations.
2018-11-07 11:11:19 +08:00
Bianca Nenciu
2070edf889
FIX: Clarify User.group_locked_trust_level.
...
* Rename User.group_locked_trust_level to User.group_granted_trust_level.
* Remove the column from users table.
2018-11-07 10:27:44 +08:00
Matthew Campbell
a2044c4528
UX: Make the edits indicator a real link for accessibility ( #6570 )
...
This link didn't have an `href` attribute, so it wasn't in the tab
order. This commit fixes that, while adding a call to `preventDefault`
in the event handler to avoid any regression in event handling.
2018-11-07 10:11:52 +11:00
Kris
ef368ec2ff
Minor spacing adjustments for new search results
2018-11-06 10:01:24 -05:00
Joffrey JAFFEUX
75b1865d15
UX: adds new categories layouts to the wizard ( #6569 )
2018-11-06 15:52:13 +01:00
Joffrey JAFFEUX
fdad24e2e4
FIX: edit category tags select-kit inputs width were wrong ( #6568 )
2018-11-06 11:30:12 +01:00
Jeff Atwood
afbdf9c2d2
Merge pull request #6558 from pmusaraj/disallow-flagging-deleted-post
...
FIX: disable flagging hidden posts
2018-11-05 11:05:32 -08:00
Kris
d7e38d2be8
Adding IE11 Grid support for admin dashboard
2018-11-05 12:52:02 -05:00
Maja Komel
ae9eddb002
FIX: don't allow adding a value containing vertical bar char to the secret list
2018-11-05 12:14:56 +01:00
Joffrey JAFFEUX
cc9869a61b
FIX: topic-map spec with VDOM and i18n plural ( #6564 )
...
It appears that in vdom nodes, pluralized i18n strings are not compiled into a string before widget is compiled and result in an error as VDOM is expecting a string and not an object.
2018-11-05 12:02:18 +01:00
Joffrey JAFFEUX
4d74688b50
UX: uses presentation role for accessibility in topic map ( #6561 )
...
Co-Authored-By: mwcampbell <mwc+github@mwcampbell.us>
2018-11-05 09:45:32 +01:00
Penar Musaraj
94f628fb4c
FIX: disable flagging hidden posts
2018-11-02 13:54:45 -04:00
Robin Ward
931c3d165b
Revert "FIX: We shouldn't include topics when mobile view is enabled"
...
This reverts commit 2feadcdafb
.
2018-11-02 10:29:44 -04:00
Joffrey JAFFEUX
4417faa7e5
Revert "FIX: uses more semantically correct spans in post map ( #6555 )"
...
This reverts commit 5cd055fd30
.
2018-11-02 15:07:22 +01:00
Joffrey JAFFEUX
8067f8a32c
FIX: disables dates filtering on most_disagreed_flags report ( #6556 )
2018-11-02 14:42:52 +01:00
Joffrey JAFFEUX
5cd055fd30
FIX: uses more semantically correct spans in post map ( #6555 )
2018-11-02 13:09:58 +01:00
Joffrey JAFFEUX
4e0f033fae
FEATURE: adds ignored flags to most_disagreed_flags report ( #6554 )
2018-11-02 11:08:00 +01:00
Sam
d84256a876
FEATURE: add Noindex to robots.txt for disallowed routes
...
This strips pages out of indexes that should not exist see:
https://meta.discourse.org/t/pages-listed-in-the-robots-txt-are-crawled-and-indexed-by-google/100309/11?u=sam
2018-11-02 16:39:47 +11:00
Joe
4234058358
UX: don't show crawler navigation in print view ( #6551 )
...
* UX: adds CSS classes to crawler navigation links
* UX: hide crawler navigation in print view
2018-11-02 09:18:07 +11:00
Robin Ward
c4ca5ed50b
FIX: Translation error
2018-11-01 17:44:55 -04:00
Kyle Zhao
f9b36820ef
FIX: only extract script tags with certain types ( #6553 )
...
`script` tags with custom types (e.g. `text/template`) are not executed
by the browser, and should not be extracted into an external theme
JavaScript
2018-11-01 16:01:46 -04:00
Robin Ward
2feadcdafb
FIX: We shouldn't include topics when mobile view is enabled
...
This setting was set to be the opposite of what we want
2018-11-01 14:47:06 -04:00
Robin Ward
ec91450aae
FEATURE: Track how many user flags are agreed/disagreed/ignored
...
Display the percentage when reviewing flags.
2018-11-01 09:59:50 -04:00
Sam
ceafcbc898
FEATURE: show added date when looking at group members
2018-11-01 15:33:28 +11:00
Sam
aa044623bd
FIX: do not create superflous sessions when logged on
...
In some SSO implementations we may want to issue SSO pipelines for
already logged on users
In these cases do not re-log-in a user if they are clearly logged on
2018-11-01 12:54:01 +11:00
Vinoth Kannan
0084b0c26e
Merge pull request #6548 from vinothkannans/category-drop-search
...
UX: Include subcategories in search result of all categories drop down
2018-10-31 23:44:54 +05:30
Vinoth Kannan
28cf4d535e
UX: Include subcategories in search result of all categories drop down
2018-10-31 23:03:24 +05:30
Bianca Nenciu
fa0e421af3
FIX: Do not leak information about post revisions. ( #6536 )
2018-10-31 14:47:00 +00:00
David Taylor
ff6676094f
FIX: Correct bookmark button class
2018-10-31 11:22:24 +00:00
Régis Hanol
0bf52d422c
FEATURE: new 'simultaneous_uploads' site setting
2018-10-31 10:58:09 +01:00
Kris
f97cf10676
Removing edit button from mobile category list
2018-10-30 22:57:06 -04:00
Sam
23423ba112
correct spec and error reporting
...
previous commit misused warn_exception which caused a spec to fail
2018-10-31 13:38:05 +11:00
Blake Erickson
589e3fcaa0
FIX: return 400 for missing required params ( #6546 )
...
If a required param is missing return a 400 and show a message
displaying which param was missing. Added this to the application
controller so that we don't have to add this logic to every controller
action.
2018-10-31 13:02:48 +11:00
Sam
32b1f34910
PERF: avoid DNS lookups when getting IP info
...
Also cleans up interface in DiscourseIpInfo
grew cache to 2000 entries
2018-10-31 12:38:57 +11:00
Bianca Nenciu
e0ccd36dbe
FEATURE: Suspicious logins report. ( #6544 )
2018-10-30 22:51:58 +00:00
Bianca Nenciu
e1e392f15b
DEV: Use DiscourseIpInfo for all IP queries. ( #6482 )
...
* DEV: Use DiscourseIpInfo for all IP queries.
* UX: Use latitude and longitude for more precision.
2018-10-30 22:08:57 +00:00
Bianca Nenciu
4b7ab97a01
FIX: Add 'log in via link' to email templates. ( #6545 )
2018-10-30 19:15:05 +00:00
Joffrey JAFFEUX
11ee07093c
FEATURE: revamps search-menu layout ( #6543 )
2018-10-30 10:44:49 -04:00
Gerhard Schlager
733b8af47b
FIX: Uploads didn't work for subfolder anymore
2018-10-30 12:53:57 +01:00
Gerhard Schlager
5b14f713a0
Use class instead of inline style
2018-10-30 11:25:51 +01:00
Joffrey JAFFEUX
af465effef
FIX: prevents y-axis labels to show useless/wrong values
2018-10-30 09:58:03 +01:00
Vinoth Kannan
92bf3c667e
FIX: Flash authentication data not rendered in latest iOS safari browser
2018-10-30 04:00:36 +05:30
Sam
f8305f53c7
FEATURE: special offline support restricted to Android only
...
The special offline page with fetch interception in service worker
is only strongly required on Android ad a pre-req for PWAs
This is now strongly restricted only to Android while iOS PWA support
gets better
Long term if we build offline support we can unlock it more globally
2018-10-29 16:29:19 +11:00
Jeff Atwood
760e09907b
add a tad more width for user pref forms
2018-10-27 20:20:01 -07:00
Jeff Atwood
817cf8b229
remove extraneous two factor auth info popup
2018-10-27 14:10:26 -07:00
Jeff Atwood
58b53f7841
update copy for "was this you?" login dialog
2018-10-27 13:57:30 -07:00
David Taylor
375bba3c31
FIX: Add String.includes
polyfill for IE11
2018-10-26 23:10:03 +01:00
Kris
cd9a41be55
IE11 fix for create account modal alignment
2018-10-26 17:04:28 -04:00
Kris
0bf413be3e
IE11 fix for category dropdown search icon position
2018-10-26 13:28:05 -04:00
Kris
1f88f69a7f
IE11 Fix for tracking dropdown
2018-10-26 12:55:26 -04:00
Rafael dos Santos Silva
84f858fc23
FIX: Remove orientation from the webmanifest
...
We don't really care about orientation, so let the user OS handle it.
2018-10-26 13:48:14 -03:00
Rafael dos Santos Silva
2450f178ca
FEATURE: Allow admins to control PWA display mode per user agent
2018-10-26 13:47:22 -03:00
Kris
fb15e04e48
Fixing broken badge grant layout
2018-10-26 11:06:31 -04:00
Kris
7c2618e914
Adding classes to login for external auth and user fields ( #6535 )
2018-10-26 10:33:06 -04:00
Joffrey JAFFEUX
b2585524a9
FEATURE: adds a most disagreed flaggers report
2018-10-26 15:59:04 +02:00
David Taylor
e955a1f24b
DEV: Skip ESLint on polyfill
2018-10-26 13:54:03 +01:00
David Taylor
af84949f25
FIX: Add polyfill so that Array.includes
works in IE11
2018-10-26 13:45:29 +01:00
Joffrey JAFFEUX
398f98c568
FIX: ensures reports links are correct on subfolder installs
2018-10-26 12:32:02 +02:00
Penar Musaraj
3c92202654
Set individual future-date-input components as clearable, fixes admin Safari bug ( #6522 )
2018-10-26 11:34:55 +11:00
Penar Musaraj
ed9c21e42c
FEATURE: hide muted categories from /categories list ( #6531 )
2018-10-26 11:34:39 +11:00
Régis Hanol
d17c8df926
Only check for suspicious login for staff members
2018-10-26 00:29:28 +02:00
Kyle Zhao
a6eca28ec6
CSP - extract all other inline JavaScripts ( #6528 )
...
* wizard page inline js
* print topic inline js
* drop JS for preventing double submission
this is the default behavior with Rails' UJS `disable_with` helper
* omniauth complete redirect JS
* account activate inline js
2018-10-25 09:52:01 -04:00
Bianca Nenciu
effbef7d0b
UX: Use user locale for locations. ( #6527 )
...
* UX: Use user locale for locations.
* DEV: Added MaxMindDB test data and fixed test.
2018-10-25 10:54:01 +00:00
Joffrey JAFFEUX
8e274f7296
UX: bumps the user-api-key version to 3 ( #6526 )
...
* UX: bumps the user-api-key version to 3
* fix spec
2018-10-25 09:46:34 +00:00
Bianca Nenciu
2a77550f8c
FIX: Do not track right clicks. ( #6530 )
2018-10-25 09:46:04 +00:00
Bianca Nenciu
6a3767cde7
FEATURE: Warn users via email about suspicious logins. ( #6520 )
...
* FEATURE: Warn users via email about suspicious logins.
* DEV: Move suspicious login check to a job.
2018-10-25 09:45:31 +00:00
Sam Saffron
abaa3f0650
FEATURE: add server:before-head-close-crawler outlet for plugins
...
This outlet allows plugins to inject html prior to closing head tag
2018-10-25 16:31:05 +11:00
Kris
1d7720ef99
UX: Adding Google-compliant logo
2018-10-24 22:11:19 -04:00
Jeff Atwood
c62a8ee335
switch topic jump glyphs to better signify move to top/bottom
2018-10-24 18:41:41 -07:00
Jeff Wong
0ead513fb0
PERF: remove total unread notifications from message bus ( #6529 )
2018-10-25 12:14:34 +11:00
Kris
36e2f863ee
UX: Increase size of topic title tap target on mobile
2018-10-24 20:43:38 -04:00
Kris
c219a5fb1e
Add btn-default class to all default buttons ( #6521 )
2018-10-24 16:09:36 -04:00
Kris
0140844eb0
Remove whitespace in template so we can use :empty psuedo
2018-10-24 16:00:22 -04:00
Matthew Campbell
05438d99a8
FIX: Ensure the like button always has a title, for accessibility ( #6525 )
...
The like button previously didn't have a title for anonymous users,
because the `canToggleLike` flag wasn't set, but the `liked` flag wasn't
set either. This made the button inaccessible to blind users.
2018-10-24 13:58:42 +00:00
Sam
5fd94d3211
PERF: limit unread count to 99 in blue circle
...
This revises: e605542c4e
Previous commit was faulty
2018-10-24 12:10:27 +11:00
Sam
e605542c4e
PERF: limit unread count to 99 in the blue circle
...
This safeguard is in place to avoid very expensive queries on the server
side
2018-10-24 11:53:28 +11:00
Kris
0b4edfc7d6
UX: improve spacing on composer controls
2018-10-23 16:37:36 -04:00
Kris
a82dfbd2dc
Mobile timeline fix
2018-10-23 07:59:00 -04:00
Kris
541b6a8446
UX: Allow vertical timeline to fit on narrower screens
2018-10-22 22:16:59 -04:00
Sam
de6b585368
minor, bypass gravatar update if user does not match
...
this protects against a race condition that can happen when a user record
is destroyed reasonably quickly
2018-10-23 12:20:41 +11:00
Daniel Hollas
cee51672c9
FIX: Strip accents from search query
...
4481836
introduced accent stipping in search_indexer,
but we need to strip it from the query itself as well
TODO in search with diacritics:
- Still need to fix excerpts on search page
- need to support accent stripping in in_topic search
- need to make sure that in:title works correctly
- need to fix "word boldening" in titles
2018-10-23 12:10:33 +11:00
Joffrey JAFFEUX
7d2e582b28
FIX: validates import theme form ( #6513 )
2018-10-23 12:09:06 +11:00
Sam
b74dd7d379
FIX: stop logging every 404 error when searching for gravatars
2018-10-23 11:43:14 +11:00
Kyle Zhao
2cc195f3d9
prettier linting fix
2018-10-22 14:18:26 -04:00
Bianca Nenciu
37fa7775f1
FIX: Fix order of recently connected devices. ( #6517 )
2018-10-22 17:30:23 +00:00
Kyle Zhao
e9a971a2b6
FEATURE: [Experimental] Content Security Policy ( #6514 )
...
do not register new MIME type, parse raw body instead
2018-10-22 13:22:23 -04:00
Jeff Wong
ec2613699f
Change box category view to use flexbox
2018-10-22 10:15:31 -07:00
Régis Hanol
b9261588f9
make the code prettier
2018-10-22 19:07:41 +02:00
Régis Hanol
3e232412e3
UX: show error when hitting the rate limit on password reset
2018-10-22 19:00:30 +02:00
David Taylor
3377f26eba
FIX: Clean tag before searching for matches
2018-10-22 11:09:06 +01:00
David Taylor
37b7afa522
FIX: Sanitize tags before creation
2018-10-22 10:53:42 +01:00
Kyle Zhao
dca830cb73
Revert "FEATURE: [Experimental] Content Security Policy ( #6504 )"
...
This reverts commit fb8231077a
.
2018-10-19 11:53:29 -04:00
Kris
b35c8fb336
Add offset to topic footer admin menu, to avoid header overlap
2018-10-19 11:30:11 -04:00
David Taylor
0dd717e641
Revert "FIX: Sanitize tags before creation"
...
This reverts commit 18ae8de9e5
.
2018-10-19 15:49:05 +01:00
David Taylor
18ae8de9e5
FIX: Sanitize tags before creation
2018-10-19 15:43:31 +01:00
Kyle Zhao
fb8231077a
FEATURE: [Experimental] Content Security Policy ( #6504 )
2018-10-19 10:39:22 -04:00
Bianca Nenciu
b69652278f
FEATURE: Add Wiki Editor badge. ( #6511 )
2018-10-19 15:30:27 +02:00
David Taylor
7166d7de9a
FIX: Prevent duplicate tags in tag-choosers ( #6512 )
...
* FIX: Prevent duplicate tags in tag-choosers
This reverts 5685b45
, which fixes the duplicate tags problem.
The fix introduced by 5685b45
is re-implemented on the server.
2018-10-19 13:44:43 +01:00
Joffrey JAFFEUX
5f86564da1
FEATURE: adds latest to user-api-key session scope
2018-10-19 09:54:06 +02:00
Sam
9bfc939692
cleanup so gravatar download failures are consistent
...
previously we would ignore socket error, but this would mean that
there could be conditions where we would keep trying to download
gravatars forever (in an hourly job)
2018-10-19 12:51:55 +11:00
Angus McLeod
85ef8e5a9f
auto is not a valid value for min/max height ( #6509 )
2018-10-18 21:33:45 -04:00
Bianca Nenciu
22ada32d4d
FIX: Strip @ when searching for users and groups. ( #6506 )
2018-10-19 11:56:10 +11:00
Robin Ward
f0af61da41
FIX: User AvatarLookup
for looking up avatar details ( #6508 )
...
This allows plugins with their own avatar logic to work in the user
summary sections.
2018-10-18 15:49:34 -04:00
Blake Erickson
93485facaf
FIX: lowercase username for add/rem group members
...
This fix searches for users based on the downcased username so that if
you pass in usernames to add/remove from a group and you don't have the
casing just right it will still find the correct users.
I updated the tests to add a username that has a mix of upper and
lowercase letters to verify this functionality.
2018-10-18 13:17:24 -06:00
Régis Hanol
3973823a33
FIX: always update 'last_gravatar_download_attempt' when updating gravatar
2018-10-18 11:02:54 +02:00
Kyle Zhao
0f1afad6da
FIX: extracted theme JavaScripts for multisite ( #6502 )
...
* FIX: extracted theme javascripts for multisite
* onceoff to rebake all theme fields
2018-10-18 17:05:34 +11:00
Guo Xiang Tan
22408f93c9
FIX: Wrap custom fields database statements in a transaction.
...
Kind of strange that we don't do it because a database statement
may fail and leave us in a weird state.
2018-10-18 12:23:04 +08:00
Guo Xiang Tan
44eba0bb60
FIX: Don't rescue PG::UniqueViolation
within a transaction.
...
Also acquire a transaction per link instead of failing when
any of the links can't be processed.
This prevents ActiveRecord from rolling back the transaction
and the next SQL statement sent to PG will fail. This is
however hard to test as it only happens when there are
two competing process trying to process this method at the
same time.
2018-10-18 10:54:30 +08:00
Guto Foletto
0abc932056
add styles so permalinks admin could fit mobile screen ( #6496 )
2018-10-17 17:37:14 +02:00
Bianca Nenciu
f60b10d090
UX: Warn users if the post that's currently edited has changed. ( #6498 )
2018-10-17 15:35:32 +02:00
David Taylor
065bf0762c
FEATURE: New plugin outlets for user card customization
2018-10-17 14:15:48 +01:00
David Taylor
c6f364224e
FEATURE: Allow plugins to whitelist user custom fields for public display ( #6499 )
...
This works exactly the same as `whitelist_staff_user_custom_fields`, but is not limited to staff
2018-10-17 10:33:27 +01:00
Arpit Jalan
42c405a820
FIX: use topic summary for meta description if topic excerpt is blank
2018-10-17 14:13:30 +05:30
Joe
1b5ba899a1
UX: header items wrap on small screens for anon
2018-10-17 14:19:20 +08:00
Joe
5815a33a9a
FIX: closing an empty fullscreen composer with toggler prevents scrolling
2018-10-17 13:52:47 +08:00
Kris
b23ebf10c2
Minor post alignment fixes
2018-10-16 12:39:55 -04:00
Vinoth Kannan
e3c6dd26c4
FIX: Do not set null value to remove cookie
2018-10-16 06:48:54 +05:30
Sam
19d7543004
FIX: clear color scheme cache when clearing theme cache
2018-10-16 12:00:46 +11:00
Vinoth Kannan
08c404e138
FIX: Do not set null value to remove cookie
2018-10-16 06:12:32 +05:30
Sam
8d06731484
FIX: reduce amount of work onceoff does
...
In the past onceoff was forcing inline download of gravatars,
this can be so expensive that it will never finish
This fix ensures it only marks avatars stale which will be picked
up by regular schedules
2018-10-16 10:29:16 +11:00
Kyle Zhao
99d1ded3b3
rename route /javascripts
to /theme-javascripts
( #6495 )
2018-10-15 11:32:52 -04:00
Maja Komel
c104256991
FIX: SSO provider secrets - check wildcard domains last, toggle secrets visibility
2018-10-15 16:18:29 +02:00
Joffrey JAFFEUX
f6eff38c0e
FEATURE: adds list#(unread|new) to user api key routes ( #6494 )
2018-10-15 15:48:35 +02:00
David Taylor
7ac08f936e
FEATURE: Upload tags from CSV ( #6484 )
2018-10-15 09:12:54 +01:00
Sam
4c8fe13500
FIX: remove code that restricted "header" theme field from admin
...
There was some old code that restricted a percentage of a themes code from
admin, only when admin was refreshed, this leads to lots of confusion
Conditional is now removed
2018-10-15 17:29:10 +11:00
Maja Komel
27e732a58d
FEATURE: allow multiple secrets for Discourse SSO provider
...
This splits off the logic between SSO keys used incoming vs outgoing, it allows to far better restrict who is allowed to log in using a site.
This allows for better auditing of the SSO provider feature
2018-10-15 16:03:53 +11:00
Kyle Zhao
6acdea37c4
DEV: extract inline js when baking theme fields ( #6447 )
...
* extract inline js when baking theme fields
* destroy javascript cache when destroying theme fields
This work is needed to support CSP work
2018-10-15 15:55:23 +11:00
Guo Xiang Tan
aa60936115
DEV: Add order to avoid randomly failing test.
2018-10-15 11:42:45 +08:00
Joe
2acb885c72
FEATURE: fullscreen composer mode on desktop
...
Adds keyboard shortcut and icon that allows expanding composer to full screen.
2018-10-15 13:59:49 +11:00
Maja Komel
57b52cd1de
FIX: keep emoji syntax for custom emojis in quotes ( #6488 )
2018-10-15 10:57:15 +08:00
Guo Xiang Tan
84d4c81a26
FEATURE: Support backup uploads/downloads directly to/from S3.
...
This reverts commit 3c59106bac
.
2018-10-15 09:43:31 +08:00
Joe
6a59187ae8
UX: images should be responsive in embedded comments
2018-10-14 23:38:07 +08:00
Robin Ward
2178f7768f
FIX: Don't show empty user stats in the card when profile is hidden
2018-10-12 12:33:27 -04:00
Sam
a1c912b630
Return 400 instead of 404 for bad token
2018-10-12 10:51:41 +11:00
Bianca Nenciu
048cdfbcfa
FIX: Do not allow revoking the token of current session. ( #6472 )
...
* FIX: Do not allow revoking the token of current session.
* DEV: Add getter of current auth_token from Guardian.
2018-10-12 10:40:48 +11:00
Bianca Nenciu
e68ecf1f1d
UX: Add link to Groups in admin dashboard. ( #6480 )
...
* UX: Add link to Groups in admin dashboard.
* UX: Site settings have immediate effect.
2018-10-12 10:34:47 +11:00
Vinoth Kannan
39b7e32848
DEV: Require sso and sig query string params for sso_login
2018-10-12 05:03:30 +05:30
Blake Erickson
13b3cead06
FEATURE: Allow bulk removing users from a group
...
This change maintains backwards compatibility to allow you to remove a
single user from a group but allows you to specify a comma separated list
of users for bulk removal from a group.
Also it extracts out common functionality for fetching users from params
used in bulk adding users so it can also be used for removing users.
2018-10-11 15:30:54 -06:00
Neil Lalonde
12f132736b
FIX: error looking at users in admin when tl3_promotion_min_duration is set to a very high value
2018-10-11 15:11:48 -04:00
Robin Ward
c2add85e75
FIX: Typo, should be authentication
...
cc @xrav3nz
2018-10-11 14:58:46 -04:00
Bianca Nenciu
ded5ff90aa
FIX: Groups list does not refresh when query changes. ( #6481 )
2018-10-11 21:20:17 +08:00
David Taylor
1b0fbc4d30
FIX: Allow theme edit route name to be overridden
...
This is required for the theme-creator plugin, this change won't have
any effect on regular Discourse installations
2018-10-11 13:20:04 +01:00
Vinoth Kannan
6a444eee56
Merge pull request #6476 from vinothkannans/tl4-flag
...
FEATURE: automatically hide non-TL4 posts when flagged by a TL4 user
2018-10-11 17:13:26 +05:30
Vinoth Kannan
227a49bb32
FEATURE: automatically hide non-TL4 posts when flagged by a TL4 user
2018-10-11 17:11:46 +05:30
Bianca Nenciu
f1a52138d6
UX: Move Recently Used Devices to the bottom. ( #6483 )
2018-10-11 19:22:30 +08:00
Jeff Wong
b5b382dcd6
Feature: add boxes with subcategories option for desktop categories page ( #6471 )
...
* Feature: add boxes with subcategories option for desktop categories page
* only add subclass div when subclasses exist
2018-10-11 15:59:37 +08:00
Bianca Nenciu
6275e745a7
FIX: Fix open quote links in new window. ( #6477 )
2018-10-11 15:51:14 +08:00
Régis Hanol
09961fb425
FIX: properly escape name of custom emoji
2018-10-11 09:35:23 +02:00
Guo Xiang Tan
3c59106bac
Revert "FEATURE: Support backup uploads/downloads directly to/from S3."
...
This reverts commit c29a4dddc1
.
We're doing a beta bump soon so un-revert this after that is done.
2018-10-11 11:08:23 +08:00
Gerhard Schlager
c29a4dddc1
FEATURE: Support backup uploads/downloads directly to/from S3.
2018-10-11 10:38:43 +08:00
Kyle Zhao
ffc241eb25
FIX: multiple loadScript to the same url may resolve prematurely ( #6474 )
...
This is how `loadScript(url)` currently deals with multiple concurrent requests
1. Check existing `<script>` tags, and mark existing scripts (other than the
input `url`) as loaded
2. Find "true" `url` of the requested resource (CDN, subfolder path, etc)
3. Check if we have loaded the resource with that "true" `url`, and resolve
immediately if we have
4. Otherwise insert a `<script>` tag with the "true" `url` to load it
For example, in a subfolder install:
- Input `url` = `/javascripts/script.js`
- "True" `url` = `/subfolder/javascript/script.js`
And the _very_ subtle bug here is that we should use also use the true `url`
for step (1), because:
- Since the input and true `url` are different, we mistakenly mark the true
`url` as loaded in step one
- After finding the true `url`, and setting `loaded[trueUrl] = true` in (1), we
resolve the promise prematurely, when the resource could still be loading
2018-10-11 08:55:36 +08:00
Robin Ward
a566ed42ae
FEATURE: Option to disable user presence and profile
...
This allows users who are privacy conscious to disable the presence
features of the forum as well as their public profile.
2018-10-10 17:34:33 -04:00
Kris
34e8d17ad0
Fixing left alignment of post controls
2018-10-10 12:11:47 -04:00
David Taylor
98211f945f
FIX: 'none' tag page would not load
2018-10-10 16:00:33 +01:00
Kris
94b115f7d9
increase contrast for $danger-medium on dark themes
2018-10-10 09:51:50 -04:00
Arpit Jalan
c84415b1f2
FEATURE: support category slug when creating new topic via URL
2018-10-10 17:06:02 +05:30
Guo Xiang Tan
ae6a5419e0
DEV: Report the backtrace as well.
2018-10-10 17:43:42 +08:00
Penar Musaraj
0ea8c1943f
Let plugins decorate banner topic, fixes local dates in banners ( #6452 )
2018-10-10 17:27:23 +08:00
Kris
1f14fb5e1e
Don't override category badge icon color in similar topic JIT
2018-10-09 15:38:49 -04:00
Bianca Nenciu
1d26a473e7
FEATURE: Show "Recently used devices" in user preferences ( #6335 )
...
* FEATURE: Added MaxMindDb to resolve IP information.
* FEATURE: Added browser detection based on user agent.
* FEATURE: Added recently used devices in user preferences.
* DEV: Added acceptance test for recently used devices.
* UX: Do not show 'Show more' button if there aren't more tokens.
* DEV: Fix unit tests.
* DEV: Make changes after code review.
* Add more detailed unit tests.
* Improve logging messages.
* Minor coding style fixes.
* DEV: Use DropdownSelectBoxComponent and run Prettier.
* DEV: Fix unit tests.
2018-10-09 22:21:41 +08:00
Erin Kosewic
51aba32651
FEATURE: add branch option to remote theme import
...
* FEATURE: add branch option to remote theme import
* FIX: Add missing variable in params
* FIX: Add missing param for import_theme method
* SPEC: Add test methods for branch support in git import
* FIX: Add missing space to scss style
* Do not assume default branch as master
* Change branch field placeholder
* FIX: add missing div start tag
2018-10-09 17:01:08 +11:00
Kyle Zhao
acba7d2a5d
Extract discourse_javascript.html.erb
to a scrip include
...
* extract omniauth auth complete inline JS
* extract Ember error logging inline JS
* transpile `authentication-complete`
This is CSP related work
2018-10-09 16:50:45 +11:00
Kyle Zhao
8b2a379e4e
DEV: transpile certain ES6 files without producing a module ( #6460 )
...
`.js.no-module.es6` files will be transpiled without producing a module.
import/export statements are deliberately not supported, so one would still need to use
`const module = require('moduleName').default.`
2018-10-09 09:18:23 +08:00
Jeff Wong
e55f220b33
add category style boxes with featured topics option
2018-10-08 16:19:54 -07:00
Kris
c889c0daee
Only prevent checkbox/radio from flex-grow
2018-10-08 13:10:51 -04:00
Gerhard Schlager
97ad9e9d9b
UX: Prompt for custom invite message was hard to translate
2018-10-08 18:01:21 +02:00
Gerhard Schlager
eb3ed7f6fd
Add missing annotations
2018-10-08 18:01:21 +02:00
Kris
ec33b46d31
IE11 doesn't support nested calc
2018-10-08 11:55:54 -04:00
Joffrey JAFFEUX
da8916aecd
FIX: adds a title attribute on value list input ( #6463 )
2018-10-08 12:08:36 +02:00
Joffrey JAFFEUX
22187508e3
FEATURE: adds header text/background color to site ( #6462 )
2018-10-08 11:52:57 +02:00
Guo Xiang Tan
3c0ec317ac
DEV: Fix wizard qunit tests not running.
2018-10-08 14:45:56 +08:00
Guo Xiang Tan
43512e9865
Merge pull request #6457 from pmusaraj/yarn-manage-test-vendor-dependencies
...
DEV: Use Yarn managed test vendor dependencies
2018-10-08 09:26:26 +08:00
Sam
550e108a8c
FEATURE: only export settings that changed via rake task
2018-10-08 11:54:52 +11:00
Kris
41ceb6ca88
topic body and small action widths inconsistent
2018-10-05 18:37:23 -04:00
David Taylor
cbb8f6f0fe
UX: Use 'trash' icon instead of 'times' for deleting small actions
2018-10-05 22:31:56 +01:00
Kris
0a1ac88f2c
last visit line needs more contrast
2018-10-05 15:28:10 -04:00
Kris
fa21b39875
FIX: topic admin menu was clipped on short posts due to overflow hidden
2018-10-05 10:51:27 -04:00
Penar Musaraj
be56f18cdd
Replace deprecated dropdown-button with DropdownSelectBoxComponent ( #6451 )
2018-10-05 09:48:17 -04:00
David Taylor
75488257c5
FIX: Redirect users to top when latest
is the homepage
2018-10-05 12:14:57 +01:00
David Taylor
9bf522f227
FEATURE: Mixed case tagging ( #6454 )
...
- By default, behaviour is not changed: tags are made lowercase upon creation and edit.
- If force_lowercase_tags is disabled, then mixed case tags are allowed.
- Tags must remain case-insensitively unique. This is enforced by ActiveRecord and Postgres.
- A migration is added to provide a `UNIQUE` index on `lower(name)`. Migration includes a safety to correct any current tags that do not meet the criteria.
- A `where_name` scope is added to `models/tag.rb`, to allow easy case-insensitive lookups. This is used instead of `Tag.where(name: "blah")`.
- URLs remain lowercase. Mixed case URLs are functional, but have the lowercase equivalent as the canonical.
2018-10-05 10:23:52 +01:00
Vinoth Kannan
8430ea927e
FIX: Generate webhook payloads before destroy events ( #6325 )
2018-10-05 16:53:59 +08:00
Sam
5b630f3188
FIX: stop logging every time invalid params are sent
...
Previously we were logging warning for invalid encoded params, this can
cause a log flood
2018-10-05 14:33:19 +10:00
Kris
948c556cc6
decrease contrast on danger-low color
2018-10-04 17:30:10 -04:00
Kris
98b9913033
UX: Disable button hover effects on touch devices
2018-10-04 17:15:37 -04:00
Kris
ab1e5732d7
UX: Category colorpicker restyle
2018-10-04 15:47:46 -04:00
Vinoth Kannan
3faa022c6f
Merge pull request #6453 from vinothkannans/sso_provider_redirect
...
FIX: redirect users to SSO client URL after social login
2018-10-05 00:34:34 +05:30
Vinoth Kannan
ca74246651
FIX: redirect users to SSO client URL after social login
2018-10-05 00:01:08 +05:30
Penar Musaraj
4ae9cb28e4
remove probes.js, highlight.pack.js
2018-10-04 13:50:54 -04:00
Kris
2e28116243
Period-chooser should have visible overflow
2018-10-04 12:28:48 -04:00
Kris
09caf95e7d
create account inputs too wide on iOS
2018-10-04 12:02:28 -04:00
Kris
8e0fe32f37
Minor login layout fixes
2018-10-04 11:54:51 -04:00
Bianca Nenciu
e0e0a91e7d
FIX: Retry sending email in case of temporary issue. ( #6375 )
2018-10-04 22:56:24 +08:00
David Taylor
3c2608d41c
FIX: Correctly censor strings starting or ending with non-word characters ( #6445 )
2018-10-04 15:15:10 +01:00
Bianca Nenciu
6ad13e5ae9
FIX: Avoid redirection when not leaving forum. ( #6419 )
...
* FIX: Avoid redirection when not leaving forum.
* DEV: Updated click-track's tests.
2018-10-04 22:06:31 +08:00
Kris
ff47609141
UX: Improve custom field layout on signup
2018-10-03 22:26:05 -04:00
Vinoth Kannan
a651d39b8a
FIX: Display errors in single theme pages ( #6449 )
...
Currently the errors are not well handled. So it breaks the whole UI of admin themes list page.
2018-10-04 02:33:06 +05:30
Penar Musaraj
b5bdd42838
Progress bar CSS refactoring ( #6444 )
...
* Less magic in calculating topic progress bar
* more minor adjustments to topic progress CSS
* Bounce back button again
* Fix prettier warning
2018-10-03 13:21:57 -04:00
Kris
46563082a9
FIX: Move overflow from cooked to parent element to allow for slight overflow of blur/italic/shadow
2018-10-03 10:18:36 -04:00
Penar Musaraj
dc8a16b43b
Use Yarn to manage dependencies, cleanup unused bootstrap libs ( #6436 )
2018-10-03 10:15:43 -04:00
Vinoth Kannan
23b4ab9bf9
DEV: Do not use concatenation in translations
2018-10-03 11:59:21 +05:30
Vinoth Kannan
2912170e9e
Update placeholder github url in correct format
2018-10-03 11:14:36 +05:30
Maja Komel
73443d889c
FIX: keep files in order when adding multiple uploads ( #6306 )
...
* FIX: keep files in order when adding multiple uploads
* use filename in the placeholder when uploading files
* add tests
* add consecutive nr to the placeholder when multiple uploads with the same filename
2018-10-03 11:12:36 +10:00
Kris
07be8e5447
caret icon is redundant on hamburger menu button
2018-10-02 15:06:50 -04:00
Neil Lalonde
dc1e7bb645
UX: when admin is deleted, make it clear in staff action logs when records belong to a deleted user and show their username in the details
2018-10-02 13:46:54 -04:00
Penar Musaraj
98aaad6675
Improve "hit area" for topic progress bar on mobile ( #6442 )
...
* Improve "hit area" for topic progress bar on mobile
* Only target admin wrench on mobile
2018-10-02 12:26:16 -04:00
Kris
7228c4964c
Flag reason "something else" fix
2018-10-02 12:05:21 -04:00
Penar Musaraj
34516c72bd
FIX: Recover public actions (likes) when recovering a post ( #6412 )
2018-10-02 11:25:08 -04:00
Kris
324b57c207
Prevent flexbox from shrinking inputs
2018-10-02 10:42:49 -04:00
Gerhard Schlager
7fe17e93e2
UX: Label of checkbox site setting needs a span for nested HTML
2018-10-02 16:25:05 +02:00
Gerhard Schlager
3a6ab02563
FEATURE: Notify admins when scheduling of backup fails
2018-10-02 15:48:16 +02:00
Jeff Atwood
40d0fc9259
UX: slightly taller progress bar for mobile
2018-10-02 03:21:08 -07:00
Joffrey JAFFEUX
a515ba8612
FIX: corrects typo and adds a spec for likes report ( #6439 )
...
* FIX: corrects typo and adds a spec for likes report
* save!
2018-10-02 02:27:43 -07:00
Joffrey JAFFEUX
f34d9202b4
UX: makes reports fade in when loading is done ( #6440 )
2018-10-02 09:20:04 +02:00
Kyle Zhao
7591da1e64
FIX: s3BaseUrl
with small s
2018-10-02 13:06:33 +08:00
Bianca Nenciu
719a433c03
FIX: Sync client & server rules regarding tag names. ( #6400 )
2018-10-01 21:45:44 -07:00
Kyle Zhao
d9bea66365
UX: confirmation before changing group membership in admin ( #6426 )
2018-10-01 21:34:08 -07:00
Kyle Zhao
ab448ca8f3
extract client side Discourse
setup inline JS ( #6409 )
2018-10-01 21:29:04 -07:00
Sam
580c923ff3
UX: remove flex basis from first item
...
We do not want to take up 100% width for name/username on first line
2018-10-02 13:16:51 +10:00
Sam
120c220c18
UX: correct ordering of username / fullname in UX
2018-10-02 12:56:50 +10:00
Penar Musaraj
533315a607
Fix progress bar position when theme has header elements outside #main ( #6425 )
2018-10-02 10:45:23 +10:00
Kris
42066e407d
UX: updating style of mobile navigation dropdown
2018-10-01 14:49:00 -04:00
Kris
eeffac3186
label needs a span to contain nested HTML in description
2018-10-01 13:42:35 -04:00
Kris
1897155479
prettier
2018-10-01 11:59:21 -04:00
Kris
eca671b972
Prevent category dropdowns from cropping text, simplify styles
2018-10-01 11:53:18 -04:00
Maja Komel
1add11d8c9
FIX: don't send multiple requests when changing category notification ( #6435 )
2018-10-01 23:41:23 +08:00