Commit Graph

12015 Commits

Author SHA1 Message Date
Kyle Zhao
2901691e87 FEATURE: per-category approval settings (#5778)
- disallow moving topics to a category that requires topic approval
2018-07-13 12:51:08 +10:00
Kris
01fe42d5e2 prettier fix 2018-07-12 16:41:44 -04:00
Kris
b79fedd540 Streamlining some breakpoint mixins 2018-07-12 16:39:16 -04:00
Maja Komel
a611db666b
Merge pull request #6088 from majakomel/edit-category-fix
FIX: hidden tooltip was preventing clicks on category settings input field
2018-07-12 21:42:11 +02:00
Maja Komel
967736caf2 FIX: hidden tooltip was preventing clicks on category settings input field 2018-07-12 18:30:32 +02:00
Sam
6bc0f97668 FEATURE: add data-username on user-info blocks
This makes it easier to target in CSS
2018-07-12 18:16:05 +10:00
Sam
1f0bbca87e FIX: on initial load category subcategories were not mapped correctly 2018-07-12 17:59:56 +10:00
Arpit Jalan
ea0498ae93 make prettier happy 2018-07-12 12:42:11 +05:30
Sam
67bc972d74 UX: make sure autocomplete does not render off screen 2018-07-12 17:07:25 +10:00
Arpit Jalan
bd760e98af FIX: display error message when upload fails in wizard 2018-07-12 12:08:09 +05:30
Sam
87a5cb982c correct action typo 2018-07-12 16:24:28 +10:00
Guo Xiang Tan
7c8cd9cfdd Fix the build. 2018-07-12 14:11:42 +08:00
Sam
29eb9dda59 DEV: add deprecation for currentThemeKey
This ensures that theme components will not explode when attempting to access this
2018-07-12 15:36:38 +10:00
Kris
a201103127 removing some old styles 2018-07-12 00:53:24 -04:00
Guo Xiang Tan
258e9e35ca PERF: Make mega topics work without a stream.
There are tradeoffs that we took here. For the complete
story see
https://meta.discourse.org/t/performance-improvements-on-long-topics/30187/27?u=tgxworld.
2018-07-12 12:46:12 +08:00
Misaka 0x4e21
de4d4747c4 UX: Focus on new topic link that appears on the page via keyboard. (#6081)
- Add an <a> tag to handle keypress events on new topic indicator.
2018-07-12 14:36:19 +10:00
OsamaSayegh
decf1f27cf FEATURE: Groundwork for user-selectable theme components
* Phase 0 for user-selectable theme components

- Drops `key` column from the `themes` table
- Drops `theme_key` column from the `user_options` table
- Adds `theme_ids` (array of ints default []) column to the `user_options` table and migrates data from `theme_key` to the new column.
- Removes the `default_theme_key` site setting and adds `default_theme_id` instead.
- Replaces `theme_key` cookie with a new one called `theme_ids`
- no longer need Theme.settings_for_client
2018-07-12 14:18:21 +10:00
OsamaSayegh
f13a7226db FIX: display tables in posts history diff (#6032) 2018-07-12 14:13:52 +10:00
Joffrey JAFFEUX
1ed4f0ee8a
FIX: datepicker will now default to monday as first day
This will be regardless of the user locale. Many users use english forums even if not from the US and would end up having sunday as the first day of the week in the calendar. This commit follows the international standard.
2018-07-11 23:49:52 +02:00
Kris
6a530b8949 Prevent long strings from overflowing bulk buttons 2018-07-10 17:05:27 -04:00
Neil Lalonde
1021bc5640 FIX: invisible images and incorrect css on password reset and accept invite pages 2018-07-10 11:18:12 -04:00
Neil Lalonde
3b7acbd086 FIX: broken image on password reset page on subfolder installs 2018-07-10 11:10:06 -04:00
Guo Xiang Tan
8f4cb1a742 UX: Timeline lookup on mega topics should use date of current post. 2018-07-10 16:43:20 +08:00
Maja Komel
ba7a8db0e8 UX: show custom footer on user activity and preferences pages (#6080) 2018-07-10 16:14:26 +08:00
Joe
59950b0f95
UX: category description display issue
html tags like `<strong>` are displayed on separate lines inside a flexbox with `flex-wrap`
2018-07-10 13:51:46 +08:00
Canapin
6cc860be09 Update user.scss (#6079)
Prevent user custom fields new lines going under the user avatar on the profile page when the user has no bio.
2018-07-10 08:03:18 +08:00
Sam
d9a9682f72 FIX: also count sub categories in hamburger when needed
previously there were cases where we suppress subcategories yet don't count them
this leads to confusion
2018-07-09 16:52:55 +10:00
Joe
d36c260dd0
UX: adds flexbox to topic user name fields on mobile 2018-07-09 11:45:00 +08:00
Guo Xiang Tan
6d0732f7b4 Disable service worker on Apple devices for now.
The service worker is not used for any features
on Apple devices and we've received multiple reports
of service workers causing problems.
2018-07-09 11:34:16 +08:00
Guo Xiang Tan
0ab42e9185 Revert "DEV: Add param that allows service worker to be removed."
This reverts commit cb12f462a2.
2018-07-09 11:29:09 +08:00
Guo Xiang Tan
cb12f462a2 DEV: Add param that allows service worker to be removed. 2018-07-09 11:24:06 +08:00
Joffrey JAFFEUX
9f558d7e74
FIX: mixed texts when mixing rtl/ltr text in topic tile on categories page 2018-07-08 08:37:12 +02:00
Joe
4852e5df34
FIX: mobile /admin/users style fixes 2018-07-07 12:28:04 +08:00
Maja Komel
18f5f646b1 FEATURE: allow selecting a tag when moving posts to a new topic (#6072) 2018-07-06 18:21:32 +02:00
Maja Komel
7cba4cbcc6 FEATURE: allow selecting a tag when moving posts to a new topic (#6074) 2018-07-06 18:21:00 +02:00
Guo Xiang Tan
73e30ff4c2 Revert "Rename s3 vars, change condition when displaying s3 uploads"
The new variables do not reflect that they represent S3 settings.

This reverts commit 24dfa1b657.
2018-07-06 15:53:57 +08:00
Joe
dc04892a2d
FIX: mobile /admin/users page adjustments 2018-07-05 16:18:51 +08:00
Guo Xiang Tan
af5cd7e548 Unregister old service workers when Discourse.ServiceWorkerURL changes. 2018-07-05 14:57:32 +08:00
Joe
b5d29f7d88
FIX: responsive admin adjustments 2018-07-05 14:32:27 +08:00
Sam
b54ba4c952 FIX: mentions broken after adding an <abbr> tag
A previous shortcut used was not allowing for <abbr and other tags starting with a

If <abbr> appeared anywhere in the text all mentions would fail to link
2018-07-05 09:27:11 +10:00
Joffrey JAFFEUX
4273e30b9a
fix prettier offense 2018-07-04 17:41:07 +02:00
Joe
d8e51095c9
FIX: mobile topic-timer adjustments 2018-07-04 19:23:09 +08:00
Maja Komel
b02b44c966 prettier formatting 2018-07-04 11:03:48 +02:00
Maja Komel
cb89797e9a FEATURE: shows remaining backup codes in user preferences 2018-07-04 10:45:42 +02:00
Vinoth Kannan
9cc7df13a4 FIX: Unable to add new webhook if the webhooks list is empty 2018-07-04 09:48:11 +05:30
Joe
888a827b93
FIX: removes inline styles applied to "all categories" in category dropdown
"all categories" in the category dropdown gets category-like inline styles when category mode is set to "box"
2018-07-03 12:02:50 +08:00
Joe
2bfe700bd6
FEATURE: responsive admin pages 2018-07-03 11:14:53 +08:00
Jeff Wong
2b240e74b5 fix typo 2018-07-02 15:35:24 -07:00
Jeff Wong
42b11fc2c5 Fix: Add pan direction data, do not activate pan when event is not vertical 2018-07-02 15:26:01 -07:00
Joffrey JAFFEUX
b4cb31d999
FIX: disabled topic timeline panning on desktop 2018-07-02 14:52:02 +02:00
Joffrey JAFFEUX
c754ece8f5
FEATURE: drops with-email-link and replaces it by with-email-button 2018-07-02 14:35:50 +02:00
Misaka 0x4e21
cb86c5ae1e FIX: Fix badge count of other users. (#6016)
Don't count the current user in "Others with this badge".
2018-07-02 15:34:09 +08:00
Maja Komel
3ddfc12307 unify user preferences views 2018-07-02 15:38:36 +10:00
Joe
f3a1b3829a
FIX: composer popup close link overlaps with text 2018-06-30 13:02:10 +08:00
Joffrey JAFFEUX
405998b3fe
FIX: ensures correct icon is displayed on mobile upload shortcut button 2018-06-30 02:26:55 +02:00
Jeff Wong
f4d77037d0 prettierjs formatting 2018-06-29 10:02:52 -07:00
Jeff Wong
d79b54de6c make linter happy 2018-06-29 09:53:07 -07:00
Jeff Wong
8bdb62ca01 FEATURE: add swipe detection for dismissing mobile topic scroller 2018-06-29 09:44:18 -07:00
Joe
15bb8954de
FIX: low contrast issues for dark themes in edit history modal 2018-06-29 14:42:26 +08:00
Guo Xiang Tan
d1c3eb6bfa FIX: Recovering a post does not insert it back into the stream correctly. 2018-06-29 11:41:44 +08:00
Robin Ward
5350429870 FIX: Don't replace the wiki button if the user can't edit 2018-06-28 14:48:28 -04:00
Robin Ward
fd7bb8e656 FIX: Scope the cn to the subfolder 2018-06-28 11:03:36 -04:00
Maja Komel
4ca09599af Add prettier preferences-second-factor-backup.js.es6 2018-06-28 18:32:20 +10:00
Maja Komel
ec3e6a81a4 FEATURE: Second factor backup 2018-06-28 10:12:32 +02:00
Joffrey JAFFEUX
aafd883466 SECURITY: prevents XSS when showing tooltip 2018-06-27 14:53:31 +02:00
Joffrey JAFFEUX
b5b847f6d6 SECURITY: prevents XSS when showing tooltip 2018-06-27 14:35:47 +02:00
OsamaSayegh
d81f8ea378
fix prettier 2018-06-26 15:31:43 +03:00
OsamaSayegh
bfe0178270 FIX: use the correct notification levels titles for PMs 2018-06-26 14:01:52 +02:00
OsamaSayegh
a603660ba5 FIX: scroll to top when accessing admin dashboard 2018-06-26 12:19:58 +02:00
Joffrey JAFFEUX
eb9b99e519
FIX: makes select-kit match searches with accents (filter and content) 2018-06-26 12:19:14 +02:00
Guo Xiang Tan
49ffc1eb61 Revert "PERF: Send down gaps as the relevant posts load instead of front loading."
This reverts commit 4c3352528e.
2018-06-26 12:54:14 +08:00
Guo Xiang Tan
4c3352528e PERF: Send down gaps as the relevant posts load instead of front loading. 2018-06-26 12:49:06 +08:00
Guo Xiang Tan
0b6a2e9d1f Remove force summary mode for megatopics for now.
The logic is too hairy and we can't reliably determine
when to force summary mode. Work is underway to improve
perf for megatopics so this will not be required
eventually.
2018-06-26 12:49:06 +08:00
Maja Komel
24dfa1b657 Rename s3 vars, change condition when displaying s3 uploads 2018-06-25 17:16:01 +02:00
Kris
a0b799810b post-info glyph margin fix 2018-06-25 10:50:16 -04:00
Joffrey JAFFEUX
666386d4b7
FIX: allows more chars than a-z in select-kit 2018-06-25 12:52:20 +02:00
Guo Xiang Tan
d08b596e47 Remove unused function in post-stream.js.es6. 2018-06-25 17:23:34 +08:00
Leo McArdle
329c94a354 add user-preferences-emails-pref-email-settings outlet 2018-06-25 16:02:03 +10:00
Sam
85d97caa56 lint file 2018-06-25 15:35:45 +10:00
OsamaSayegh
d58ff44b04 Simplify to only support topics list for now 2018-06-25 15:02:22 +10:00
OsamaSayegh
b4a13a1afa UX: keyboard shortcuts (j/k) should work with /categories 2018-06-25 15:02:22 +10:00
Joffrey JAFFEUX
c722fc5164
FIX: makes sure category and tag drop headers have a title 2018-06-24 22:23:31 +02:00
Guo Xiang Tan
6597cc4cd0 Fix the build. 2018-06-22 13:42:43 +08:00
Guo Xiang Tan
cb622ead43 Make prettier happy. 2018-06-22 11:37:43 +08:00
Guo Xiang Tan
f69356e628 FIX: Users can't "show all posts" in forced summary topics. 2018-06-22 11:32:45 +08:00
Guo Xiang Tan
bad6a5142c PERF: Don't include entire post stream when we're loading more posts. 2018-06-22 10:49:03 +08:00
Guo Xiang Tan
657c8a013a UX: Don't display an empty participants section. 2018-06-22 10:16:43 +08:00
Guo Xiang Tan
4c6a0a4046 UX: Don't display participants count if it is zero.
This can happen for megatopics where we don't send
down the payload for participants count.
2018-06-22 08:32:20 +08:00
Joffrey JAFFEUX
fed86225c8
FEATURE: differentiate total and total for period on admin table report 2018-06-21 22:46:53 +02:00
Joffrey JAFFEUX
a41057aa6e
FEATURE: display report total value when showing report 2018-06-21 18:17:22 +02:00
Kris
5d0d56e474 removing unneeded line-height 2018-06-21 10:37:30 -04:00
Guo Xiang Tan
71908cd634 Make prettier happy. 2018-06-21 15:37:24 +08:00
Guo Xiang Tan
9a7a079f4d Force summary mode when user enters at the top of megalodoon topics. 2018-06-21 15:18:52 +08:00
Guo Xiang Tan
c5cc582549 FIX: Participants may not be in topic maps's attributes. 2018-06-21 10:23:55 +08:00
Joffrey JAFFEUX
50d11fd582
FIX: improves durability display check 2018-06-20 23:15:11 +02:00
Joffrey JAFFEUX
95d99de7b4
FIX: hides durability section in dashboard if backups are disabled 2018-06-20 22:26:37 +02:00
Robin Ward
45a2c94fb3 FIX: Margin on post-info should be present in mobile and desktop 2018-06-20 15:39:36 -04:00
Robin Ward
5290138e84 Support for a decorator within the user name 2018-06-20 15:26:37 -04:00
Robin Ward
02cb944fee FIX: Linting error 2018-06-20 13:44:03 -04:00
Robin Ward
e7fbcf4ba4
UX: Refactor topic metadata's many floats into flexbox (#6018) 2018-06-20 13:06:20 -04:00
Joffrey JAFFEUX
2f7960bd2a
DEV: updates prettier and displays linters/prettifiers version in CI 2018-06-20 18:34:49 +02:00
Joffrey JAFFEUX
8126b603e4
fix prettier 2018-06-20 18:26:43 +02:00
Robin Ward
fbc194c330 Don't use !important for wiki color. Allow themes to override it. 2018-06-20 10:47:27 -04:00
Robin Ward
bb11375590 FIX: Don't add undefined as a class name 2018-06-20 10:37:24 -04:00
Guo Xiang Tan
0365806b93 FIX: Properly display error when post action fails to create. 2018-06-20 21:20:23 +08:00
Guo Xiang Tan
9c925a66ff PERF: Don't display days ago on timeline for megatopics.
Analysis using `pg_stat_statements` showed this query
to be eating up a significant portion of CPU.
2018-06-20 16:25:54 +08:00
Joe
5fc4e9e324
FIX: nav-pill dropdown overlaps category-selector when both are open 2018-06-20 13:09:14 +08:00
Jeff Wong
ca4d08f9d9 Make linter happy 2018-06-19 18:07:41 -07:00
Jeff Wong
406c6d679a FIX: correct display for unlocking on tl0 2018-06-19 17:47:03 -07:00
Kris
b637b57e4f FIX: Alignment of user dropdown menu icons 2018-06-19 15:38:06 -04:00
Kris
82cb163ef3 formatting fix 2018-06-19 13:07:16 -04:00
Kris
0d81633da9 Replacing onebox loading gif with css spinner 2018-06-19 12:59:00 -04:00
Jeff Wong
7a1cefce78 Fix: let user fields respond when their labels are clicked 2018-06-18 11:15:22 -07:00
Joffrey JAFFEUX
913d97e780
fix prettier 2018-06-18 20:10:48 +02:00
Kris
ceb9226518 Giving post admin menu variable width in case of long translations 2018-06-18 13:02:50 -04:00
Joffrey JAFFEUX
3fc82bf200
FIX: adds a title to composer actions header 2018-06-18 19:01:37 +02:00
Joffrey JAFFEUX
f2dbe66367
FEATURE: adds a /admin/reports route to list all reports 2018-06-18 12:31:56 +02:00
Joffrey JAFFEUX
4b604b1e68
FIX: displays correct upload icon when only images are allowed 2018-06-18 11:16:34 +02:00
Joe
e8e8d540d3
FIX: desktop pin-topic modal not wide enough for date-picker 2018-06-16 15:19:08 +08:00
Arpit Jalan
a30165ab8d FIX: show time on activity column instead of random number 2018-06-16 07:12:43 +05:30
Joffrey JAFFEUX
60ff0e9b8c
missing prettified files 2018-06-15 18:42:20 +02:00
Joffrey JAFFEUX
03a7d532cf
DEV: introduces prettier for es6 files 2018-06-15 17:03:24 +02:00
Arpit Jalan
c7ee70941e FEATURE: show category page options on wizard 'homepage' step 2018-06-15 19:11:41 +05:30
Joe
4645cf6b28
FIX: remove unwanted space in user notification items 2018-06-15 15:44:51 +08:00
Kris
a8660b8be9 formatting build fix 2018-06-15 00:09:09 -04:00
OsamaSayegh
06777aa47d FIX: use the correct notification levels descriptions for PMs 2018-06-15 14:04:14 +10:00
Kris
872656fe52 Give admin list more horizontal space 2018-06-14 23:50:46 -04:00
Joffrey JAFFEUX
c82887a0f0 Revert "tests prettier trigger"
This reverts commit f74d86639f.
2018-06-14 15:46:03 +02:00
Joffrey JAFFEUX
f74d86639f
tests prettier trigger 2018-06-14 15:15:25 +02:00
Jeff Wong
160898acf3 Feature: add jump to post modal on mobile 2018-06-13 22:01:35 -07:00
Robin Ward
fd54c92a52 FEATURE: New site setting, whitelisted_link_domains
If provided, users who normally couldn't post links (say, due to a
low trust level), can post links to those specific hosts.
2018-06-13 16:11:22 -04:00
Neil Lalonde
debbb5be16 FIX: staff see the wrong message when changing another user's email address 2018-06-13 15:18:48 -04:00
Arpit Jalan
4107a02ae8
Merge pull request #5991 from jjaffeux/plugin-sharing-api
FEATURE: adds plugin sharing api
2018-06-13 17:24:03 +05:30
Joffrey JAFFEUX
eddcb07f03 FEATURE: adds plugin sharing api 2018-06-13 13:25:51 +02:00
Régis Hanol
f93ba5694e UX: show quote button at end of selection on Opera 2018-06-13 11:07:19 +02:00
Joffrey JAFFEUX
4e0c06a0b1
FIX: focusing input displayed after clicking on a link more reliable 2018-06-13 10:31:46 +02:00
Jeff Wong
0c2f590c64 Feature - allow user and group specific cards styling (#5989) 2018-06-13 14:08:03 +08:00
Jeff Wong
3d1ff8e0ad FIX: correct group membership on cards for admins 2018-06-12 14:57:26 -07:00
Joffrey JAFFEUX
5e4a1e812a UX: reworks dashboard problems section to be in line with new style 2018-06-12 11:48:53 -04:00
Arpit Jalan
57f5f7d755 FIX: do not show SSO external_email to moderators 2018-06-12 11:48:10 -04:00
Joe
7c9aa82625 FIX: adjust 2FA input width in mobile login form 2018-06-12 11:48:08 -04:00
Joe
1612c28718 FIX: adjust max-width of social login buttons for non-English locals 2018-06-12 11:48:07 -04:00
Joffrey JAFFEUX
2b3faa8d0b FIX: do not use number helper for charts Y value 2018-06-12 11:48:06 -04:00
Joffrey JAFFEUX
940c0f569f FIX: incorrect backup and update times on dashboard 2018-06-12 11:48:06 -04:00
Joffrey JAFFEUX
e66d5425e4 FIX: slightly safer rounding 2018-06-12 11:48:06 -04:00
Joffrey JAFFEUX
2f84d43bb2 FIX: makes format number round the value before using parseInt 2018-06-12 11:48:05 -04:00
Joe
134300001c FIX: user-fields layout in desktop create account form 2018-06-12 11:48:05 -04:00
Joe
cb9753267a FIX: user-fields layout in mobile create account form 2018-06-12 11:48:04 -04:00
Joffrey JAFFEUX
9334d36a23 FIX: sharing popup not showing on macos/chrome
Despite `navigator.share` being defined the call was failing with this error:

```
sharing DOMException: Internal error: could not connect to Web Share interface.
```
2018-06-12 11:48:03 -04:00
Robin Ward
abbb0ece4f FIX: Keyboard shortcuts didn't work on subfolders 2018-06-12 11:48:02 -04:00
Joe
08aca35b37 FIX: alignment for instructions on change email and 2FA fields 2018-06-12 11:48:02 -04:00
Régis Hanol
d8063d09d5 FIX: Add members button wasn't working on mobile for non-admin group owners 2018-06-12 15:05:22 +02:00
Joffrey JAFFEUX
3381a0a42a
UX: reworks dashboard problems section to be in line with new style 2018-06-12 12:47:03 +02:00
Arpit Jalan
59a8471308 FIX: do not show SSO external_email to moderators 2018-06-12 14:20:44 +05:30
Vinoth Kannan
72196ee951 Move the dashboard-problems block outside the condition 2018-06-12 12:01:41 +05:30
Guo Xiang Tan
c06824e9c2 FIX: Clients get stucked in readonly mode if messageBus fails. 2018-06-12 12:02:37 +08:00
kleinfreund
4ce1d230c7 Prefer throwing a new Error object instead of just a string expression 2018-06-12 12:56:22 +10:00
Shoshana Berleant
f48338df54 add plugin outlet create-account-after-password 2018-06-12 12:42:37 +10:00
Joffrey JAFFEUX
73731463a3
UX: makes sure close modal icon is aligned with title 2018-06-11 13:38:57 +02:00
Joe
2ec53a9628
FIX: adjust 2FA input width in mobile login form 2018-06-10 21:33:41 +08:00
Joe
5eb0066be9
FIX: adjust max-width of social login buttons for non-English locals 2018-06-09 14:14:59 +08:00
Joffrey JAFFEUX
174d392e5a
DEV: adds prettier (#5956)
Run `prettier --write "app/assets/stylesheets/**/*.scss" "plugins/**/*.scss"` after making sure you installed it with `yarn`

It's recommended to configure your editor to run prettier on file save.
2018-06-08 11:49:31 +02:00
Arpit Jalan
8bd4c11f53 FIX: do not show email disabled notice to staff when they can receive emails 2018-06-08 11:22:26 +05:30
Jeff Wong
b7d92061e2 FEATURE: add an option to create undismissable modals 2018-06-07 20:49:33 -07:00
Arpit Jalan
f9ab3848ed FEATURE: support disabling emails for non-staff users 2018-06-07 18:31:08 +05:30
Joffrey JAFFEUX
d556975cdc
FIX: do not use number helper for charts Y value 2018-06-07 14:56:49 +02:00
Joffrey JAFFEUX
74ced977be
FIX: incorrect backup and update times on dashboard 2018-06-07 11:18:17 +02:00
Joffrey JAFFEUX
1071aa21ab
FIX: slightly safer rounding 2018-06-07 10:59:17 +02:00
Joffrey JAFFEUX
ab089cd68b
FIX: makes format number round the value before using parseInt 2018-06-07 10:44:21 +02:00
Joe
c3ac32d991
FIX: user-fields layout in desktop create account form 2018-06-07 14:03:54 +08:00
Joe
56dbbfbd2a
FIX: user-fields layout in mobile create account form 2018-06-06 21:02:35 +08:00
Guo Xiang Tan
a83ab01264 REFACTOR: Remove extra param for group mentionable and messableable route. 2018-06-06 09:42:09 +08:00
Neil Lalonde
9ba9ff187c Add plugin outlet to admin plugins index 2018-06-05 17:47:30 -04:00
Rafael dos Santos Silva
74c33a5316
Merge pull request #5915 from jjaffeux/sharing-macos-chrome
FIX: sharing popup not showing on macos/chrome
2018-06-04 20:38:10 -03:00
Joffrey JAFFEUX
40b3efacaa FIX: sharing popup not showing on macos/chrome
Despite `navigator.share` being defined the call was failing with this error:

```
sharing DOMException: Internal error: could not connect to Web Share interface.
```
2018-06-05 01:18:57 +02:00
Arpit Jalan
46fc57222f FEATURE: improve handling of site setting secrets 2018-06-04 21:31:34 +05:30
Robin Ward
597ffd7e3f FIX: Keyboard shortcuts didn't work on subfolders 2018-06-01 14:38:09 -04:00
Kris
41999b9949 Limiting history modal height and width 2018-06-01 11:59:29 -04:00
Joe
560a950da9
FIX: alignment for instructions on change email and 2FA fields 2018-06-01 09:51:46 +08:00
Kris
0aa8d75be1 safety so pre blocks can't break modal width 2018-05-31 18:23:32 -04:00
Kris
12ebcc325b envelope missing on invite page, long pre lines making modals wide 2018-05-31 18:19:59 -04:00
Neil Lalonde
b675f5fa6b Merge master 2018-05-31 18:19:36 -04:00
Kris
ba7aff62db safety so pre blocks can't break modal width 2018-05-31 18:19:27 -04:00
Kris
6c15effca2 envelope missing on invite page, long pre lines making modals wide 2018-05-31 18:11:24 -04:00
Kris
3e9f1d5cf6 Few small modal fixes 2018-05-30 23:24:43 -04:00
Kris
57cef06192 incoming email modal width too narrow 2018-05-30 15:28:29 -04:00
Joffrey JAFFEUX
8128cbd7db
UX: adds subtitle support for modals 2018-05-30 17:14:00 +02:00
Joffrey JAFFEUX
43b1768987
UX: ceil dahsboard values 2018-05-30 16:32:43 +02:00
Arpit Jalan
704cca3de2 FIX: add proper search context for personal messages 2018-05-30 14:47:46 +05:30
Gerhard Schlager
864ada835b FEATURE: Add Bulgarian language 2018-05-29 21:07:17 +02:00
Kris
7483805f0c Increasing min-width of modals for larger screens 2018-05-29 13:13:35 -04:00
Joffrey JAFFEUX
ee8cda691d
FIX: simplifies and corrects new collection header tag/drop behaviour 2018-05-29 17:34:34 +02:00
Gerhard Schlager
ce687f334b UX: The "enable 2FA" string was hard to translate 2018-05-29 16:25:43 +02:00
Joffrey JAFFEUX
a8079ab679
FIX: show none/all on cat/tag drop only when needed 2018-05-29 16:08:31 +02:00
Joffrey JAFFEUX
597095f56f
UX: adds visual feedback when hovering info 2018-05-29 13:31:57 +02:00
Joffrey JAFFEUX
87edde3113
UX: improves dashboard UI for RTL locales 2018-05-29 10:22:31 +02:00
Arpit Jalan
277e216d25 FIX: link to pm tags when searching in personal messages 2018-05-29 12:32:20 +05:30
Joffrey JAFFEUX
16d0ab5654 Revert "UX: localizes titles in dashboard table reports"
This reverts commit 409c0ddf85.
2018-05-28 20:35:22 +02:00
Joffrey JAFFEUX
409c0ddf85
UX: localizes titles in dashboard table reports 2018-05-28 20:03:05 +02:00
Joffrey JAFFEUX
4b9c713581
FIX: avoids hidding mobile keyboard on each keystroke 2018-05-28 16:18:25 +02:00
Joffrey JAFFEUX
a585c19f2e
FIX: prevents collection header from going under rows 2018-05-28 15:47:07 +02:00
Joffrey JAFFEUX
478ccb6698
UX: lower no-change trend emphasis in charts 2018-05-28 13:55:25 +02:00
Joffrey JAFFEUX
82e5727287
UX: -2/+2% change in stats should be no-change in dashboard 2018-05-28 10:55:42 +02:00
Arpit Jalan
54338cfdcb FEATURE: add support for group_name parameter in /new-message route 2018-05-28 13:26:41 +05:30
Guo Xiang Tan
0b55416742 UX: Don't display all groups option if group directory is disabled.a
https://meta.discourse.org/t/all-groups-option-leads-to-access-denied-page/88464
2018-05-28 11:32:55 +08:00
Kris
4bd24e78fc padding fix, small phone fix 2018-05-26 01:12:33 -04:00
Régis Hanol
f988fa31aa FIX: ensure 'notifications_state' is up to date after creating a notification 2018-05-26 02:09:48 +02:00
Kris
cc0a5f4526 login fixes, auth message and alignment 2018-05-25 19:15:39 -04:00
Kris
6fc292fef5 reducing some specificty 2018-05-25 17:33:45 -04:00
Kris
3b2af4b91f Adjustments and fixes to updated login design 2018-05-25 16:44:44 -04:00
Robin Ward
4195c7c9ea FEATURE: Ability to clear a user's penalty history
You can do this manually if you want to allow them to reach TL3 without
their penalty history counting against them.
2018-05-25 12:54:22 -04:00
Robin Ward
c658fb6e31 Move some display logic out of model, upgrade old code patterns 2018-05-25 12:54:22 -04:00
Neil Lalonde
fdce116838 UX: mobile watched words UI in admin needs a way to see all word lists 2018-05-25 11:13:38 -04:00
Robin Ward
3c8369def6 The isSilenced and isSuspended aliases were useless
We already had `silenced` and `suspended` on the model with the same
effect!
2018-05-25 10:29:26 -04:00
Joe
4a2931f43d
FEATURE: New login / create account form layout 2018-05-25 20:16:38 +08:00
Joe
1948a9912c
FEATURE: Horizontal login / create accout layout 2018-05-25 20:15:34 +08:00
Joe
7f6f61cff2
FIX: Move tips into instructions div 2018-05-25 20:13:06 +08:00
Joe
1a9aeca93b
FIX: Move tips into instructions div 2018-05-25 20:12:08 +08:00
Joe
9e546e9ddc
FIX: Move tips into instructions div 2018-05-25 20:11:22 +08:00
Joffrey JAFFEUX
acc5e42066
removes logging 2018-05-25 12:12:28 +02:00
Joffrey JAFFEUX
e67ac93e6c
UX: makes table report trend icons as charts
This commit will also reverse icon orientation if higher_is_better = false
2018-05-25 12:09:30 +02:00
Guo Xiang Tan
569f63b8a2
Merge pull request #5825 from featheredtoast/extend-service-worker-cache
FIX: update cache times for service workers
2018-05-25 09:28:17 +08:00
Joffrey JAFFEUX
1be76d066c
FIX: forces boolean when content is only "true" && "false" 2018-05-24 23:41:39 +02:00
Robin Ward
a31a458a67 Trivially fix some odd whitespace, indentation 2018-05-24 12:29:55 -04:00
Kris
c5dbfe1886 liked icon should use d-icon 2018-05-24 11:08:13 -04:00
Joe
5ec896d163
FIX: align categories with menu panel links 2018-05-24 16:15:57 +08:00
Guo Xiang Tan
0e284e54f3
Merge pull request #5832 from featheredtoast/safari-no-serviceworkers
Fix: Safari failing to download backups from email links
2018-05-24 15:44:51 +08:00
Sam
4fef9e95d2 should not be a const 2018-05-24 15:42:00 +10:00
Sam
70179290f3 clean up callbacks during acceptance tests 2018-05-24 15:28:54 +10:00
Sam
4194886b62 correct failing test 2018-05-24 13:02:20 +10:00
Sam
ed08545d1f FEATURE: allow searching in title in advanced search
Add UI for matching in title only in advanced search options
2018-05-24 12:34:53 +10:00
Sam
11b544ef4e DEV: add support for custom post message callbacks
Allows for cleaner subscription to changes by plugins, polls will move to
it.
2018-05-24 12:34:53 +10:00
Jeff Wong
ebd966fbdb Feature: Add warning banner in email settings when mailing list mode enabled 2018-05-23 18:54:10 -07:00
Kris
15f7d06108 User metric badge alignment fix 2018-05-23 18:46:25 -04:00
Régis Hanol
232ed64865 UX: Add category & tags in mobile topic timeline 2018-05-23 23:05:34 +02:00
Kris
b519beb314 Turning admin dashboard user counts into badges 2018-05-23 16:55:57 -04:00
Joffrey JAFFEUX
a45d8a69f9
FIX: prevents &hellip from being displayed in title attribute 2018-05-23 19:04:26 +02:00
Joffrey JAFFEUX
7232a6e5a9
FIX: do not show composer actions if irrelevant 2018-05-23 18:25:58 +02:00
Joffrey JAFFEUX
dd76ba90b3
FIX: bbcode regex was greedy and preventing quotes 2018-05-23 11:55:02 +02:00
Kris
d19d491d65 Styling dashboard user tables 2018-05-22 15:33:06 -04:00
Joshua Rosenfeld
cd8d512429
Fix user tag preferences icon 2018-05-22 11:37:18 -04:00
Joffrey JAFFEUX
508b65b76a
UX: refactoring/refining tables of new dashboard 2018-05-22 16:47:23 +02:00
Joe
48c4f192e9
FIX: make the image field use its own help string 2018-05-22 16:06:25 +08:00
Kris
209a8d5e31 Reucing vertical spacing for github onebox pre 2018-05-21 23:29:36 -04:00
Kris
8b96d9a52d fixing group filter 2018-05-18 15:18:10 -04:00
Régis Hanol
e209faa6cf UX: ensure whitespace isn't removed when playing with quotes 2018-05-18 19:32:10 +02:00
Guo Xiang Tan
2fecb4b46e FIX: Client not setting TopicTimer#based_on_last_post.
https://meta.discourse.org/t/incorrect-message-key-in-temporarily-closed-topic/87773
2018-05-18 16:32:12 +08:00
OsamaSayegh
0800098f1a FIX: don't allow duplicate watched words (#5844)
We already have logic in place for server side, this'll just display a little message that says the word already exists
2018-05-18 10:11:08 +02:00
David Taylor
c168639be2 Add plugin outlet in admin theme list (#5837)
This will be used by discourse-theme-creator to add avatars next to each theme.
2018-05-18 10:09:21 +02:00
Guo Xiang Tan
416d19af27 FIX: Wrong target user displayed for user actions in activity stream.
https://meta.discourse.org/t/wrong-assigned-username-in-activity-list/73816
2018-05-18 11:28:13 +08:00
Joffrey JAFFEUX
4fd17abb76
linting 2018-05-17 23:44:38 +02:00
Kris
c1f13ce6a6 adding icons, updating style 2018-05-17 17:03:56 -04:00
Joffrey JAFFEUX
af548c23c4
new dashboard quality pass (code, tests and UI) 2018-05-17 22:44:33 +02:00
Régis Hanol
53f8f6095d FEATURE: staff action logs when creating/updating/deleting badges 2018-05-17 18:09:27 +02:00
Kris
7ab7696c94 fine-tuning dashboard alignment 2018-05-17 11:41:58 -04:00
Sam
560a16d864 correct resizing in firefox 2018-05-17 14:47:10 +10:00
Barry van Oudtshoorn
b6322a35f2 Fix super-wide tables in Firefox
In Firefox (tested in Fx61), the "activity metrics" and related tables can become stupendously wide. Adding a `max-width` resolves this issue.
2018-05-17 14:41:39 +10:00
Sam
cc7ecb8a06 FIX: hyperlinks did not work in category boxes 2018-05-17 12:02:24 +10:00
Sam
f6c35e5abc FIX: destroy picker if it was loaded 2018-05-17 11:18:04 +10:00
Sam
e0695b02d9 Stabalize order of tables in dashboard 2018-05-17 11:05:01 +10:00
Sam
c381d60471 Replace the "posts" line with message count 2018-05-17 10:26:30 +10:00
Sam
0b14e6b556 Resizing dashboard should not break graphs 2018-05-17 10:26:30 +10:00
Régis Hanol
a9ebde5111 FEATURE: new 'staged' users list for admins 2018-05-17 01:52:49 +02:00
Régis Hanol
bfbdee6a57 UX: show footer on groups pages 2018-05-17 01:34:44 +02:00
Régis Hanol
4f945abba2 FIX: infinite loading was broken on group activity posts/mentions pages 2018-05-17 01:34:13 +02:00
Régis Hanol
674318e127 UX: don't show 'auto delete' option for TL4 2018-05-17 00:42:48 +02:00
Kris
98f8f74f37 dashboard column alignment 2018-05-16 17:18:13 -04:00
Kris
91af7cf46c dashboard alignment fix 2018-05-16 16:04:22 -04:00
Kris
827ba2d3cf styling misc section of dashboard 2018-05-16 15:49:02 -04:00
Kris
4b0bf35cd7 dashboard style updates 2018-05-16 15:07:35 -04:00
Jeff Atwood
dcf97ca559
Merge pull request #5834 from riking/admin-users-groups
UX: Add link to /groups from Admin>Users
2018-05-16 10:24:21 -07:00
Régis Hanol
938934f5e9 FIX: keep '<kbd>' formatting when quoting posts 2018-05-16 17:40:45 +02:00
Régis Hanol
d5ae0a92ef FIX: puts the datepicker on it's own line on mobile device in the feature topic modal 2018-05-16 17:33:55 +02:00
Joffrey JAFFEUX
9554d9c56a
UX: tooltips and improvements to new dashboard
- tooltips
- revert chart title UI
- reduce period chooser font-size
- localize dates of data points
- fix a bug where multiple reports were loaded at the same time
- fix a bug where % was not showing anymore
- remove spacing at the top
- remove loadingTitle feature (Loading...%report name%) incompatible with new hijack design
2018-05-16 16:45:21 +02:00
Joe Buhlig
3cd4c82c49 Allow parameters for group and username filters on directory (#5815) 2018-05-16 16:20:17 +02:00
Régis Hanol
489e7f220d UX: show a message when more than 30 site settings matches the current filter
UX: show the counts when displaying only overridden settings
UX: show 30+ count when more than 30 site settings matches the current filter
2018-05-16 15:37:40 +02:00
Régis Hanol
5e97a9bfb7 FIX: tags in a 'visible by everyone but usable only by staff' group weren't visible by everyone 2018-05-16 09:48:19 +02:00
Sam
6ee0eae335 =handle chart loading concurrency issues 2018-05-16 17:35:03 +10:00
Sam
f9d2c69bbe correct it so we always load Chart just before creating it 2018-05-16 16:44:35 +10:00
Sam
21e0b7c818 avoid async report pattern and replace with simpler hijack 2018-05-16 16:05:03 +10:00
Kris
7dc192a081 improving column alignment 2018-05-16 00:23:02 -04:00
Kris
85425348c5 reducing margin 2018-05-15 22:32:19 -04:00
Sam
5d4502f18b Split off topics and posts cause they have very different scales 2018-05-16 11:33:22 +10:00
Kris
693650c3a2 Scaling down H-tag size in posts 2018-05-15 21:04:51 -04:00
Kris
b850b2d0d2 Missing title for latest version 2018-05-15 20:58:00 -04:00
Kris
58eb45a560 Improving version section of dashboard 2018-05-15 20:19:31 -04:00
Jeff Wong
82a95164e9 Fix: Safari failing to download backups from email links
disable service workers on safari

bypass serviceworker network if this is a URL with a token param
2018-05-15 14:38:31 -07:00
Joshua Rosenfeld
e28a443fc1
Fix What's New Link 2018-05-15 17:04:13 -04:00
Joffrey JAFFEUX
9947c38e1c
UX: support for multiple datasets in one chart 2018-05-15 20:12:03 +02:00
Arpit Jalan
51ee31b3eb FIX: changing tag group privacy setting was not consistent (#5818) 2018-05-15 18:06:43 +02:00
Joe
02e0426de6
FIX: search icon is rendered outside of tag-selector filter-input
Make the selectors from this sheet match the ones from selectors from the select-kit sheet... different states for the filter-input were causing it to expand outside of the tag-selector and push the search icon.
2018-05-15 15:28:27 +08:00
Sam
7dd68e64d9 FEATURE: allow plugins to modify class statics
Adds `modifyClassStatic` to plugin api which can be used to amend static
methods on a class
2018-05-15 16:01:51 +10:00
Sam
193b6d5651 UX: improve new dashboard
- top referred topics
- limit search logs to 8 results
2018-05-15 15:08:36 +10:00
Sam
eb33f6e9b9 correct daily engaged users to look at average 2018-05-15 10:17:17 +10:00
Jeff Wong
e4a33cbc0a FIX: update cache times for service workers
Add a last modified time.

Register newer service workers and claim clients more quickly.
2018-05-14 12:29:24 -07:00
Régis Hanol
e9abdaebbe UX: show an enveloppe icon when a badge is used in messages
- the badge count now includes messages
- only show the message badges to admins
2018-05-14 19:02:00 +02:00
Kris
1e132b4599 Checkbox fix for iOS 2018-05-14 11:11:16 -04:00
Joffrey JAFFEUX
94b1a8c841
UX: disables all time col in activity metrics new dashboard
This commit also makes it work for old dashboard.
2018-05-14 16:04:54 +02:00
Joffrey JAFFEUX
ba0cec2091
UX: minor fixes to new dashboard UI
- adds a link to search log
- display a text if log search queries is disabled
- adds link to trust level and user types
- adds a description for eeach report when browsing a report directly
2018-05-14 14:23:51 +02:00
Sam
cb9baaade9 correct localization for dashboard periods
previously would fail for non roman numerals
2018-05-14 16:31:50 +10:00
Sam
6332d5040d UX: switch dashboard to be the new dashboard
Also:
- add pageviews
- add problems and version sections
2018-05-14 13:07:59 +10:00
Sam
5f54b005a1 UX: remove ? from new dashboard
Link to actual report
2018-05-14 11:33:36 +10:00
Sam
9d97e1244e correct it so when we have no dates we still return graphs 2018-05-14 11:12:52 +10:00
Régis Hanol
be6404d651 FIX: redirect users after signing up with a social login when using SSO provider 2018-05-13 16:03:11 +02:00
Régis Hanol
81f4da7dd2 FIX: remove unneeded escape when building a Quote 2018-05-12 01:16:05 +02:00
Kris
b10c684459 border/alignment fix 2018-05-11 10:23:31 -04:00
Alexis Duran
1404294a12 Fix issue for custom image badges urls (#5814) 2018-05-11 10:29:24 +02:00
Sam
e92f9568a4 correct typo 2018-05-11 16:25:41 +10:00
Guo Xiang Tan
bed039aebf Remove incorrect added code in d31417d3af (diff-655c787458e67d84dc1178f5d2b674f1) 2018-05-11 13:19:20 +08:00
Guo Xiang Tan
a0fc5de5c4 Revert "Static update for htmlHelper method within bound-avatar helper"
This reverts commit ba383027e8.
2018-05-11 13:19:20 +08:00
Guo Xiang Tan
1e4abc63d0
Merge pull request #5813 from duranmla/ad/bound-avatar-typo
Static update for htmlHelper method within bound-avatar helper
2018-05-11 12:59:00 +08:00
Sam
8a783412b7 UX: improvements to new dashboard
- remove inactive user report and replace with posts
- clean up internals so grouping by week happens on client
- when switching periods old report was not destroyed leading to bugs
- calculate trend based on previous interval ... not previous 30 days
- show percentages for mau/dau
- be more careful about utc date usage
- show uniqu and click through rate on search panel
- publish key of report with report so we only load the correct one
- subscribe earlier in channel in case of concurrency issues
2018-05-11 13:30:32 +10:00
Alexis Duran
ba383027e8
Static update for htmlHelper method within bound-avatar helper 2018-05-10 19:15:34 -04:00
Kris
5c7a235c03 minor mobile nav fix 2018-05-10 00:17:15 -04:00
Kris
941b309616 dashboard style adjustments 2018-05-09 21:33:53 -04:00
Guo Xiang Tan
c720bf32c3 UX: Add proper titles to topic navigation links in hamburger menu.
https://meta.discourse.org/t/what-is-the-difference-between-latest-and-new/47809/9?u=tgxworld
2018-05-10 09:29:02 +08:00
Kris
a2e2b83415 fix for tag notification dropdown 2018-05-09 19:03:02 -04:00
Kris
7d66e11771
UX: Mobile Nav Cleanup (#5812) 2018-05-09 17:48:34 -04:00
Régis Hanol
deaf3682e9 FIX: clicking a group mention on mobile was 404ing
(cc @featheredtoast)
2018-05-09 17:27:59 +02:00
Régis Hanol
3483c7bc58 FIX: supports user/group mentions and category hashtags when quoting posts 2018-05-09 12:42:12 +02:00
Régis Hanol
858ac6b61e FIX: prevent theme uploads from overwriting existing variables 2018-05-09 11:54:43 +02:00
Sam
c475905387 Improvements to new community dashboard
- Limit dashboard to yearly,quarterly,monthly,weekly
- Always prefer UTC full days for reporting
2018-05-09 18:06:13 +10:00
Guo Xiang Tan
36d9f7f814 Revert "UX: Don't set width to auto for select kit combo box."
This reverts commit c7b526b9e0.
2018-05-09 14:28:45 +08:00
Guo Xiang Tan
c7b526b9e0 UX: Don't set width to auto for select kit combo box. 2018-05-09 14:21:47 +08:00
Kris
5fc2dd8b8d group name alignment in user-stream 2018-05-08 21:35:53 -04:00
Robin Ward
2c4da30f1b UX: The first sentence in the line had a period but the second did not. 2018-05-08 16:36:36 -04:00
Kris
903163a65c Updating group usercard layout 2018-05-08 15:38:55 -04:00
Kris
48b5af28e5 remove duplicate button class 2018-05-08 12:27:25 -04:00
Kris
edb97edf5f moving user filter for groups 2018-05-08 10:09:12 -04:00
Arpit Jalan
3a6e137e70 FIX: add context for deactivated user logs 2018-05-08 08:18:04 +05:30
Guo Xiang Tan
8cf0f51eb2 UX: Display site settings shortcut for poll and discourse-nginx-performance-report.
https://meta.discourse.org/t/improving-admin-plugins/84585/29?u=tgxworld
2018-05-08 10:34:32 +08:00
Jeff Wong
9738025bb2 Feature: display description for group cards 2018-05-07 10:45:21 -07:00
Guo Xiang Tan
5e45b682a2 Fix JS tests take 2. 2018-05-07 18:34:45 +08:00
Guo Xiang Tan
0042d94f76 Fix broken JS specs. 2018-05-07 18:21:48 +08:00
Guo Xiang Tan
4f4c576311 FIX: Retrigger search scoped to a topic if topic changes.
https://meta.discourse.org/t/highlight-the-search-results/10322/12?u=tgxworld
2018-05-07 17:18:30 +08:00
Guo Xiang Tan
5a57a454fe Revert "FIX: Only show topic timer to staff"
This reverts commit e3e6fd6ea0.
2018-05-07 15:59:16 +08:00
Guo Xiang Tan
32147d4ff9 FIX: Search term scoped to topic should be highlighted in widget dom era.
https://meta.discourse.org/t/highlight-the-search-results/10322/4?u=tgxworld
2018-05-07 15:17:34 +08:00
Guo Xiang Tan
b618ffb715 Remove file that is no longer used. 2018-05-07 12:07:50 +08:00
Sam
911f898a23 UX: improved performance of emoji dialog
Shift all emoji loading into an animation frame to chrome stops deferring
timers
2018-05-07 11:25:46 +10:00
Sam
9c6cf9eb14 FIX: decorate user stream should include element
In the past we would call the decorate function with no element
this made the extension on user stream pointless
2018-05-07 09:50:56 +10:00
Bianca Nenciu
71f74c0b28 Improved email validation in user search module. (#5804) 2018-05-06 11:39:59 +02:00
Régis Hanol
71f5215711 FEATURE: keep formatting when quoting 2018-05-05 10:51:54 +02:00
Jeff Wong
008480127f Feature: Add plugin outlet for desktop (live) notifications area 2018-05-04 18:59:36 -07:00
Jeff Wong
c450b70bcc fix: revert to es5 function syntax 2018-05-04 15:42:48 -07:00
Jeff Wong
91b31860a1
Feature: Push notifications for Android (#5792)
* Feature: Push notifications for Android

Notification config for desktop and mobile are merged.

Desktop notifications stay as they are for desktop views.

If mobile mode, push notifications are enabled.

Added push notification subscriptions in their own table, rather than through
custom fields.

Notification banner prompts appear for both mobile and desktop when enabled.
2018-05-04 15:31:48 -07:00
Robin Ward
84cc52d8fc FIX: Show a nicer message when there aren't any flagged topics. 2018-05-04 10:24:18 -04:00
Kris
15268a47b0 Prevent group-member-info from wrapping 2018-05-03 21:00:24 -04:00
Neil Lalonde
a0447b47e0 UX: when deleting a user, show a modal indicating that the delete is happening. User hijack so requests don't time out. 2018-05-03 16:18:19 -04:00
Kris
2288389a93 Using user page layout/styles for groups where possible 2018-05-03 15:13:59 -04:00
Kris
f69c289fcf select-kit consistency fix 2018-05-03 11:08:47 -04:00