Commit Graph

14652 Commits

Author SHA1 Message Date
Robin Ward
db929e58fc FIX: Don't allow staff to approve users with unverified emails 2017-09-04 12:55:39 -04:00
Robin Ward
be1cce503c FIX: Don't bind events in defaultState 2017-09-04 11:48:36 -04:00
Joffrey JAFFEUX
afe6f46b03 merges after_save 2017-09-04 13:40:11 +02:00
Joffrey JAFFEUX
caedefd675 FIX: correctly resets user_themes template
This commit adds tests for this behaviour and also adds support for
reseting cache when updating a theme name and destroying a theme.
2017-09-04 13:27:58 +02:00
Arpit Jalan
3b7128102c FIX: disable follow in topic summary links
https://meta.discourse.org/t/links-in-popular-links-appear-without-nofollow/68974
2017-09-04 16:21:12 +05:30
Guo Xiang Tan
5c1143cd55 Add missing test case for PostController#timings. 2017-09-04 16:36:02 +08:00
Arpit Jalan
ebbdd4fe0f FIX: error when rebaking posts 2017-09-02 22:22:29 +05:30
Robin Ward
dfe347fb1d FIX: Wizard tests don't need Discourse defined 2017-09-01 12:26:42 -04:00
Robin Ward
c6ff387ce9 Use more semantic names for various tracking icons
This way they can be replaced by plugins without conflicting with other
icons. For example `circle` is used in some places that doesn't
represent `tracking`.
2017-09-01 12:14:58 -04:00
Sam Saffron
46ebd0ee40 correct spec and allow for zero allowed iframes 2017-09-01 12:08:55 -04:00
Robin Ward
cb56dcdf2e FIX: Use proper iconNode when compiling virtual dom templates 2017-09-01 11:20:33 -04:00
Vinoth Kannan
0fb7831749 FEATURE: Add placeholders to broken and large image files (#5113) 2017-09-01 10:26:13 -04:00
Sam Saffron
e283e6aea0 FEATURE: allowed_iframes site setting for allowing iframes
This allows you to whitelist custom iframes if needed in posts
2017-09-01 10:15:44 -04:00
minusfive
b3b6eeff97 Ensure css applies to .user-main > .about icons regardless of tag 2017-09-01 06:32:27 -07:00
minusfive
611d62e4a5 Cleanup, deduplicate, debug user css, separated user-info component css 2017-09-01 06:32:27 -07:00
Robin Ward
dffb1fc4ee FEATURE: Use Glimmer compiler for widget templates
Widgets can now specify a template which is precompiled using Glimmer's
AST and then converted into our virtual dom code.

Example:

```javascript
createWidget('post-link-arrow', {
  template: hbs`
    {{#if attrs.above}}
      <a class="post-info arrow" title={{i18n "topic.jump_reply_up"}}>
        {{fa-icon "arrow-up"}}
      </a>
    {{else}}
      <a class="post-info arrow" title={{i18n "topic.jump_reply_down"}}>
        {{fa-icon "arrow-down"}}
      </a>
    {{/if}}
  `,

  click() {
    DiscourseURL.routeTo(this.attrs.shareUrl);
  }
});
```
2017-09-01 09:28:16 -04:00
Arpit Jalan
66f2925348 SECURITY: do not include links from whispers in topic summary map
https://meta.discourse.org/t/staff-whispers-links-in-whispers-showing-up-publicly-in-topics-summary/69134?u=techapj
2017-08-31 23:44:54 +05:30
Robin Ward
ef0f346eec Add custom style for header buttons 2017-08-31 12:10:54 -04:00
Joffrey JAFFEUX
56468582ee FIX: visual regressions on title-wrapper 2017-08-31 15:08:09 +02:00
Joffrey JAFFEUX
0957ac9ee2 FIX: minor css tweaks to title-wrapper 2017-08-31 11:16:08 +02:00
Joffrey JAFFEUX
84e992363c FIX: use maximum z-index for select-box when expanded 2017-08-31 00:55:05 +02:00
Robin Ward
75b2aa2edd Better support for inline modals 2017-08-30 17:52:49 -04:00
Robin Ward
a48abc6556 Tweaks for better modal distinction between fixed/inline 2017-08-30 17:38:49 -04:00
Robin Ward
6361618188 fixed-modal is a better name 2017-08-30 15:52:29 -04:00
Robin Ward
3d95bac3fb Migrate away from #discourse-modal to .d-modal 2017-08-30 15:29:51 -04:00
Robin Ward
8fcd5af5b1 UX: Use a template for the d-modal component 2017-08-30 15:20:49 -04:00
Robin Ward
64bb0f9f05 Add a class to target the sugested topics message 2017-08-30 13:50:39 -04:00
Robin Ward
3aed047b7e UX: Add another div to aid in styling via flexbox 2017-08-30 13:43:56 -04:00
minusfive
5fd4970602 Cleanup nav-stacked .active state styles, remove unnecessary nesting 2017-08-30 09:14:56 -07:00
minusfive
8781c6bfcb Removed unnecessary outer link-tos from admin/settings|watched-words navs 2017-08-30 09:14:56 -07:00
Joffrey JAFFEUX
746c5927e1 Replaces remaining {{category-chooser}} by {{category-select-box}}
To achieve replacement, this commit also adds support for:
- clearSelectionLabel which will allows to unselect any chosen category
- select-box inside a modal
- fixes minor css positioning issues

Note: {{category-chooser}} will be removed in the next weeks.
2017-08-30 17:04:17 +02:00
Guo Xiang Tan
0a53c589c4 Fix linting. 2017-08-30 15:36:45 +08:00
Sam
9a861c1b43 Correct previous commit
Selector was way too wide
2017-08-29 16:51:57 -04:00
Sam
5cdb486332 UX: large topic creation area on mobile
This refines the iOS hack and allows for height 100%
on the composer

Also removes annoying box shadows
2017-08-29 15:45:02 -04:00
Sam
c705159d22 Remove email column from user table 2017-08-29 11:50:56 -04:00
Sam
b3fd091379 annotate stuff 2017-08-29 10:48:22 -04:00
Joffrey JAFFEUX
98c6c7e35a FIX: css regression on select-box 2017-08-29 15:52:38 +02:00
Joffrey JAFFEUX
cb4f690937 uses new select-box for quick topic edit 2017-08-29 15:15:17 +02:00
Joffrey JAFFEUX
dcc5f93344 FIX: disable highlighting when no value set on select-box 2017-08-29 14:32:23 +02:00
Joffrey JAFFEUX
21c4e38eec clean select-box css 2017-08-29 14:31:03 +02:00
Joffrey JAFFEUX
f101fec19c FIX: improves uncategorized support for category-select-box 2017-08-29 12:48:26 +02:00
Joffrey JAFFEUX
861dbe3b51 select-box refactoring
- more flexibility (allows custom title)
- less re-render
- more robustness
2017-08-29 12:25:54 +02:00
Joshua Rosenfeld
e3e6fd6ea0 FIX: Only show topic timer to staff 2017-08-28 23:49:30 -04:00
Sam
50203794e6 FIX: staged users should get emails on must_approve_users sites 2017-08-28 17:32:07 -04:00
Sam
41e7bdff38 FIX: don't refresh notifications in a tight loop 2017-08-28 16:52:00 -04:00
Sam
9f0f086b3e FEATURE: allow API to mark accounts as approved on creation 2017-08-28 15:36:46 -04:00
Bianca Nenciu
fa69e0dd77 Improved metadata for tags. (#5067) 2017-08-28 13:11:34 -04:00
Leo McArdle
fd2cd63b08 FIX: make /new-topic redirect survive full screen login (#5105) 2017-08-28 12:40:31 -04:00
Bianca Nenciu
6bc74ceb50 Split alias levels in mentionable and messageable levels. (#5065)
* Split alias levels in mentionable and messageable levels.

* Fixed some tests.

* Set messageable level to everyone by default.

* By defaults, groups are not mentionable or messageable.

* Made staff groups messageable by the system.
2017-08-28 12:32:08 -04:00
David Taylor
ce2250d7aa Add avatar-flair plugin outlet for user card (#5104) 2017-08-28 12:26:42 -04:00
minusfive
d70ecf1c53 Simplify user-nav styles to facilitate theming 2017-08-28 09:24:41 -07:00
Bianca Nenciu
bb3a5910d7 Support for sending PMs to email addresses (#4988)
* Added support for sending PMs to email addresses.

* Made changes after review.

* Added settings validator.

* Fixed tests.
2017-08-28 12:07:30 -04:00
Joffrey JAFFEUX
b83c0747d9 FIX: select-box improvments
- more tests for category-select-box
- allows to clear selection
- fix positioning on safari
- focus on click
- do not display uncategorized if not allowed in settings
- fix component state impacting other specs
- better texts
- higher category-select-box on mobile
2017-08-28 14:34:04 +02:00
Arpit Jalan
be972912cb FIX: do not show full name field when accepting invite if full names are disabled
https://meta.discourse.org/t/require-password-for-trusted-user-invites/13750/58?u=techapj
2017-08-27 12:15:32 +05:30
Robin Ward
a77ede05e2 FIX: Don't re-render if you find composer messages after destroying 2017-08-26 00:41:24 -04:00
Robin Ward
b93f491035 Add option for button type under posts 2017-08-26 00:00:52 -04:00
Robin Ward
27b10a709b Revert "FIX: Un-revert the btn class added to the topic post menu"
This reverts commit aa07d23caa.
2017-08-25 23:50:00 -04:00
Joffrey JAFFEUX
5d12db1fb5 FIX: html not showing in select-box header 2017-08-26 02:44:36 +02:00
Joffrey JAFFEUX
918f5045b4 FEATURE: display subcategories when filtering on parent name 2017-08-26 02:01:34 +02:00
Joffrey JAFFEUX
2efb39289c FIX: select-box fragile specs 2017-08-26 01:24:17 +02:00
Robin Ward
aa07d23caa FIX: Un-revert the btn class added to the topic post menu 2017-08-25 17:08:34 -04:00
Joffrey JAFFEUX
296ea6c7b1 FIX: castInteger on initial value 2017-08-25 22:41:35 +02:00
Robin Ward
7f16323ba4 REVERT: btn class looked ugly, let's revert for now 2017-08-25 16:06:56 -04:00
Neil Lalonde
398604ac71 FEATURE: set purge_unactivated_users_grace_period_days to 0 to disable purging unactivated users 2017-08-25 15:20:06 -04:00
minusfive
d911d3ff6e Namespaced Sass color brightness function to avoid conflict w/CSS filter 2017-08-25 11:10:11 -07:00
Joffrey JAFFEUX
14f06c2740 select-box minor fixes 2017-08-25 19:56:57 +02:00
Robin Ward
075cc1a8bb FIX: some button classes 2017-08-25 13:44:28 -04:00
Robin Ward
493fd707f8 UX: Add missing btn class to flat-button 2017-08-25 13:16:18 -04:00
Robin Ward
4e9c4f0768 Add option to collapse buttons in post menu 2017-08-25 13:11:53 -04:00
Robin Ward
324b02a830 Add option to move the poster name in with the avatar 2017-08-25 13:11:53 -04:00
Neil Lalonde
ea969d1ed0 FEATURE: add Thai language 2017-08-25 12:33:09 -04:00
Neil Lalonde
2c56f8df7c FEATURE: show tags in search results 2017-08-25 11:52:59 -04:00
minusfive
cdcc5d6174 Extracted/DRYed user-stream-item component CSS from user.css into own files
- Renamed 'stream-item' component to 'user-stream-item'
- Replaced generic 'item' class with clearer 'user-stream-item' class
- Retained 'item' class for backward compatibility, marked as 'DEPRECATED'
- Extracted CSS pertaining 'user-stream-item' component to component CSS files
- Removed unnecessary duplication from 'user-stream-item' CSS
- Removed unnecessary nesting from 'user-stream-item' CSS
2017-08-25 08:38:27 -07:00
Joffrey JAFFEUX
bbd428fb94 FIX: more consistent filter from keyboard on select-box 2017-08-25 01:48:32 +02:00
minusfive
8a06d3d312 Fix + remove unnecessary indentation, dead code, cleanup user.css 2017-08-24 14:46:01 -07:00
Jeff Atwood
c8ce3c6dee make composer edu panel close button more visible 2017-08-24 13:49:33 -07:00
minusfive
512858c2e7 Removed no-longer-used styles from group.scss 2017-08-24 10:07:36 -07:00
minusfive
c01dc26ea6 Add no-content message for user/activity/replies, fix no-content display 2017-08-24 09:51:39 -07:00
Joffrey JAFFEUX
f3388043db FIX: avoids select-box being over composer popup 2017-08-24 18:49:35 +02:00
minusfive
cdf0fefe8c Removed icons + no-glyph classes from /user sub-navs, normalized indentation 2017-08-24 09:41:27 -07:00
Joffrey JAFFEUX
39a89419b6 uses select-box for theme selection on user profile 2017-08-24 18:33:01 +02:00
Joffrey JAFFEUX
d05df4a337 FIX: better headerText handling on select-box 2017-08-24 18:31:33 +02:00
Robin Ward
a6251f717b Convert user card buttons to {{d-button}} components 2017-08-24 12:23:08 -04:00
Joffrey JAFFEUX
9c446fcb4d FIX: modify select-box orientation when composer resizes 2017-08-24 17:14:55 +02:00
Joffrey JAFFEUX
21d6c7f6b3 FIX: duplicated categories in select-box 2017-08-24 16:54:10 +02:00
Joffrey JAFFEUX
d52048ad34 Revert "Revert "FEATURE: improves select-box to support category selection on new topic""
This reverts commit 1d90f6016a.
2017-08-24 16:04:47 +02:00
Guo Xiang Tan
0531ef2e20 Fix calling exists? on Arrays. 2017-08-24 09:56:07 +09:00
Guo Xiang Tan
4b4169c8fd Merge pull request #5053 from fantasticfears/session-controller
Spec for local auth check
2017-08-24 09:42:54 +09:00
Guo Xiang Tan
91d3929f52 Merge pull request #5078 from lelelelemon/master
change count>0 to exists
2017-08-24 09:24:42 +09:00
Guo Xiang Tan
027b999828 Merge pull request #5071 from LeoMcA/remove_duplicated_without_posts
FIX: removed the duplicated staged users without posts
2017-08-24 09:23:36 +09:00
junwen yang
8124f26a6e change count>0 to exists 2017-08-23 22:54:51 +00:00
minusfive
38eef177d4 Cleanup & debug .nav-stacked styles 2017-08-23 13:58:41 -07:00
Robin Ward
950c9e50ac Add wrapper div to aid in styling 2017-08-23 14:47:09 -04:00
Sam
f766ea4257 Correct short url decoding for sha1s leading with zero
This was picked up cause we had a flaky test!
2017-08-23 11:08:18 -04:00
Joffrey JAFFEUX
1d90f6016a Revert "FEATURE: improves select-box to support category selection on new topic"
This reverts commit 7b4e302677.
2017-08-23 16:33:03 +02:00
Leo McArdle
3986367f3f update pr based on review 2017-08-23 14:55:34 +01:00
Joffrey JAFFEUX
7b4e302677 FEATURE: improves select-box to support category selection on new topic 2017-08-23 15:08:19 +02:00
Sam
8dfb1be4d1 FEATURE: unlisted *only* means not listed in topic lists
Remove security by obscurity feature that tries for exact slug match

If you need to hide a topic from users either move to a secure category
or convert to a PM
2017-08-22 17:53:54 -04:00
Neil Lalonde
224796a7d4 FIX: wrongs counts on tags with deleted topics 2017-08-22 16:55:05 -04:00
Sam
d7a2584c6e FEATURE: image uploads now have short urls
Shorten all image uploads to use short urls, this is the client
side implementation.
2017-08-22 16:40:08 -04:00
Robin Ward
605653a369 Add classes to small action buttons 2017-08-22 14:49:14 -04:00
Robin Ward
cbe17be40e Remove unused small action component 2017-08-22 14:39:57 -04:00
Robin Ward
7e8766cee8 UX: Move buttons into the nav section of the topic map 2017-08-22 14:20:18 -04:00
Joffrey JAFFEUX
a3e9819158 FEATURE: allows to disable automaticPositioning of emoji-picker (#5074)
Usage:
{{emoji-picker automaticPositioning=false}}
2017-08-22 19:41:02 +02:00
Sam
ce8030716f FIX: broken badge show page 2017-08-22 13:28:02 -04:00
Sam
bcf7dc38c2 FEATURE: server side support for upload:// markdown
This allows uploads to be specified using short sha1 hash instead of full
URL

Client side change is pending
2017-08-22 11:46:23 -04:00
Leo McArdle
be1df3ba75 FIX: transfer posts by duplicated staged users to original 2017-08-22 09:58:51 +01:00
Arpit Jalan
b00747fd49 FIX: do not create topic link reflection for unlisted topics 2017-08-22 14:28:01 +05:30
Guo Xiang Tan
29a9e0c4d2 Fix the build. 2017-08-22 15:52:24 +09:00
Guo Xiang Tan
bc3e43b496 FIX: Topic timers being incorrectly trashed!.
https://meta.discourse.org/t/temporary-timed-closure-of-topic-not-re-opening-topic/67877
2017-08-22 15:23:09 +09:00
Guo Xiang Tan
87994a86ce FIX: Don't set topic timer for close topics when changing category.
https://meta.discourse.org/t/moving-a-topic-after-closure-reopens-topic/67659/4
2017-08-22 12:54:34 +09:00
Robin Ward
3a3dca32a3 FIX: Move before post count outlet inside the link 2017-08-21 20:40:35 -04:00
Robin Ward
8bd7cfedfd Convert suggested topics to a component 2017-08-21 17:03:38 -04:00
Sam
2f0c6c99e0 FIX: ip lookup not working
Also add a powered by line so it is clear this makes an external service call
2017-08-21 14:18:49 -04:00
Joffrey JAFFEUX
c264348fcb FIX: avoids user-selector having no width 2017-08-21 18:55:44 +02:00
Guo Xiang Tan
93fe76fc02 Make eslint happy. 2017-08-21 21:56:22 +09:00
Kyle Zhao
1a32de722b last attempt at fixing user page layout
drop the width setting on the right column *completely* so it can
 adjust on it own

https://meta.discourse.org/t/long-words-not-wrapping-in-user-activity-page/68181
2017-08-18 17:28:50 -04:00
Sam
5c80d4bcdd UX: move close button to bottom and add esc hint. 2017-08-18 15:40:34 -04:00
Bianca Nenciu
e976b98efc Show the select badge button only once. (#5064) 2017-08-18 14:00:20 -04:00
minusfive
77469cfb88 Unnest top level selectors from body 2017-08-18 13:00:26 -04:00
Robin Ward
286bc7db33 Revert "fixes overflowing div width on user activity page"
This reverts commit 375153ce57.
2017-08-18 10:43:42 -04:00
Jeff Atwood
d84f105288 Merge pull request #5060 from xrav3nz/fix-user-activity-word-wrap-take-2
fixes overflowing div width on user activity page
2017-08-17 22:48:52 -07:00
Kyle Zhao
375153ce57 fixes overflowing div width on user activity page
detailed explanation: https://meta.discourse.org/t/long-words-not-wrapping-in-user-activity-page/68181/8?u=xrav3nz
2017-08-18 01:01:09 -04:00
Bianca Nenciu
ac8bc04ad7 Set user title from the badge view (#5049)
* title info under notification

* create badge-title as component

* display available titles, close button

* remove visual feedback when grant new badge

* Made changes after review.

* Some minor fixes.
2017-08-17 16:32:37 -04:00
Sam
c2a6616035 Correct erratic spec failure 2017-08-17 15:26:31 -04:00
Sam
0c4527323e FIX: queues posts broken for multiple posts 2017-08-17 14:47:09 -04:00
Robin Ward
4b0dcd64eb FIX: Footer message was missing the class 2017-08-17 14:40:14 -04:00
Sam
9246bc3400 support up button from first result 2017-08-17 13:32:30 -04:00
Sam
889b99552a FEATURE: allow ctrl+shift+s to open search 2017-08-17 12:57:08 -04:00
Sam
dc4d5677eb FEATURE: use a when search result is focused to add to composer 2017-08-17 12:39:43 -04:00
Jen
d29fc781fb trigger for other backup choices 2017-08-17 10:34:24 -04:00
Jen
b5823a3b03 add event for other backup choices 2017-08-17 10:34:24 -04:00
Mudasir Raza
84c83afd35 Allow optional import_mode param for posts in api (#4952) 2017-08-17 07:53:04 -04:00
Kyle Zhao
43e2c91845 fixes word wrap issue on user activity page (#5056)
By default, the width of a table and its cells are adjusted to fit
the content. Thus, longer words are not wrapped and lead to a
wider width.
2017-08-17 08:52:50 +02:00
Régis Hanol
629810bd07 FIX: when registering custom_field types, ensure we're casting them before checking for equality 2017-08-16 23:04:40 +02:00
Sam
304379d436 FEATURE: up/down arrow will highlight search result
Then you can use enter to visit result.
2017-08-16 14:14:55 -04:00
Robin Ward
b78958fbfc Silence CSS logging in development - it's way too noisy 2017-08-16 10:59:56 -04:00
Sam
c68999e128 annotate models
WARNING annotators out there, be to run bin/annotate on RAILS_ENV=test on a clean db
2017-08-16 10:38:11 -04:00
Sam Saffron
56f7b4e01e PERF: reindex search data without loading large post counts 2017-08-16 08:18:59 -04:00
Erick Guan
6e59149a77 FIX: rebuild index when engine replaced (#5021) 2017-08-16 07:38:34 -04:00
Erick Guan
c7a101476e Spec for local auth check 2017-08-16 11:01:00 +02:00
Guo Xiang Tan
b77aa29e71 Merge pull request #5013 from LeoMcA/alternate-emails-phase-1.5
FIX: add additional email to tests and clean up resulting mess
2017-08-16 16:19:28 +09:00
Guo Xiang Tan
ed851dbfff FIX: Avoid publishing a gigantic payload.
* Certain sites have way too many categories.
2017-08-16 11:38:30 +09:00
jomaxro
1219ae685b Add specific class to site description on /about 2017-08-15 19:48:57 -04:00
Joffrey JAFFEUX
cad6107624 refactors select-box
Note: this commit also now uses select-box for mobile topics controls
2017-08-16 00:41:56 +02:00
Neil Lalonde
d506e577a5 FEATURE: if full search returns no results, show google search form 2017-08-15 16:46:41 -04:00
Robin Ward
4085c40e50 Minor CSS changes 2017-08-15 13:17:25 -04:00
Kyle Zhao
c3249f6e93 FEATURE: add full editing access to queued posts (#5047)
For pending new topics: the body of the post, title, categories
and the tags are editable.

For pending new replies: only the body is applicable and thus
editable

DISCUSSION: https://meta.discourse.org/t/66754
2017-08-15 12:44:05 -04:00
Erick Guan
1146772deb Fix: unlinked topic search model (#5044) 2017-08-15 11:46:57 -04:00
Neil Lalonde
130ae2cd4b FEATURE: add Latvian language 2017-08-15 11:40:00 -04:00