github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-24 09:17:30 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
33,371 Commits 190 Branches 500 Tags 938 MiB
f415712269
Commit Graph

6668 Commits

Author SHA1 Message Date
Sam Saffron
f415712269 DEV: avoid double sign-in which can lead to flaky tests 
We should not be signing in twice in tests, it is both wasteful and risky
 2019-06-03 10:15:49 +10:00
David Taylor
ff17177bf9 DEV: Update specs for new stylesheet location 
Followup to 75fc126224
 2019-05-31 16:15:08 +01:00
Sam Saffron
3b8819f0ab FEATURE: add support for defer topic functionality 
This feature allows end users to "defer" topics by marking them unread

The functionality is default disabled. This also introduces the new site
setting default_other_enable_defer: to enable this by default on new user
accounts.
 2019-05-31 15:44:35 +10:00
Robin Ward
2e0a40007b FIX: Category topics should not be deletable via review queue 2019-05-30 16:43:23 -04:00
Bianca Nenciu
7716617c0d DEV: Add spec for BrowserDetection and Chromebook. 2019-05-30 16:31:28 +03:00
Guo Xiang Tan
0eb8d74284 DEV: Reduce object fabrication in CookedPostProcessor spec. 2019-05-30 08:50:10 +08:00
romanrizzi
2fa8df7cd2 New: can_see_groups? method for better perf 2019-05-30 08:45:20 +08:00
romanrizzi
e7ee556e87 Support multi-group user search 2019-05-30 08:45:20 +08:00
Dan Ungureanu
8728850452 FEATURE: Mute topics tagged with both muted and unmuted tags. 2019-05-30 07:58:17 +08:00
Guo Xiang Tan
8858dbb5b8 DEV: Refactor SystemMessage#create specs. 2019-05-30 07:56:36 +08:00
Arpit Jalan
23fdaf07f2 FIX: create system message in user selected locale 
DEV: refactor `create_from_system_user` to use `create` method
 2019-05-29 21:43:43 +05:30
Guo Xiang Tan
20e783337d DEV: Remove use of fake external store in optimized images spec. 
Testing against fake stuff is bad because we're not testing against reality when
reality changes.
 2019-05-29 20:13:23 +08:00
Guo Xiang Tan
8d1b0224ac Fix the build a3938f98f8. 2019-05-29 18:53:31 +08:00
Sam Saffron
b114bcd294 DEV: switch message bus backend to memory for tests 
This backend is a bit faster and well tested, this is part of a longer
term plan to have a `backend: :memory, threaded: false` type config for
message bus which we can use in test.

The threading in message bus causes all sorts of surprises in test, it will
be nice not to be beholden to them.
 2019-05-29 16:34:55 +10:00
Sam Saffron
5c524ea8a4 FEATURE: introduce dedicated storage and DB constraints for anon users 
Previously we used custom fields to denote a user was anonymous, this was
risky in that custom fields are prone to race conditions and are not
properly dedicated, missing constraints and so on.

The new table `anonymous_users` is properly protected. There is only one
possible shadow account per user, which is enforced using a constraint.

Every anonymous user will have a unique row in the new table.
 2019-05-29 14:26:24 +10:00
Guo Xiang Tan
f0620e7118 FEATURE: Support [description|attachment](upload://<short-sha>) in MD take 2. 
Previous attempt was missing `post_uploads` records.
 2019-05-29 09:26:32 +08:00
Guo Xiang Tan
6cceb72173 DEV: Reduce verbosity in TopicQuery spec. 2019-05-29 08:32:10 +08:00
Penar Musaraj
7c9fb95c15 Temporarily revert "FEATURE: Support [description|attachment](upload://<short-sha>) in MD. (#7603)" 
This reverts commit b1d3c678ca.

We need to make sure post_upload records are correctly stored.
 2019-05-28 16:37:01 -04:00
Guo Xiang Tan
b1d3c678ca FEATURE: Support [description|attachment](upload://<short-sha>) in MD. (#7603) 2019-05-28 11:18:21 -04:00
Penar Musaraj
42818b810e Better handling of custom SVG sprites in themes when using S3 2019-05-28 10:58:19 -04:00
Arpit Jalan
028121b95b
FIX: delete system generated message when user_export record is deleted (#7595) 
FIX: system generated message for user export should be closed by default
 2019-05-28 16:38:41 +05:30
Bianca Nenciu
07b80d491b FIX: Refresh automatic groups after inviting moderators. 2019-05-28 17:19:34 +08:00
Sam Saffron
3d2c3bd478 FIX: username suggester incorrectly skipping over whitelisted username 
SSO uses a special param to username suggester that whitelists a username
due to previous work we amended our lookup logic and started ignoring this
whitelist.

The fix ensures we always respect it, and also improves on the original
implementation that forgot to normalize the username.
 2019-05-28 16:48:46 +10:00
Ralph Rooding
0d9fdbf8fe FEATURE: Allow import of hidden site settings (#7601) 
* Allow optional import of hidden site settings

* Always import hidden settings
 2019-05-28 16:20:18 +10:00
Sam Saffron
a02a7d66a9 DEV: properly clean up temp files in FileHelper spec 
Followup to 74297003 , also noticed other specs were not properly cleaning
up so fixed that as well.
 2019-05-28 11:33:08 +10:00
Sam Saffron
7429700389 FIX: ensure we can download maxmind without redis or db config 
This also corrects FileHelper.download so it supports "follow_redirect"
correctly (it used to always follow 1 redirect) and adds a `validate_url`
param that will bypass all uri validation if set to false (default is true)
 2019-05-28 10:28:57 +10:00
Joffrey JAFFEUX
ec02696fa2
DEV: introduces coding style spec (#7615) 2019-05-27 23:38:17 +02:00
Robin Ward
b85fa62882 FIX: Don't send replies to flags that are ignored by expiry 
The `AutoQueueHandler` will ignore really old flags. In that case, don't
notify the user that the moderator is looking into it. They probably
never saw it because it didn't meet the reviewable minimum priority.
 2019-05-27 17:24:36 -04:00
Robin Ward
d95a68b837 FEATURE: When suspending a user, allow the Delete + Replies action 
Previously you could only delete the post
 2019-05-27 12:27:16 -04:00
Dan Ungureanu
6bd082feab
FIX: Update mapping between locales and Postgres dictionaries. (#7606) 2019-05-27 16:52:09 +03:00
Blake Erickson
373b8a2139 FIX: Consistently handle category param 
See https://meta.discourse.org/t/api-post-to-posts-json-inconsistent-between-users/118571
for more info.

This commit removes a 5 year old temporary fix that is no longer needed.

bc1824a6ed (diff-d8c648926664f849aec050757bfcb6f9R72)

The web interface uses category_id when creating a topic so I think we
should unify on category_id when using the api.
 2019-05-27 16:39:56 +08:00
Sam Saffron
170c66c190 DEV: correct flaky test, insufficient timeout 
In some cases with all the new mitigations the 10ms delay is no longer
enough. Wait up to 1 second here instead.
 2019-05-27 17:08:35 +10:00
Guo Xiang Tan
f54e4b71b1 DEV: Make CookedPostProcessor#post_process_images method private. 2019-05-27 11:28:37 +08:00
Dan Ungureanu
da39d66e83
DEV: Improve support for plugins. (#7332) 
* DEV: Allow NewPostManager handlers handle PMs.
* DEV: Add custom fields topic option to PostCreator.
* DEV: Add topic_id to serializer data.
* DEV: Wrap topic title from notification item in a span.
 2019-05-25 16:53:03 +03:00
Robin Ward
89b84651c3 Migrate score settings to use sensitivities 
We hide scores so these settings no longer made sense.
 2019-05-24 15:44:24 -04:00
Osama Sayegh
e20c30987c
FEATURE: detect theme errors and catch them (#7589) 
* FEATURE: detect theme errors and catch them

* Bump COMPILER_VERSION

* Feedback

* Override eslint no console for one line

* Can't use our ajax method

* remove emoji from translation file
 2019-05-24 17:25:55 +03:00
Gerhard Schlager
f4a471f0eb FIX: Correctly cache hash of extra translations 2019-05-24 11:38:26 +02:00
Gerhard Schlager
c1e9a70d59 FIX: Fallback locale was not available for extra translations 
Translations from fallback locales were not sent to the client
for admin_js and wizard_js.
 2019-05-24 11:38:26 +02:00
Guo Xiang Tan
fd0eff6ce3 Revert "FIX: Add missing unique index on user_id for user_profiles." 
Oops `user_id` is the primary key.

This reverts commit 5478aa63ab.
 2019-05-24 12:58:36 +08:00
Guo Xiang Tan
5478aa63ab FIX: Add missing unique index on user_id for user_profiles. 2019-05-24 12:11:49 +08:00
Blake Erickson
1fbe078ae0 FIX: Undefined method when serializing a user 
Apparently is is possible to have a user without a user_profile. This
fix will return nil for any user_profile fields during serialization
(like the after delete web hook) instead of blowing up.
 2019-05-23 19:44:55 -06:00
Robin Ward
e74cd54fc6 REFACTOR: Replace score bonuses with low/med/high priorities 
We removed score from the UX so it makes more sense to have sites set
priorities instead of score bonuses.
 2019-05-23 11:54:45 -04:00
Guo Xiang Tan
b72cec188a Fix the build. 
Follow up to df1e6eed5a.
 2019-05-23 16:11:50 +08:00
Guo Xiang Tan
df1e6eed5a FIX: Pull hotlinked images for lightbox links as well. 2019-05-23 15:44:37 +08:00
Daniel Waterworth
cac7e43ba7 Fixed test suite with PREFABRICATION=0 (#7574) 
The issue here was that, with prefabrication, bumped_at was being
persisted and then loaded and the DB was storing it with less precision
than the object state.
 2019-05-23 07:57:12 +10:00
Gerhard Schlager
58f72cd439 Remove duplicate translations 2019-05-22 16:15:22 +02:00
Gerhard Schlager
e224100023 FIX: Don't convert :) into Emoji when emojis or emoji shurtcuts are disabled 2019-05-22 11:44:39 +02:00
Daniel Waterworth
f46d2ad086 DEV: Update test-prof (#7572) 
* Updated test-prof

* Made rails_helper.rb use new test-prof APIs

Instead of the previous temporary hacks.

* Added environment option to disable prefabrication

It was removed mistakenly
 2019-05-21 22:07:40 +10:00
Vinoth Kannan
793915fe6a DEV: should ignore missing post uploads when a user export destroyed 2019-05-21 13:32:36 +05:30
Sam Saffron
307c526840 DEV: correct test that assumed group 123 did not exist 
This is an incorrect assumption leading to a flaky test, cause for all we
know, since sequences do not reset every test, group 123 could exist.
 2019-05-21 12:57:14 +10:00