Penar Musaraj
274c22e7a2
Revert "DEV: Log deprecated FA 4.7 icon names in /logs"
...
This reverts commit 2dd9727c11
.
2019-12-18 12:44:52 -05:00
Penar Musaraj
2dd9727c11
DEV: Log deprecated FA 4.7 icon names in /logs
2019-12-18 12:22:03 -05:00
David Taylor
fab3bbf705
FIX: IE11 compatibility for readonly check
...
In some situations, the xhr object is undefined in IE11
2019-12-18 16:57:20 +00:00
Kris
37c9579a01
UX: reduce opacity on hidden topic contents, but not the controls
2019-12-18 11:34:33 -05:00
Dan Ungureanu
95390e3333
FIX: Show parent and subcategories for 2nd level categories ( #8579 )
...
The maximum level used to be one, which meant that a category could be
either a parent or a child. If it was a parent, the subcategories were
shown; if it was a child then the parent selector was shown.
With multiple levels of nesting, a category can be both a parent and a
child.
2019-12-18 17:44:28 +02:00
dependabot-preview[bot]
e0df0f479a
Bump aws-sdk-s3 from 1.59.0 to 1.59.1 ( #8575 )
...
Bumps [aws-sdk-s3](https://github.com/aws/aws-sdk-ruby ) from 1.59.0 to 1.59.1.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases )
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/master/gems/aws-sdk-s3/CHANGELOG.md )
- [Commits](https://github.com/aws/aws-sdk-ruby/compare/v1.59.0...v1.59.1 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-12-18 12:11:43 -03:00
dependabot-preview[bot]
2cdaf05c37
Bump ruby-prof from 1.0.0 to 1.1.0 ( #8546 )
...
Bumps [ruby-prof](https://github.com/ruby-prof/ruby-prof ) from 1.0.0 to 1.1.0.
- [Release notes](https://github.com/ruby-prof/ruby-prof/releases )
- [Changelog](https://github.com/ruby-prof/ruby-prof/blob/master/CHANGES )
- [Commits](https://github.com/ruby-prof/ruby-prof/commits )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-12-18 12:10:09 -03:00
dependabot-preview[bot]
7b7926c486
Bump rake-compiler from 1.0.7 to 1.0.8 ( #8559 )
...
Bumps [rake-compiler](https://github.com/luislavena/rake-compiler ) from 1.0.7 to 1.0.8.
- [Release notes](https://github.com/luislavena/rake-compiler/releases )
- [Changelog](https://github.com/rake-compiler/rake-compiler/blob/master/History.txt )
- [Commits](https://github.com/luislavena/rake-compiler/compare/v1.0.7...v1.0.8 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-12-18 11:56:16 -03:00
dependabot-preview[bot]
aaf159c48c
Bump aws-partitions from 1.255.0 to 1.256.0 ( #8566 )
...
Bumps [aws-partitions](https://github.com/aws/aws-sdk-ruby ) from 1.255.0 to 1.256.0.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases )
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/master/gems/aws-partitions/CHANGELOG.md )
- [Commits](https://github.com/aws/aws-sdk-ruby/commits )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-12-18 11:55:44 -03:00
dependabot-preview[bot]
caa7cc51f1
Build(deps): Bump thor from 1.0.0 to 1.0.1 ( #8572 )
...
Bumps [thor](https://github.com/erikhuda/thor ) from 1.0.0 to 1.0.1.
- [Release notes](https://github.com/erikhuda/thor/releases )
- [Changelog](https://github.com/erikhuda/thor/blob/master/CHANGELOG.md )
- [Commits](https://github.com/erikhuda/thor/compare/v1.0.0...v1.0.1 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-12-18 11:55:18 -03:00
Kris
89154308b0
UX: Minor user admin page adjustments, accomodating for long group names
2019-12-18 09:26:03 -05:00
David Taylor
96bfefac5c
FIX: Prevent errors in IE11 following AJAX request
...
In some situations, the xhr object is undefined, so check that it's present before continuing
2019-12-18 13:38:36 +00:00
David Taylor
b4f28ce2b1
FIX: Add missing Object.entries polyfill for IE11
...
This was omitted when IE polyfills were migrated from polyfills.js to ie.js
2019-12-18 11:36:26 +00:00
Krzysztof Kotlarek
1921538faa
FIX: show new/unread button when a new topic or post is created ( #8576 )
...
There is a problem that if you read all messages, even when a new one
arrives, the button on the top is not showing.
This is because once the button got `hidden` class, a label under is
properly updated, however, the class is not removed.
Therefore, I added computed isHidden function which is recalculated when
`count` change.
2019-12-18 11:22:28 +00:00
Vinoth Kannan
3b7f5db5ba
FIX: parallel spec system needs a dedicated upload folder for each worker. ( #8547 )
2019-12-18 11:21:57 +05:30
Krzysztof Kotlarek
f59647cd55
FIX: move IE specific CSS rules to discourse-internet-explorer plugin ( #8567 )
2019-12-18 15:25:16 +11:00
Mark VanLandingham
44612f900e
FIX: Remove 'staff_only' results option for non-staff ( #8565 )
2019-12-17 13:43:15 -08:00
Mark VanLandingham
e916bd7ea0
FIX: Fix choose-topic component to search by url ( #8574 )
2019-12-17 13:01:52 -08:00
Mark VanLandingham
d37dc14c57
REVERT: Remove feature topic on profile button from topic view ( #8573 )
2019-12-17 12:41:49 -08:00
Kris
62ebfbbb67
UX: Minor adjustment to give the PM recipient input more flexibility.
2019-12-17 14:56:57 -05:00
Joffrey JAFFEUX
007652ece5
DEV: allows this.get in widgets ( #8571 )
2019-12-17 18:39:51 +01:00
Blake Erickson
1c7305c0f1
DEV: Remove buffered rendering from topic-status
...
This is another refactoring in the multi-step process to remove all uses
of our custom Render Buffer.
Previous commit: 006e5904be
in this
series.
This commit affects the icons next to the topic title that indicate if
it is closed, unlisted, pinned, etc. It is just a refactor and should
not change any functionality.
Originally I was going to continue to use the existing
topic-status-icons arrayProxy helper but this would require using
observers, so I opted instead to use computed properties and have a bit
larger hbs template.
2019-12-17 10:35:05 -07:00
Kris
ff1be40980
UX: Increase combo-box tap area for mobile
2019-12-17 11:43:11 -05:00
Dan Ungureanu
d9e7611910
FIX: Avoid String.matchAll for IE11 support
2019-12-17 18:09:29 +02:00
Penar Musaraj
ea05a68df7
FIX: Use updated_at date to denote expired invites ( #8521 )
2019-12-17 10:13:49 -05:00
David Taylor
8106d94c05
SECURITY: Correct permission check when revoking user API keys
2019-12-17 10:56:16 +00:00
Joffrey JAFFEUX
81b4de39ee
FIX: prevents crash in discourse_tagging with empty term ( #8548 )
2019-12-17 10:55:06 +01:00
Martin Brennan
6ab12ed96b
FIX: If a prettified slug is a number, return defaultt ( #8554 )
...
Meta thread: https://meta.discourse.org/t/sending-a-pm-with-the-following-title-causes-an-error/135654/3
We had an issue where if someone sent a PM with crazy
characters that are stripped and we end up with only
a number, the topic redirect errored because the slug was
a number. so instead we return the default as well if
the slug is a number after prettification
2019-12-17 10:34:20 +10:00
Martin Brennan
beb91e7eff
FIX: require: false for rotp gem ( #8540 )
...
The ROTP gem is only used in a very small amount of places in the app, we don't need to globally require it.
Also set the Addressable gem to not have a specific version range, as it has not been a problem yet.
Some slight refactoring of UserSecondFactor here too to use SecondFactorManager to avoid code repetition
2019-12-17 10:33:51 +10:00
Krzysztof Kotlarek
84ede5867c
FIX: category id in filterCategory ( #8555 )
...
Small regression was created here: https://github.com/discourse/discourse/commit/374534f00ee#diff-4af46675500edc092f9224ca5835a7ddR106
After that change `listFilter` is including `categoryId` like `c/cat/subcat/6/l/latest` instead of `c/cat/subcat/l/latest`
Therefore, `trackIncoming` function in topic-tracking-state couldn't properly filter new messages
2019-12-17 08:33:38 +11:00
dependabot-preview[bot]
998bbdc40f
Bump fspath from 3.1.0 to 3.1.2 ( #8564 )
...
Bumps [fspath](https://github.com/toy/fspath ) from 3.1.0 to 3.1.2.
- [Release notes](https://github.com/toy/fspath/releases )
- [Commits](https://github.com/toy/fspath/compare/v3.1.0...v3.1.2 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-12-16 12:19:31 -08:00
Penar Musaraj
776840c810
FIX: Ensure currentUser exists before getting ID
...
Otherwise this would trigger a JS error for anonymous users.
2019-12-16 14:53:43 -05:00
Robin Ward
480e2ec523
FIX: If we run db:migrate
on its own, it should load the environment
2019-12-16 14:46:33 -05:00
Robin Ward
ce78eff888
FIX: Migration paths were being forgotten
...
According to the [Rails
Source](https://github.com/rails/rails/blob/master/activerecord/lib/active_record/railties/databases.rake#L20 )
the `ActiveRecord::Migrator.migrations_paths` are overwritten with the
value of `ActiveRecord::Tasks::DatabaseTasks.migrations_paths` every
time the config is loaded.
This caused a bug for Discourse development where if you ran:
`rake db:drop db:create db:migrate` in one line, you would not get our
post migrations, as those had a custom value for `migrations_paths`.
The fix is to use `ActiveRecord::Tasks::DatabaseTasks.migrations_paths`
to set up all our custom paths. Everything seems to work as expected.
2019-12-16 14:13:47 -05:00
dependabot-preview[bot]
5acecfcb91
Bump in_threads from 1.5.1 to 1.5.3 ( #8556 )
...
Bumps [in_threads](https://github.com/toy/in_threads ) from 1.5.1 to 1.5.3.
- [Release notes](https://github.com/toy/in_threads/releases )
- [Changelog](https://github.com/toy/in_threads/blob/master/CHANGELOG.markdown )
- [Commits](https://github.com/toy/in_threads/compare/v1.5.1...v1.5.3 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-12-16 10:57:22 -08:00
dependabot-preview[bot]
82828d5145
Bump progress from 3.5.0 to 3.5.2 ( #8560 )
...
Bumps [progress](https://github.com/toy/progress ) from 3.5.0 to 3.5.2.
- [Release notes](https://github.com/toy/progress/releases )
- [Changelog](https://github.com/toy/progress/blob/master/CHANGELOG.markdown )
- [Commits](https://github.com/toy/progress/compare/v3.5.0...v3.5.2 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-12-16 10:45:33 -08:00
dependabot-preview[bot]
aee3c6b96b
Bump json from 2.2.0 to 2.3.0 ( #8563 )
...
Bumps [json](https://github.com/flori/json ) from 2.2.0 to 2.3.0.
- [Release notes](https://github.com/flori/json/releases )
- [Changelog](https://github.com/flori/json/blob/master/CHANGES.md )
- [Commits](https://github.com/flori/json/compare/v2.2.0...v2.3.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-12-16 10:35:08 -08:00
dependabot-preview[bot]
e328700ae5
Bump aws-sdk-core from 3.85.0 to 3.86.0 ( #8558 )
...
Bumps [aws-sdk-core](https://github.com/aws/aws-sdk-ruby ) from 3.85.0 to 3.86.0.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases )
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/master/gems/aws-sdk-core/CHANGELOG.md )
- [Commits](https://github.com/aws/aws-sdk-ruby/commits )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-12-16 10:09:38 -08:00
dependabot-preview[bot]
22f1aa0c58
Bump jquery-rails from 4.3.3 to 4.3.5 ( #8557 )
...
Bumps [jquery-rails](https://github.com/rails/jquery-rails ) from 4.3.3 to 4.3.5.
- [Release notes](https://github.com/rails/jquery-rails/releases )
- [Changelog](https://github.com/rails/jquery-rails/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rails/jquery-rails/compare/v4.3.3...v4.3.5 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-12-16 09:44:56 -08:00
dependabot-preview[bot]
db82ed86c4
Bump thor from 0.20.3 to 1.0.0 ( #8550 )
2019-12-16 09:23:47 -08:00
dependabot-preview[bot]
6b3308d614
Bump excon from 0.70.0 to 0.71.0 ( #8551 )
...
Bumps [excon](https://github.com/excon/excon ) from 0.70.0 to 0.71.0.
- [Release notes](https://github.com/excon/excon/releases )
- [Changelog](https://github.com/excon/excon/blob/master/changelog.txt )
- [Commits](https://github.com/excon/excon/compare/v0.70.0...v0.71.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-12-16 08:53:42 -08:00
Mark VanLandingham
8c4ffaea1b
FEATURE: Modal for profile featured topic & admin wrench refactor ( #8545 )
2019-12-16 08:41:34 -08:00
David Taylor
7b6bafc651
Revert "DEV: Bind to ipv6 loopback address in addition to ipv4 ( #8544 )"
...
This reverts commit 1002bf62e5
.
2019-12-16 15:51:04 +00:00
Joffrey JAFFEUX
aa73df768a
DEV: improves error message when sso param is not passed ( #8549 )
...
SingleSignOnProvider is expecting a sso param later in the chain. If sso param is not found it will cause a 500 with the following exception: `NoMethodError (undefined method `unpack1' for nil:NilClass)` as `set_return_sso_url` is attempting to decode it: https://github.com/discourse/discourse/blob/master/lib/single_sign_on_provider.rb#L19
2019-12-16 12:33:24 +01:00
David Taylor
1002bf62e5
DEV: Bind to ipv6 loopback address in addition to ipv4 ( #8544 )
2019-12-16 11:01:02 +00:00
Martin Brennan
b6b05d3b48
Add bookmark-clock icon ( #8553 )
...
Adds a custom bookmark-clock icon to discourse-additional.svg for use with the new bookmarks with reminder functionality.
Also add some code to correctly refresh the post-stream icon for bookmark to show the clock after save.
2019-12-16 12:37:34 +10:00
Gerhard Schlager
e7402b3feb
DEV: Allow unsafe-eval
in development mode
...
It's needed because of this: 5f1e346e16/lib/source_url.rb (L18-L24)
2019-12-14 22:36:50 +01:00
Régis Hanol
5f1e346e16
DEV: lint file
2019-12-13 22:37:19 +01:00
Régis Hanol
1309262569
UX: pluralize "likes/read this"
...
When expending the number of likes/reads, the text wasn't handling
proper pluralization that might be useful in locales that requires it.
2019-12-13 22:18:28 +01:00
Robin Ward
bc97d39688
FIX: Allow IE script to load with a CDN
...
A proper fix would involve it being precompiled like other assets, but
due to the conditional nature of the resource this is more complicated.
For now this is better than IE being broken.
2019-12-13 15:50:46 -05:00