Commit Graph

57119 Commits

Author SHA1 Message Date
Kelv
0f2033dd69
DEV: Update more deprecated Font Awesome icon names ()
* DEV: Update more deprecated Font Awesome icon names

* revert update to icon-library test - test is covering deprecation case
2024-12-08 22:14:28 +01:00
Sérgio Saquetim
b8325f2190
FIX: Recover user deleted post ()
This commit fixes an issue where the recover button would not be displayed for a user delete post.
2024-12-06 15:47:57 -03:00
Joffrey JAFFEUX
b0be89cb17
FIX: lower thread panel min-width ()
It's been set to this value as a workaround for long thread titles, but we now have standalone thread titles in the thread body which makes this not needed. People had troubles understanding why they couldn't resize more the thread panel.
2024-12-06 19:18:45 +01:00
Discourse Translator Bot
4f8293e78f
Update translations () 2024-12-06 18:04:53 +01:00
Kris
5ce54fe7fa
DEV: admin-login submit should be a button, not an input () 2024-12-06 11:48:15 -05:00
David Taylor
55980a2a84
DEV: Add workaround for chrome crash ()
Some users are seeing consistent "Error 5" crashes in chrome when saving/deleting bookmarks on chat messages.

When crash logging is enabled, the message is:

`[33466:259:1206/122312.195048:ERROR:ax_object.cc(3400)] Check failed: !NeedsToUpdateCachedValues(). Stale values: "Group" axid#7543 <svg#discourse-emojis> needsToUpdateCachedValues/disallowed isIgnored inUserAgentShadowRoot:<use> isInert needsToUpdateChildren hasDirtyDescendants`

This seems to be influenced by a few factors, including the re-render of the bookmarks button, the adjacent 'reactions' button, and also the opening/closing of the modal.

Adding this `activeElement.blur` seems to avoid the issue in my manual testing. Hopefully, this can be dropped after future chrome releases.

Internal topic: t/143485
2024-12-06 16:05:09 +00:00
Mark VanLandingham
07f4e56658
FIX: freeze_original for moved_post notifications for OP moves, link to destination topic ()
Currently when copy an OP to another topic, the link is to the topic that wasn't moved. The notification should instead be to the new topic the OP was moved to -- we have duplicate logic already for this but first post creation get special treatment, and this applies the same treatment.
2024-12-06 09:50:53 -06:00
Bianca Nenciu
2defab25b7
DEV: Remove references to categories_only_optimized ()
This category style has been removed in f1700ca5.
2024-12-06 17:39:22 +02:00
Régis Hanol
35ecd0335c
UX: only show automatic group tooltip to admins ()
Follow up to  which added the tooltip on automatic group.

It was missing a check to ensure the current user is an admin, since only admins can manage automatic groups.

Reported in https://meta.discourse.org/t/324215 by @moin-Jana
2024-12-06 15:43:03 +01:00
David Battersby
4f4498994c
UX: fix channel name style for unread threads ()
Follow up to .

Normally when viewing a channel with tracked threads, we dismiss the blue dot next to the channel name even though the thread has not been read yet.

This change applies the same criteria to determine if we should bold the channel name.
2024-12-06 17:38:13 +04:00
Kris
d35d8193aa
UX: fix PM topic map layout () 2024-12-06 08:34:54 -05:00
Alan Guo Xiang Tan
58556ed434
DEV: Drop experimental_topics_filter site setting take 2 ()
This is a follow-up to e6fdfcdcd2 which
did not remove the site setting from `config/site_settings.yml` and drop
the site setting value from the database.
2024-12-06 08:10:38 -05:00
David Taylor
eaa45ae4d0
DEV: Update transformers in topic-list/item ()
These will enable https://github.com/discourse/discourse-topic-thumbnails/pull/60
2024-12-06 10:08:10 +00:00
Martin Brennan
31abb0b59e
UX: Minor fix to admin what's new link ()
Followup 9c4c17ad3f
2024-12-06 14:23:09 +10:00
Martin Brennan
9c4c17ad3f
UX: Change "What's new in Discourse?" link ()
We want to point to our dedicated /admin/whats-new
page which is more focused and has better screenshots
and so on.
2024-12-06 10:11:18 +10:00
Mark VanLandingham
71bec686a2
DEV: Add user_id and post_user_id to MovedPost records ()
Follow-up from this commit - 9b8af0ea9f

Adds helpful data into MovedPost records for later lookup. ALSO fixes notifications for freeze_original to point to the newly created post, not the moved post.
2024-12-05 17:10:32 -06:00
Jarek Radosz
13793a3d8e
DEV: Convert bookmark-icon to gjs/glimmer () 2024-12-05 23:58:43 +01:00
dependabot[bot]
06bc5256df
Build(deps-dev): Bump webpack from 5.97.0 to 5.97.1 ()
Bumps [webpack](https://github.com/webpack/webpack) from 5.97.0 to 5.97.1.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v5.97.0...v5.97.1)

---
updated-dependencies:
- dependency-name: webpack
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-12-05 23:52:02 +01:00
dependabot[bot]
2ae69a7cfd
Build(deps): Bump terser from 5.36.0 to 5.37.0 ()
Bumps [terser](https://github.com/terser/terser) from 5.36.0 to 5.37.0.
- [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md)
- [Commits](https://github.com/terser/terser/compare/v5.36.0...v5.37.0)

---
updated-dependencies:
- dependency-name: terser
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-12-05 23:18:45 +01:00
dependabot[bot]
5b06965047
Build(deps): Bump @babel/standalone in the babel group ()
Bumps the babel group with 1 update: [@babel/standalone](https://github.com/babel/babel/tree/HEAD/packages/babel-standalone).


Updates `@babel/standalone` from 7.26.3 to 7.26.4
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.26.4/packages/babel-standalone)

---
updated-dependencies:
- dependency-name: "@babel/standalone"
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: babel
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-12-05 23:14:58 +01:00
Blake Erickson
2d8a62aec1
DEV: Update create user w/ custom fields api docs ()
Since the example specifies json use a json formatted example instead of
form-data.

https://meta.discourse.org/t/161413/5
2024-12-05 12:28:48 -07:00
Renato Atilio
4a5a499d94
DEV: refactor textarea from autocomplete ()
Extracts the dependency we had on specifics of a textarea in our Autocomplete, this approach uses a TextareaTextManipulation, particularly the value getter, getCaretPosition, getCaretCoords, replaceText, and inCodeBlock.
2024-12-05 16:09:06 -03:00
Renato Atilio
e37952c9db
DEV: refactor placeholder handling from UppyComposerUpload ()
Extracts the textual upload placeholder handle logic from UppyComposerUpload to a new TextareaPlaceholderHandler class, implicitly instantiated by TextareaTextManipulation.
2024-12-05 15:07:55 -03:00
Sérgio Saquetim
8ce6aa3e7d
DEV: Ensure composer opens properly when the post topic is not yet loaded ()
This PR fixes an error that would be thrown in some edge cases where the composer is opened for a post instance without an associated topic model already loaded.

An example of such edge cases would be, a plugin trying to edit a post outside the topic view.

This was causing an error that would prevent the composer from being opened.
2024-12-05 14:21:29 -03:00
Mark VanLandingham
68e57190df
DEV: Allow freeze_original argument in topics controller & JS transformer ()
PostMover has a new option called freeze_original implemented in this commit. It was previously unexposed in the controller. This PR permits the param in the controller, and passes it into PostMover.

Also, this applies a value transformer for move/merge payload options. In addition a plugin outlet in the move post modal. This allows plugins to add content to the modal, which can modify the payload (and use the freeze_original argument for example)
2024-12-05 08:31:05 -06:00
Juan David Martínez Cubillos
555ca4da55
DEV: Add plugin wrapper to avoid template override in plugins ()
* DEV: Add plugin wrapper to avoid template override in plugins

* added plugin wrapper

* linter issues

* added suggested change

Co-authored-by: Jarek Radosz <jradosz@gmail.com>

* added suggested changes

---------

Co-authored-by: Jarek Radosz <jradosz@gmail.com>
2024-12-05 09:05:16 -05:00
Joffrey JAFFEUX
5ad09f7564
DEV: adds default option to form-kit select ()
This commit will now show a "Select..." option when no value selected and a "None" option when a value is selected, as the first row. It ensures that people don't think a value is selected when it's actually just the html select showing the first available option.
2024-12-05 13:52:22 +01:00
Ella E.
c817a94c89
UX: Move revoked API key status to dedicated column ()
* DEV: add table heading for status

* UX: Move revoked status to its own column with a badge; remove revoked icon

* UX: Increase text contrast for revoked rows
2024-12-05 04:24:01 -07:00
dependabot[bot]
59413e72d4
Build(deps-dev): Bump puppeteer-core from 23.10.0 to 23.10.1 ()
Bumps [puppeteer-core](https://github.com/puppeteer/puppeteer) from 23.10.0 to 23.10.1.
- [Release notes](https://github.com/puppeteer/puppeteer/releases)
- [Changelog](https://github.com/puppeteer/puppeteer/blob/main/release-please-config.json)
- [Commits](https://github.com/puppeteer/puppeteer/compare/puppeteer-core-v23.10.0...puppeteer-core-v23.10.1)

---
updated-dependencies:
- dependency-name: puppeteer-core
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-12-05 12:17:30 +01:00
dependabot[bot]
b4e95d7157
Build(deps): Bump @babel/standalone in the babel group ()
Bumps the babel group with 1 update: [@babel/standalone](https://github.com/babel/babel/tree/HEAD/packages/babel-standalone).


Updates `@babel/standalone` from 7.26.2 to 7.26.3
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.26.3/packages/babel-standalone)

---
updated-dependencies:
- dependency-name: "@babel/standalone"
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: babel
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-12-05 12:17:14 +01:00
David Battersby
4e8a1487ca
UX: make channel name bold for unread threads ()
Channels with unread threads should have a font weight of bold to match unread channels.
2024-12-05 14:17:31 +04:00
David Battersby
b3c94839ed
FIX: improve chat channel sorting for DMs ()
This change sorts unread channels in descending order based on last message date, so channels with the latest activity will always appear at the top. It also adds some improvements for sorting channels with unread threads, now when multiple channels have unread threads, they will be sorted by last thread reply date to ensure more active channels rise to the top.

For DM channels, the order is now:

- Urgent (green badge) - unread messages, mentions and unread watched threads (most recent activity at top)
- Unread (blue badge) - unread tracked threads (most recent thread reply at top)
- Everything else (most recent message at top)
2024-12-05 13:33:55 +04:00
Kelv
1ca90c3070
DEV: update more deprecated font awesome icon names ()
* update more deprecated font awesome icon names

* add migration to remove deprecated default for badges.icon
2024-12-05 15:20:02 +08:00
Martin Brennan
8a89a77248
FIX: Discard empty bundles for reviewables ()
Followup c7e471d35a

It is currently possible to add a bundle (which is a collection
of actions used for a dropdown on the client) for a reviewable
via actions.add_bundle and then never add any actions to it.

This causes the client to explode, as seen in the referenced
commit, because of the way our store expects to resolve objects
referenced by ID that are passed down by the serializer, which
then causes Ember to have an unrecoverable render error.

Fixing this on the serializer level is not really possible because
of all the ActiveModel::Serializer magic that serializes
objects by ID reference when doing things like has_many.
`Reviewable#actions_for` is a better place to do this anyway,
because this is the main location where the bundles and actions
are built for every action via the serializer.
2024-12-05 15:41:13 +10:00
Kelv
dd0b4e26a7
DEV: update fa6 icons to drop fa prefix ()
* remove fa- part of prefix from font awesome icon names
2024-12-05 10:00:41 +08:00
Gary Pendergast
bb2e9645f2
FIX: Move granted badges to the end of the post header. () 2024-12-05 09:22:03 +11:00
dependabot[bot]
111a922a69
Build(deps): Bump google-protobuf from 4.29.0 to 4.29.1 ()
Bumps [google-protobuf](https://github.com/protocolbuffers/protobuf) from 4.29.0 to 4.29.1.
- [Release notes](https://github.com/protocolbuffers/protobuf/releases)
- [Changelog](https://github.com/protocolbuffers/protobuf/blob/main/protobuf_release.bzl)
- [Commits](https://github.com/protocolbuffers/protobuf/commits)

---
updated-dependencies:
- dependency-name: google-protobuf
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-12-05 06:19:39 +08:00
dependabot[bot]
8d39830983
Build(deps): Bump useragent from 0.16.10 to 0.16.11 ()
Bumps [useragent](https://github.com/gshutler/useragent) from 0.16.10 to 0.16.11.
- [Commits](https://github.com/gshutler/useragent/compare/v0.16.10...v0.16.11)

---
updated-dependencies:
- dependency-name: useragent
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-12-05 06:19:25 +08:00
dependabot[bot]
3b27ef9bbd
Build(deps-dev): Bump @swc/core from 1.9.3 to 1.10.0 ()
Bumps [@swc/core](https://github.com/swc-project/swc) from 1.9.3 to 1.10.0.
- [Release notes](https://github.com/swc-project/swc/releases)
- [Changelog](https://github.com/swc-project/swc/blob/main/CHANGELOG.md)
- [Commits](https://github.com/swc-project/swc/compare/v1.9.3...v1.10.0)

---
updated-dependencies:
- dependency-name: "@swc/core"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-12-05 06:18:46 +08:00
dependabot[bot]
c8c54bdc52
Build(deps): Bump minitest from 5.25.3 to 5.25.4 ()
Bumps [minitest](https://github.com/minitest/minitest) from 5.25.3 to 5.25.4.
- [Changelog](https://github.com/minitest/minitest/blob/master/History.rdoc)
- [Commits](https://github.com/minitest/minitest/compare/v5.25.3...v5.25.4)

---
updated-dependencies:
- dependency-name: minitest
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-12-05 06:18:19 +08:00
dependabot[bot]
a13eb7ce3c
Build(deps-dev): Bump sqlite3 from 2.3.1 to 2.4.0 ()
Bumps [sqlite3](https://github.com/sparklemotion/sqlite3-ruby) from 2.3.1 to 2.4.0.
- [Release notes](https://github.com/sparklemotion/sqlite3-ruby/releases)
- [Changelog](https://github.com/sparklemotion/sqlite3-ruby/blob/main/CHANGELOG.md)
- [Commits](https://github.com/sparklemotion/sqlite3-ruby/compare/v2.3.1...v2.4.0)

---
updated-dependencies:
- dependency-name: sqlite3
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-12-05 06:17:53 +08:00
Kris
19f530a827
UX: refactor title editing CSS to improve layout () 2024-12-04 16:30:48 -05:00
Régis Hanol
f75c43713b
FEATURE: bump DM limits from 20 to 50 ()
So people who are having a **lot** of 1-1/group conversations in #chat can have even more 😅

Internal ref - t/143226/8
2024-12-04 16:34:28 +01:00
Kris
5c2e05cf5d
UX: fix topic map padding in low-content situations () 2024-12-04 09:39:14 -05:00
Joffrey JAFFEUX
3ddb1cfbad
FIX: ensures tabbing from trigger focus content ()
`DMenu` is using in-element, which means the content is detached from the trigger, and pressing tab from the trigger is not going to jump into the content. This commit catches the tab event and attempts to focus the first focusable element of the content.
2024-12-04 12:46:02 +01:00
Régis Hanol
d2d8fbcf3b
FIX: properly quote videos ()
Follow up to f294f984cf

All that was needed was a little fix to our markdown engine to use the
"image src" as the "video src" when the "data video src" was not
defined.

That way we can use the regular image markdown with the "|video" option
(?).
2024-12-04 12:39:38 +01:00
Régis Hanol
1ce12ae718
DEV: Deleted the "ChatComposerPresenceManager"... ()
...since it was mostly duplicating the work the "ComposerPresenceManager" was doing.

So now the #chat composer uses the same "presence manager" as the composer, benefiting from the "hide presence" checks, with the only difference that the "keep alive" timeout is 5s for chat and 10s for topics/posts.
2024-12-04 12:21:55 +01:00
Discourse Translator Bot
838d7478c1
Update translations () 2024-12-04 11:59:28 +01:00
Régis Hanol
f294f984cf
FIX: unable to quote video ()
This replaces the video container / thumbnail with a proper "<video>" element when quoting a video.

It's not the best UX, especially when "morphing" is disabled.

Needs more work.

Internal ref - t/143321
2024-12-04 11:56:28 +01:00
Régis Hanol
3e7f0867ea
FIX: whisper's presence channels ()
In 0993273 we introduced the `whisper_allowed_group_ids` to allow whispers to more users than "staff".

The presence plugin hadn't been updated to account for this change.
2024-12-04 11:47:05 +01:00