Commit Graph

8806 Commits

Author SHA1 Message Date
Guo Xiang Tan
fb75f188ba FEATURE: Disallow login via omniauth when user has 2FA enabled. 2018-03-01 15:47:07 +08:00
Neil Lalonde
764b6c005c FIX: don't show Other Tags on /tags if there aren't any to show 2018-02-27 22:30:46 -05:00
Kris
b832c3d885 Glyph wasn't wrapping properly with long categories 2018-02-27 17:10:02 -05:00
Joffrey JAFFEUX
8ca1b1ab0b
FIX: load tag_groups and not tags 2018-02-27 21:10:57 +01:00
Joffrey JAFFEUX
9b680fc45c
FIX: prevents create row to be displayed if term is in displayed list 2018-02-27 18:31:58 +01:00
Joffrey JAFFEUX
ba2f01c0bd
FIX: prevents selected value from hiding one item of the list 2018-02-27 18:31:51 +01:00
Arpit Jalan
4010d8d9f9 FEATURE: show "edit message" button on message footer for staff
Show "Edit Message" button on personal message footer for staff if PM tagging is enabled.
2018-02-27 14:22:03 +05:30
Joffrey JAFFEUX
410b90dde0
FIX: mini-tag-chooser was not returning a correct list of tags
Should also fix an issue where it validates the creation of an existing tag.
2018-02-27 08:47:44 +01:00
Guo Xiang Tan
104df3126b UX: Incorrect width for webhook events. Take 2. 2018-02-27 10:34:46 +08:00
Guo Xiang Tan
8d16ca2af2 UX: Incorrect width for webhook events. 2018-02-27 10:32:11 +08:00
Guo Xiang Tan
24f3b78548 Fix incorrect ids for 2FA inputs. 2018-02-27 10:12:22 +08:00
Guo Xiang Tan
70f14da732 UX: Use 'tel' input type for 2FA token inputs. 2018-02-27 09:30:44 +08:00
Robin Ward
8296f493ed add class to easier targetting 2018-02-26 19:03:21 -05:00
Neil Lalonde
8f27456acb UX: Move 'show words' checkbox close to the words in the Watched Words UI 2018-02-26 16:35:52 -05:00
Neil Lalonde
3313072957 Remove censored_pattern site setting, which is replaced by watched words 2018-02-26 16:29:27 -05:00
Robin Ward
f8856f3d7a FIX: Anonymous users shouldn't see the link to new in the footer 2018-02-26 13:46:50 -05:00
Joffrey JAFFEUX
ac701696b3
FEATURE: replaces tag-chooser/tag-group-chooser with select-kit component
These component were also the last using select2. As a consequence select2 is removed from Discourse in this commit.
2018-02-26 11:42:57 +01:00
Guo Xiang Tan
a9699da672 UX: Specify pattern and maxlength for 2FA input fields. 2018-02-26 18:29:46 +08:00
Guo Xiang Tan
3e1afbedc5 FIX: Missing translation for non-admin when editing a group.
https://meta.discourse.org/t/text-glitch-on-group-admin-page/77303
2018-02-26 10:11:18 +08:00
Guo Xiang Tan
616d210911
Merge pull request #5614 from nbianca/fix_period
Try extracting time period only when the filter is 'top'.
2018-02-26 09:38:33 +08:00
Guo Xiang Tan
4791b39773 UX: Add reset password email button when confirming password before enabling 2FA. 2018-02-23 15:37:17 +08:00
Guo Xiang Tan
4250ab522a UX: Don't show admin 2FA edit icon on profile of other users. 2018-02-23 13:51:02 +08:00
Guo Xiang Tan
e137b7f836 UX: Improve indication of 2FA status in user's preferences. 2018-02-23 10:36:48 +08:00
Guo Xiang Tan
5e60f6b533 UX: Don't disable submit button before transitioning in 2FA flow. 2018-02-23 10:36:48 +08:00
Guo Xiang Tan
2e2da3a6e2 Update copy for 2FA. 2018-02-23 10:36:48 +08:00
Robin Ward
ee9be65b2c FIX: Show names when available 2018-02-22 20:06:53 -05:00
Guo Xiang Tan
9f5bc7a5ee
Merge pull request #5605 from nbianca/favorites
Added the required hooks for discourse-favorites plugin.
2018-02-23 07:12:09 +08:00
Guo Xiang Tan
18c1d1565c UX: Fix missing css styles on invite modal. 2018-02-23 07:08:19 +08:00
Guo Xiang Tan
dd26bbe868
Merge pull request #5610 from discourse/pm-tags
FEATURE: Allow staffs to tag PMs
2018-02-23 07:07:41 +08:00
Bianca Nenciu
184d521fc9 Added the required hooks for discourse-favorites plugin. 2018-02-22 23:58:53 +02:00
Bianca Nenciu
0e3e5f25a6 Try extracting time period only when the filter is 'top'. 2018-02-22 23:56:37 +02:00
Régis Hanol
0210a7f2bf FIX: social login buttons were not working 2018-02-22 18:06:28 +01:00
Guo Xiang Tan
862e83287e
Merge pull request #5575 from featheredtoast/tab-index-composer-actions
tab index composer actions
2018-02-22 15:16:41 +08:00
Guo Xiang Tan
7bcc0c1da9 FIX: Login buttons not working on sign up modal. 2018-02-22 14:01:07 +08:00
Arpit Jalan
d170c8fccc Revert 'Accessibility: focus management in topics'
reverts:

- 3df0626aa5
- 3212cdda78
- 59b7760e2e
- bfc1301823
2018-02-22 10:32:37 +05:30
Kane York
59b7760e2e UX: Make the .selected class follow focus 2018-02-22 12:20:47 +08:00
Kane York
3212cdda78 UX: Use focus as the first selector for J/K navigation 2018-02-22 11:55:36 +08:00
Sam
f4418ae884 PERF: fast docking of timeline so it does not overlap
In the past we debounced all dock check this causes situations where
sometimes timeline would not dock in time especially on slow computers

This works around it by performing the dock by hand.

Also there was missing integer casting causing over aggressive re-rendering
2018-02-22 12:52:43 +11:00
Guo Xiang Tan
412b298f55 UX: Smaller input field for preferences 2FA form. 2018-02-22 09:07:43 +08:00
Guo Xiang Tan
1b04d881c5 UX: Display lock icon in admin user lists when user has 2FA enabled. 2018-02-22 09:00:09 +08:00
Joffrey JAFFEUX
6f5acfe783 Login with email/forget password UI refactoring
* move button into login modal with social buttons
* adds email link next to login field when filling it
* adds proper validation messages
* improves forgot password flash clearing
* more tests
2018-02-22 08:06:15 +08:00
Sam
720e1965e3 FEATURE: add category suppress from latest
In the past we used suppress_from_homepage, it had mixed semantics
it would remove from category list if category list was on home and
unconditionally remove from latest.

New setting explicitly only removes from latest list but leaves the
category list alond
2018-02-22 09:56:35 +11:00
Jeff Wong
d2b518c61c QR code display fix on dark backgrounds (#5613)
https://meta.discourse.org/t/2fa-qr-code-not-visible-on-dark-theme/81152?u=awole20
2018-02-21 23:23:47 +01:00
Vinoth Kannan
2b509eaa91
Merge branch 'master' into pm-tags 2018-02-21 23:55:59 +05:30
Régis Hanol
4e7244d8d9 FIX: never open internal links in a new tab when user prefers opening external links in a new tab 2018-02-21 17:51:53 +01:00
Vinoth Kannan
d4b2e840cb remove unwanted code 2018-02-21 20:19:19 +05:30
Vinoth Kannan
84ce1acfef FEATURE: Allow staffs to tag PMs 2018-02-21 20:11:46 +05:30
Guo Xiang Tan
14f3594f9f Review Changes for f4f8a293e7. 2018-02-21 14:55:49 +08:00
Jeff Wong
f4f8a293e7 FEATURE: Implement 2factor login TOTP
implemented review items.

Blocking previous codes - valid 2-factor auth tokens can only be authenticated once/30 seconds.
I played with updating the “last used” any time the token was attempted but that seemed to be overkill, and frustrating as to why a token would fail.
Translatable texts.
Move second factor logic to a helper class.
Move second factor specific controller endpoints to its own controller.
Move serialization logic for 2-factor details in admin user views.
Add a login ember component for de-duplication
Fix up code formatting
Change verbiage of google authenticator

add controller tests:
second factor controller tests
change email tests
change password tests
admin login tests

add qunit tests - password reset, preferences

fix: check for 2factor on change email controller
fix: email controller - only show second factor errors on attempt
fix: check against 'true' to enable second factor.

Add modal for explaining what 2fa with links to Google Authenticator/FreeOTP

add two factor to email signin link

rate limit if second factor token present

add rate limiter test for second factor attempts
2018-02-21 09:04:07 +08:00
Régis Hanol
60ec483caa FIX: include title in local onebox when linking to a different topic 2018-02-19 22:40:14 +01:00