David Taylor
dbcf05d62c
DEV: Code style improvements following review
...
Followup to 05ee1d1aba
2019-02-19 20:02:29 +00:00
Robin Ward
34b2157b8c
FIX: Slow test (deadlock)
...
It was getting caught in a `DistributedMutex` deadlock (twice!), which
meant this test was taking 120s to run.
I'm not sure why queue jobs was turned off here, because when I turn it
on the test passes and takes <2s instead.
2019-02-19 12:31:23 -05:00
Vinoth Kannan
563b953224
DEV: Add 'backfill_etags_' to the method name since it also backfilling the etags
2019-02-19 21:54:35 +05:30
David Taylor
7878e5007a
FIX: Refactor to prevent themes affecting core stylesheets ( #7029 )
...
If a theme setting contained invalid SCSS, it would cause an error 500 on the site, with no way to recover. This commit stops loading theme settings in the core stylesheets, and instead only loads the color scheme variables. This change also makes `common/foundation/variables.scss` available to themes without an explicit import.
2019-02-19 15:55:59 +00:00
Joffrey JAFFEUX
9ade04b709
FIX: removes legacy browsers-refresh button ( #7028 )
2019-02-19 16:38:21 +01:00
Gerhard Schlager
b3ab0e5753
FIX: moment_js locale files for zh_CN and zh_TW were not found
...
moment_js uses a different format for locale names in plugins and files in core. Follow-up to 4799cf2811
2019-02-19 16:08:06 +01:00
Gerhard Schlager
4799cf2811
FIX: moment_js locale files provided by plugins were ignored
2019-02-19 15:28:47 +01:00
Gerhard Schlager
84c56e16f9
REFACTOR: Use keyword argument for fallback_to_english flag
2019-02-19 15:28:47 +01:00
David Taylor
05ee1d1aba
FEATURE: Added settings/translations support to theme editor UI ( #7026 )
...
- These advanced fields are hidden behind an 'advanced' button, so will not affect normal use
- The editor has been refactored into a component, and styling cleaned up so menu items do not overlap on small screens
- Styling has been added to indicate which fields are in use for a theme
- Icons have been added to identify which fields have errors
2019-02-19 12:56:01 +00:00
Joffrey JAFFEUX
0616837a5d
UX: moves wizard's "Finish" button to the left of back and next ( #7027 )
...
This was done to avoid clicking finish when clicking fast on next.
2019-02-19 13:32:01 +01:00
Joffrey JAFFEUX
8a4cd15e46
REFACTOR: topic model ( #7020 )
2019-02-19 10:13:46 +01:00
Joffrey JAFFEUX
15fd875855
REFACTOR: color-scheme-color model ( #7019 )
2019-02-19 09:31:26 +01:00
Joffrey JAFFEUX
cba0dd33ee
REFACTOR: admin-customize-color ( #7018 )
2019-02-19 09:31:11 +01:00
Joffrey JAFFEUX
2c6bf184bc
REFACTOR: admin-badge-preview ( #7017 )
2019-02-19 09:30:52 +01:00
Joffrey JAFFEUX
3bf61fca66
REFACTOR: admin-user-field-item ( #7016 )
2019-02-19 09:30:38 +01:00
Joffrey JAFFEUX
ee692414ce
REFACTORING: admin-edit-badge-groupings ( #7015 )
2019-02-19 09:30:24 +01:00
Vinoth Kannan
bf2059baf5
SPEC: check enqueued jobs size instead of using mocks
2019-02-19 13:14:06 +05:30
Vinoth Kannan
76696b22fe
DEV: call 'enqueue_hooks' method only if active webhooks exist
2019-02-19 12:47:57 +05:30
Vinoth Kannan
27e7f2bee0
DEV: call 'enqueue_hooks' method only if active webhooks exist
2019-02-19 12:43:08 +05:30
Vinoth Kannan
f2c3415548
FIX: Should not generate payload until active webhooks are exist
2019-02-19 12:23:42 +05:30
Guo Xiang Tan
8cd4ceba49
DEV: Remove unnecessary Sidekiq.unpause! during backup.
2019-02-19 14:01:13 +08:00
Guo Xiang Tan
adbc87857e
DEV: Fix randomly failing test.
...
Even if a thread is alive in the loop check, it may be dead by the
time `Thread#wakeup` is called on it.
2019-02-19 13:34:52 +08:00
Sam Saffron
83f13ecf82
FEATURE: bump onebox dependency
...
- Adds support of kaltura oneboxes
- Adds support for typeform oneboxes
2019-02-19 15:22:43 +11:00
Guo Xiang Tan
bf21ebaecc
DEV: Allow custom value when pausing sidekiq to aid in debugging.
...
Sometimes, it is useful to know what caused Sidekiq to be paused.
2019-02-19 10:55:53 +08:00
Guo Xiang Tan
c29076152d
PERF: Reduce hit to Redis server when keeping a site in reaonly mode.
2019-02-19 10:29:08 +08:00
Guo Xiang Tan
86a2172bda
DEV: Fix heisentest.
...
Unpause sidekiq before clearning up all threads.
2019-02-19 08:21:51 +08:00
Kris
4f5aebc338
UX: reduce subcategory badge spacing
2019-02-18 19:04:36 -05:00
Joffrey JAFFEUX
c08b2ddecf
FIX: stricter matching on local-dates ( #7023 )
2019-02-18 22:39:45 +01:00
Gerhard Schlager
08ae73f868
Fix typo
2019-02-18 16:51:57 +01:00
Gerhard Schlager
99ad61afb7
FEATURE: Trigger an event after a backup restore
2019-02-18 11:48:03 +01:00
Arpit Jalan
50f833def0
fix the build
...
JsPrettier on Sublime was failing because: https://github.com/jonlabelle/SublimeJsPrettier/issues/157#issuecomment-458175837
2019-02-18 11:52:11 +05:30
Arpit Jalan
dc2776bcdd
FIX: do not show "move to new PM" option to moderators
2019-02-18 11:35:00 +05:30
Jeff Atwood
052eaed16a
lighten embed blockquote style for consistency
2019-02-17 21:00:46 -08:00
Jeff Atwood
dfba36fdca
remove bgcolor from embed quotes for consistency
2019-02-17 20:57:27 -08:00
Arpit Jalan
a960cbd97f
fix the build ❤️
2019-02-18 10:00:17 +05:30
Arpit Jalan
7cb194f2db
Add more specs for word watcher service.
2019-02-18 09:55:16 +05:30
Sam
0e6d0b0f8e
FEATURE: always update docker image for dev prior to launching
...
Previously people could stay stuck on old dev images, this ensures they
are always on latest when booting
2019-02-18 13:12:00 +11:00
Guo Xiang Tan
7da7a30e02
PERF: Restore exists? in favor of blank?.
...
Regression from dcd7b92532
2019-02-18 10:04:21 +08:00
Gerhard Schlager
24369a8166
Improve phpBB3 importer
...
* Log errors when mapping of posts, messages, etc. fails
* Allow permalink normalizations for old subfolder installation
* Disable importing of polls for now. It's broken.
2019-02-17 23:20:20 +01:00
Gerhard Schlager
8d5dfe1e01
FIX: Don't import parts of the email address as name
2019-02-17 22:59:18 +01:00
David Taylor
f04471e422
REFACTOR: Proxy letter avatars in rails instead of nginx
...
Co-authored-by: Sam Saffron <sam.saffron@gmail.com>
Co-authored-by: David Taylor <david@taylorhq.com>
This gives more control over the request. In particular we can easily
lookup DNS dynamically, instead of only upon NGINX startup.
Previously, NGINX was looking up IP for the letter avatar service and
caching the CDN IP address, this caused issues if CDN changed IP, in
which letter avatars would be broken till a container restarted.
NGINX config has been updated to add caching. This change will require
a container rebuild.
The proxy will now function in development environments, so the patch
for `letter_avatar_proxy` has been removed.
2019-02-18 08:46:56 +11:00
Bianca Nenciu
944f8249a3
FIX: Add missing translation. ( #7014 )
2019-02-18 08:28:32 +11:00
Simon Cossar
a76d6eb186
Replace 'topics' with 'messages' in group notification level copy ( #7013 )
2019-02-15 16:08:37 -08:00
Gerhard Schlager
b0862bd15d
FIX: Push notifications could fail with UnauthorizedRegistration
...
The webpush gem by default sets the expiration date of the JWT token to exactly 24 hours in the future. That's not really needed because the token isn't reused. And it might cause UnauthorizedRegistration if the server's clock isn't 100% correct, because the maximum allowed value is 24 hours.
2019-02-15 21:12:09 +01:00
Gerhard Schlager
17f1a76570
FIX: Delete push subscription on MismatchSenderId error
...
This should prevent repeated MismatchSenderId warnings when the VAPID keys have changed.
2019-02-15 21:12:09 +01:00
peterlamber
159dd69fcb
UX: make adding permissions more visible and intuitive to click. ( #6999 )
2019-02-15 12:01:10 -05:00
Arpit Jalan
99c6db21e6
FEATURE: allow blocking emojis ( #7011 )
...
https://meta.discourse.org/t/blocking-emojis-wont-work/105853
2019-02-15 20:55:48 +05:30
Dan Ungureanu
a423a9383f
FIX: Stop autocomplete for invalid usernames. ( #7005 )
2019-02-15 11:29:26 +11:00
Sam
f8b70f4ca3
FIX: unable to create new categories
...
Previous attempt at 70adb940
2019-02-15 10:24:29 +11:00
Vinoth Kannan
0472bd4adc
FIX: Remove 'backfill_etags' keyword argument from 'uploads:missing' rake task
...
And etags backfilling code is optimized
2019-02-15 00:34:35 +05:30
