Joffrey JAFFEUX
0807751390
REFACTOR: poll-pie-chart widget ( #8415 )
...
This commit mostly get rid of the later() call and encapsulate all pie chart display logic inside discourse-poll-pie-canvas widget instead of sharing it between discourse-poll-pie-chart and discourse-poll-pie-canvas
2019-11-27 00:10:43 +01:00
Joffrey JAFFEUX
cfa6ec8034
FIX: improves recurring by ensuring DST is computed correctly ( #8410 )
2019-11-25 23:32:24 +01:00
Mark VanLandingham
a3157f0e38
FIX: The build; ran prettier ( #8412 )
2019-11-25 12:12:44 -06:00
Mark VanLandingham
b92a8131c0
FEATURE: Pie chart option for poll results ( #8352 )
2019-11-25 11:51:01 -06:00
Benjamin Hipple
c75ebfee57
UX: Rename 'Hide results' to 'Show vote' in polls ( #8403 )
...
For various reasons, users may want to change their response to a poll.
Currently they have permission to do so, however it is hidden behind the 'Hide
results' button. Since what this button does is take the user back to the vote
panel, it seems more appropriate to name it 'Show vote', where it becomes
obvious that it can be modified and re-submitted.
As discussed here [1], there are mulitple users, myself included, who assumed
that editing a misclick response was impossible. This improves the label to make
it more descriptive of the action actually being taken.
[1] https://meta.discourse.org/t/ability-to-remove-my-choice-in-a-poll/53642/6
2019-11-25 12:26:19 +01:00
Rafael dos Santos Silva
fd0025a735
FEATURE: Add export poll button ( #8370 )
...
This PR aims to make poll results easily exportable to staff in a CSV format, so they can be analyzed in external software.
It also makes the export data easily customizable by allowing users to leverage any data explorer query to generate the report. By default, we use a query that ships with data explorer, but user can change the ID in settings or use 0 to disable this feature.
One potential upgrade is using the recent work that allows arbitrary group to run data explorer and allow all the groups with access to the configured query to also export polls, but that can be added later.
Co-Authored-By: Joffrey JAFFEUX <j.jaffeux@gmail.com>
2019-11-22 16:06:39 -03:00
Joffrey JAFFEUX
c498780479
FIX: prevents exception and more duplicates ( #8396 )
2019-11-22 19:43:37 +01:00
Joffrey JAFFEUX
a40bc1e92b
FIX: prevents timezone to show duplicated zones in preview
...
It could happen if you have Etc/UTC in default settings, and timezone="UTC" on date, the equality check is now more strict.
2019-11-22 17:14:27 +01:00
Joffrey JAFFEUX
3d1b6b6729
FIX: handle german quotes in discourse local-dates ( #8386 )
...
https://meta.discourse.org/t/insert-date-timezone-is-always-utc-my-timezone-is-ignored/126307
2019-11-21 11:43:35 +01:00
David Taylor
22e713d2b0
FIX: Add skip_validations in one more place for narrative bot plugin
...
Followup to bbb814e58e
2019-11-20 15:43:42 +00:00
David Taylor
bbb814e58e
FIX: Allow advanced tutorial when title emojis are disabled
...
We already skip validations for other uses of PostCreator in the narrative bot, so this commit adds it in the `reply_to` action as well
2019-11-20 15:29:06 +00:00
Joffrey JAFFEUX
e6442a2d2f
FIX: we don't need to refresh dates so often ( #8367 )
2019-11-18 10:04:07 +01:00
Joffrey JAFFEUX
45648e46ba
FIX: attempts to be correct about dst when using recurrence ( #8366 )
2019-11-18 10:02:58 +01:00
Sam Saffron
e2ccb0c608
DEV: remove NGINX performance report
...
This report is no longer supported or tested, it was moved to:
https://github.com/SamSaffron/discourse-nginx-performance-report
The new home for the performance report means this is no longer an official
Discourse plugin
2019-11-18 15:30:57 +11:00
Penar Musaraj
20f5a062f4
Fix Prettier in poll plugin
2019-11-15 11:01:22 -05:00
romanrizzi
f87d38fc7c
Use correct variable name
2019-11-14 17:46:20 -03:00
Blake Erickson
73e33ce243
DEV: send url string to FileHelper and refactor another open-uri call
...
FileHelper.download requires a string not a URI. I also found another
instance of using open-uri directly and swapped it out to use
FileHelper.
I also updated it to not `read` a file if it comes back nil.
Follow up to: fe01099a38
2019-11-14 08:25:30 -07:00
Gerhard Schlager
f72730703a
Update translations
2019-11-14 15:41:42 +01:00
Blake Erickson
fe01099a38
DEV: Be sure to read the file into string before base64
...
Follow up to: 08b4753843
2019-11-14 05:55:36 -07:00
Blake Erickson
08b4753843
DEV: Use FileHelper instead for downloading narrative bot avatar
...
Follow up to
b69450bee2
2019-11-14 05:23:51 -07:00
Blake Erickson
b69450bee2
FIX: need to require open-uri for discourse-narrative-bot plugin
...
By requiring open-uri this will fix the following error:
```
NoMethodError (private method `open' called for #<URI::Generic...
```
also switched to the shorter syntax and removed default options. Since
ruby 2.4 redirect is on by default.
2019-11-13 18:11:50 -07:00
Roman Rizzi
c63e84dc62
FEATURE: Send a message to new TL2 users and point them to the advanced tutorial ( #8335 )
...
* FEATURE: Send a message to new TL2 users and point them to the advanced tutorial
* DEV: Use a method to find the discobot user
2019-11-13 18:31:49 -03:00
Robin Ward
f518065654
FIX: computed is part of @ember/object not @ember/object/computed
2019-11-13 11:58:09 -05:00
Arpit Jalan
5ff84be8cc
FIX: do not strip nil string
2019-11-13 16:58:14 +05:30
Jarek Radosz
17bca00661
DEV: Run prettier
2019-11-12 12:07:19 +01:00
Jarek Radosz
5d4b240453
DEV: Provide radix argument to parseInt ( #8281 )
...
* DEV: Provide radix 10 argument to parseInt
* DEV: Provide radix 16 argument to parseInt
* DEV: Remove unnecessary parseInt calls
* Fix year formatting
parseInt was used here to convert decimals to ints
2019-11-12 10:47:42 +01:00
Robin Ward
e39d89ecd9
REFACTOR: Remove InputValidation which was simply an Ember.Object
2019-11-11 15:48:56 -05:00
Robin Ward
da04c602ba
REFACTOR: Remove debounce to discourseDebounce
...
Otherwise it can be confused with the ember debounce
2019-11-11 13:34:01 -05:00
Kris
b066a4128d
Adding a text-overflow: ellipsis; mixin and related cleanup
2019-11-06 14:00:29 -05:00
Neil Lalonde
b151963f18
Update translations
2019-11-06 10:43:13 -05:00
Gerhard Schlager
94a34af702
Update translations
2019-11-05 16:52:48 +01:00
Jarek Radosz
d43e7354ec
DEV: Convert <button> tags to {{d-button}} components ( #8224 )
...
* DEV: Convert <button> tags to {{d-button}}
* Fixes
2019-11-04 11:23:54 +01:00
Robin Ward
90f934a660
REFACTOR: Use a module for Ember.isEmpty
2019-11-01 13:50:15 -04:00
Robin Ward
8d34f4bbd9
Revert "Revert Ember.run refactors"
...
This reverts commit fcb1ca52f9
2019-10-30 09:48:24 -04:00
Robin Ward
fcb1ca52f9
Revert Ember.run refactors
...
This reverts commit 5ca60fcb6b
2019-10-29 17:10:47 -04:00
Robin Ward
5ca60fcb6b
REFACTOR: Use imports for Ember.run
2019-10-29 15:31:56 -04:00
Robin Ward
7744b636e9
FIX: Handle nil case for avatar, just in case
2019-10-24 14:02:51 -04:00
Robin Ward
8b4e71cb21
FIX: Allow avatar downloads to follow redirects
2019-10-24 14:01:54 -04:00
Robin Ward
2c0efac25e
FIX: Broken certificates
2019-10-24 12:39:58 -04:00
Bianca Nenciu
690db4fd36
FIX: Show poll voters in Oneboxed posts. ( #7768 )
2019-10-24 14:00:25 +03:00
Robin Ward
6287eccb35
REFACTOR: Remove Ember.Controller in favor of import
2019-10-23 13:06:54 -04:00
Robin Ward
a8a76198b1
REFACTOR: Remove Ember.Component global variable
...
Use imports instead.
2019-10-23 12:30:52 -04:00
Roman Rizzi
835d2be4da
FIX: Rate limit and hijack certificate generation. ( #8215 )
...
To eliminate a DDOS attack vector, we're taking the following measures:
The endpoint will be rate-limited to 3 requests every 60 seconds (per user).
A 24 hours max-age cache header is sent with the response.
The route will be hijacked to generate the certificate in the background.
2019-10-21 13:14:15 -03:00
Joffrey JAFFEUX
54bc2bdba7
UX: emphasizes on local-dates being UTC in excerpts ( #8208 )
2019-10-17 10:18:06 -04:00
Kris
4338515a85
fix poll test
2019-10-16 21:53:37 -04:00
Kris
b005377d0a
UX: add newline after closing poll tag for poll builder
2019-10-16 21:40:42 -04:00
Robin Ward
74207ef03a
Refactor search_answer to be dynamically inserted so it can be changed
2019-10-16 14:37:17 -04:00
Robin Ward
a37dafdd4d
FIX: Use the quote generator in the example text
...
This way if a plugin customizes the quotes the example will match.
2019-10-16 13:40:44 -04:00
Krzysztof Kotlarek
e2f9b7dd6f
FIX: Narrative Bot certificates are ERB templates ( #8174 )
...
There are at least two ways of rendering templates outside of the controller. The first one is Rails way enabled with Rails 5 https://evilmartians.com/chronicles/new-feature-in-rails-5-render-views-outside-of-actions
The downside of this method is that all variables need to be passed as params (I could find a way to pass the whole context)
Another way is to use instance_eval described in Erubi documentation
https://github.com/jeremyevans/erubi#usage - it works perfectly fine, however, I didn't feel very confident about using eval unless necessary.
An additional benefit of using `ApplicationController.render` is that if Rails would change the ERB engine in the future, this code should still work.
If you want to test it on your local, you need to be signed in and then that two URLs are generating certificates:
http://localhost:3000/discobot/certificate.svg?date=Oct+07+2019&type=standard&user_id=1
http://localhost:3000/discobot/certificate.svg?date=Oct+07+2019&type=advanced&user_id=1
Dev: https://dev.discourse.org/t/discourse-narrative-bot-should-not-be-storing-giant-strings/17130
2019-10-09 17:45:01 +11:00
Gerhard Schlager
3dfe9f3b8d
Update translations
2019-10-08 12:25:24 +02:00
