Commit Graph

29836 Commits

Author SHA1 Message Date
Sam
e0be5145cf FIX: correct readonly timeout
So it only applies in readonly mode
2018-09-20 15:15:46 +10:00
Guo Xiang Tan
195bd02fce FIX: Avoid race condition when enqueuing job. 2018-09-20 11:24:01 +08:00
Arpit Jalan
72be638728 FEATURE: add external details to user fields 2018-09-20 08:10:51 +05:30
Kris
dfbc93aa2e Prevent post date from overflowing with long usernames 2018-09-19 18:53:48 -04:00
Jeff Wong
d5442fbf08 FIX: do not send tl1 welcome message when a user has the basic user badge 2018-09-19 12:53:36 -07:00
Gerhard Schlager
469a2c36ed FIX: Always unpause Sidekiq after backup and restore
* Logs exceptions during the cleanup phase, but doesn't stop executing subsequent cleanup tasks.
* Notifies the user at the end of the cleanup phase, so that the log contains possible errors during that phase.
2018-09-19 20:35:43 +02:00
Gerhard Schlager
681262ddce FIX: Backup logs were usually missing the first few lines
And because of debouncing, the log wasn't always reset at the beginning of a backup or restore.
2018-09-19 20:27:35 +02:00
Gerhard Schlager
18d5d51d98 UX: Remove double scrollbars from backup logs
* Removes the wrapping, because the log is easier to read without it.
* Fixes the automatic scrolling to the bottom, which didn't work anymore
2018-09-19 20:27:34 +02:00
Joe
8d6ccde402
UX: removes bottom margins from inputs in admin controls 2018-09-20 00:32:41 +08:00
Joe
2144009520
UX: ensure ac-wrap input height matches other inputs 2018-09-20 00:02:45 +08:00
Joe
0010e7ddd2
UX: better padding for multi-select items 2018-09-19 23:56:26 +08:00
Joe
026bab116a
UX: label alignment for Firefox / IE 2018-09-19 23:48:48 +08:00
Guo Xiang Tan
d41f74578a Fix JS build. 2018-09-19 23:12:34 +08:00
Guo Xiang Tan
767f27929d Rename Jobs::RecoverPostUploads to rerun the job take 2. 2018-09-19 22:40:32 +08:00
Joe
b64436ba09
UX: select-kit filter input size fix 2018-09-19 22:05:56 +08:00
Guo Xiang Tan
6dbe1d832d Rename Jobs::RecoverPostUploads to rerun the job.
Running a migration to destroy the onceoff job doesn't work
because an instance running the old code may execute the job.
2018-09-19 21:59:44 +08:00
Joe
0ac64b6d50
UX: radio / checkbox inputs margin fix 2018-09-19 21:22:40 +08:00
Joe
8fb50a7e8b
UX: last-seen input alignment fix 2018-09-19 21:20:04 +08:00
Joe
9e9fdac023
UX: multi-select items alignment fixes 2018-09-19 21:14:27 +08:00
Joe
acd18ff9d8
Fixes typo 2018-09-19 21:08:03 +08:00
Joe
e844fa5370
UX: general cleanup of inputs, buttons and select elements - part 1 2018-09-19 20:37:04 +08:00
Guo Xiang Tan
667e68ec58 Prefer create over create! when not checking for response. 2018-09-19 18:22:54 +08:00
Guo Xiang Tan
d4bd04c3a7 Allow purge_deleted_uploads_grace_period_days to be shadowed. 2018-09-19 17:49:00 +08:00
Guo Xiang Tan
d403883d16 DEV: Improve specs for 293cf600f0. 2018-09-19 16:03:52 +08:00
Guo Xiang Tan
293cf600f0 FIX: Use a tmp file in UploadRecovery for local store. 2018-09-19 15:47:15 +08:00
Sam
e0e6dae6a7 minor cleanup to previous commit from code review 2018-09-19 16:07:29 +10:00
Sam
5302709343 FIX: in redis readonly raise an exception from DistributedMutex
If we detect redis is in readonly we can not correctly get a mutex
raise an exception to notify caller

When getting optimized images avoid the distributed mutex unless
for some reason it is the first call and we need to generate a thumb

In redis readonly no thumbnails will be generated
2018-09-19 15:50:58 +10:00
Arpit Jalan
80229668f9 bump onebox version
- FIX: user correct steam placeholder image url
- catch up Ruby 2.6
2018-09-19 10:06:43 +05:30
Guo Xiang Tan
95293a6997 Re-run Jobs::RecoverPostUploads.
Previously, `UploadRecovery` did not account for uploads which
may be present in links. This meant that attachments were not
recovered.
2018-09-19 12:17:01 +08:00
Guo Xiang Tan
bc7f58191e FIX: UploadRecovery should look at links too. 2018-09-19 11:52:57 +08:00
Guo Xiang Tan
4a92c5b2d6 UploadRecovery should recover attachments too. 2018-09-19 10:44:36 +08:00
Guo Xiang Tan
5a9b029014 Improve error messaging in SocketServer. 2018-09-19 09:11:10 +08:00
Jeff Atwood
b33a623774 very minor copyedit 2018-09-18 15:48:48 -07:00
Vinoth Kannan
4383afb769
Merge pull request #6413 from vinothkannans/log-entity-export
FEATURE: Log entity export in staff logs
2018-09-19 03:18:28 +05:30
Vinoth Kannan
9281b72308 FEATURE: Log entity export in staff logs 2018-09-19 03:16:45 +05:30
Jeff Atwood
f43b5bb3c1 considerably simplify copy for change owner 2018-09-18 14:15:08 -07:00
Kris
e95d6a12c5 prettier 2018-09-18 13:39:58 -04:00
Kris
8bfb016386 remove trailing spaces 2018-09-18 13:25:50 -04:00
Kris
d20a174a6b UX: Lighter style for category and tag dropdown nav 2018-09-18 13:11:00 -04:00
Kris
4cf3ef53bc Prevent spinner in tag dropdown from being squished 2018-09-18 11:27:01 -04:00
Joffrey JAFFEUX
a713c0d366
FIX: ensures onSelect/onDeselect are called
This commit also add a FIX and a test for toolbar-popup-menu-options which had a behavior slightly specific.
2018-09-18 11:31:23 +02:00
Arpit Jalan
fadcd36f92 FIX: do not treat ignore_redirects domains as blacklisted
This fix prevents domains present in `ignore_redirects` to be treated as
blacklisted domains and makes sure that onboxing happens for those domains.
Issue reported here: https://meta.discourse.org/t/steam-store-oneboxing-no-longer-works/97266
2018-09-18 10:38:02 +05:30
Guo Xiang Tan
ce6a0a5e9e FIX: Moving upload to tombstone should update modification time.
A upload created a long time ago will be nuked from the tombstone
immediately if it gets deleted.
2018-09-18 10:48:29 +08:00
Guo Xiang Tan
f2fbf1fdb0 DEV: Basic specs for TagGroupsController. 2018-09-18 08:22:03 +08:00
Sam
7d6b348d0b SECURITY: correct XSS on long topic titles 2018-09-18 08:54:44 +10:00
Sam
0e9841b995 SECURITY: remove admin memory diagnostics routes 2018-09-18 08:35:09 +10:00
Joffrey JAFFEUX
2ff2c49908 Revert "FIX: ensures onSelect/onDeselect are called"
This reverts commit 52eed73294.
2018-09-17 22:14:41 +02:00
Kris
7f420b61cb Removing unneeded theme intro text 2018-09-17 12:00:20 -04:00
Neil Lalonde
6f1b8ad16d FIX: tag groups page should only be visible to staff
No security concern here because nothing private was visible,
and no actions could be taken by non-staff users.
2018-09-17 11:41:18 -04:00
Gerhard Schlager
fb9e3e6423 Update aws-sdk-s3
In preparation for https://github.com/discourse/discourse/pull/6345
2018-09-17 17:39:46 +02:00