mirror of
https://github.com/discourse/discourse.git
synced 2024-11-22 08:49:06 +08:00
ad7d5426d8
⚠️ This commit is a revert of a revert due to a migration which was causing `{}` metadata to be transformed into `{"value": [null]}`. The new migration shouldn't cause this and will also clean the existing errors, there shouldn't be any data loss given the affected fields where not containing actual data. We might want to stop storing these empty fields in the future.
To achieve it, this commit does the following:
- create a new `groups field`, ideally we would have reused the existing group field, but many automations now have the expectation that this field will return a group id and not an array of group ids, which makes it a dangerous change
- alter the code in `post_created_edited` to use this new groups field and change the logic to use an array
- migrate the existing group fields post_created_edited automations to change name from `restricted_group` to `restricted_groups`, the component from `group` to `groups` and the metadata from `{"value": integer}` to `{"value": [integer]}`
<!-- NOTE: All pull requests should have tests (rspec in Ruby, qunit in JavaScript). If your code does not include test coverage, please include an explanation of why it was omitted. -->
72 lines
2.0 KiB
JavaScript
72 lines
2.0 KiB
JavaScript
import { getOwner } from "@ember/owner";
|
|
import { render } from "@ember/test-helpers";
|
|
import { hbs } from "ember-cli-htmlbars";
|
|
import { module, test } from "qunit";
|
|
import { setupRenderingTest } from "discourse/tests/helpers/component-test";
|
|
import pretender, { response } from "discourse/tests/helpers/create-pretender";
|
|
import selectKit from "discourse/tests/helpers/select-kit-helper";
|
|
import AutomationFabricators from "discourse/plugins/automation/admin/lib/fabricators";
|
|
|
|
module("Integration | Component | da-groups-field", function (hooks) {
|
|
setupRenderingTest(hooks);
|
|
|
|
hooks.beforeEach(function () {
|
|
this.automation = new AutomationFabricators(getOwner(this)).automation();
|
|
|
|
pretender.get("/groups/search.json", () => {
|
|
return response([
|
|
{
|
|
id: 1,
|
|
name: "cats",
|
|
flair_url: "fa-bars",
|
|
flair_bg_color: "CC000A",
|
|
flair_color: "FFFFFA",
|
|
},
|
|
{
|
|
id: 2,
|
|
name: "dogs",
|
|
flair_url: "fa-bars",
|
|
flair_bg_color: "CC000A",
|
|
flair_color: "FFFFFA",
|
|
},
|
|
]);
|
|
});
|
|
});
|
|
|
|
test("set value", async function (assert) {
|
|
this.field = new AutomationFabricators(getOwner(this)).field({
|
|
component: "groups",
|
|
});
|
|
|
|
await render(
|
|
hbs`<AutomationField @automation={{this.automation}} @field={{this.field}} />`
|
|
);
|
|
|
|
await selectKit().expand();
|
|
await selectKit().selectRowByValue(1);
|
|
|
|
assert.deepEqual(this.field.metadata.value, [1]);
|
|
});
|
|
|
|
test("supports a maxmimum value", async function (assert) {
|
|
this.field = new AutomationFabricators(getOwner(this)).field({
|
|
component: "groups",
|
|
extra: { maximum: 1 },
|
|
});
|
|
|
|
await render(
|
|
hbs`<AutomationField @automation={{this.automation}} @field={{this.field}} />`
|
|
);
|
|
|
|
await selectKit().expand();
|
|
await selectKit().selectRowByValue(1);
|
|
|
|
assert.deepEqual(this.field.metadata.value, [1]);
|
|
|
|
await selectKit().expand();
|
|
await selectKit().selectRowByValue(2);
|
|
|
|
assert.deepEqual(this.field.metadata.value, [2]);
|
|
});
|
|
});
|