mirror of
https://github.com/discourse/discourse.git
synced 2024-12-18 21:05:58 +08:00
5bff65aa69
Both of the commits in this PR are meant to fix the problem of invalid
option being shown in the flair chooser. An invalid option can be shown
if at some point it was a valid one - a group with a flair that was
later changed by an admin and flair was removed. The other option an
invalid option can be selected is if the user had a primary group when
the migration ran and copied the same value to the flair_group_id
column.
* FIX: Set flair_group_id only if group has flair
Follow up to 4ba93aac66.
* FIX: Do not show invalid option in flair chooser
If selected flair group became unavailable because the flair was removed
then the option would still be selected and visible as an ID only.
15 lines
398 B
Ruby
15 lines
398 B
Ruby
# frozen_string_literal: true
|
|
|
|
class SetUsersFlairGroupId < ActiveRecord::Migration[6.1]
|
|
def change
|
|
execute <<~SQL
|
|
UPDATE users
|
|
SET flair_group_id = primary_group_id
|
|
FROM groups
|
|
WHERE users.primary_group_id = groups.id AND
|
|
users.flair_group_id IS NULL AND
|
|
(groups.flair_icon IS NOT NULL OR groups.flair_upload_id IS NOT NULL)
|
|
SQL
|
|
end
|
|
end
|