mirror of
https://github.com/discourse/discourse.git
synced 2024-12-18 23:55:57 +08:00
f0c6dd5682
* FIX: Fix a bug that is accessing the values in a hash wrongly and write tests
I decided to write tests in order to be confident in my refactor that's in the next commit.
Meanwhile I have discovered a potential bug. The `title_attr` key was accessed as a string,
but all the keys are actually symbols so it was never evaluated to be true.
irb(main):025:0> d = {key: 'value'}
=> {:key=>"value"}
irb(main):026:0> d['key']
=> nil
irb(main):027:0> d[:key]
=> "value"
* DEV: Extract methods for readability
I will be adding a new method following the conventions in place for adding a new normalizer. And this will make the readability of the `raw` block even more difficult; so I am extracting self contained private methods beforehand.
* FEATURE: Parse JSON-LD and introduce Movie object
JSON LD data is very easily transferable to Ruby objects because they contain types. If these types are mapped to Ruby objects, it is also better to make all the parsed data very explicit and easily extendable.
JSON-LD has many more standardized item types, with a full list here: https://schema.org/docs/full.html
However in order to decrease the scope, I only adapted the movie type.
* DEV: Change inheritance between normalizers
Normalizers are not supposed to have an inheritance relationships amongst each other. They are all normalizers, but all normalizing separate protocols. This is why I chose to extract a parent class and relieve Open Graph off that responsibility. Removing the parent class altogether could also a possibility, but I am keeping the scope limited to having a more accurate representation of the normalizers while making it easier to add a new one.
* Lint changes
* Bring back the Oembed OpenGraph inheritance
There is one test that caught that this inheritance was necessary. I still think modelling wise this inheritance shouldn't exist, but this can be tackled separately.
* Return empty hash if the json received is invalid
Before this change if there was a parsing error with JSON it would throw an exception. The goal of this commit is to rescue that exception and then log a warning. I chose to use Discourse's logger wrapper `warn_exception` to have the backtrace and not just used Rails logger. I considered raising an `InvalidParameters` error however if the JSON here is invalid it should not block showing of the Onebox, so logging is enough.
* Prep to support more JSONLD schema types with case
* Extract mustache template object created from JSONLD
47 lines
773 B
Ruby
47 lines
773 B
Ruby
# frozen_string_literal: true
|
|
|
|
module Onebox
|
|
class Movie
|
|
def initialize(json_ld_data)
|
|
@json_ld_data = json_ld_data
|
|
end
|
|
|
|
def name
|
|
@json_ld_data['name']
|
|
end
|
|
|
|
def image
|
|
@json_ld_data['image']
|
|
end
|
|
|
|
def description
|
|
@json_ld_data['description']
|
|
end
|
|
|
|
def rating
|
|
@json_ld_data.dig('aggregateRating', 'ratingValue')
|
|
end
|
|
|
|
def genres
|
|
@json_ld_data['genre']
|
|
end
|
|
|
|
def duration
|
|
return nil unless @json_ld_data['duration']
|
|
|
|
Time.parse(@json_ld_data['duration']).strftime '%H:%M'
|
|
end
|
|
|
|
def to_h
|
|
{
|
|
name: name,
|
|
image: image,
|
|
description: description,
|
|
rating: rating,
|
|
genres: genres,
|
|
duration: duration
|
|
}
|
|
end
|
|
end
|
|
end
|