mirror of
https://github.com/discourse/discourse.git
synced 2024-12-24 21:15:21 +08:00
57ea56ee05
We have all these calls to Group.refresh_automatic_groups! littered throughout the tests. Including tests that are seemingly unrelated to groups. This is because automatic group memberships aren't fabricated when making a vanilla user. There are two places where you'd want to use this: You have fabricated a user that needs a certain trust level (which is now based on group membership.) You need the system user to have a certain trust level. In the first case, we can pass refresh_auto_groups: true to the fabricator instead. This is a more lightweight operation that only considers a single user, instead of all users in all groups. The second case is no longer a thing after #25400.
96 lines
2.5 KiB
Ruby
96 lines
2.5 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
RSpec.describe BasicGroupSerializer do
|
|
subject(:serializer) { described_class.new(group, scope: guardian, root: false) }
|
|
|
|
let(:guardian) { Guardian.new }
|
|
fab!(:group)
|
|
|
|
describe "#display_name" do
|
|
describe "automatic group" do
|
|
let(:group) { Group.find(1) }
|
|
|
|
it "should include the display name" do
|
|
expect(serializer.display_name).to eq(I18n.t("groups.default_names.admins"))
|
|
end
|
|
end
|
|
|
|
describe "normal group" do
|
|
fab!(:group)
|
|
|
|
it "should not include the display name" do
|
|
expect(serializer.display_name).to eq(nil)
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "#bio_raw" do
|
|
subject(:serializer) do
|
|
described_class.new(group, scope: guardian, root: false, owner_group_ids: [group.id])
|
|
end
|
|
|
|
fab!(:group) { Fabricate(:group, bio_raw: "testing :slightly_smiling_face:") }
|
|
|
|
describe "group owner" do
|
|
it "should include bio_raw" do
|
|
expect(serializer.as_json[:bio_raw]).to eq("testing :slightly_smiling_face:")
|
|
expect(serializer.as_json[:bio_excerpt]).to start_with("testing <img")
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "#has_messages" do
|
|
fab!(:group) { Fabricate(:group, has_messages: true) }
|
|
|
|
describe "for a staff user" do
|
|
let!(:guardian) { Guardian.new(Fabricate(:moderator)) }
|
|
|
|
it "should be present" do
|
|
expect(serializer.as_json[:has_messages]).to eq(true)
|
|
end
|
|
end
|
|
|
|
describe "for a group user" do
|
|
fab!(:user) { Fabricate(:user, refresh_auto_groups: true) }
|
|
let(:guardian) { Guardian.new(user) }
|
|
|
|
before { group.add(user) }
|
|
|
|
it "should be present" do
|
|
expect(serializer.as_json[:has_messages]).to eq(true)
|
|
end
|
|
end
|
|
|
|
describe "for a normal user" do
|
|
let(:guardian) { Guardian.new(Fabricate(:user)) }
|
|
|
|
it "should not be present" do
|
|
expect(serializer.as_json[:has_messages]).to eq(nil)
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "#can_see_members" do
|
|
fab!(:group) { Fabricate(:group, members_visibility_level: Group.visibility_levels[:members]) }
|
|
|
|
describe "for a group user" do
|
|
fab!(:user)
|
|
let(:guardian) { Guardian.new(user) }
|
|
|
|
before { group.add(user) }
|
|
|
|
it "should be true" do
|
|
expect(serializer.as_json[:can_see_members]).to eq(true)
|
|
end
|
|
end
|
|
|
|
describe "for a normal user" do
|
|
let(:guardian) { Guardian.new(Fabricate(:user)) }
|
|
|
|
it "should be false" do
|
|
expect(serializer.as_json[:can_see_members]).to eq(false)
|
|
end
|
|
end
|
|
end
|
|
end
|