mirror of
https://github.com/discourse/discourse.git
synced 2024-12-21 09:23:42 +08:00
6e161d3e75
The most common thing that we do with fab! is:
fab!(:thing) { Fabricate(:thing) }
This commit adds a shorthand for this which is just simply:
fab!(:thing)
i.e. If you omit the block, then, by default, you'll get a `Fabricate`d object using the fabricator of the same name.
42 lines
1.2 KiB
Ruby
42 lines
1.2 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
RSpec.describe UploadSerializer do
|
|
subject(:serializer) { UploadSerializer.new(upload, root: false) }
|
|
|
|
fab!(:upload)
|
|
|
|
it "should render without errors" do
|
|
json_data = JSON.parse(serializer.to_json)
|
|
|
|
expect(json_data["id"]).to eql upload.id
|
|
expect(json_data["width"]).to eql upload.width
|
|
expect(json_data["height"]).to eql upload.height
|
|
expect(json_data["thumbnail_width"]).to eql upload.thumbnail_width
|
|
expect(json_data["thumbnail_height"]).to eql upload.thumbnail_height
|
|
expect(json_data["short_path"]).to eql upload.short_path
|
|
end
|
|
|
|
context "when the upload is secure" do
|
|
fab!(:upload) { Fabricate(:secure_upload) }
|
|
|
|
context "when secure uploads is disabled" do
|
|
it "just returns the normal URL, otherwise S3 errors are encountered" do
|
|
UrlHelper.expects(:cook_url).with(upload.url, secure: false)
|
|
serializer.to_json
|
|
end
|
|
end
|
|
|
|
context "when secure uploads is enabled" do
|
|
before do
|
|
setup_s3
|
|
SiteSetting.secure_uploads = true
|
|
end
|
|
|
|
it "returns the cooked URL based on the upload URL" do
|
|
UrlHelper.expects(:cook_url).with(upload.url, secure: true)
|
|
serializer.to_json
|
|
end
|
|
end
|
|
end
|
|
end
|