github-mirror/discourse
github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-21 02:48:09 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
discourse/spec/components
History
Guo Xiang Tan 053cbe3112
PERF: Limit characters used to generate headline for search blurb. 
We determined using the following benchmark script that limiting to 2500 chars would mean a maximum of
25ms spent generating headlines.

```
require 'benchmark/ips'

string = <<~STRING
Far far away, behind the word mountains...
STRING

def sql_excerpt(string, l = 1000000)
  DB.query_single(<<~SQL)
  SELECT TS_HEADLINE('english', left('#{string}', #{l}), PLAINTO_TSQUERY('mountains'))
  SQL
end

def ruby_excerpt(string)
  output = DB.query_single("SELECT '#{string}'")[0]
  Search::GroupedSearchResults::TextHelper.excerpt(output, 'mountains', radius: 100)
end

puts "Ruby Excerpt: #{ruby_excerpt(string)}"
puts "SQL Excerpt: #{sql_excerpt(string)}"
puts

Benchmark.ips do |x|
  x.time = 10

  [1000, 2500, 5000, 10000, 20000, 50000].each do |l|
    short_string = string[0..l]

    x.report("ts_headline excerpt #{l}") do
      sql_excerpt(short_string, l)
    end

    x.report("actionview excerpt #{l}") do
      ruby_excerpt(short_string)
    end
  end

  x.compare!
end
```

```
actionview excerpt 1000:    20570.7 i/s
actionview excerpt 2500:    17863.1 i/s - 1.15x  (± 0.00) slower
actionview excerpt 5000:    14228.9 i/s - 1.45x  (± 0.00) slower
actionview excerpt 10000:    10906.2 i/s - 1.89x  (± 0.00) slower
actionview excerpt 20000:     6255.0 i/s - 3.29x  (± 0.00) slower
ts_headline excerpt 1000:     4337.5 i/s - 4.74x  (± 0.00) slower
actionview excerpt 50000:     3222.7 i/s - 6.38x  (± 0.00) slower
ts_headline excerpt 2500:     2240.4 i/s - 9.18x  (± 0.00) slower
ts_headline excerpt 5000:     1258.7 i/s - 16.34x  (± 0.00) slower
ts_headline excerpt 10000:      667.2 i/s - 30.83x  (± 0.00) slower
ts_headline excerpt 20000:      348.7 i/s - 58.98x  (± 0.00) slower
ts_headline excerpt 50000:      131.9 i/s - 155.91x  (± 0.00) slower
```
2020-08-07 14:36:52 +08:00
..
auth
FIX: use allowlist and blocklist terminology (#10209)
2020-07-27 10:23:54 +10:00
common_passwords
DEV: Upgrading Discourse to Zeitwerk (#8098)
2019-10-02 14:01:53 +10:00
concern
FIX: use allowlist and blocklist terminology (#10209)
2020-07-27 10:23:54 +10:00
email
FIX: use allowlist and blocklist terminology (#10209)
2020-07-27 10:23:54 +10:00
file_store
FIX: Use ActionDispatch::Http::ContentDisposition for uploads content-disposition (#10108)
2020-06-23 17:10:56 +10:00
freedom_patches
Upgrade fastimage and remove our freedom patch
2020-07-27 13:23:17 -04:00
guardian
FEATURE: Allow group moderators to close/archive topics
2020-07-14 12:36:19 -04:00
highlight_js
DEV: Upgrading Discourse to Zeitwerk (#8098)
2019-10-02 14:01:53 +10:00
imap
FIX: IMAP archive fix and group list mailbox code unification (#10355)
2020-08-04 14:19:57 +10:00
import
DEV: Upgrading Discourse to Zeitwerk (#8098)
2019-10-02 14:01:53 +10:00
middleware
SECURITY: 413 for GET, HEAD or DELETE requests with payload.
2020-08-03 14:21:33 +08:00
migration
FIX: Allow post migrations using #change to carry out unsafe migration
2020-05-15 14:23:27 +08:00
onebox/engine
FIX: use allowlist and blocklist terminology (#10209)
2020-07-27 10:23:54 +10:00
plugin
DEV: Plugins can extend color definitions (#10383)
2020-08-06 09:46:17 -04:00
pretty_text
SPEC: 'lookup_upload_urls' method should use cdn url if available.
2019-10-14 12:57:33 +05:30
rate_limiter
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
scheduler
DEV: reduce logging when no external id is specified
2020-04-08 12:42:28 +10:00
site_settings
UX: Add simple-list setting type (#9970)
2020-06-04 10:44:54 -04:00
stylesheet
DEV: Plugins can extend color definitions (#10383)
2020-08-06 09:46:17 -04:00
svg_sprite
Remove support for FontAwesome 4.7 icon names (#9871)
2020-05-26 14:53:32 -04:00
theme_store
FEATURE: Allow themes to specify modifiers in their about.json file (#9097)
2020-03-11 13:30:45 +00:00
validators
FIX: use allowlist and blocklist terminology (#10209)
2020-07-27 10:23:54 +10:00
wizard
FIX: Default to light theme in wizard so that previews are displayed
2020-04-02 18:37:45 +01:00
admin_confirmation_spec.rb
Update rubocop to 2.3.1.
2020-07-24 17:19:21 +08:00
admin_user_index_query_spec.rb
DEV: Standardize table sorting verbiage (#9757)
2020-05-14 20:10:59 -06:00
archetype_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
cache_spec.rb
DEV: s/\$redis/Discourse\.redis (#8431)
2019-12-03 10:05:53 +01:00
category_badge_spec.rb
FIX: Correctly escape category description text (#8107)
2019-10-01 12:04:39 -04:00
composer_messages_finder_spec.rb
DEV: Improve flaky time-sensitive specs (#9141)
2020-03-10 22:13:17 +01:00
content_buffer_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
cooked_post_processor_spec.rb
REFACTOR: Refactor pull_hotlinked_images job
2020-08-05 12:14:59 +01:00
crawler_detection_spec.rb
FIX: use allowlist and blocklist terminology (#10209)
2020-07-27 10:23:54 +10:00
current_user_spec.rb
DEV: Upgrading Discourse to Zeitwerk (#8098)
2019-10-02 14:01:53 +10:00
directory_helper_spec.rb
DEV: Upgrading Discourse to Zeitwerk (#8098)
2019-10-02 14:01:53 +10:00
discourse_diff_spec.rb
Remove focus from specs
2019-10-16 14:28:04 -04:00
discourse_event_spec.rb
DEV: Upgrading Discourse to Zeitwerk (#8098)
2019-10-02 14:01:53 +10:00
discourse_hub_spec.rb
DEV: Upgrading Discourse to Zeitwerk (#8098)
2019-10-02 14:01:53 +10:00
discourse_plugin_registry_spec.rb
DEV: Plugins can extend color definitions (#10383)
2020-08-06 09:46:17 -04:00
discourse_redis_spec.rb
DEV: Remove specs that are no longer relevant.
2020-06-23 12:09:04 +08:00
discourse_spec.rb
DEV: Use a longer TTL for pg readonly mode.
2020-07-14 16:15:58 +08:00
discourse_tagging_spec.rb
FIX: delete synonyms in topics if target tag is already added.
2020-07-21 21:02:01 +05:30
discourse_updates_spec.rb
Update rubocop to 2.3.1.
2020-07-24 17:19:21 +08:00
distributed_memoizer_spec.rb
DEV: s/\$redis/Discourse\.redis (#8431)
2019-12-03 10:05:53 +01:00
distributed_mutex_spec.rb
DEV: Improve flaky time-sensitive specs (#9141)
2020-03-10 22:13:17 +01:00
email_cook_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
email_updater_spec.rb
Update rubocop to 2.3.1.
2020-07-24 17:19:21 +08:00
enum_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
excerpt_parser_spec.rb
FEATURE: Nokogumbo (#9577)
2020-05-05 13:46:57 +10:00
feed_element_installer_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
feed_item_accessor_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
file_helper_spec.rb
DEV: properly clean up temp files in FileHelper spec
2019-05-28 11:33:08 +10:00
filter_best_posts_spec.rb
DEV: Prefabrication (test optimization) (#7414)
2019-05-07 13:12:20 +10:00
final_destination_spec.rb
FIX: use allowlist and blocklist terminology (#10209)
2020-07-27 10:23:54 +10:00
flag_settings_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
gaps_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
global_path_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
guardian_spec.rb
FIX: use allowlist and blocklist terminology (#10209)
2020-07-27 10:23:54 +10:00
has_errors_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
hijack_spec.rb
FEATURE: Stricter rules for user presence
2020-03-26 17:36:52 +11:00
html_prettify_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
html_to_markdown_spec.rb
FIX: Inline error when converting html to markdown
2020-06-03 15:59:19 -06:00
image_sizer_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
inline_oneboxer_spec.rb
FIX: use allowlist and blocklist terminology (#10209)
2020-07-27 10:23:54 +10:00
js_locale_helper_spec.rb
FIX: Using the default_locale in locale fallbacks caused problems
2020-05-06 22:59:07 +02:00
json_error_spec.rb
DEV: Upgrading Discourse to Zeitwerk (#8098)
2019-10-02 14:01:53 +10:00
letter_avatar_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
method_profiler_spec.rb
DEV: Upgrading Discourse to Zeitwerk (#8098)
2019-10-02 14:01:53 +10:00
new_post_manager_spec.rb
enqueue spam/dmarc failing emails instead of hiding (#8674)
2020-01-21 11:12:00 -05:00
new_post_result_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
oneboxer_spec.rb
FIX: use allowlist and blocklist terminology (#10209)
2020-07-27 10:23:54 +10:00
onpdiff_spec.rb
Remove focus from specs
2019-10-16 14:28:04 -04:00
pbkdf2_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
pinned_check_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
plain_text_to_markdown_spec.rb
FIX: use URI.regexp to find URLs in plain text
2019-06-07 01:26:06 +02:00
post_action_creator_spec.rb
FIX: Reviews that are auto-hidden by a trusted spam flagger should always have enough weight. (#10284)
2020-07-22 11:42:15 -03:00
post_creator_spec.rb
FIX: Ensure topic user bookmarked synced on bookmark auto-delete (#10323)
2020-07-29 09:43:32 +10:00
post_destroyer_spec.rb
FIX: Resolve issue where deleted spam topics marked as Not Spam were not being recovered (#10322)
2020-07-28 12:06:15 +10:00
post_locker_spec.rb
DEV: Upgrading Discourse to Zeitwerk (#8098)
2019-10-02 14:01:53 +10:00
post_merger_spec.rb
DEV: Prefabrication (test optimization) (#7414)
2019-05-07 13:12:20 +10:00
post_revisor_spec.rb
FEATURE - allow Group Moderators to edit category description (#10292)
2020-07-23 09:50:00 -04:00
pretty_text_spec.rb
FIX: use allowlist and blocklist terminology (#10209)
2020-07-27 10:23:54 +10:00
promotion_spec.rb
PERF: Dematerialize topic_reply_count (#9769)
2020-05-14 15:42:00 -07:00
quote_comparer_spec.rb
DEV: Prefabrication (test optimization) (#7414)
2019-05-07 13:12:20 +10:00
rate_limiter_spec.rb
DEV: s/\$redis/Discourse\.redis (#8431)
2019-12-03 10:05:53 +01:00
redis_store_spec.rb
DEV: Implement a faster Discourse.cache
2019-11-27 16:11:49 +11:00
retrieve_title_spec.rb
DEV: Upgrading Discourse to Zeitwerk (#8098)
2019-10-02 14:01:53 +10:00
rtl_spec.rb
DEV: Upgrading Discourse to Zeitwerk (#8098)
2019-10-02 14:01:53 +10:00
s3_helper_spec.rb
FIX: Update S3 stubs for more aws-sdk API changes (#8534)
2019-12-11 11:26:52 -08:00
s3_inventory_spec.rb
PERF: Preload S3 inventory data for multisite clusters
2020-07-29 10:31:55 +01:00
score_calculator_spec.rb
DEV: Prefabrication (test optimization) (#7414)
2019-05-07 13:12:20 +10:00
search_spec.rb
PERF: Limit characters used to generate headline for search blurb.
2020-08-07 14:36:52 +08:00
secure_session_spec.rb
DEV: correct implementation of expiry api
2019-11-11 11:18:12 +11:00
site_icon_manager_spec.rb
DEV: enable frozen string literal on all files
2019-05-13 09:31:32 +08:00
site_setting_extension_spec.rb
FIX: use allowlist and blocklist terminology (#10209)
2020-07-27 10:23:54 +10:00
slug_spec.rb
FIX: If a prettified slug is a number, return defaultt (#8554)
2019-12-17 10:34:20 +10:00
spam_handler_spec.rb
FIX: use allowlist and blocklist terminology (#10209)
2020-07-27 10:23:54 +10:00
suggested_topics_builder_spec.rb
DEV: Default to skipping creating a topic when fabricating categories (#7976)
2019-08-06 11:26:54 +01:00
system_message_spec.rb
DEV: Refactor SystemMessage#create specs.
2019-05-30 07:56:36 +08:00
text_cleaner_spec.rb
FEATURE: English locale with international date formats
2019-05-20 13:47:20 +02:00
text_sentinel_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
theme_settings_manager_spec.rb
DEV: Prefabrication (test optimization) (#7414)
2019-05-07 13:12:20 +10:00
theme_settings_parser_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
timeline_lookup_spec.rb
DEV: Upgrading Discourse to Zeitwerk (#8098)
2019-10-02 14:01:53 +10:00
topic_creator_spec.rb
DEV: Improve flaky time-sensitive specs (#9141)
2020-03-10 22:13:17 +01:00
topic_publisher_spec.rb
DEV: Improve flaky time-sensitive specs (#9141)
2020-03-10 22:13:17 +01:00
topic_query_spec.rb
FEATURE: add tracked filter to topic lists
2020-07-23 10:30:23 +10:00
topic_retriever_spec.rb
FIX: An opts hash was not, in fact, optional :)
2020-04-20 14:17:13 -04:00
topic_view_spec.rb
FIX: Topic map was incorrectly counting assign actions (#10360)
2020-08-05 11:51:28 +10:00
topics_bulk_action_spec.rb
FIX: Unread topics not clearing when whisper is last post (#8271)
2019-11-01 09:19:43 +10:00
trashable_spec.rb
DEV: Upgrading Discourse to Zeitwerk (#8098)
2019-10-02 14:01:53 +10:00
trust_level_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
unread_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
url_helper_spec.rb
FIX: Stop encoding presigned URLs with UrlHelper (#8818)
2020-01-31 09:09:34 +10:00
user_lookup_spec.rb
PERF: Combine avatar_lookup and primary_group_lookup into user_lookup (#10253)
2020-07-17 10:48:08 +01:00
user_name_suggester_spec.rb
FIX: use allowlist and blocklist terminology (#10209)
2020-07-27 10:23:54 +10:00
version_spec.rb
FIX: Test output related to Discourse::VERSION
2020-07-09 14:57:27 -04:00