mirror of
https://github.com/discourse/discourse.git
synced 2024-12-27 09:15:58 +08:00
6e161d3e75
The most common thing that we do with fab! is: fab!(:thing) { Fabricate(:thing) } This commit adds a shorthand for this which is just simply: fab!(:thing) i.e. If you omit the block, then, by default, you'll get a `Fabricate`d object using the fabricator of the same name.
168 lines
5.5 KiB
Ruby
168 lines
5.5 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
RSpec.describe EmbeddableHost do
|
|
it "trims http" do
|
|
eh = EmbeddableHost.new(host: "http://example.com")
|
|
expect(eh).to be_valid
|
|
expect(eh.host).to eq("example.com")
|
|
end
|
|
|
|
it "trims https" do
|
|
eh = EmbeddableHost.new(host: "https://example.com")
|
|
expect(eh).to be_valid
|
|
expect(eh.host).to eq("example.com")
|
|
end
|
|
|
|
it "trims paths" do
|
|
eh = EmbeddableHost.new(host: "https://example.com/1234/45")
|
|
expect(eh).to be_valid
|
|
expect(eh.host).to eq("example.com")
|
|
end
|
|
|
|
it "supports ip addresses" do
|
|
eh = EmbeddableHost.new(host: "192.168.0.1")
|
|
expect(eh).to be_valid
|
|
expect(eh.host).to eq("192.168.0.1")
|
|
end
|
|
|
|
it "supports localhost" do
|
|
eh = EmbeddableHost.new(host: "localhost")
|
|
expect(eh).to be_valid
|
|
expect(eh.host).to eq("localhost")
|
|
end
|
|
|
|
it "supports ports of localhost" do
|
|
eh = EmbeddableHost.new(host: "localhost:8080")
|
|
expect(eh).to be_valid
|
|
expect(eh.host).to eq("localhost:8080")
|
|
end
|
|
|
|
it "supports ports for ip addresses" do
|
|
eh = EmbeddableHost.new(host: "192.168.0.1:3000")
|
|
expect(eh).to be_valid
|
|
expect(eh.host).to eq("192.168.0.1:3000")
|
|
end
|
|
|
|
it "supports subdomains of localhost" do
|
|
eh = EmbeddableHost.new(host: "discourse.localhost")
|
|
expect(eh).to be_valid
|
|
expect(eh.host).to eq("discourse.localhost")
|
|
end
|
|
|
|
it "supports multiple hyphens" do
|
|
eh = EmbeddableHost.new(host: "deploy-preview-1--example.example.app")
|
|
expect(eh).to be_valid
|
|
expect(eh.host).to eq("deploy-preview-1--example.example.app")
|
|
end
|
|
|
|
it "rejects misspellings of localhost" do
|
|
eh = EmbeddableHost.new(host: "alocalhost")
|
|
expect(eh).not_to be_valid
|
|
end
|
|
|
|
describe "it works with ports" do
|
|
fab!(:host) { Fabricate(:embeddable_host, host: "localhost:8000") }
|
|
|
|
it "works as expected" do
|
|
expect(EmbeddableHost.url_allowed?("http://localhost:8000/eviltrout")).to eq(true)
|
|
end
|
|
end
|
|
|
|
it "doesn't allow forum own URL if no hosts exist" do
|
|
expect(EmbeddableHost.url_allowed?(Discourse.base_url)).to eq(false)
|
|
end
|
|
|
|
describe "url_allowed?" do
|
|
fab!(:host) { Fabricate(:embeddable_host) }
|
|
|
|
it "works as expected" do
|
|
expect(EmbeddableHost.url_allowed?("http://eviltrout.com")).to eq(true)
|
|
expect(EmbeddableHost.url_allowed?("https://eviltrout.com")).to eq(true)
|
|
expect(EmbeddableHost.url_allowed?("https://eviltrout.com/انگلیسی")).to eq(true)
|
|
expect(EmbeddableHost.url_allowed?("https://not-eviltrout.com")).to eq(false)
|
|
end
|
|
|
|
it "works with multiple hosts" do
|
|
Fabricate(:embeddable_host, host: "discourse.org")
|
|
expect(EmbeddableHost.url_allowed?("http://eviltrout.com")).to eq(true)
|
|
expect(EmbeddableHost.url_allowed?("http://discourse.org")).to eq(true)
|
|
end
|
|
|
|
it "does not allow forum own URL" do
|
|
expect(EmbeddableHost.url_allowed?(Discourse.base_url)).to eq(false)
|
|
end
|
|
end
|
|
|
|
describe "allowed_paths" do
|
|
it "matches the path" do
|
|
Fabricate(:embeddable_host, allowed_paths: '^/fp/\d{4}/\d{2}/\d{2}/.*$')
|
|
expect(EmbeddableHost.url_allowed?("http://eviltrout.com")).to eq(false)
|
|
expect(EmbeddableHost.url_allowed?("http://eviltrout.com/fp/2016/08/25/test-page")).to eq(
|
|
true,
|
|
)
|
|
end
|
|
|
|
it "respects query parameters" do
|
|
Fabricate(:embeddable_host, allowed_paths: "^/fp$")
|
|
expect(EmbeddableHost.url_allowed?("http://eviltrout.com/fp?test=1")).to eq(false)
|
|
expect(EmbeddableHost.url_allowed?("http://eviltrout.com/fp")).to eq(true)
|
|
end
|
|
|
|
it "allows multiple records with different paths" do
|
|
Fabricate(:embeddable_host, allowed_paths: "/rick/.*")
|
|
Fabricate(:embeddable_host, allowed_paths: "/morty/.*")
|
|
expect(EmbeddableHost.url_allowed?("http://eviltrout.com/rick/smith")).to eq(true)
|
|
expect(EmbeddableHost.url_allowed?("http://eviltrout.com/morty/sanchez")).to eq(true)
|
|
end
|
|
|
|
it "works with non-english paths" do
|
|
Fabricate(:embeddable_host, allowed_paths: "/انگلیسی/.*")
|
|
Fabricate(:embeddable_host, allowed_paths: "/definição/.*")
|
|
expect(EmbeddableHost.url_allowed?("http://eviltrout.com/انگلیسی/foo")).to eq(true)
|
|
expect(EmbeddableHost.url_allowed?("http://eviltrout.com/definição/foo")).to eq(true)
|
|
expect(EmbeddableHost.url_allowed?("http://eviltrout.com/bar/foo")).to eq(false)
|
|
end
|
|
|
|
it "works with URL encoded paths" do
|
|
Fabricate(:embeddable_host, allowed_paths: "/definição/.*")
|
|
Fabricate(:embeddable_host, allowed_paths: "/ingl%C3%A9s/.*")
|
|
|
|
expect(EmbeddableHost.url_allowed?("http://eviltrout.com/defini%C3%A7%C3%A3o/foo")).to eq(
|
|
true,
|
|
)
|
|
expect(EmbeddableHost.url_allowed?("http://eviltrout.com/inglés/foo")).to eq(true)
|
|
end
|
|
end
|
|
|
|
describe "reset_embedding_settings" do
|
|
it "resets all embedding related settings when last embeddable host is removed" do
|
|
host = Fabricate(:embeddable_host)
|
|
host2 = Fabricate(:embeddable_host)
|
|
|
|
SiteSetting.embed_post_limit = 300
|
|
|
|
host2.destroy
|
|
|
|
expect(SiteSetting.embed_post_limit).to eq(300)
|
|
|
|
host.destroy
|
|
|
|
expect(SiteSetting.embed_post_limit).to eq(SiteSetting.defaults[:embed_post_limit])
|
|
end
|
|
end
|
|
|
|
describe ".record_for_url" do
|
|
fab!(:embeddable_host)
|
|
|
|
it "returns the right record if given URL matches host" do
|
|
expect(EmbeddableHost.record_for_url("https://#{embeddable_host.host}")).to eq(
|
|
embeddable_host,
|
|
)
|
|
end
|
|
|
|
it "returns false if URL is malformed" do
|
|
expect(EmbeddableHost.record_for_url("@@@@@")).to eq(false)
|
|
end
|
|
end
|
|
end
|