mirror of
https://github.com/discourse/discourse.git
synced 2024-11-28 03:10:11 +08:00
03818e642a
This introduces new APIs for obtaining optimized thumbnails for topics. There are a few building blocks required for this:
- Introduces new `image_upload_id` columns on the `posts` and `topics` table. This replaces the old `image_url` column, which means that thumbnails are now restricted to uploads. Hotlinked thumbnails are no longer possible. In normal use (with pull_hotlinked_images enabled), this has no noticeable impact
- A migration attempts to match existing urls to upload records. If a match cannot be found then the posts will be queued for rebake
- Optimized thumbnails are generated during post_process_cooked. If thumbnails are missing when serializing a topic list, then a sidekiq job is queued
- Topic lists and topics now include a `thumbnails` key, which includes all the available images:
```
"thumbnails": [
{
"max_width": null,
"max_height": null,
"url": "//example.com/original-image.png",
"width": 1380,
"height": 1840
},
{
"max_width": 1024,
"max_height": 1024,
"url": "//example.com/optimized-image.png",
"width": 768,
"height": 1024
}
]
```
- Themes can request additional thumbnail sizes by using a modifier in their `about.json` file:
```
"modifiers": {
"topic_thumbnail_sizes": [
[200, 200],
[800, 800]
],
...
```
Remember that these are generated asynchronously, so your theme should include logic to fallback to other available thumbnails if your requested size has not yet been generated
- Two new raw plugin outlets are introduced, to improve the customisability of the topic list. `topic-list-before-columns` and `topic-list-before-link`
62 lines
1.7 KiB
Ruby
62 lines
1.7 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'rails_helper'
|
|
|
|
RSpec.describe DbHelper do
|
|
describe '.remap' do
|
|
it 'should remap columns properly' do
|
|
post = Fabricate(:post, cooked: "this is a specialcode that I included")
|
|
post_attributes = post.reload.attributes
|
|
|
|
badge = Fabricate(:badge, query: "specialcode")
|
|
badge_attributes = badge.reload.attributes
|
|
|
|
DbHelper.remap("specialcode", "codespecial")
|
|
|
|
post.reload
|
|
|
|
expect(post.cooked).to include("codespecial")
|
|
|
|
badge.reload
|
|
|
|
expect(badge.query).to eq("codespecial")
|
|
|
|
expect(badge_attributes.except("query"))
|
|
.to eq(badge.attributes.except("query"))
|
|
end
|
|
|
|
it 'allows tables to be excluded from scanning' do
|
|
post = Fabricate(:post, cooked: "test")
|
|
|
|
DbHelper.remap("test", "something else", excluded_tables: %w{posts})
|
|
|
|
expect(post.reload.cooked).to eq('test')
|
|
end
|
|
|
|
it "does not remap readonly columns" do
|
|
post = Fabricate(:post, raw: "This is a test", cooked: "This is a test")
|
|
|
|
Migration::ColumnDropper.mark_readonly("posts", "cooked")
|
|
|
|
DbHelper.remap("test", "something else")
|
|
|
|
post.reload
|
|
|
|
expect(post.raw).to eq("This is a something else")
|
|
expect(post.cooked).to eq("This is a test")
|
|
|
|
DB.exec "DROP FUNCTION #{Migration::BaseDropper.readonly_function_name("posts", "cooked")} CASCADE"
|
|
end
|
|
end
|
|
|
|
describe ".regexp_replace" do
|
|
it "should remap columns correctly" do
|
|
post = Fabricate(:post, raw: "this is a [img]test[/img] post")
|
|
|
|
DbHelper.regexp_replace("\\[img\\]test\\[/img\\]", "[img]something[/img]")
|
|
|
|
expect(post.reload.raw).to include("[img]something[/img]")
|
|
end
|
|
end
|
|
end
|