mirror of
https://github.com/discourse/discourse.git
synced 2024-11-24 04:13:22 +08:00
90efdd7f9d
This commit starts from a simple observation: cooking messages on the hot path can be slow. Especially with a lot of mentions. To move cooking from the hot path, this commit has made the following changes: - updating cooked, inserting mentions and notifying user of new mentions has been moved inside the `process_message` job. It happens right after the `Chat::MessageProcessor` run, which is where the cooking happens. - the similar existing code in `rebake!` has also been moved to rely on the `process_message`job only - refactored `create_mentions` and `update_mentions` into one single `upsert_mentions` which can be called invariably - allows services to decide if their job is ran inline or later. It avoids to need to know you have to use `Jobs.run_immediately!` in this case, in tests it will be inline per default - made various frontend changes to make the chat-channel component lifecycle clearer. we had to handle `did-update @channel` which was super awkward and creating bugs with listeners which the changes of the PR made clear in failing specs - adds a new `-processed` (and `-not-processed`) class on the chat message, this is made to have a good lifecyle hook in system specs
61 lines
1.9 KiB
Ruby
61 lines
1.9 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
RSpec.describe "Edited message", type: :system do
|
|
let(:chat_page) { PageObjects::Pages::Chat.new }
|
|
let(:channel_page) { PageObjects::Pages::ChatChannel.new }
|
|
|
|
fab!(:current_user) { Fabricate(:user) }
|
|
fab!(:channel_1) { Fabricate(:category_channel) }
|
|
|
|
before do
|
|
chat_system_bootstrap
|
|
channel_1.add(current_user)
|
|
sign_in(current_user)
|
|
end
|
|
|
|
context "when editing message" do
|
|
context "with multiple users in the channel" do
|
|
fab!(:editing_user) { Fabricate(:user) }
|
|
fab!(:message_1) { Fabricate(:chat_message, chat_channel: channel_1, user: editing_user) }
|
|
|
|
before { channel_1.add(editing_user) }
|
|
|
|
it "shows as edited for all users" do
|
|
chat_page.visit_channel(channel_1)
|
|
|
|
using_session(:user_1) do |session|
|
|
sign_in(editing_user)
|
|
chat_page.visit_channel(channel_1)
|
|
channel_page.edit_message(message_1, "a different message")
|
|
expect(page).to have_content(I18n.t("js.chat.edited"))
|
|
session.quit
|
|
end
|
|
|
|
expect(page).to have_content(I18n.t("js.chat.edited"))
|
|
end
|
|
end
|
|
|
|
it "runs decorators on the edited message" do
|
|
message_1 =
|
|
Fabricate(:chat_message, chat_channel: channel_1, user: current_user, use_service: true)
|
|
chat_page.visit_channel(channel_1)
|
|
|
|
channel_page.edit_message(message_1, '[date=2025-03-10 timezone="Europe/Paris"]')
|
|
|
|
expect(page).to have_css(".cooked-date")
|
|
end
|
|
end
|
|
|
|
context "when replying to and edited message" do
|
|
fab!(:message_1) { Fabricate(:chat_message, chat_channel: channel_1, user: current_user) }
|
|
|
|
it "shows the correct reply indicator" do
|
|
chat_page.visit_channel(channel_1)
|
|
channel_page.edit_message(message_1, message_1.message + "a")
|
|
channel_page.reply_to(message_1)
|
|
|
|
expect(channel_page.composer.message_details).to be_replying_to(message_1)
|
|
end
|
|
end
|
|
end
|