mirror of
https://github.com/discourse/discourse.git
synced 2024-12-19 16:44:06 +08:00
a20b7fa83f
* DEV: Gracefully handle `regex_replace` violations of column length constraints
This is a follow-up to the `remap` [refactor](9b0cfa99c5).
Similar to `remap`, the entire `regex_replace` operation fails if the new content exceeds the column’s max length.
This change introduces an optional mode, controlled by the new `skip_max_length_violations` param
to skip records eligible for `regex_replace` where the new content violates the max column length constraint.
It also includes updates to the exception message raised when `regex_replace` fails to include more details
* DEV: Remove string escapes in heredoc text
140 lines
4.4 KiB
Ruby
140 lines
4.4 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
RSpec.describe DbHelper do
|
|
fab!(:bookmark1) { Fabricate(:bookmark, name: "short-bookmark") }
|
|
fab!(:bookmark2) { Fabricate(:bookmark, name: "another-bookmark") }
|
|
let(:bookmark_name_limit) { Bookmark.columns_hash["name"].limit }
|
|
let(:long_bookmark_name) { "a" * (bookmark_name_limit + 1) }
|
|
|
|
describe ".remap" do
|
|
it "should remap columns properly" do
|
|
post = Fabricate(:post, cooked: "this is a specialcode that I included")
|
|
post_attributes = post.reload.attributes
|
|
|
|
badge = Fabricate(:badge, query: "specialcode")
|
|
badge_attributes = badge.reload.attributes
|
|
|
|
DbHelper.remap("specialcode", "codespecial")
|
|
|
|
post.reload
|
|
|
|
expect(post.cooked).to include("codespecial")
|
|
|
|
badge.reload
|
|
|
|
expect(badge.query).to eq("codespecial")
|
|
|
|
expect(badge_attributes.except("query")).to eq(badge.attributes.except("query"))
|
|
end
|
|
|
|
it "allows tables to be excluded from scanning" do
|
|
post = Fabricate(:post, cooked: "test")
|
|
|
|
DbHelper.remap("test", "something else", excluded_tables: %w[posts])
|
|
|
|
expect(post.reload.cooked).to eq("test")
|
|
end
|
|
|
|
it "does not remap readonly columns" do
|
|
post = Fabricate(:post, raw: "This is a test", cooked: "This is a test")
|
|
|
|
Migration::ColumnDropper.mark_readonly("posts", "cooked")
|
|
|
|
DbHelper.remap("test", "something else")
|
|
|
|
post.reload
|
|
|
|
expect(post.raw).to eq("This is a something else")
|
|
expect(post.cooked).to eq("This is a test")
|
|
|
|
DB.exec "DROP FUNCTION #{Migration::BaseDropper.readonly_function_name("posts", "cooked")} CASCADE"
|
|
end
|
|
|
|
context "when skip_max_length_violations is false" do
|
|
it "raises an exception if remap exceeds column length constraint by default" do
|
|
expect { DbHelper.remap("bookmark", long_bookmark_name) }.to raise_error(
|
|
PG::StringDataRightTruncation,
|
|
/value too long.*table: bookmarks,.*name/,
|
|
)
|
|
end
|
|
end
|
|
|
|
context "when skip_max_length_violations is true" do
|
|
it "skips a remap eligible row if new value exceeds column length constraint" do
|
|
DbHelper.remap("bookmark", long_bookmark_name, skip_max_length_violations: true)
|
|
|
|
bookmark1.reload
|
|
bookmark2.reload
|
|
|
|
expect(bookmark1.name).to eq("short-bookmark")
|
|
expect(bookmark2.name).to eq("another-bookmark")
|
|
end
|
|
|
|
it "logs skipped remaps due to max length constraints when verbose is true" do
|
|
expect {
|
|
DbHelper.remap(
|
|
"bookmark",
|
|
long_bookmark_name,
|
|
verbose: true,
|
|
skip_max_length_violations: true,
|
|
)
|
|
}.to output(/SKIPPED:/).to_stdout
|
|
|
|
bookmark1.reload
|
|
bookmark2.reload
|
|
|
|
expect(bookmark1.name).to eq("short-bookmark")
|
|
expect(bookmark2.name).to eq("another-bookmark")
|
|
end
|
|
end
|
|
end
|
|
|
|
describe ".regexp_replace" do
|
|
it "should remap columns correctly" do
|
|
post = Fabricate(:post, raw: "this is a [img]test[/img] post")
|
|
|
|
DbHelper.regexp_replace("\\[img\\]test\\[/img\\]", "[img]something[/img]")
|
|
|
|
expect(post.reload.raw).to include("[img]something[/img]")
|
|
end
|
|
|
|
context "when skip_max_length_violations is false" do
|
|
it "raises an exception if regexp_replace exceeds column length constraint by default" do
|
|
expect { DbHelper.regexp_replace("bookmark", long_bookmark_name) }.to raise_error(
|
|
PG::StringDataRightTruncation,
|
|
/value too long.*table: bookmarks,.*name/,
|
|
)
|
|
end
|
|
end
|
|
|
|
context "when skip_max_length_violations is true" do
|
|
it "skips regexp_replace eligible rows if new value exceeds column length constraint" do
|
|
DbHelper.regexp_replace("bookmark", long_bookmark_name, skip_max_length_violations: true)
|
|
|
|
bookmark1.reload
|
|
bookmark2.reload
|
|
|
|
expect(bookmark1.name).to eq("short-bookmark")
|
|
expect(bookmark2.name).to eq("another-bookmark")
|
|
end
|
|
|
|
it "logs skipped regexp_replace due to max length constraints when verbose is true" do
|
|
expect {
|
|
DbHelper.regexp_replace(
|
|
"bookmark",
|
|
long_bookmark_name,
|
|
verbose: true,
|
|
skip_max_length_violations: true,
|
|
)
|
|
}.to output(/SKIPPED:/).to_stdout
|
|
|
|
bookmark1.reload
|
|
bookmark2.reload
|
|
|
|
expect(bookmark1.name).to eq("short-bookmark")
|
|
expect(bookmark2.name).to eq("another-bookmark")
|
|
end
|
|
end
|
|
end
|
|
end
|