mirror of
https://github.com/discourse/discourse.git
synced 2024-12-25 16:53:45 +08:00
dadb7eaa23
setting all categories to be secured led to a blank screen on all pages use stabby lambda for consistency in class make the test a little more concise - move the local assignments into let blocks for reusability - remove calls to `to_a`, which aren't needed - use 'be_empty' instead of '[]' to be consistent with the other matchers in the test add a test for the `secured` scope with multiple secured categories
213 lines
5.1 KiB
Ruby
213 lines
5.1 KiB
Ruby
# encoding: utf-8
|
|
|
|
require 'spec_helper'
|
|
|
|
describe Category do
|
|
it { should validate_presence_of :user_id }
|
|
it { should validate_presence_of :name }
|
|
|
|
it 'validates uniqueness of name' do
|
|
Fabricate(:category)
|
|
should validate_uniqueness_of(:name)
|
|
end
|
|
|
|
it { should belong_to :topic }
|
|
it { should belong_to :user }
|
|
|
|
it { should have_many :topics }
|
|
it { should have_many :category_featured_topics }
|
|
it { should have_many :featured_topics }
|
|
|
|
describe "security" do
|
|
let(:category) { Fabricate(:category) }
|
|
let(:category_2) { Fabricate(:category) }
|
|
let(:user) { Fabricate(:user) }
|
|
let(:group) { Fabricate(:group) }
|
|
|
|
it "secures categories correctly" do
|
|
category.secure?.should be_false
|
|
|
|
category.deny(:all)
|
|
category.secure?.should be_true
|
|
|
|
category.allow(:all)
|
|
category.secure?.should be_false
|
|
|
|
user.secure_categories.should be_empty
|
|
|
|
group.add(user)
|
|
group.save
|
|
|
|
category.allow(group)
|
|
category.save
|
|
|
|
user.reload
|
|
user.secure_categories.should == [category]
|
|
end
|
|
|
|
it "lists all secured categories correctly" do
|
|
group.add(user)
|
|
category.allow(group)
|
|
|
|
Category.secured.should == [category]
|
|
|
|
category_2.allow(group)
|
|
|
|
Category.secured.should =~ [category, category_2]
|
|
end
|
|
end
|
|
|
|
describe "uncategorized name" do
|
|
let(:category) { Fabricate.build(:category, name: SiteSetting.uncategorized_name) }
|
|
|
|
it "is invalid to create a category with the reserved name" do
|
|
category.should_not be_valid
|
|
end
|
|
end
|
|
|
|
describe "short name" do
|
|
let!(:category) { Fabricate(:category, name: 'xx') }
|
|
|
|
it "creates the category" do
|
|
category.should be_present
|
|
end
|
|
|
|
it 'has one topic' do
|
|
Topic.where(category_id: category.id).count.should == 1
|
|
end
|
|
end
|
|
|
|
describe 'caching' do
|
|
it "invalidates the site cache on creation" do
|
|
Site.expects(:invalidate_cache).once
|
|
Fabricate(:category)
|
|
end
|
|
|
|
it "invalidates the site cache on update" do
|
|
cat = Fabricate(:category)
|
|
Site.expects(:invalidate_cache).once
|
|
cat.update_attributes(name: 'new name')
|
|
end
|
|
|
|
it "invalidates the site cache on destroy" do
|
|
cat = Fabricate(:category)
|
|
Site.expects(:invalidate_cache).once
|
|
cat.destroy
|
|
end
|
|
end
|
|
|
|
describe 'non-english characters' do
|
|
let(:category) { Fabricate(:category, name: "電車男") }
|
|
|
|
it "creates a blank slug, this is OK." do
|
|
category.slug.should be_blank
|
|
end
|
|
end
|
|
|
|
describe 'after create' do
|
|
before do
|
|
@category = Fabricate(:category, name: 'Amazing Category')
|
|
@topic = @category.topic
|
|
end
|
|
|
|
it 'is created correctly' do
|
|
@category.slug.should == 'amazing-category'
|
|
|
|
@category.hotness.should == 5.0
|
|
|
|
@category.description.should be_blank
|
|
|
|
Topic.where(category_id: @category).count.should == 1
|
|
|
|
@topic.should be_present
|
|
|
|
@topic.category.should == @category
|
|
|
|
@topic.should be_visible
|
|
|
|
@topic.pinned_at.should be_present
|
|
|
|
Guardian.new(@category.user).can_delete?(@topic).should be_false
|
|
|
|
@topic.posts.count.should == 1
|
|
|
|
@category.topic_url.should be_present
|
|
end
|
|
|
|
describe "creating a new category with the same slug" do
|
|
it "should have a blank slug" do
|
|
Fabricate(:category, name: "Amazing Categóry").slug.should be_blank
|
|
end
|
|
end
|
|
|
|
describe "trying to change the category topic's category" do
|
|
before do
|
|
@new_cat = Fabricate(:category, name: '2nd Category', user: @category.user)
|
|
@topic.change_category(@new_cat.name)
|
|
@topic.reload
|
|
@category.reload
|
|
end
|
|
|
|
it 'does not cause changes' do
|
|
@category.topic_count.should == 0
|
|
@topic.category.should == @category
|
|
@category.topic.should == @topic
|
|
end
|
|
|
|
end
|
|
end
|
|
|
|
describe 'destroy' do
|
|
before do
|
|
@category = Fabricate(:category)
|
|
@category_id = @category.id
|
|
@topic_id = @category.topic_id
|
|
@category.destroy
|
|
end
|
|
|
|
it 'is deleted correctly' do
|
|
Category.exists?(id: @category_id).should be_false
|
|
Topic.exists?(id: @topic_id).should be_false
|
|
end
|
|
end
|
|
|
|
describe 'update_stats' do
|
|
before do
|
|
@category = Fabricate(:category)
|
|
end
|
|
|
|
context 'with regular topics' do
|
|
before do
|
|
@category.topics << Fabricate(:topic, user: @category.user)
|
|
Category.update_stats
|
|
@category.reload
|
|
end
|
|
|
|
it 'updates topic stats' do
|
|
@category.topics_week.should == 1
|
|
@category.topics_month.should == 1
|
|
@category.topics_year.should == 1
|
|
@category.topic_count.should == 1
|
|
end
|
|
|
|
end
|
|
|
|
context 'with deleted topics' do
|
|
before do
|
|
@category.topics << Fabricate(:deleted_topic,
|
|
user: @category.user)
|
|
Category.update_stats
|
|
@category.reload
|
|
end
|
|
|
|
it 'does not count deleted topics' do
|
|
@category.topics_week.should == 0
|
|
@category.topic_count.should == 0
|
|
@category.topics_month.should == 0
|
|
@category.topics_year.should == 0
|
|
end
|
|
|
|
end
|
|
end
|
|
end
|