discourse/spec
Sam Saffron 0a5a6dfded DEV: stop mutating inputs as a side effect
We had quite a few cases in core where inputs are being mutated as a side
effect of calling a method.

This handles all the cases where specs caught this.

Mutating inputs makes code harder to reason about. Eg:

```
frog = "frog"
jump(frog)
puts frog
"fly" # ?????
```

This commit is part of a followup commit that adds # frozen_string_literal
to all our specs.
2019-04-30 10:25:53 +10:00
..
components DEV: stop mutating inputs as a side effect 2019-04-30 10:25:53 +10:00
fabricators DEV: User email test optimization (#7405) 2019-04-23 17:49:05 +08:00
fixtures PERF: Avoid looking up the same group multiple times during bulk invite. 2019-04-16 09:42:25 +08:00
helpers FEATURE: remove "COMPRESS_BROTLI" optional behavior 2019-04-11 12:36:18 +10:00
import_export
integration DEV: remove update_attributes which is deprecated in Rails 6 2019-04-29 17:32:25 +10:00
integrity FIX: Relative links in translations should work with subfolder 2018-11-08 23:31:05 +00:00
jobs DEV: remove update_attributes which is deprecated in Rails 6 2019-04-29 17:32:25 +10:00
lib FIX: should look through posts for image markdown 2019-04-10 13:52:35 +05:30
mailers FIX: Keep original subject in emails to staged users 2019-01-18 11:07:54 +01:00
models FIX: staff-only tags visible on /tags page when restricted to a category 2019-04-29 12:38:28 -04:00
multisite DEV: remove update_attributes which is deprecated in Rails 6 2019-04-29 17:32:25 +10:00
requests DEV: remove a couple of warnings from spec 2019-04-30 08:41:28 +10:00
serializers Removed unused let blocks (#7446) 2019-04-29 15:08:56 +08:00
services FIX: Remove duplicate Emoji names from blurb 2019-04-29 17:26:39 +02:00
support FEATURE: New 'Reviewable' model to make reviewable items generic 2019-03-28 12:45:10 -04:00
tasks DEV: remove update_attributes which is deprecated in Rails 6 2019-04-29 17:32:25 +10:00
views/omniauth_callbacks FEATURE: Use translated name for 'your email has been authenticated by' (#6649) 2018-11-22 19:12:04 +00:00
rails_helper.rb Removed "shoulda" gem in favor of "shoulda-matchers" and update (#7387) 2019-04-18 07:41:37 +10:00