mirror of
https://github.com/discourse/discourse.git
synced 2025-01-31 08:46:14 +08:00
38216f6f0b
- Only validate if custom_fields are loaded, so that we don't trigger a db query
- Only validate public user fields, not all custom_fields
This commit also reverts the unrelated spec changes in ba148e08, which were required to work around these issues
39 lines
1.3 KiB
Ruby
39 lines
1.3 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
describe Jobs::ActivationReminderEmails do
|
|
before { Jobs.run_immediately! }
|
|
|
|
# should be between 2 and 3 days
|
|
let(:created_at) { 50.hours.ago }
|
|
|
|
it 'should email inactive users' do
|
|
user = Fabricate(:user, active: false, created_at: created_at)
|
|
|
|
expect { described_class.new.execute({}) }
|
|
.to change { ActionMailer::Base.deliveries.size }.by(1)
|
|
.and change { user.email_tokens.count }.by(1)
|
|
|
|
expect(user.custom_fields['activation_reminder']).to eq("t")
|
|
expect { described_class.new.execute({}) }.to change { ActionMailer::Base.deliveries.size }.by(0)
|
|
|
|
user.activate
|
|
expect(user.reload.custom_fields['activation_reminder']).to eq(nil)
|
|
end
|
|
|
|
it 'should not email active users' do
|
|
user = Fabricate(:user, active: true, created_at: created_at)
|
|
|
|
expect { described_class.new.execute({}) }
|
|
.to change { ActionMailer::Base.deliveries.size }.by(0)
|
|
.and change { user.email_tokens.count }.by(0)
|
|
end
|
|
|
|
it 'should not email staged users' do
|
|
user = Fabricate(:user, active: false, staged: true, created_at: created_at)
|
|
|
|
expect { described_class.new.execute({}) }
|
|
.to change { ActionMailer::Base.deliveries.size }.by(0)
|
|
.and change { user.email_tokens.count }.by(0)
|
|
end
|
|
end
|