Alan Guo Xiang Tan 0e69aeb276 SECURITY: Default tags to show count of topics in unrestricted categories (#19929) ... Currently, `Tag#topic_count` is a count of all regular topics regardless of whether the topic is in a read restricted category or not. As a result, any users can technically poll a sensitive tag to determine if a new topic is created in a category which the user has not excess to. We classify this as a minor leak in sensitive information. The following changes are introduced in this commit: 1. Introduce `Tag#public_topic_count` which only count topics which have been tagged with a given tag in public categories. 2. Rename `Tag#topic_count` to `Tag#staff_topic_count` which counts the same way as `Tag#topic_count`. In other words, it counts all topics tagged with a given tag regardless of the category the topic is in. The rename is also done so that we indicate that this column contains sensitive information. 3. Change all previous spots which relied on `Topic#topic_count` to rely on `Tag.topic_column_count(guardian)` which will return the right "topic count" column to use based on the current scope. 4. Introduce `SiteSetting.include_secure_categories_in_tag_counts` site setting to allow site administrators to always display the tag topics count using `Tag#staff_topic_count` instead.		2023-01-20 11:59:37 +08:00
..
auth	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
backup_restore	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
common_passwords	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
compression	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
concern	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
content_security_policy	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
email	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
file_store	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
final_destination	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
freedom_patches	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
guardian	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
highlight_js	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
i18n	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
imap	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
import	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
middleware	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
migration	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
onebox	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
plugin	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
pretty_text	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
rate_limiter	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
scheduler	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
second_factor	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
seed_data	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
site_settings	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
stylesheet	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
svg_sprite	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
theme_store	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
topic_query	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
validators	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
webauthn	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
wizard	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
admin_confirmation_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
admin_user_index_query_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
archetype_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
bookmark_manager_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
bookmark_query_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
bookmark_reminder_notification_handler_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
browser_detection_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
cache_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
category_badge_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
category_guardian_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
composer_messages_finder_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
content_buffer_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
content_security_policy_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
cooked_post_processor_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
crawler_detection_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
current_user_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
db_helper_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
directory_helper_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
discourse_diff_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
discourse_event_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
discourse_hub_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
discourse_js_processor_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
discourse_plugin_registry_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
discourse_redis_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
discourse_sourcemapping_url_processor_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
discourse_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
discourse_tagging_spec.rb	SECURITY: Default tags to show count of topics in unrestricted categories (#19929)	2023-01-20 11:59:37 +08:00
discourse_updates_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
distributed_cache_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
distributed_memoizer_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
distributed_mutex_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
email_cook_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
email_updater_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
ember_cli_spec.rb	DEV: Add test for EmberCli#ember_version (#18140)	2022-08-30 20:33:08 +01:00
encodings_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
enum_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
excerpt_parser_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
feed_element_installer_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
feed_item_accessor_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
file_helper_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
filter_best_posts_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
final_destination_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
flag_settings_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
gaps_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
git_url_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
global_path_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
group_email_credentials_check_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
guardian_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
has_errors_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
hijack_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
html_prettify_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
html_to_markdown_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
image_sizer_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
inline_oneboxer_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
js_locale_helper_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
json_error_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
letter_avatar_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
message_id_service_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
method_profiler_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
mini_sql_multisite_connection_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
mobile_detection_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
new_post_manager_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
new_post_result_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
onebox_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
oneboxer_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
onpdiff_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
pbkdf2_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
pinned_check_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
plain_text_to_markdown_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
post_action_creator_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
post_action_destroyer_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
post_creator_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
post_destroyer_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
post_jobs_enqueuer_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
post_locker_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
post_merger_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
post_revisor_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
presence_channel_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
pretty_text_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
promotion_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
quote_comparer_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
rate_limiter_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
retrieve_title_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
rtl_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
s3_cors_rulesets_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
s3_helper_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
s3_inventory_multisite_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
s3_inventory_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
score_calculator_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
scss_checker_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
search_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
secure_session_spec.rb	Add RSpec 4 compatibility (#17652)	2022-07-28 10:27:38 +08:00
shrink_uploaded_image_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
sidebar_section_links_updater_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
site_icon_manager_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
site_setting_extension_multisite_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
site_setting_extension_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
slug_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
spam_handler_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
suggested_topics_builder_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
system_message_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
text_cleaner_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
text_sentinel_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
theme_flag_modifier_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
theme_javascript_compiler_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
theme_settings_manager_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
theme_settings_parser_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
timeline_lookup_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
tiny_japanese_segmenter_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
topic_creator_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
topic_publisher_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
topic_query_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
topic_retriever_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
topic_upload_security_manager_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
topic_view_spec.rb	SECURITY: Default tags to show count of topics in unrestricted categories (#19929)	2023-01-20 11:59:37 +08:00
topics_bulk_action_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
trashable_spec.rb	Add RSpec 4 compatibility (#17652)	2022-07-28 10:27:38 +08:00
trust_level_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
twitter_api_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
unread_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
upload_creator_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
upload_markdown_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
upload_recovery_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
upload_security_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
url_helper_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
user_comm_screener_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
user_lookup_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
user_name_suggester_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
version_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00