discourse/spec
Jeff Wong 0e553f1fd1 FIX: correctly remove authentication_data cookie on oauth login flow (#9238)
Additionally correctly handle cookie path for authentication_data

There were two bugs that exposed an interesting case where two discourse
instances hosted across two subfolder installs in the same domain
with oauth may clash and cause strange redirection on first login:

Log in to example.com/forum1. authentication_data cookie is set with path /
On the first redirection, the current authentication_data cookie is not unset.
Log in to example.com/forum2. In this case, the authentication_data cookie
is already set from forum1 - the initial page load will incorrectly redirect
the user to the redirect URL from the already-stored cookie, to /forum1.

This removes this issue by:
* Setting the cookie for the correct path, and not having it on root
* Correctly removing the cookie on first login
2020-03-23 16:01:39 -07:00
..
components DEV: Fix build 2020-03-05 11:45:45 -05:00
fabricators FEATURE: Improving bookmarks part 2 -- Topic Bookmarking (#8954) 2020-02-13 16:26:02 +10:00
fixtures FIX: Consider webp a supported image format for upload (#9015) 2020-02-21 13:08:01 +10:00
helpers FIX: blank popular posts in summary emails due to lightbox images 2020-02-21 16:18:38 -05:00
import_export FIX: Import sub-sub-categories (#8810) 2020-01-30 18:46:33 +02:00
integration UX: Include public groups in mentionable groups set (#8516) 2019-12-12 13:13:40 +02:00
integrity DEV: Update markdown-it from 8.4.1 to 10.0.0 (#8164) 2019-10-08 13:00:22 +02:00
jobs FIX: Ensure web hooks are retried at most 5 times 2020-02-21 17:02:40 +02:00
lib Merge diffs from master 2020-02-25 17:23:37 -05:00
mailers Fix test another way 2020-02-11 17:07:18 -05:00
models SECURITY: Respect topic permissions when loading draft metadata 2020-03-23 11:54:36 +00:00
multisite FIX: parallel spec system needs a dedicated upload folder for each worker. (#8547) 2019-12-18 11:21:57 +05:30
requests FIX: correctly remove authentication_data cookie on oauth login flow (#9238) 2020-03-23 16:01:39 -07:00
serializers FEATURE: Improving bookmarks part 2 -- Topic Bookmarking (#8954) 2020-02-13 16:26:02 +10:00
services Link website when reviewing users 2020-02-19 10:18:05 -05:00
support Suppres task spec output using capture_stdout 2020-02-20 14:47:47 +10:00
tasks Suppres task spec output using capture_stdout 2020-02-20 14:47:47 +10:00
views/omniauth_callbacks FEATURE: Use full page redirection for all external auth methods (#8092) 2019-10-08 12:10:43 +01:00
rails_helper.rb SECURITY: 2FA with U2F / TOTP 2020-01-15 11:27:12 +01:00