Blake Erickson 12f041de5d FIX: Tag watching for everyone tag groups (#15622) ... * FIX: Tag watching for everyone tag groups Tags in tag groups that have permissions set to everyone were not able to be saved correctly. A user on their preferences page would mark the tags that they wanted to save, but the watched_tags in the response would be empty. This did not apply to admins, just regular users. Even though the watched tags were being saved in the db, the user serializer response was filtering them out. When a user refreshed their preferences pages it would show zero watched tags. This appears to be a regression introduced by: 0f598ca51e The issue that needed to be fixed is that we don't track the "everyone" group (which has an id of 0) in the group_users table. This is because everyone has access to it, so why fill a row for every single user, that would be a lot. The fix was to update the query to include tag groups that had permissions set to the "everyone" group (group_id 0). I also added another check to the existing spec for updating watched tags for tags that aren't in a tag group so that it checks the response body. I then added a new spec which updates watched tags for tags in a tag group which has permissions set to everyone. * Resolve failing tests Improve SQL query syntax for including the "everyone" group with the id of 0. This commit also fixes a few failing tests that were introduced. It turns out that the Fabrication of the Tag Group Permissions was faulty. What happens when creating the tag groups without any permissions is that it sets the permission to "everyone". If we then follow up with fabricating a tag group permission on the tag group instead of having a single permission it will have 2 (everyone + the group specified)! We don't want this. To fix it I removed the fabrication of tag group permissions and just set the permissions directly when creating the tag group. * Use response.parsed_body instead of JSON.parse		2022-01-18 15:02:29 -07:00
..
components	DEV: Fix failing test.	2022-01-11 11:45:22 +08:00
fabricators	DEV: Add API docs for uploads and API doc watcher (#15387)	2021-12-23 08:40:15 +10:00
fixtures	FIX: Broken GitHub folder onebox logic (#15612)	2022-01-17 18:32:07 +01:00
helpers	PERF: Redis snapshotting during tests (#15260)	2021-12-10 14:25:26 -06:00
import_export	FEATURE: Rake task to export groups (#9450)	2020-04-17 14:59:54 -07:00
initializers	FEATURE: A low priority filter for the review queue. (#12822)	2021-04-23 15:34:24 -03:00
integration	FIX: Make thumbnail tests start with a clean slate (#15216)	2021-12-07 13:07:45 -06:00
integrity	DEV: Fix a flaky Onceoff spec (#13314)	2021-06-07 20:38:31 +02:00
jobs	FIX: Don't allow NULL values for notification_level in category_users (#15407)	2021-12-29 09:19:39 +11:00
lib	FIX: origins_to_regexes should always return an array (#15589)	2022-01-17 12:48:41 -05:00
mailers	DEV: Hash tokens stored from email_tokens (#14493)	2021-11-25 09:34:39 +02:00
models	FIX: Tag watching for everyone tag groups (#15622)	2022-01-18 15:02:29 -07:00
multisite	FEATURE: Apply rate limits per user instead of IP for trusted users (#14706)	2021-11-17 23:27:30 +03:00
requests	FIX: Tag watching for everyone tag groups (#15622)	2022-01-18 15:02:29 -07:00
script/import_scripts	DEV: If disabled do not change setting after import (#12142)	2021-02-19 09:33:35 -07:00
serializers	UX: change text of public_topic action code in login required sites. (#14764)	2022-01-11 11:35:16 +05:30
services	FIX: Tag watching for everyone tag groups (#15622)	2022-01-18 15:02:29 -07:00
support	DEV: Fix git deprecation warnings in specs (#15503)	2022-01-09 20:26:19 +01:00
tasks	DEV: Clean up old bookmark code (#15455)	2022-01-05 10:02:02 +10:00
views/omniauth_callbacks
rails_helper.rb	DEV: Avoid $ globals (#15453)	2022-01-08 23:39:46 +01:00
regenerate_swagger_docs	DEV: Add API docs for uploads and API doc watcher (#15387)	2021-12-23 08:40:15 +10:00
swagger_helper.rb	DEV: Add API docs for uploads and API doc watcher (#15387)	2021-12-23 08:40:15 +10:00