mirror of
https://github.com/discourse/discourse.git
synced 2024-11-28 00:44:12 +08:00
f380643528
We recently added a "don't feed the trolls" feature which warns you about interacting with posts that have been flagged and are pending review. The problem is the warning persists even if an admin reviews the post and rejects the flag. After this change we only consider active flags when deciding whether to show the warning or not.
311 lines
8.7 KiB
Ruby
311 lines
8.7 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
class ComposerMessagesFinder
|
|
def initialize(user, details)
|
|
@user = user
|
|
@details = details
|
|
@topic = Topic.find_by(id: details[:topic_id]) if details[:topic_id]
|
|
end
|
|
|
|
def self.check_methods
|
|
@check_methods ||= instance_methods.find_all { |m| m =~ /\Acheck\_/ }
|
|
end
|
|
|
|
def find
|
|
return if editing_post?
|
|
|
|
self.class.check_methods.each do |m|
|
|
msg = public_send(m)
|
|
return msg if msg.present?
|
|
end
|
|
|
|
nil
|
|
end
|
|
|
|
# Determines whether to show the user education text
|
|
def check_education_message
|
|
return if @topic&.private_message?
|
|
|
|
if creating_topic?
|
|
count = @user.created_topic_count
|
|
education_key = "education.new-topic"
|
|
else
|
|
count = @user.post_count
|
|
education_key = "education.new-reply"
|
|
end
|
|
|
|
if count < SiteSetting.educate_until_posts
|
|
return(
|
|
{
|
|
id: "education",
|
|
templateName: "education",
|
|
wait_for_typing: true,
|
|
body:
|
|
PrettyText.cook(
|
|
I18n.t(
|
|
education_key,
|
|
education_posts_text:
|
|
I18n.t("education.until_posts", count: SiteSetting.educate_until_posts),
|
|
site_name: SiteSetting.title,
|
|
base_path: Discourse.base_path,
|
|
),
|
|
),
|
|
}
|
|
)
|
|
end
|
|
|
|
nil
|
|
end
|
|
|
|
# New users have a limited number of replies in a topic
|
|
def check_new_user_many_replies
|
|
return unless replying? && @user.posted_too_much_in_topic?(@details[:topic_id])
|
|
|
|
{
|
|
id: "too_many_replies",
|
|
templateName: "education",
|
|
body:
|
|
PrettyText.cook(
|
|
I18n.t(
|
|
"education.too_many_replies",
|
|
newuser_max_replies_per_topic: SiteSetting.newuser_max_replies_per_topic,
|
|
),
|
|
),
|
|
}
|
|
end
|
|
|
|
# Should a user be contacted to update their avatar?
|
|
def check_avatar_notification
|
|
# A user has to be basic at least to be considered for an avatar notification
|
|
return unless @user.has_trust_level?(TrustLevel[1])
|
|
|
|
# We don't notify users who have avatars or who have been notified already.
|
|
if @user.uploaded_avatar_id || UserHistory.exists_for_user?(@user, :notified_about_avatar)
|
|
return
|
|
end
|
|
|
|
# Do not notify user if any of the following is true:
|
|
# - "disable avatar education message" is enabled
|
|
# - "sso overrides avatar" is enabled
|
|
# - "allow uploaded avatars" is disabled
|
|
if SiteSetting.disable_avatar_education_message ||
|
|
SiteSetting.discourse_connect_overrides_avatar ||
|
|
!TrustLevelAndStaffAndDisabledSetting.matches?(SiteSetting.allow_uploaded_avatars, @user)
|
|
return
|
|
end
|
|
|
|
# If we got this far, log that we've nagged them about the avatar
|
|
UserHistory.create!(
|
|
action: UserHistory.actions[:notified_about_avatar],
|
|
target_user_id: @user.id,
|
|
)
|
|
|
|
# Return the message
|
|
{
|
|
id: "avatar",
|
|
templateName: "education",
|
|
body:
|
|
PrettyText.cook(
|
|
I18n.t(
|
|
"education.avatar",
|
|
profile_path: "/u/#{@user.username_lower}/preferences/account#profile-picture",
|
|
),
|
|
),
|
|
}
|
|
end
|
|
|
|
# Is a user replying too much in succession?
|
|
def check_sequential_replies
|
|
return unless educate_reply?(:notified_about_sequential_replies)
|
|
|
|
# Count the posts made by this user in the last day
|
|
recent_posts_user_ids =
|
|
Post
|
|
.where(topic_id: @details[:topic_id])
|
|
.where("created_at > ?", 1.day.ago)
|
|
.where(post_type: Post.types[:regular])
|
|
.order("created_at desc")
|
|
.limit(SiteSetting.sequential_replies_threshold)
|
|
.pluck(:user_id)
|
|
|
|
# Did we get back as many posts as we asked for, and are they all by the current user?
|
|
if recent_posts_user_ids.size != SiteSetting.sequential_replies_threshold ||
|
|
recent_posts_user_ids.detect { |u| u != @user.id }
|
|
return
|
|
end
|
|
|
|
# If we got this far, log that we've nagged them about the sequential replies
|
|
UserHistory.create!(
|
|
action: UserHistory.actions[:notified_about_sequential_replies],
|
|
target_user_id: @user.id,
|
|
topic_id: @details[:topic_id],
|
|
)
|
|
|
|
{
|
|
id: "sequential_replies",
|
|
templateName: "education",
|
|
wait_for_typing: true,
|
|
extraClass: "education-message",
|
|
hide_if_whisper: true,
|
|
body: PrettyText.cook(I18n.t("education.sequential_replies")),
|
|
}
|
|
end
|
|
|
|
def check_dominating_topic
|
|
return unless educate_reply?(:notified_about_dominating_topic)
|
|
|
|
if @topic.blank? || @topic.user_id == @user.id ||
|
|
@topic.posts_count < SiteSetting.summary_posts_required || @topic.private_message?
|
|
return
|
|
end
|
|
|
|
posts_by_user = @user.posts.where(topic_id: @topic.id).count
|
|
|
|
ratio = (posts_by_user.to_f / @topic.posts_count.to_f)
|
|
return if ratio < (SiteSetting.dominating_topic_minimum_percent.to_f / 100.0)
|
|
|
|
# Log the topic notification
|
|
UserHistory.create!(
|
|
action: UserHistory.actions[:notified_about_dominating_topic],
|
|
target_user_id: @user.id,
|
|
topic_id: @details[:topic_id],
|
|
)
|
|
|
|
{
|
|
id: "dominating_topic",
|
|
templateName: "dominating-topic",
|
|
wait_for_typing: true,
|
|
extraClass: "education-message dominating-topic-message",
|
|
body: PrettyText.cook(I18n.t("education.dominating_topic")),
|
|
}
|
|
end
|
|
|
|
def check_get_a_room(min_users_posted: 5)
|
|
return unless educate_reply?(:notified_about_get_a_room)
|
|
return unless @details[:post_id].present?
|
|
return if @topic.category&.read_restricted
|
|
|
|
reply_to_user_id = Post.where(id: @details[:post_id]).pluck(:user_id)[0]
|
|
|
|
# Users's last x posts in the topic
|
|
last_x_replies =
|
|
@topic
|
|
.posts
|
|
.where(user_id: @user.id)
|
|
.order("created_at desc")
|
|
.limit(SiteSetting.get_a_room_threshold)
|
|
.pluck(:reply_to_user_id)
|
|
.find_all { |uid| uid != @user.id && uid == reply_to_user_id }
|
|
|
|
return if last_x_replies.size != SiteSetting.get_a_room_threshold
|
|
return if @topic.posts.count("distinct user_id") < min_users_posted
|
|
|
|
UserHistory.create!(
|
|
action: UserHistory.actions[:notified_about_get_a_room],
|
|
target_user_id: @user.id,
|
|
topic_id: @details[:topic_id],
|
|
)
|
|
|
|
reply_username = User.where(id: last_x_replies[0]).pick(:username)
|
|
|
|
{
|
|
id: "get_a_room",
|
|
templateName: "get-a-room",
|
|
wait_for_typing: true,
|
|
reply_username: reply_username,
|
|
extraClass: "education-message get-a-room",
|
|
body:
|
|
PrettyText.cook(
|
|
I18n.t(
|
|
"education.get_a_room",
|
|
count: SiteSetting.get_a_room_threshold,
|
|
reply_username: reply_username,
|
|
base_path: Discourse.base_path,
|
|
),
|
|
),
|
|
}
|
|
end
|
|
|
|
def check_dont_feed_the_trolls
|
|
return if !replying?
|
|
|
|
post =
|
|
if @details[:post_id]
|
|
Post.find_by(id: @details[:post_id])
|
|
else
|
|
@topic&.first_post
|
|
end
|
|
|
|
return if post.blank?
|
|
|
|
flags = post.flags.active.group(:user_id).count
|
|
flagged_by_replier = flags[@user.id].to_i > 0
|
|
flagged_by_others = flags.values.sum >= SiteSetting.dont_feed_the_trolls_threshold
|
|
|
|
return if !flagged_by_replier && !flagged_by_others
|
|
|
|
{
|
|
id: "dont_feed_the_trolls",
|
|
templateName: "education",
|
|
wait_for_typing: false,
|
|
extraClass: "urgent",
|
|
body: PrettyText.cook(I18n.t("education.dont_feed_the_trolls")),
|
|
}
|
|
end
|
|
|
|
def check_reviving_old_topic
|
|
return unless replying?
|
|
if @topic.nil? || SiteSetting.warn_reviving_old_topic_age < 1 || @topic.last_posted_at.nil? ||
|
|
@topic.last_posted_at > SiteSetting.warn_reviving_old_topic_age.days.ago
|
|
return
|
|
end
|
|
|
|
{
|
|
id: "reviving_old",
|
|
templateName: "education",
|
|
wait_for_typing: false,
|
|
extraClass: "education-message",
|
|
body:
|
|
PrettyText.cook(
|
|
I18n.t(
|
|
"education.reviving_old_topic",
|
|
time_ago:
|
|
AgeWords.time_ago_in_words(
|
|
@topic.last_posted_at,
|
|
false,
|
|
scope: :"datetime.distance_in_words_verbose",
|
|
),
|
|
),
|
|
),
|
|
}
|
|
end
|
|
|
|
def self.user_not_seen_in_a_while(usernames)
|
|
User
|
|
.where(username_lower: usernames)
|
|
.where("last_seen_at < ?", SiteSetting.pm_warn_user_last_seen_months_ago.months.ago)
|
|
.pluck(:username)
|
|
.sort
|
|
end
|
|
|
|
private
|
|
|
|
def educate_reply?(type)
|
|
replying? && @details[:topic_id] && (@topic.present? && !@topic.private_message?) &&
|
|
(@user.post_count >= SiteSetting.educate_until_posts) &&
|
|
!UserHistory.exists_for_user?(@user, type, topic_id: @details[:topic_id])
|
|
end
|
|
|
|
def creating_topic?
|
|
@details[:composer_action] == "createTopic"
|
|
end
|
|
|
|
def replying?
|
|
@details[:composer_action] == "reply"
|
|
end
|
|
|
|
def editing_post?
|
|
@details[:composer_action] == "edit"
|
|
end
|
|
end
|