github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-12-21 09:03:49 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
19321a0b86
discourse/plugins/discourse-presence
History
Régis Hanol 35656a1d5f
DEV: attempt to fix some system spec flakes (#30182) 
Since 3e7f0867ea, I started seeing some specs fail due to the following error

```plain
Error occurred while rendering: top-level application > discourse-root > topic > discourse-topic > topic-navigation > plugin-outlet > plugin-connector > topic-presence-display

/assets/plugins/discourse-presence.js - Uncaught TypeError: Cannot destructure property 'whisperer' of 'this.currentUser' as it is null.
```

For some reasons I can't fanthom, the presence components seem to be rendered even though they're using outlets that are only rendered when a user is signed in... 🤷‍♂️

Lost too much time trying to reproduce so I ended up adding this `if (!this.currentUser) { return; }` condition to both "presence display" component to (hopefully) fix these flakes.
2024-12-09 18:01:22 +01:00
..
assets DEV: attempt to fix some system spec flakes (#30182) 2024-12-09 18:01:22 +01:00
config FEATURE: Add Uyghur language (#27183) 2024-05-27 09:58:18 +02:00
spec/integration FIX: whisper's presence channels (#30097) 2024-12-04 11:47:05 +01:00
test/javascripts/acceptance DEV: Refactor composer-/topic-presence-display (#29455) 2024-10-29 10:44:05 +01:00
plugin.rb FIX: whisper's presence channels (#30097) 2024-12-04 11:47:05 +01:00
README.md

README.md

Discourse Presence plugin

This plugin shows which users are currently writing a reply at the same time as you.