mirror of
https://github.com/discourse/discourse.git
synced 2024-11-26 23:33:45 +08:00
0c42a1e5f3
Allows creating a bookmark with the `for_topic` flag introduced ind1d2298a4c
set to true. This happens when clicking on the Bookmark button in the topic footer when no other posts are bookmarked. In a later PR, when clicking on these topic-level bookmarks the user will be taken to the last unread post in the topic, not the OP. Only the OP can have a topic level bookmark, and users can also make a post-level bookmark on the OP of the topic. I had to do some pretty heavy refactors because most of the bookmark code in the JS topics controller was centred around instances of Post JS models, but the topic level bookmark is not centred around a post. Some refactors were just for readability as well. Also removes some missed reminderType code from the purge in41e19adb0d
133 lines
3.8 KiB
Ruby
133 lines
3.8 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'rails_helper'
|
|
|
|
describe BookmarksController do
|
|
let(:current_user) { Fabricate(:user) }
|
|
let(:bookmark_post) { Fabricate(:post) }
|
|
let(:bookmark_user) { current_user }
|
|
|
|
before do
|
|
sign_in(current_user)
|
|
end
|
|
|
|
describe "#create" do
|
|
it "rate limits creates" do
|
|
SiteSetting.max_bookmarks_per_day = 1
|
|
RateLimiter.enable
|
|
RateLimiter.clear_all!
|
|
|
|
post "/bookmarks.json", params: {
|
|
post_id: bookmark_post.id,
|
|
reminder_at: (Time.zone.now + 1.day).iso8601
|
|
}
|
|
|
|
expect(response.status).to eq(200)
|
|
|
|
post "/bookmarks.json", params: {
|
|
post_id: Fabricate(:post).id
|
|
}
|
|
expect(response.status).to eq(429)
|
|
end
|
|
|
|
it "creates a for_topic bookmark" do
|
|
post "/bookmarks.json", params: {
|
|
post_id: bookmark_post.id,
|
|
reminder_type: "tomorrow",
|
|
reminder_at: (Time.zone.now + 1.day).iso8601,
|
|
for_topic: true
|
|
}
|
|
expect(response.status).to eq(200)
|
|
bookmark = Bookmark.find(response.parsed_body["id"])
|
|
expect(bookmark.for_topic).to eq(true)
|
|
end
|
|
|
|
it "errors when trying to create a for_topic bookmark for post_number > 1" do
|
|
post "/bookmarks.json", params: {
|
|
post_id: Fabricate(:post, topic: bookmark_post.topic).id,
|
|
reminder_type: "tomorrow",
|
|
reminder_at: (Time.zone.now + 1.day).iso8601,
|
|
for_topic: true
|
|
}
|
|
expect(response.status).to eq(400)
|
|
expect(response.parsed_body['errors']).to include(
|
|
I18n.t("bookmarks.errors.for_topic_must_use_first_post")
|
|
)
|
|
end
|
|
|
|
context "if the user reached the max bookmark limit" do
|
|
before do
|
|
SiteSetting.max_bookmarks_per_user = 1
|
|
end
|
|
|
|
it "returns failed JSON with a 400 error" do
|
|
post "/bookmarks.json", params: {
|
|
post_id: bookmark_post.id,
|
|
reminder_at: (Time.zone.now + 1.day).iso8601
|
|
}
|
|
post "/bookmarks.json", params: {
|
|
post_id: Fabricate(:post).id
|
|
}
|
|
|
|
expect(response.status).to eq(400)
|
|
user_bookmarks_url = "#{Discourse.base_url}/my/activity/bookmarks"
|
|
expect(response.parsed_body['errors']).to include(
|
|
I18n.t("bookmarks.errors.too_many", user_bookmarks_url: user_bookmarks_url, limit: SiteSetting.max_bookmarks_per_user)
|
|
)
|
|
end
|
|
end
|
|
|
|
context "if the user already has bookmarked the post" do
|
|
before do
|
|
Fabricate(:bookmark, post: bookmark_post, user: bookmark_user)
|
|
end
|
|
|
|
it "returns failed JSON with a 400 error" do
|
|
post "/bookmarks.json", params: {
|
|
post_id: bookmark_post.id,
|
|
reminder_at: (Time.zone.now + 1.day).iso8601
|
|
}
|
|
|
|
expect(response.status).to eq(400)
|
|
expect(response.parsed_body['errors']).to include(
|
|
I18n.t("bookmarks.errors.already_bookmarked_post")
|
|
)
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "#destroy" do
|
|
let!(:bookmark) { Fabricate(:bookmark, post: bookmark_post, user: bookmark_user) }
|
|
|
|
it "destroys the bookmark" do
|
|
delete "/bookmarks/#{bookmark.id}.json"
|
|
expect(Bookmark.find_by(id: bookmark.id)).to eq(nil)
|
|
end
|
|
|
|
context "if the bookmark has already been destroyed" do
|
|
it "returns failed JSON with a 403 error" do
|
|
bookmark.destroy!
|
|
delete "/bookmarks/#{bookmark.id}.json"
|
|
|
|
expect(response.status).to eq(404)
|
|
expect(response.parsed_body['errors'].first).to include(
|
|
I18n.t("not_found")
|
|
)
|
|
end
|
|
end
|
|
|
|
context "if the bookmark does not belong to the user" do
|
|
let(:bookmark_user) { Fabricate(:user) }
|
|
|
|
it "returns failed JSON with a 403 error" do
|
|
delete "/bookmarks/#{bookmark.id}.json"
|
|
|
|
expect(response.status).to eq(403)
|
|
expect(response.parsed_body['errors'].first).to include(
|
|
I18n.t("invalid_access")
|
|
)
|
|
end
|
|
end
|
|
end
|
|
end
|