mirror of
https://github.com/discourse/discourse.git
synced 2025-02-25 00:58:57 +08:00

In core, `escapeExpression` was being applied during the model loading phase. However, plugin consumers of the UserStreamItem component were not necessarily doing the same. This commit moves the emoji-replacement logic (which also safely handles escaping) into the component template, so that it is safe-by-default, regardless of how it's used by plugins.
28 lines
942 B
Ruby
28 lines
942 B
Ruby
# frozen_string_literal: true
|
|
|
|
describe "User activity posts", type: :system do
|
|
before_all { UserActionManager.enable }
|
|
fab!(:user)
|
|
|
|
fab!(:topic1) do
|
|
Fabricate(:topic, title: "Title with & characters and emoji :wave:").tap do |t|
|
|
Fabricate.times(2, :post, topic: t, user: user).each { |p| UserActionManager.post_created(p) }
|
|
end
|
|
end
|
|
fab!(:topic2) do
|
|
Fabricate(:topic).tap do |t|
|
|
Fabricate.times(2, :post, topic: t, user: user).each { |p| UserActionManager.post_created(p) }
|
|
end
|
|
end
|
|
|
|
it "lists posts with correctly-formatted titles" do
|
|
visit "/u/#{user.username_lower}/activity/replies"
|
|
|
|
expect(page).to have_css(".stream-topic-title .title", count: 2)
|
|
|
|
title_element = find(".stream-topic-title .title a[href*='/#{topic1.id}']")
|
|
expect(title_element).to have_text("Title with & characters and emoji")
|
|
expect(title_element).to have_css("img.emoji[title='wave']")
|
|
end
|
|
end
|