mirror of
https://github.com/discourse/discourse.git
synced 2024-12-05 10:53:44 +08:00
514 lines
18 KiB
Ruby
514 lines
18 KiB
Ruby
require 'spec_helper'
|
|
require 'topic_view'
|
|
|
|
describe TopicQuery do
|
|
|
|
let!(:user) { Fabricate(:coding_horror) }
|
|
let(:creator) { Fabricate(:user) }
|
|
let(:topic_query) { TopicQuery.new(user) }
|
|
|
|
let(:moderator) { Fabricate(:moderator) }
|
|
let(:admin) { Fabricate(:admin) }
|
|
|
|
context 'secure category' do
|
|
it "filters categories out correctly" do
|
|
category = Fabricate(:category)
|
|
group = Fabricate(:group)
|
|
category.set_permissions(group => :full)
|
|
category.save
|
|
|
|
topic = Fabricate(:topic, category: category)
|
|
topic = Fabricate(:topic, visible: false)
|
|
|
|
expect(TopicQuery.new(nil).list_latest.topics.count).to eq(0)
|
|
expect(TopicQuery.new(user).list_latest.topics.count).to eq(0)
|
|
|
|
expect(Topic.top_viewed(10).count).to eq(0)
|
|
expect(Topic.recent(10).count).to eq(0)
|
|
|
|
# mods can see hidden topics
|
|
expect(TopicQuery.new(moderator).list_latest.topics.count).to eq(1)
|
|
# admins can see all the topics
|
|
expect(TopicQuery.new(admin).list_latest.topics.count).to eq(3)
|
|
|
|
group.add(user)
|
|
group.save
|
|
|
|
expect(TopicQuery.new(user).list_latest.topics.count).to eq(2)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
context "list_topics_by" do
|
|
|
|
it "allows users to view their own invisible topics" do
|
|
topic = Fabricate(:topic, user: user)
|
|
invisible_topic = Fabricate(:topic, user: user, visible: false)
|
|
|
|
expect(TopicQuery.new(nil).list_topics_by(user).topics.count).to eq(1)
|
|
expect(TopicQuery.new(user).list_topics_by(user).topics.count).to eq(2)
|
|
end
|
|
|
|
end
|
|
|
|
context 'bookmarks' do
|
|
it "filters and returns bookmarks correctly" do
|
|
post = Fabricate(:post)
|
|
reply = Fabricate(:post, topic_id: post.topic_id)
|
|
|
|
post2 = Fabricate(:post)
|
|
|
|
PostAction.act(user, post, PostActionType.types[:bookmark])
|
|
PostAction.act(user, reply, PostActionType.types[:bookmark])
|
|
TopicUser.change(user, post.topic, notification_level: 1)
|
|
TopicUser.change(user, post2.topic, notification_level: 1)
|
|
|
|
query = TopicQuery.new(user, filter: 'bookmarked').list_latest
|
|
|
|
expect(query.topics.length).to eq(1)
|
|
expect(query.topics.first.user_data.post_action_data).to eq({PostActionType.types[:bookmark] => [1,2]})
|
|
end
|
|
end
|
|
|
|
context 'deleted filter' do
|
|
it "filters deleted topics correctly" do
|
|
_topic = Fabricate(:topic, deleted_at: 1.year.ago)
|
|
|
|
expect(TopicQuery.new(admin, status: 'deleted').list_latest.topics.size).to eq(1)
|
|
expect(TopicQuery.new(moderator, status: 'deleted').list_latest.topics.size).to eq(1)
|
|
expect(TopicQuery.new(user, status: 'deleted').list_latest.topics.size).to eq(0)
|
|
expect(TopicQuery.new(nil, status: 'deleted').list_latest.topics.size).to eq(0)
|
|
end
|
|
end
|
|
|
|
context 'category filter' do
|
|
let(:category) { Fabricate(:category) }
|
|
|
|
let(:diff_category) { Fabricate(:diff_category) }
|
|
|
|
it "returns topics in the category when we filter to it" do
|
|
expect(TopicQuery.new(moderator).list_latest.topics.size).to eq(0)
|
|
|
|
# Filter by slug
|
|
expect(TopicQuery.new(moderator, category: category.slug).list_latest.topics.size).to eq(1)
|
|
expect(TopicQuery.new(moderator, category: "#{category.id}-category").list_latest.topics.size).to eq(1)
|
|
|
|
list = TopicQuery.new(moderator, category: diff_category.slug).list_latest
|
|
expect(list.topics.size).to eq(1)
|
|
expect(list.preload_key).to eq("topic_list_c/different-category/l/latest")
|
|
|
|
# Defaults to no category filter when slug does not exist
|
|
expect(TopicQuery.new(moderator, category: 'made up slug').list_latest.topics.size).to eq(2)
|
|
end
|
|
|
|
context 'subcategories' do
|
|
let!(:subcategory) { Fabricate(:category, parent_category_id: category.id)}
|
|
|
|
it "works with subcategories" do
|
|
expect(TopicQuery.new(moderator, category: category.id).list_latest.topics.size).to eq(1)
|
|
expect(TopicQuery.new(moderator, category: subcategory.id).list_latest.topics.size).to eq(1)
|
|
expect(TopicQuery.new(moderator, category: category.id, no_subcategories: true).list_latest.topics.size).to eq(1)
|
|
end
|
|
|
|
end
|
|
|
|
|
|
end
|
|
|
|
context 'muted categories' do
|
|
it 'is removed from new and latest lists' do
|
|
category = Fabricate(:category)
|
|
topic = Fabricate(:topic, category: category)
|
|
CategoryUser.create!(user_id: user.id,
|
|
category_id: category.id,
|
|
notification_level: CategoryUser.notification_levels[:muted])
|
|
expect(topic_query.list_new.topics.map(&:id)).not_to include(topic.id)
|
|
expect(topic_query.list_latest.topics.map(&:id)).not_to include(topic.id)
|
|
end
|
|
end
|
|
|
|
context 'a bunch of topics' do
|
|
let!(:regular_topic) do
|
|
Fabricate(:topic, title: 'this is a regular topic',
|
|
user: creator,
|
|
views: 100,
|
|
like_count: 66,
|
|
posts_count: 3,
|
|
participant_count: 11,
|
|
bumped_at: 15.minutes.ago)
|
|
end
|
|
let!(:pinned_topic) do
|
|
Fabricate(:topic, title: 'this is a pinned topic',
|
|
user: creator,
|
|
views: 10,
|
|
like_count: 100,
|
|
posts_count: 5,
|
|
participant_count: 12,
|
|
pinned_at: 10.minutes.ago,
|
|
pinned_globally: true,
|
|
bumped_at: 10.minutes.ago)
|
|
end
|
|
let!(:archived_topic) do
|
|
Fabricate(:topic, title: 'this is an archived topic',
|
|
user: creator,
|
|
views: 50,
|
|
like_count: 30,
|
|
posts_count: 4,
|
|
archived: true,
|
|
participant_count: 1,
|
|
bumped_at: 6.minutes.ago)
|
|
end
|
|
let!(:invisible_topic) do
|
|
Fabricate(:topic, title: 'this is an invisible topic',
|
|
user: creator,
|
|
views: 1,
|
|
like_count: 5,
|
|
posts_count: 2,
|
|
visible: false,
|
|
participant_count: 3,
|
|
bumped_at: 5.minutes.ago)
|
|
end
|
|
let!(:closed_topic) do
|
|
Fabricate(:topic, title: 'this is a closed topic',
|
|
user: creator,
|
|
views: 2,
|
|
like_count: 1,
|
|
posts_count: 1,
|
|
closed: true,
|
|
participant_count: 2,
|
|
bumped_at: 1.minute.ago)
|
|
end
|
|
let!(:future_topic) do
|
|
Fabricate(:topic, title: 'this is a topic in far future',
|
|
user: creator,
|
|
views: 30,
|
|
like_count: 11,
|
|
posts_count: 6,
|
|
participant_count: 5,
|
|
bumped_at: 1000.years.from_now)
|
|
end
|
|
|
|
let(:topics) { topic_query.list_latest.topics }
|
|
|
|
context 'list_latest' do
|
|
it "returns the topics in the correct order" do
|
|
expect(topics.map(&:id)).to eq([pinned_topic, future_topic, closed_topic, archived_topic, regular_topic].map(&:id))
|
|
|
|
# includes the invisible topic if you're a moderator
|
|
expect(TopicQuery.new(moderator).list_latest.topics.include?(invisible_topic)).to eq(true)
|
|
|
|
# includes the invisible topic if you're an admin" do
|
|
expect(TopicQuery.new(admin).list_latest.topics.include?(invisible_topic)).to eq(true)
|
|
end
|
|
|
|
context 'sort_order' do
|
|
|
|
def ids_in_order(order, descending=true)
|
|
TopicQuery.new(admin, order: order, ascending: descending ? 'false' : 'true').list_latest.topics.map(&:id)
|
|
end
|
|
|
|
it "returns the topics in correct order" do
|
|
# returns the topics in likes order if requested
|
|
expect(ids_in_order('posts')).to eq([future_topic, pinned_topic, archived_topic, regular_topic, invisible_topic, closed_topic].map(&:id))
|
|
|
|
# returns the topics in reverse likes order if requested
|
|
expect(ids_in_order('posts', false)).to eq([closed_topic, invisible_topic, regular_topic, archived_topic, pinned_topic, future_topic].map(&:id))
|
|
|
|
# returns the topics in likes order if requested
|
|
expect(ids_in_order('likes')).to eq([pinned_topic, regular_topic, archived_topic, future_topic, invisible_topic, closed_topic].map(&:id))
|
|
|
|
# returns the topics in reverse likes order if requested
|
|
expect(ids_in_order('likes', false)).to eq([closed_topic, invisible_topic, future_topic, archived_topic, regular_topic, pinned_topic].map(&:id))
|
|
|
|
# returns the topics in views order if requested
|
|
expect(ids_in_order('views')).to eq([regular_topic, archived_topic, future_topic, pinned_topic, closed_topic, invisible_topic].map(&:id))
|
|
|
|
# returns the topics in reverse views order if requested" do
|
|
expect(ids_in_order('views', false)).to eq([invisible_topic, closed_topic, pinned_topic, future_topic, archived_topic, regular_topic].map(&:id))
|
|
|
|
# returns the topics in posters order if requested" do
|
|
expect(ids_in_order('posters')).to eq([pinned_topic, regular_topic, future_topic, invisible_topic, closed_topic, archived_topic].map(&:id))
|
|
|
|
# returns the topics in reverse posters order if requested" do
|
|
expect(ids_in_order('posters', false)).to eq([archived_topic, closed_topic, invisible_topic, future_topic, regular_topic, pinned_topic].map(&:id))
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
context 'after clearring a pinned topic' do
|
|
before do
|
|
pinned_topic.clear_pin_for(user)
|
|
end
|
|
|
|
it "no longer shows the pinned topic at the top" do
|
|
expect(topics).to eq([future_topic, closed_topic, archived_topic, pinned_topic, regular_topic])
|
|
end
|
|
end
|
|
|
|
end
|
|
|
|
context 'categorized' do
|
|
let(:category) { Fabricate(:category) }
|
|
let(:topic_category) { category.topic }
|
|
let!(:topic_no_cat) { Fabricate(:topic) }
|
|
let!(:topic_in_cat1) { Fabricate(:topic, category: category,
|
|
bumped_at: 10.minutes.ago,
|
|
created_at: 10.minutes.ago) }
|
|
let!(:topic_in_cat2) { Fabricate(:topic, category: category) }
|
|
|
|
describe '#list_new_in_category' do
|
|
it 'returns the topic category and the categorized topic' do
|
|
expect(
|
|
topic_query.list_new_in_category(category).topics.map(&:id)
|
|
).to eq([topic_in_cat2.id, topic_category.id, topic_in_cat1.id])
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'unread / read topics' do
|
|
|
|
context 'with no data' do
|
|
it "has no unread topics" do
|
|
expect(topic_query.list_unread.topics).to be_blank
|
|
end
|
|
end
|
|
|
|
context 'with read data' do
|
|
let!(:partially_read) { Fabricate(:post, user: creator).topic }
|
|
let!(:fully_read) { Fabricate(:post, user: creator).topic }
|
|
|
|
before do
|
|
TopicUser.update_last_read(user, partially_read.id, 0, 0)
|
|
TopicUser.update_last_read(user, fully_read.id, 1, 0)
|
|
end
|
|
|
|
context 'list_unread' do
|
|
it 'contains no topics' do
|
|
expect(topic_query.list_unread.topics).to eq([])
|
|
end
|
|
end
|
|
|
|
context 'user with auto_track_topics list_unread' do
|
|
before do
|
|
user.auto_track_topics_after_msecs = 0
|
|
user.save
|
|
end
|
|
|
|
it 'only contains the partially read topic' do
|
|
expect(topic_query.list_unread.topics).to eq([partially_read])
|
|
end
|
|
end
|
|
|
|
context 'list_read' do
|
|
it 'contain both topics ' do
|
|
expect(topic_query.list_read.topics).to match_array([fully_read, partially_read])
|
|
end
|
|
end
|
|
end
|
|
|
|
end
|
|
|
|
context 'list_new' do
|
|
|
|
context 'without a new topic' do
|
|
it "has no new topics" do
|
|
expect(topic_query.list_new.topics).to be_blank
|
|
end
|
|
end
|
|
|
|
context 'with a new topic' do
|
|
let!(:new_topic) { Fabricate(:topic, user: creator, bumped_at: 10.minutes.ago) }
|
|
let(:topics) { topic_query.list_new.topics }
|
|
|
|
|
|
it "contains the new topic" do
|
|
expect(topics).to eq([new_topic])
|
|
end
|
|
|
|
it "contains no new topics for a user that has missed the window" do
|
|
user.new_topic_duration_minutes = 5
|
|
user.save
|
|
new_topic.created_at = 10.minutes.ago
|
|
new_topic.save
|
|
expect(topics).to eq([])
|
|
end
|
|
|
|
context "muted topics" do
|
|
before do
|
|
new_topic.notify_muted!(user)
|
|
end
|
|
|
|
it "returns an empty set" do
|
|
expect(topics).to be_blank
|
|
end
|
|
|
|
context 'un-muted' do
|
|
before do
|
|
new_topic.notify_tracking!(user)
|
|
end
|
|
|
|
it "returns the topic again" do
|
|
expect(topics).to eq([new_topic])
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
end
|
|
|
|
context 'list_posted' do
|
|
let(:topics) { topic_query.list_posted.topics }
|
|
|
|
it "returns blank when there are no posted topics" do
|
|
expect(topics).to be_blank
|
|
end
|
|
|
|
context 'created topics' do
|
|
let!(:created_topic) { create_post(user: user).topic }
|
|
|
|
it "includes the created topic" do
|
|
expect(topics.include?(created_topic)).to eq(true)
|
|
end
|
|
end
|
|
|
|
context "topic you've posted in" do
|
|
let(:other_users_topic) { create_post(user: creator).topic }
|
|
let!(:your_post) { create_post(user: user, topic: other_users_topic )}
|
|
|
|
it "includes the posted topic" do
|
|
expect(topics.include?(other_users_topic)).to eq(true)
|
|
end
|
|
end
|
|
|
|
context "topic you haven't posted in" do
|
|
let(:other_users_topic) { create_post(user: creator).topic }
|
|
|
|
it "does not include the topic" do
|
|
expect(topics).to be_blank
|
|
end
|
|
|
|
context "but interacted with" do
|
|
|
|
it "is not included if read" do
|
|
TopicUser.update_last_read(user, other_users_topic.id, 0, 0)
|
|
|
|
expect(topics).to be_blank
|
|
end
|
|
|
|
it "is not included if muted" do
|
|
other_users_topic.notify_muted!(user)
|
|
|
|
expect(topics).to be_blank
|
|
end
|
|
|
|
it "is not included if tracking" do
|
|
other_users_topic.notify_tracking!(user)
|
|
|
|
expect(topics).to be_blank
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'suggested_for' do
|
|
|
|
|
|
before do
|
|
RandomTopicSelector.clear_cache!
|
|
end
|
|
|
|
context 'when anonymous' do
|
|
let(:topic) { Fabricate(:topic) }
|
|
let!(:new_topic) { Fabricate(:post, user: creator).topic }
|
|
|
|
it "should return the new topic" do
|
|
expect(TopicQuery.new.list_suggested_for(topic).topics).to eq([new_topic])
|
|
end
|
|
end
|
|
|
|
context "anonymously browsing with invisible, closed and archived" do
|
|
let!(:topic) { Fabricate(:topic) }
|
|
let!(:regular_topic) { Fabricate(:post, user: creator).topic }
|
|
let!(:closed_topic) { Fabricate(:topic, user: creator, closed: true) }
|
|
let!(:archived_topic) { Fabricate(:topic, user: creator, archived: true) }
|
|
let!(:invisible_topic) { Fabricate(:topic, user: creator, visible: false) }
|
|
|
|
it "should omit the closed/archived/invisbiel topics from suggested" do
|
|
expect(TopicQuery.new.list_suggested_for(topic).topics).to eq([regular_topic])
|
|
end
|
|
end
|
|
|
|
context 'when logged in' do
|
|
|
|
let(:topic) { Fabricate(:topic) }
|
|
let(:suggested_topics) {
|
|
tt = topic
|
|
# lets clear cache once category is created - working around caching is hard
|
|
RandomTopicSelector.clear_cache!
|
|
topic_query.list_suggested_for(tt).topics.map{|t| t.id}
|
|
}
|
|
|
|
it "should return empty results when there is nothing to find" do
|
|
expect(suggested_topics).to be_blank
|
|
end
|
|
|
|
context 'with some existing topics' do
|
|
let!(:partially_read) { Fabricate(:post, user: creator).topic }
|
|
let!(:new_topic) { Fabricate(:post, user: creator).topic }
|
|
let!(:fully_read) { Fabricate(:post, user: creator).topic }
|
|
let!(:closed_topic) { Fabricate(:topic, user: creator, closed: true) }
|
|
let!(:archived_topic) { Fabricate(:topic, user: creator, archived: true) }
|
|
let!(:invisible_topic) { Fabricate(:topic, user: creator, visible: false) }
|
|
let!(:fully_read_closed) { Fabricate(:post, user: creator).topic }
|
|
let!(:fully_read_archived) { Fabricate(:post, user: creator).topic }
|
|
|
|
before do
|
|
user.auto_track_topics_after_msecs = 0
|
|
user.save
|
|
TopicUser.update_last_read(user, partially_read.id, 0, 0)
|
|
TopicUser.update_last_read(user, fully_read.id, 1, 0)
|
|
TopicUser.update_last_read(user, fully_read_closed.id, 1, 0)
|
|
TopicUser.update_last_read(user, fully_read_archived.id, 1, 0)
|
|
fully_read_closed.closed = true
|
|
fully_read_closed.save
|
|
fully_read_archived.archived = true
|
|
fully_read_archived.save
|
|
end
|
|
|
|
|
|
it "returns unread, then new, then random" do
|
|
SiteSetting.suggested_topics = 7
|
|
expect(suggested_topics[0]).to eq(partially_read.id)
|
|
expect(suggested_topics[1,3]).to include(new_topic.id)
|
|
expect(suggested_topics[1,3]).to include(closed_topic.id)
|
|
expect(suggested_topics[1,3]).to include(archived_topic.id)
|
|
|
|
# The line below appears to randomly fail, no idea why need to restructure test
|
|
#expect(suggested_topics[4]).to eq(fully_read.id)
|
|
# random doesn't include closed and archived
|
|
end
|
|
|
|
it "won't return new or fully read if there are enough partially read topics" do
|
|
SiteSetting.suggested_topics = 1
|
|
expect(suggested_topics).to eq([partially_read.id])
|
|
end
|
|
|
|
it "won't return fully read if there are enough partially read topics and new topics" do
|
|
SiteSetting.suggested_topics = 4
|
|
expect(suggested_topics[0]).to eq(partially_read.id)
|
|
expect(suggested_topics[1,3]).to include(new_topic.id)
|
|
expect(suggested_topics[1,3]).to include(closed_topic.id)
|
|
expect(suggested_topics[1,3]).to include(archived_topic.id)
|
|
end
|
|
|
|
end
|
|
end
|
|
|
|
end
|
|
|
|
end
|