mirror of
https://github.com/discourse/discourse.git
synced 2024-11-23 23:54:16 +08:00
4ea21fa2d0
This change both speeds up specs (less strings to allocate) and helps catch cases where methods in Discourse are mutating inputs. Overall we will be migrating everything to use #frozen_string_literal: true it will take a while, but this is the first and safest move in this direction
100 lines
3.5 KiB
Ruby
100 lines
3.5 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'rails_helper'
|
|
|
|
describe TranslationOverride do
|
|
context 'validations' do
|
|
describe '#value' do
|
|
before do
|
|
I18n.backend.store_translations(:en, some_key: '%{first} %{second}')
|
|
end
|
|
|
|
describe 'when interpolation keys are missing' do
|
|
it 'should not be valid' do
|
|
translation_override = TranslationOverride.upsert!(
|
|
I18n.locale, 'some_key', '%{key} %{omg}'
|
|
)
|
|
|
|
expect(translation_override.errors.full_messages).to include(I18n.t(
|
|
'activerecord.errors.models.translation_overrides.attributes.value.invalid_interpolation_keys',
|
|
keys: 'key, omg'
|
|
))
|
|
end
|
|
|
|
context 'when custom interpolation keys are included' do
|
|
it 'should be valid' do
|
|
translation_override = TranslationOverride.upsert!(
|
|
I18n.locale,
|
|
'some_key',
|
|
"#{described_class::CUSTOM_INTERPOLATION_KEYS_WHITELIST['user_notifications.user_'].join(", ")} %{something}"
|
|
)
|
|
|
|
expect(translation_override.errors.full_messages).to include(I18n.t(
|
|
'activerecord.errors.models.translation_overrides.attributes.value.invalid_interpolation_keys',
|
|
keys: 'something'
|
|
))
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
it "upserts values" do
|
|
TranslationOverride.upsert!('en', 'some.key', 'some value')
|
|
|
|
ovr = TranslationOverride.where(locale: 'en', translation_key: 'some.key').first
|
|
expect(ovr).to be_present
|
|
expect(ovr.value).to eq('some value')
|
|
end
|
|
|
|
it "stores js for a message format key" do
|
|
TranslationOverride.upsert!('ru', 'some.key_MF', '{NUM_RESULTS, plural, one {1 result} other {many} }')
|
|
|
|
ovr = TranslationOverride.where(locale: 'ru', translation_key: 'some.key_MF').first
|
|
expect(ovr).to be_present
|
|
expect(ovr.compiled_js).to start_with('function')
|
|
expect(ovr.compiled_js).to_not match(/Invalid Format/i)
|
|
end
|
|
|
|
context "site cache" do
|
|
def cached_value(guardian, types_name, name_key, attribute)
|
|
json = Site.json_for(guardian)
|
|
|
|
JSON.parse(json)[types_name]
|
|
.find { |x| x['name_key'] == name_key }[attribute]
|
|
end
|
|
|
|
shared_examples "resets site text" do
|
|
it "resets the site cache when translations of post_action_types are changed" do
|
|
anon_guardian = Guardian.new
|
|
user_guardian = Guardian.new(Fabricate(:user))
|
|
original_value = I18n.t(translation_key)
|
|
types_name, name_key, attribute = translation_key.split('.')
|
|
|
|
expect(cached_value(user_guardian, types_name, name_key, attribute)).to eq(original_value)
|
|
expect(cached_value(anon_guardian, types_name, name_key, attribute)).to eq(original_value)
|
|
|
|
TranslationOverride.upsert!('en', translation_key, 'bar')
|
|
expect(cached_value(user_guardian, types_name, name_key, attribute)).to eq('bar')
|
|
expect(cached_value(anon_guardian, types_name, name_key, attribute)).to eq('bar')
|
|
|
|
TranslationOverride.revert!('en', translation_key)
|
|
expect(cached_value(user_guardian, types_name, name_key, attribute)).to eq(original_value)
|
|
expect(cached_value(anon_guardian, types_name, name_key, attribute)).to eq(original_value)
|
|
end
|
|
end
|
|
|
|
context "post_action_types" do
|
|
let(:translation_key) { 'post_action_types.off_topic.description' }
|
|
|
|
include_examples "resets site text"
|
|
end
|
|
|
|
context "topic_flag_types" do
|
|
let(:translation_key) { 'topic_flag_types.spam.description' }
|
|
|
|
include_examples "resets site text"
|
|
end
|
|
end
|
|
end
|