mirror of
https://github.com/discourse/discourse.git
synced 2024-11-24 04:31:56 +08:00
accbbded15
Serializer is injecting information into cooked and reaching direct to custom fields that were not preloaded This amends it so basic post serializer can use the proper interface That said we should probably follow this up so we don't reach for this info on every post.
87 lines
2.0 KiB
Ruby
87 lines
2.0 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
# The most basic attributes of a topic that we need to create a link for it.
|
|
class BasicPostSerializer < ApplicationSerializer
|
|
attributes :id,
|
|
:name,
|
|
:username,
|
|
:avatar_template,
|
|
:created_at,
|
|
:cooked,
|
|
:cooked_hidden
|
|
|
|
attr_accessor :topic_view
|
|
|
|
def name
|
|
object.user && object.user.name
|
|
end
|
|
|
|
def username
|
|
object.user && object.user.username
|
|
end
|
|
|
|
def avatar_template
|
|
object.user && object.user.avatar_template
|
|
end
|
|
|
|
def cooked_hidden
|
|
object.hidden && !scope.is_staff?
|
|
end
|
|
|
|
def include_cooked_hidden?
|
|
cooked_hidden
|
|
end
|
|
|
|
def cooked
|
|
if cooked_hidden
|
|
if scope.current_user && object.user_id == scope.current_user.id
|
|
I18n.t('flagging.you_must_edit', path: "/my/messages")
|
|
else
|
|
I18n.t('flagging.user_must_edit')
|
|
end
|
|
else
|
|
cooked = object.filter_quotes(@parent_post)
|
|
|
|
if scope&.user
|
|
|
|
# PERF: this should not run on every post, only specific ones
|
|
# also, why is this in basic post serializer?
|
|
requested_group_id = post_custom_fields['requested_group_id'].to_i
|
|
|
|
if requested_group_id > 0
|
|
group = Group
|
|
.joins('JOIN group_users ON groups.id = group_users.group_id')
|
|
.find_by(
|
|
id: object.custom_fields['requested_group_id'].to_i,
|
|
group_users: { user_id: scope.user.id, owner: true }
|
|
)
|
|
|
|
if group
|
|
cooked << <<~EOF
|
|
<hr />
|
|
<a href="#{Discourse.base_uri}/g/#{group.name}/requests">
|
|
#{I18n.t('groups.request_membership_pm.handle')}
|
|
</a>
|
|
EOF
|
|
end
|
|
end
|
|
end
|
|
|
|
cooked
|
|
end
|
|
end
|
|
|
|
def include_name?
|
|
SiteSetting.enable_names?
|
|
end
|
|
|
|
def post_custom_fields
|
|
@post_custom_fields ||= if @topic_view
|
|
(@topic_view.post_custom_fields || {})[object.id] || {}
|
|
else
|
|
object.custom_fields
|
|
end
|
|
end
|
|
|
|
end
|