mirror of
https://github.com/discourse/discourse.git
synced 2024-12-16 08:46:30 +08:00
3e50313fdc
Since rspec-rails 3, the default installation creates two helper files: * `spec_helper.rb` * `rails_helper.rb` `spec_helper.rb` is intended as a way of running specs that do not require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's current `spec_helper.rb` does). For more information: https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files In this commit, I've simply replaced all instances of `spec_helper` with `rails_helper`, and renamed the original `spec_helper.rb`. This brings the Discourse project closer to the standard usage of RSpec in a Rails app. At present, every spec relies on loading Rails, but there are likely many that don't need to. In a future pull request, I hope to introduce a separate, minimal `spec_helper.rb` which can be used in tests which don't rely on Rails.
60 lines
1.5 KiB
Ruby
60 lines
1.5 KiB
Ruby
require 'rails_helper'
|
|
|
|
require_dependency 'backup'
|
|
|
|
describe Backup do
|
|
|
|
let(:b1) { Backup.new('backup1') }
|
|
let(:b2) { Backup.new('backup2') }
|
|
let(:b3) { Backup.new('backup3') }
|
|
|
|
before do
|
|
Backup.stubs(:all).returns([b1, b2, b3])
|
|
end
|
|
|
|
context '#remove_old' do
|
|
it "does nothing if there aren't more backups than the setting" do
|
|
SiteSetting.maximum_backups = 3
|
|
Backup.any_instance.expects(:remove).never
|
|
Backup.remove_old
|
|
end
|
|
|
|
it "calls remove on the backups over our limit" do
|
|
SiteSetting.maximum_backups = 1
|
|
b1.expects(:remove).never
|
|
b2.expects(:remove).once
|
|
b3.expects(:remove).once
|
|
Backup.remove_old
|
|
end
|
|
end
|
|
|
|
context ".after_create_hook" do
|
|
it "calls upload_to_s3 if the SiteSetting is true" do
|
|
SiteSetting.enable_s3_backups = true
|
|
b1.expects(:upload_to_s3).once
|
|
b1.after_create_hook
|
|
end
|
|
|
|
it "calls upload_to_s3 if the SiteSetting is false" do
|
|
SiteSetting.enable_s3_backups = false
|
|
b1.expects(:upload_to_s3).never
|
|
b1.after_create_hook
|
|
end
|
|
end
|
|
|
|
context ".after_remove_hook" do
|
|
it "calls remove_from_s3 if the SiteSetting is true" do
|
|
SiteSetting.enable_s3_backups = true
|
|
b1.expects(:remove_from_s3).once
|
|
b1.after_remove_hook
|
|
end
|
|
|
|
it "calls remove_from_s3 if the SiteSetting is false" do
|
|
SiteSetting.enable_s3_backups = false
|
|
b1.expects(:remove_from_s3).never
|
|
b1.after_remove_hook
|
|
end
|
|
end
|
|
|
|
end
|