mirror of
https://github.com/discourse/discourse.git
synced 2024-11-24 00:51:03 +08:00
64be371749
Our discourse_public_exceptions middleware is designed to catch bubbled exceptions from lower in the stack, and then use `ApplicationController.rescue_with_handler` to render an appropriate error response. When the request itself is invalid, we had an escape-hatch to skip re-dispatching the request to ApplicationController. However, it was possible to work around this by 'layering' the errors. For example, if you made a request which resulted in a 404, but **also** had some other invalidity, the escape hatch would not be triggered. This commit ensures that these kind of 'layered' errors are properly handled, without logging warnings. It also adds detection for invalid JSON bodies and badly-formed multipart requests. The user-facing behavior is unchanged. This commit simply prevents warnings being logged for invalid requests. |
||
|---|---|---|
| .. | ||
| api_keys_spec.rb | ||
| auto_reject_reviewable_users_spec.rb | ||
| category_tag_spec.rb | ||
| content_security_policy_spec.rb | ||
| email_style_spec.rb | ||
| flags_spec.rb | ||
| group_spec.rb | ||
| invalid_request_spec.rb | ||
| invite_only_registration_spec.rb | ||
| message_bus_spec.rb | ||
| multisite_cookies_spec.rb | ||
| multisite_spec.rb | ||
| rate_limiting_spec.rb | ||
| same_ip_spammers_spec.rb | ||
| spam_rules_spec.rb | ||
| topic_auto_close_spec.rb | ||
| topic_thumbnail_spec.rb | ||
| watched_words_spec.rb | ||