mirror of
https://github.com/discourse/discourse.git
synced 2024-11-29 22:48:33 +08:00
1f1709d249
Currently, when the custom flag has the same name as the system flag (which is disabled) then it is not displayed. To fix the problem, `custom_` prefix as `name_key` is used to distinguish between the system and the custom flag. I considered writing a migration to fix existing custom flags name key. However, at the end of migration I would need to run rails code to reset cache `Flag.reset_flag_settings!`. I decided to skip that step as it is a very edge case. If someone has the same flag name as the system flag, then all they have to do is edit the flag and click save. In addition, I made 2 small fixes: - edit flag title was missing translation; - flag form UI was not showing that description is the required field.
109 lines
3.1 KiB
Ruby
109 lines
3.1 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
RSpec.describe Flag, type: :model do
|
|
after(:each) { Flag.reset_flag_settings! }
|
|
|
|
it "has id lower than 1000 for system flags" do
|
|
flag = Fabricate(:flag, id: 1)
|
|
expect(flag.system?).to be true
|
|
flag.destroy!
|
|
end
|
|
|
|
it "has id greater than 1000 for non-system flags" do
|
|
flag = Fabricate(:flag)
|
|
expect(flag.system?).to be false
|
|
expect(flag.id).to be > 1000
|
|
flag.destroy!
|
|
end
|
|
|
|
it "has correct name key" do
|
|
flag = Fabricate(:flag, name: "FlAg!!!")
|
|
expect(flag.name_key).to eq("custom_flag")
|
|
|
|
flag.update!(name: "It's Illegal")
|
|
expect(flag.name_key).to eq("custom_its_illegal")
|
|
|
|
flag.update!(name: "THIS IS SPaM!+)(*&^%$#@@@!)")
|
|
expect(flag.name_key).to eq("custom_this_is_spam")
|
|
|
|
flag.destroy!
|
|
end
|
|
|
|
it "updates post action types when created, modified or destroyed" do
|
|
expect(PostActionType.flag_types.keys).to eq(
|
|
%i[notify_user off_topic inappropriate spam illegal notify_moderators],
|
|
)
|
|
expect(ReviewableScore.types.keys).to eq(
|
|
%i[notify_user off_topic inappropriate spam illegal notify_moderators needs_approval],
|
|
)
|
|
|
|
flag = Fabricate(:flag, name: "flag")
|
|
expect(PostActionType.flag_types.keys).to eq(
|
|
%i[notify_user off_topic inappropriate spam illegal notify_moderators custom_flag],
|
|
)
|
|
expect(ReviewableScore.types.keys).to eq(
|
|
%i[
|
|
notify_user
|
|
off_topic
|
|
inappropriate
|
|
spam
|
|
illegal
|
|
notify_moderators
|
|
custom_flag
|
|
needs_approval
|
|
],
|
|
)
|
|
|
|
flag.update!(name: "edited_flag")
|
|
expect(PostActionType.flag_types.keys).to eq(
|
|
%i[notify_user off_topic inappropriate spam illegal notify_moderators custom_edited_flag],
|
|
)
|
|
expect(ReviewableScore.types.keys).to eq(
|
|
%i[
|
|
notify_user
|
|
off_topic
|
|
inappropriate
|
|
spam
|
|
illegal
|
|
notify_moderators
|
|
custom_edited_flag
|
|
needs_approval
|
|
],
|
|
)
|
|
|
|
flag.destroy!
|
|
expect(PostActionType.flag_types.keys).to eq(
|
|
%i[notify_user off_topic inappropriate spam illegal notify_moderators],
|
|
)
|
|
expect(ReviewableScore.types.keys).to eq(
|
|
%i[notify_user off_topic inappropriate spam illegal notify_moderators needs_approval],
|
|
)
|
|
end
|
|
|
|
describe ".used_flag_ids" do
|
|
fab!(:post_action) { Fabricate(:post_action, post_action_type_id: PostActionType.types[:like]) }
|
|
fab!(:post_action_2) do
|
|
Fabricate(:post_action, post_action_type_id: PostActionType.types[:like])
|
|
end
|
|
fab!(:post_action_3) do
|
|
Fabricate(:post_action, post_action_type_id: PostActionType.types[:off_topic])
|
|
end
|
|
fab!(:reviewable_score) do
|
|
Fabricate(:reviewable_score, reviewable_score_type: PostActionType.types[:off_topic])
|
|
end
|
|
fab!(:reviewable_score_2) do
|
|
Fabricate(:reviewable_score, reviewable_score_type: PostActionType.types[:illegal])
|
|
end
|
|
|
|
it "returns an array of unique flag ids" do
|
|
expect(Flag.used_flag_ids).to eq(
|
|
[
|
|
PostActionType.types[:like],
|
|
PostActionType.types[:off_topic],
|
|
PostActionType.types[:illegal],
|
|
],
|
|
)
|
|
end
|
|
end
|
|
end
|