mirror of
https://github.com/discourse/discourse.git
synced 2024-11-23 15:32:26 +08:00
8253f8fc5c
* PERF: we don't need to use a huge image to test thumbnails Generating images with 5000x5000 dimensions is an expensive operation. Using smaller images reduce the time of model spec from 11s to 3s and integration spec from 6s to 2s.
76 lines
2.0 KiB
Ruby
76 lines
2.0 KiB
Ruby
# frozen_string_literal: true
|
|
require 'rails_helper'
|
|
|
|
describe "TopicThumbnail" do
|
|
let(:upload1) { Fabricate(:image_upload, width: 50, height: 50) }
|
|
let(:topic) { Fabricate(:topic, image_upload: upload1) }
|
|
let(:upload2) { Fabricate(:image_upload, width: 50, height: 50) }
|
|
let(:topic2) { Fabricate(:topic, image_upload: upload2) }
|
|
let(:upload3) { Fabricate(:upload_no_dimensions) }
|
|
let(:topic3) { Fabricate(:topic, image_upload: upload3) }
|
|
|
|
before do
|
|
SiteSetting.create_thumbnails = true
|
|
|
|
Topic.stubs(:thumbnail_sizes).returns([[49, 49]])
|
|
|
|
topic.generate_thumbnails!(extra_sizes: nil)
|
|
|
|
TopicThumbnail.ensure_consistency!
|
|
topic.reload
|
|
|
|
expect(topic.topic_thumbnails.length).to eq(1)
|
|
end
|
|
|
|
it "does not enque job if original image is too large" do
|
|
upload2.filesize = SiteSetting.max_image_size_kb.kilobytes + 1
|
|
SiteSetting.create_thumbnails = true
|
|
topic2.generate_thumbnails!(extra_sizes: nil)
|
|
|
|
TopicThumbnail.ensure_consistency!
|
|
topic2.reload
|
|
|
|
expect(topic2.topic_thumbnails.length).to eq(0)
|
|
expect(Jobs::GenerateTopicThumbnails.jobs.size).to eq(0)
|
|
end
|
|
|
|
it "does not enque job if image_upload width is nil" do
|
|
SiteSetting.create_thumbnails = true
|
|
topic3.image_url(enqueue_if_missing: true)
|
|
|
|
TopicThumbnail.ensure_consistency!
|
|
topic3.reload
|
|
|
|
expect(topic3.topic_thumbnails.length).to eq(0)
|
|
expect(Jobs::GenerateTopicThumbnails.jobs.size).to eq(0)
|
|
end
|
|
|
|
it "cleans up deleted uploads" do
|
|
upload1.delete
|
|
|
|
TopicThumbnail.ensure_consistency!
|
|
topic.reload
|
|
|
|
expect(topic.topic_thumbnails.length).to eq(0)
|
|
end
|
|
|
|
it "cleans up deleted optimized images" do
|
|
upload1.optimized_images.reload.delete_all
|
|
|
|
TopicThumbnail.ensure_consistency!
|
|
topic.reload
|
|
|
|
expect(topic.topic_thumbnails.length).to eq(0)
|
|
end
|
|
|
|
it "cleans up unneeded sizes" do
|
|
expect(topic.topic_thumbnails.length).to eq(1)
|
|
topic.topic_thumbnails[0].update_column(:max_width, 999999)
|
|
|
|
TopicThumbnail.ensure_consistency!
|
|
topic.reload
|
|
|
|
expect(topic.topic_thumbnails.length).to eq(0)
|
|
end
|
|
end
|