github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-01-19 16:02:45 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
21f23cc032
discourse/config/locales
History
Isaac Janzen 21f23cc032
DEV: Convert header to glimmer (#25214) 
Here is a breakdown of the changes that will be implemented in this PR.

# Widgets -> Glimmer

Obviously, the intention of the todo here is to convert the header from widgets to glimmer. This PR splits the respective widgets as so:

### widgets/site-header.js
```mermaid height=200
flowchart TB
    A[widgets/site-header.js] 
    A-->B[components/glimmer-site-header.gjs]
```

### widgets/header.js and children
```mermaid height=200
flowchart TB
    A[widgets/header.js] 
    A-->B[components/glimmer-header.gjs]
    B-->C[glimmer-header/contents.gjs]
    C-->D[./auth-buttons.gjs]
    C-->E[./icons.gjs]
    C-->F[./user-menu-wrapper.gjs]
    C-->G[./hamburger-dropdown-wrapper.gjs]
    C-->H[./user-menu-wrapper.gjs]
    C-->I[./sidebar-toggle.gjs]
    C-->J[./topic/info.gjs]
```

There are additional components rendered within the `glimmer-header/*` components, but I will leave those out for now. From this view you can see that we split apart the logic of `widgets/header.js` into 10+ components. Breaking apart these mega files has many benefits (readability, etc).

# Services

I have introduced a [header](cdb42caa04/app/assets/javascripts/discourse/app/services/header.js) service. This simplifies how we pass around data in the header, as well as fixes a bug we have with "swiping" menu panels.


# Modifiers
Added a [close-on-click-outside](cdb42caa04/app/assets/javascripts/discourse/app/modifiers/close-on-click-outside.js) modifier that is built upon the [close-on-click-outside modifier](https://github.com/discourse/discourse/blob/main/app/assets/javascripts/float-kit/addon/modifiers/close-on-click-outside.js) that @jjaffeux built for float-kit. I think we could replace float-kit's implementation with mine and have it in a centralized location as they are extremely similar.

# Tests
Rewrote the existing header tests ([1](https://github.com/discourse/discourse/blob/main/app/assets/javascripts/discourse/tests/integration/components/widgets/header-test.js), [2](https://github.com/discourse/discourse/blob/main/app/assets/javascripts/discourse/tests/integration/components/site-header-test.js)) as system tests. 

# Other
- Converted `widgets/user-status-bubble.js` to a gjs component
- Converted `widgets/sidebar-toggle.js` to a gjs component
- Converted `topicFeaturedLinkNode()` to a gjs component
- Deprecated the [docking mixin](https://github.com/discourse/discourse/blob/main/app/assets/javascripts/discourse/app/mixins/docking.js)
2024-02-23 11:08:15 -07:00
..
client.ar.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
client.be.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
client.bg.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
client.bs_BA.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
client.ca.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
client.cs.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
client.da.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
client.de.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
client.el.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
client.en_GB.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
client.en.yml DEV: Include deprecation link in warning banner (#25839) 2024-02-23 14:28:23 +00:00
client.es.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
client.et.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
client.fa_IR.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
client.fi.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
client.fr.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
client.gl.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
client.he.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
client.hr.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
client.hu.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
client.hy.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
client.id.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
client.it.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
client.ja.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
client.ko.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
client.lt.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
client.lv.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
client.nb_NO.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
client.nl.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
client.pl_PL.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
client.pt_BR.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
client.pt.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
client.ro.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
client.ru.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
client.sk.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
client.sl.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
client.sq.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
client.sr.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
client.sv.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
client.sw.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
client.te.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
client.th.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
client.tr_TR.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
client.uk.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
client.ur.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
client.vi.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
client.zh_CN.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
client.zh_TW.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
names.yml FIX: Vietnamese language native name 2023-12-21 18:03:57 +01:00
plurals.rb DEV: Apply syntax_tree formatting to config/* 2023-01-09 11:13:29 +00:00
server.ar.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
server.be.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
server.bg.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
server.bs_BA.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
server.ca.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
server.cs.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
server.da.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
server.de.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
server.el.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
server.en_GB.yml Update translations (#25278) 2024-01-16 14:54:32 +01:00
server.en.yml DEV: Convert header to glimmer (#25214) 2024-02-23 11:08:15 -07:00
server.es.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
server.et.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
server.fa_IR.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
server.fi.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
server.fr.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
server.gl.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
server.he.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
server.hr.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
server.hu.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
server.hy.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
server.id.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
server.it.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
server.ja.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
server.ko.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
server.lt.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
server.lv.yml Update translations (#25476) 2024-01-30 17:05:37 +01:00
server.nb_NO.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
server.nl.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
server.pl_PL.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
server.pt_BR.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
server.pt.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
server.ro.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
server.ru.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
server.sk.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
server.sl.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
server.sq.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
server.sr.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
server.sv.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
server.sw.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
server.te.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
server.th.yml Update translations (#25476) 2024-01-30 17:05:37 +01:00
server.tr_TR.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
server.uk.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
server.ur.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
server.vi.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
server.zh_CN.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
server.zh_TW.yml Update translations (#25767) 2024-02-20 09:42:19 -05:00
transliterate.ar.yml
transliterate.bg.yml
transliterate.de.yml
transliterate.el.yml
transliterate.en.yml
transliterate.ru.yml
transliterate.vi.yml