discourse/spec
Jeff Wong a1f9b1a7fc
FIX: correctly remove authentication_data cookie on oauth login flow (#9238)
Additionally correctly handle cookie path for authentication_data

There were two bugs that exposed an interesting case where two discourse
instances hosted across two subfolder installs in the same domain
with oauth may clash and cause strange redirection on first login:

Log in to example.com/forum1. authentication_data cookie is set with path /
On the first redirection, the current authentication_data cookie is not unset.
Log in to example.com/forum2. In this case, the authentication_data cookie
is already set from forum1 - the initial page load will incorrectly redirect
the user to the redirect URL from the already-stored cookie, to /forum1.

This removes this issue by:
* Setting the cookie for the correct path, and not having it on root
* Correctly removing the cookie on first login
2020-03-19 09:00:46 -07:00
..
components FIX: Improve HTML to Markdown conversion (#9231) 2020-03-18 19:31:10 +02:00
fabricators FEATURE: Send notifications for time-based and At Desktop bookmark reminders (#9071) 2020-03-12 10:16:00 +10:00
fixtures FIX: Bulk badge awards should work even if the CSV has nil values 2020-02-27 11:08:24 -03:00
helpers FIX: blank popular posts in summary emails due to lightbox images 2020-02-21 16:18:38 -05:00
import_export FIX: Import sub-sub-categories (#8810) 2020-01-30 18:46:33 +02:00
initializers FIX: We need to skip users with associated reviewables when auto-approving (#9080) 2020-03-02 14:33:52 -05:00
integration DEV: Improve flaky time-sensitive specs (#9141) 2020-03-10 22:13:17 +01:00
integrity DEV: Improve flaky time-sensitive specs (#9141) 2020-03-10 22:13:17 +01:00
jobs FIX: Ignore suspect users that were migrated or users who were created more than six months ago (#9205) 2020-03-14 08:47:53 -03:00
lib FIX: N1 issues for bookmark list (#9236) 2020-03-19 15:48:23 +10:00
mailers Fix test another way 2020-02-11 17:07:18 -05:00
models FEATURE: Demote muted categories on category list (#9226) 2020-03-17 15:33:15 -05:00
multisite FIX: parallel spec system needs a dedicated upload folder for each worker. (#8547) 2019-12-18 11:21:57 +05:30
requests FIX: correctly remove authentication_data cookie on oauth login flow (#9238) 2020-03-19 09:00:46 -07:00
serializers FIX: Make sure bookmark serializer works with deleted topics + posts (#9195) 2020-03-13 10:44:39 +10:00
services FEATURE: Send notifications for time-based and At Desktop bookmark reminders (#9071) 2020-03-12 10:16:00 +10:00
support DEV: Upload and secure media retroactive rake task improvements (#9027) 2020-03-03 10:03:58 +11:00
tasks FIX: Improve bookmark modal on mobile and bookmark sync rake task (#9221) 2020-03-17 15:15:22 +10:00
views/omniauth_callbacks FEATURE: Use full page redirection for all external auth methods (#8092) 2019-10-08 12:10:43 +01:00
rails_helper.rb DEV: Improve flaky time-sensitive specs (#9141) 2020-03-10 22:13:17 +01:00