mirror of
https://github.com/discourse/discourse.git
synced 2025-02-27 15:51:53 +08:00
2301dddcff
* DEV: Upgrade Rails to 7.1 * FIX: Remove references to `Rails.logger.chained` `Rails.logger.chained` was provided by Logster before Rails 7.1 introduced their broadcast logger. Now all the loggers are added to `Rails.logger.broadcasts`. Some code in our initializers was still using `chained` instead of `broadcasts`. * DEV: Make parameters optional to all FakeLogger methods * FIX: Set `override_level` on Logster loggers (#27519) A followup to f595d599dd361b7fb39fb3c82cbc11d19d518c19 * FIX: Don’t duplicate Rack response --------- Co-authored-by: Jarek Radosz <jradosz@gmail.com>
86 lines
2.9 KiB
Ruby
86 lines
2.9 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
# since all the rescue from clauses are not caught by the application controller for matches
|
|
# we need to handle certain exceptions here
|
|
module Middleware
|
|
class DiscoursePublicExceptions < ::ActionDispatch::PublicExceptions
|
|
# These middlewares will be re-run when the exception response is generated
|
|
EXCEPTION_RESPONSE_MIDDLEWARES = [
|
|
ContentSecurityPolicy::Middleware,
|
|
Middleware::CspScriptNonceInjector,
|
|
]
|
|
|
|
INVALID_REQUEST_ERRORS =
|
|
Set.new(
|
|
[
|
|
Rack::QueryParser::InvalidParameterError,
|
|
ActionController::BadRequest,
|
|
ActionDispatch::Http::Parameters::ParseError,
|
|
ActionController::RoutingError,
|
|
],
|
|
)
|
|
|
|
def call(env)
|
|
# this is so so gnarly
|
|
# sometimes we leak out exceptions prior to creating a controller instance
|
|
# this can happen if we have an exception in a route constraint in some cases
|
|
# this code re-dispatches the exception to our application controller so we can
|
|
# properly translate the exception to a page
|
|
exception = env["action_dispatch.exception"]
|
|
response = ActionDispatch::Response.new
|
|
|
|
exception = nil if INVALID_REQUEST_ERRORS.include?(exception)
|
|
|
|
if exception
|
|
begin
|
|
fake_controller = ApplicationController.new
|
|
fake_controller.set_response!(response)
|
|
fake_controller.request = request = ActionDispatch::Request.new(env)
|
|
|
|
# We can not re-dispatch bad mime types
|
|
begin
|
|
request.format
|
|
rescue Mime::Type::InvalidMimeType
|
|
return [
|
|
400,
|
|
{ "Cache-Control" => "private, max-age=0, must-revalidate" },
|
|
["Invalid MIME type"]
|
|
]
|
|
end
|
|
|
|
# Or badly formatted multipart requests
|
|
begin
|
|
request.POST
|
|
rescue ActionController::BadRequest => error
|
|
if error.cause.is_a?(EOFError)
|
|
return [
|
|
400,
|
|
{ "Cache-Control" => "private, max-age=0, must-revalidate" },
|
|
["Invalid request"]
|
|
]
|
|
else
|
|
raise
|
|
end
|
|
end
|
|
|
|
if ApplicationController.rescue_with_handler(exception, object: fake_controller)
|
|
body = response.body
|
|
body = [body] if String === body
|
|
rack_response = [response.status, response.headers, body]
|
|
app = lambda { |env| rack_response }
|
|
EXCEPTION_RESPONSE_MIDDLEWARES.each { |middleware| app = middleware.new(app) }
|
|
return app.call(env)
|
|
end
|
|
rescue => e
|
|
return super if INVALID_REQUEST_ERRORS.include?(e.class)
|
|
Discourse.warn_exception(
|
|
e,
|
|
message: "Failed to handle exception in exception app middleware",
|
|
)
|
|
end
|
|
end
|
|
super
|
|
end
|
|
end
|
|
end
|