Andrei Prigorshnev 26543a5b59 FIX: nil exception in chat notifier (#21105) ... We've found these exceptions in logs: Job exception: undefined method `destroy!' for nil:NilClass /var/www/discourse/plugins/chat/lib/chat/notifier.rb:102:in `block in notify_edit' /var/www/discourse/plugins/chat/lib/chat/notifier.rb💯in `each' /var/www/discourse/plugins/chat/lib/chat/notifier.rb💯in `notify_edit' /var/www/discourse/plugins/chat/app/jobs/regular/chat/send_message_notifications.rb:18:in `execute' In the past, we were creating `chat_mention` records only for sending notifications, so every mention record had a related notification. It isn't the case anymore (since fa543cda). This PR fixes the problem by making sure the notification exists before trying to remove it. Also, we shouldn't be deleting a `chat_mention` record itself, only a notification, this PR fixes that too. It's quite hard to reproduce this bug locally, I wasn't able to do so, the logic in this class is quite complicated, that's why I'm not adding a test. Also, when looking at this I realized that this method isn't in a fully correct state now, I suspect sometimes some notifications may not be delivered after someone edits a chat message and adds new mentions to it. I'm going to refactor and simplify the method in a subsequent PR.		2023-04-18 19:57:56 +04:00
..
chat	FIX: nil exception in chat notifier (#21105)	2023-04-18 19:57:56 +04:00
email_controller_helper
onebox/templates	UX: update chat icon to d-chat (#20744)	2023-03-21 10:40:42 -04:00
tasks	DEV: properly namespace chat (#20690)	2023-03-17 14:24:38 +01:00
service_runner.rb	FEATURE: Mark all chat channels read with a shortcut (#20629)	2023-03-22 13:24:07 +10:00