Martin Brennan 8437081d94
FIX: Add MessageBust.last_id to chat channel subscriptions (#19255)
This commit adds variousMessageBus.last_ids to serializer payloads
for chat channels and the chat view (for chat live pane) so
we can use those IDs when subscribing to MessageBus channels
from chat.

This allows us to ensure that any messages created between the
server being hit and the UI loaded and subscribing end up being
delivered to the client, rather than just silently dropped.

This commit also fixes an issue where we were subscribing to
the new-messages and new-mentions MessageBus channels multiple
times when following/unfollowing a channel multiple times.
2022-12-02 10:57:53 +10:00

133 lines
3.8 KiB
JavaScript

import {
acceptance,
query,
queryAll,
} from "discourse/tests/helpers/qunit-helpers";
import { click, currentURL, fillIn, visit } from "@ember/test-helpers";
import { test } from "qunit";
import I18n from "I18n";
import fabricators from "../helpers/fabricators";
import { isEmpty } from "@ember/utils";
acceptance("Discourse Chat - browse channels", function (needs) {
needs.user({ has_chat_enabled: true, can_chat: true });
needs.settings({ chat_enabled: true });
needs.pretender((server, helper) => {
// we don't need anything in the sidebar for this test
server.get("/chat/chat_channels.json", () => {
return helper.response({
public_channels: [],
direct_message_channels: [],
message_bus_last_ids: {
channel_metadata: 0,
channel_edits: 0,
channel_status: 0,
new_channel: 0,
user_tracking_state: 0,
},
});
});
server.get("/chat/api/chat_channels.json", (request) => {
const params = request.queryParams;
if (!isEmpty(params.filter)) {
if (params.filter === "foo") {
return helper.response([fabricators.chatChannel()]);
} else {
return helper.response([]);
}
}
const channels = [];
if (isEmpty(params.status) || params.status === "open") {
channels.push(fabricators.chatChannel());
channels.push(fabricators.chatChannel());
}
if (params.status === "closed" || isEmpty(params.status)) {
channels.push(fabricators.chatChannel({ status: "closed" }));
}
if (params.status === "archived" || isEmpty(params.status)) {
channels.push(fabricators.chatChannel({ status: "archived" }));
}
return helper.response(channels);
});
});
test("Defaults to open filter", async function (assert) {
await visit("/chat/browse");
assert.equal(currentURL(), "/chat/browse/open");
});
test("All filter", async function (assert) {
await visit("/chat/browse");
await click(".chat-browse-view__filter-link.-all");
assert.equal(currentURL(), "/chat/browse/all");
assert.equal(queryAll(".chat-channel-card").length, 4);
});
test("Open filter", async function (assert) {
await visit("/chat/browse");
await click(".chat-browse-view__filter-link.-open");
assert.equal(currentURL(), "/chat/browse/open");
assert.equal(queryAll(".chat-channel-card").length, 2);
});
test("Closed filter", async function (assert) {
await visit("/chat/browse");
await click(".chat-browse-view__filter-link.-closed");
assert.equal(currentURL(), "/chat/browse/closed");
assert.equal(queryAll(".chat-channel-card").length, 1);
});
test("Archived filter", async function (assert) {
this.siteSettings.chat_allow_archiving_channels = true;
await visit("/chat/browse");
await click(".chat-browse-view__filter-link.-archived");
assert.equal(currentURL(), "/chat/browse/archived");
assert.equal(queryAll(".chat-channel-card").length, 1);
});
test("Filtering results", async function (assert) {
await visit("/chat/browse");
assert.equal(queryAll(".chat-channel-card").length, 2);
await fillIn(".dc-filter-input", "foo");
assert.equal(queryAll(".chat-channel-card").length, 1);
});
test("No results", async function (assert) {
await visit("/chat/browse");
await fillIn(".dc-filter-input", "bar");
assert.equal(
query(".empty-state-title").innerText.trim(),
I18n.t("chat.empty_state.title")
);
});
test("Archiving channels is not allowed", async function (assert) {
this.siteSettings.chat_allow_archiving_channels = false;
await visit("/chat/browse");
assert.equal(
queryAll(".chat-browse-view__filter-link.-archived").length,
0
);
this.siteSettings.chat_allow_archiving_channels = true;
});
});