mirror of
https://github.com/discourse/discourse.git
synced 2024-11-26 06:23:43 +08:00
ccb345bd88
This commit implements many changes to topic and comments embedding. It deprecates the class_name field from EmbeddableHost and suggests using the className parameter. discourse_username parameter has been deprecated and it will fetch it from embedded site from the author or discourse-username meta. See the updated code sample from Admin > Customize > Embedding page. * FEATURE: Add className parameter for Discourse embed * DEV: Hide class_name from EmbeddableHost * DEV: Deprecate class_name field of EmbeddableHost * FEATURE: Use either author or discourse-username meta tag * DEV: Deprecate discourse_username parameter * DEV: Improve embed code sample
67 lines
2.0 KiB
Ruby
67 lines
2.0 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
RSpec.describe TopicRetriever do
|
|
let(:embed_url) { "http://eviltrout.com/2013/02/10/why-discourse-uses-emberjs.html" }
|
|
let(:topic_retriever) { TopicRetriever.new(embed_url) }
|
|
|
|
it "can initialize without optional parameters" do
|
|
t = TopicRetriever.new(embed_url)
|
|
expect(t).to be_present
|
|
end
|
|
|
|
describe "#retrieve" do
|
|
context "when host is invalid" do
|
|
before { topic_retriever.stubs(:invalid_url?).returns(true) }
|
|
|
|
it "does not perform_retrieve" do
|
|
topic_retriever.expects(:perform_retrieve).never
|
|
topic_retriever.retrieve
|
|
end
|
|
end
|
|
|
|
context "when topics have been retrieved recently" do
|
|
before { topic_retriever.stubs(:retrieved_recently?).returns(true) }
|
|
|
|
it "does not perform_retrieve" do
|
|
topic_retriever.expects(:perform_retrieve).never
|
|
topic_retriever.retrieve
|
|
end
|
|
end
|
|
|
|
context "when host is valid" do
|
|
before { Fabricate(:embeddable_host, host: "http://eviltrout.com/") }
|
|
|
|
context "when topics have been retrieved recently" do
|
|
before { topic_retriever.stubs(:retrieved_recently?).returns(true) }
|
|
|
|
it "does not perform_retrieve" do
|
|
topic_retriever.expects(:perform_retrieve).never
|
|
topic_retriever.retrieve
|
|
end
|
|
end
|
|
|
|
context "when topics have not been retrieved recently" do
|
|
before { topic_retriever.stubs(:retrieved_recently?).returns(false) }
|
|
|
|
it "does perform_retrieve" do
|
|
topic_retriever.expects(:perform_retrieve).once
|
|
topic_retriever.retrieve
|
|
end
|
|
end
|
|
end
|
|
|
|
context "when host is invalid" do
|
|
before { Fabricate(:embeddable_host, host: "http://not-eviltrout.com/") }
|
|
|
|
it "does not perform_retrieve" do
|
|
topic_retriever.expects(:perform_retrieve).never
|
|
topic_retriever.retrieve
|
|
end
|
|
end
|
|
|
|
it "works with URLs with whitespaces" do
|
|
expect { TopicRetriever.new(" https://example.com ").retrieve }.not_to raise_error
|
|
end
|
|
end
|
|
end
|