mirror of
https://github.com/discourse/discourse.git
synced 2024-11-24 05:34:28 +08:00
90efdd7f9d
This commit starts from a simple observation: cooking messages on the hot path can be slow. Especially with a lot of mentions. To move cooking from the hot path, this commit has made the following changes: - updating cooked, inserting mentions and notifying user of new mentions has been moved inside the `process_message` job. It happens right after the `Chat::MessageProcessor` run, which is where the cooking happens. - the similar existing code in `rebake!` has also been moved to rely on the `process_message`job only - refactored `create_mentions` and `update_mentions` into one single `upsert_mentions` which can be called invariably - allows services to decide if their job is ran inline or later. It avoids to need to know you have to use `Jobs.run_immediately!` in this case, in tests it will be inline per default - made various frontend changes to make the chat-channel component lifecycle clearer. we had to handle `did-update @channel` which was super awkward and creating bugs with listeners which the changes of the PR made clear in failing specs - adds a new `-processed` (and `-not-processed`) class on the chat message, this is made to have a good lifecyle hook in system specs
96 lines
2.9 KiB
Ruby
96 lines
2.9 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require "faker"
|
|
|
|
module ChatSystemHelpers
|
|
def chat_system_bootstrap(user = Fabricate(:admin), channels_for_membership = [])
|
|
# ensures we have one valid registered admin/user
|
|
user.activate
|
|
|
|
SiteSetting.chat_enabled = true
|
|
SiteSetting.chat_allowed_groups = Group::AUTO_GROUPS[:everyone]
|
|
|
|
channels_for_membership.each do |channel|
|
|
membership = channel.add(user)
|
|
if channel.chat_messages.any?
|
|
membership.update!(last_read_message_id: channel.chat_messages.last.id)
|
|
end
|
|
end
|
|
|
|
Group.refresh_automatic_groups!
|
|
end
|
|
|
|
def chat_system_user_bootstrap(user:, channel:)
|
|
user.activate
|
|
user.user_option.update!(chat_enabled: true)
|
|
Group.refresh_automatic_group!("trust_level_#{user.trust_level}".to_sym)
|
|
channel.add(user)
|
|
end
|
|
|
|
def chat_thread_chain_bootstrap(channel:, users:, messages_count: 4, thread_attrs: {})
|
|
last_user = nil
|
|
last_message = nil
|
|
|
|
users.each { |user| chat_system_user_bootstrap(user: user, channel: channel) }
|
|
messages_count.times do |i|
|
|
in_reply_to = i.zero? ? nil : last_message.id
|
|
thread_id = i.zero? ? nil : last_message.thread_id
|
|
last_user = ((users - [last_user]).presence || users).sample
|
|
creator =
|
|
Chat::CreateMessage.call(
|
|
chat_channel_id: channel.id,
|
|
in_reply_to_id: in_reply_to,
|
|
thread_id: thread_id,
|
|
guardian: last_user.guardian,
|
|
message: Faker::Lorem.words(number: 5).join(" "),
|
|
)
|
|
|
|
raise "#{creator.inspect_steps.inspect}\n\n#{creator.inspect_steps.error}" if creator.failure?
|
|
last_message = creator.message_instance
|
|
end
|
|
|
|
last_message.thread.set_replies_count_cache(messages_count - 1, update_db: true)
|
|
last_message.thread.update!(thread_attrs) if thread_attrs.any?
|
|
last_message.thread
|
|
end
|
|
|
|
def thread_excerpt(message)
|
|
CGI.escapeHTML(
|
|
message.censored_excerpt(max_length: ::Chat::Thread::EXCERPT_LENGTH).gsub("…", "…"),
|
|
)
|
|
end
|
|
end
|
|
|
|
module ChatSpecHelpers
|
|
def service_failed!(result)
|
|
raise RSpec::Expectations::ExpectationNotMetError.new(
|
|
"Service failed, see below for step details:\n\n" + result.inspect_steps.inspect,
|
|
)
|
|
end
|
|
|
|
def update_message(message, text: nil, user: Discourse.system_user, upload_ids: nil)
|
|
result =
|
|
Chat::UpdateMessage.call(
|
|
guardian: user.guardian,
|
|
message_id: message.id,
|
|
upload_ids: upload_ids,
|
|
message: text,
|
|
process_inline: true,
|
|
)
|
|
service_failed!(result) if result.failure?
|
|
result.message_instance
|
|
end
|
|
end
|
|
|
|
RSpec.configure do |config|
|
|
config.include ChatSystemHelpers, type: :system
|
|
config.include ChatSpecHelpers
|
|
config.include Chat::WithServiceHelper
|
|
config.include Chat::ServiceMatchers
|
|
|
|
config.expect_with :rspec do |c|
|
|
# Or a very large value, if you do want to truncate at some point
|
|
c.max_formatted_output_length = nil
|
|
end
|
|
end
|